On Sun, Nov 12, 2017 at 04:24:37PM +, Thomas Köppe wrote:
> Variables used in inline assembly need to be marked with attribute((used)).
> Static constants already were, via the define of DECLARE_ASM_CONST.
> But DECLARE_ALIGNED does not add this attribute, and some of the variables
> defined wi
Variables used in inline assembly need to be marked with attribute((used)).
Static constants already were, via the define of DECLARE_ASM_CONST.
But DECLARE_ALIGNED does not add this attribute, and some of the variables
defined with it are const only used in inline assembly, and therefore
appeared d
On Sat, Nov 11, 2017 at 08:36:32AM +, Thomas Köppe wrote:
> Variables used in inline assembly need to be marked with attribute((used)).
> Static constants already were, via the define of DECLARE_ASM_CONST.
> But DECLARE_ALIGNED does not add this attribute, and some of the variables
> defined wi
Variables used in inline assembly need to be marked with attribute((used)).
Static constants already were, via the define of DECLARE_ASM_CONST.
But DECLARE_ALIGNED does not add this attribute, and some of the variables
defined with it are const only used in inline assembly, and therefore
appeared d
Thank you, I'll package this up as a patch and send it as a separate mail.
On 9 November 2017 at 11:52, Teresa Johnson wrote:
> I implemented this change to add a new macro. I tried to find the
> variables used in MANGLE and change those to use the new
> DECLARE_ASM_ALIGNED, and the build succee
I implemented this change to add a new macro. I tried to find the variables
used in MANGLE and change those to use the new DECLARE_ASM_ALIGNED, and the
build succeeds with these changes. New changes are in cl/172133815.
Teresa
On Wed, Nov 1, 2017 at 7:25 AM, Teresa Johnson wrote:
>
>
> On Tue,
Hi
On Wed, Nov 01, 2017 at 07:25:08AM -0700, Teresa Johnson wrote:
> On Tue, Oct 31, 2017 at 5:42 PM, Michael Niedermayer > wrote:
>
> > Hi
> >
> > On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote:
> > > It's needed for the same reason the used attribute was already added to
> > th
On Tue, Oct 31, 2017 at 5:42 PM, Michael Niedermayer wrote:
> Hi
>
> On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote:
> > It's needed for the same reason the used attribute was already added to
> the
> > "static const" variables. For those, when building with just -O2, they
> > cou
Hi
On Tue, Oct 31, 2017 at 04:29:18PM +, Teresa Johnson wrote:
> It's needed for the same reason the used attribute was already added to the
> "static const" variables. For those, when building with just -O2, they
> could be removed by optimization since they had local (file) scope, and we
> c
It's needed for the same reason the used attribute was already added to the
"static const" variables. For those, when building with just -O2, they
could be removed by optimization since they had local (file) scope, and we
couldn't see the uses in the inline assembly (without the used attribute).
Wi
On Tue, Oct 31, 2017 at 03:52:14PM +, Thomas Köppe wrote:
> +Teresa, who drafted the patch initially.
>
> On 31 October 2017 at 15:38, Michael Niedermayer
> wrote:
>
> > On Tue, Oct 31, 2017 at 12:16:18PM +, Thomas Köppe wrote:
> > > Variables used in inline assembly need to be marked wi
+Teresa, who drafted the patch initially.
On 31 October 2017 at 15:38, Michael Niedermayer
wrote:
> On Tue, Oct 31, 2017 at 12:16:18PM +, Thomas Köppe wrote:
> > Variables used in inline assembly need to be marked with
> attribute((used)).
>
> This should not be the case.
> Variables referen
On Tue, Oct 31, 2017 at 12:16:18PM +, Thomas Köppe wrote:
> Variables used in inline assembly need to be marked with attribute((used)).
This should not be the case.
Variables referenced through in/out operands should not need that.
Only ones accessed directly bypassing operands should need thi
Variables used in inline assembly need to be marked with attribute((used)).
Static constants already were, via the define of DECLARE_ASM_CONST.
But DECLARE_ALIGNED does not add this attribute, and some of the variables
defined with it are const only used in inline assembly, and therefore
appeared d
Please find below the actual patch:
==
Variables used in inline assembly need to be marked with attribute((used)).
Static constants already were, via the define of DECLARE_ASM_CONST.
But DECLARE_ALIGNED does not add this attribute, and some of the variables
defined with it are const on
(I must have forgotten to rebase first!)
On 30 October 2017 at 20:14, Thomas Köppe wrote:
> It should be under __GNUC__ -- something went wrong with the patch! I'll
> make a new one. Sorry about that!
>
> On 30 October 2017 at 19:31, James Almer wrote:
>
>> On 10/30/2017 4:17 PM, Thomas Köppe w
It should be under __GNUC__ -- something went wrong with the patch! I'll
make a new one. Sorry about that!
On 30 October 2017 at 19:31, James Almer wrote:
> On 10/30/2017 4:17 PM, Thomas Köppe wrote:
> > Variables used in inline assembly need to be marked with
> attribute((used)).
> > Static con
On 10/30/2017 4:17 PM, Thomas Köppe wrote:
> Variables used in inline assembly need to be marked with attribute((used)).
> Static constants already were, via the define of DECLARE_ASM_CONST.
> But DECLARE_ALIGNED does not add this attribute, and some of the variables
> defined with it are const onl
Variables used in inline assembly need to be marked with attribute((used)).
Static constants already were, via the define of DECLARE_ASM_CONST.
But DECLARE_ALIGNED does not add this attribute, and some of the variables
defined with it are const only used in inline assembly, and therefore
appeared d
19 matches
Mail list logo
