Re: [FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-08-10 Thread Baozeng
Sorry. I do not understand the API. I will learn it later. Thank you. 2018-08-10 17:24 GMT+08:00 Hendrik Leppkes : > On Fri, Aug 10, 2018 at 10:41 AM Baozeng wrote: > > > > I do not agree with you. We cannot trust any user input. > > > > The API requires this, if this is not fullfilled then the

Re: [FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-08-10 Thread Hendrik Leppkes
On Fri, Aug 10, 2018 at 10:41 AM Baozeng wrote: > > I do not agree with you. We cannot trust any user input. > The API requires this, if this is not fullfilled then the user application is buggy, not avcodec. PS: Please don't top post on this ML. - Hendrik __

Re: [FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-08-10 Thread Baozeng
I do not agree with you. We cannot trust any user input. 2018-06-27 1:29 GMT+08:00 Michael Niedermayer : > On Tue, Jun 26, 2018 at 07:02:38PM +0800, Baozeng Ding wrote: > > Signed-off-by: Baozeng Ding > > --- > > libavcodec/parser.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deleti

Re: [FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-06-26 Thread Michael Niedermayer
On Tue, Jun 26, 2018 at 07:02:38PM +0800, Baozeng Ding wrote: > Signed-off-by: Baozeng Ding > --- > libavcodec/parser.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) This looks wrong. The input must have AV_INPUT_BUFFER_PADDING_SIZE allocated at the end. Is the buffer you p

[FFmpeg-devel] [PATCH] Fix heap buffer overflow in ff_combine_frame

2018-06-26 Thread Baozeng Ding
Signed-off-by: Baozeng Ding --- libavcodec/parser.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index f43b197..a9786af 100644 --- a/libavcodec/parser.c +++ b/libavcodec/parser.c @@ -355,6 +355,7 @@ int ff_combine_frame(P