2017-10-17 23:27 GMT+02:00 Carl Eugen Hoyos :
> 2017-10-17 3:16 GMT+02:00 Carl Eugen Hoyos :
> Remaining comment is:
> The paletteuse filter does not work correctly on big-endian
The issue was yuva->rgb on big-endian, patch sent.
Sorry, Carl Eugen
___
On Mon, Oct 23, 2017 at 7:17 PM, Bjorn Roche wrote:
> On Sat, Oct 21, 2017 at 4:00 PM, Clément Bœsch wrote:
>
>> On Sat, Oct 21, 2017 at 09:47:47PM +0200, Carl Eugen Hoyos wrote:
>> > 2017-10-21 21:43 GMT+02:00 Clément Bœsch :
>> > > On Sat, Oct 21, 2017 at 09:37:06PM +0200, Carl Eugen Hoyos wro
On Sat, Oct 21, 2017 at 4:00 PM, Clément Bœsch wrote:
> On Sat, Oct 21, 2017 at 09:47:47PM +0200, Carl Eugen Hoyos wrote:
> > 2017-10-21 21:43 GMT+02:00 Clément Bœsch :
> > > On Sat, Oct 21, 2017 at 09:37:06PM +0200, Carl Eugen Hoyos wrote:
> > >> 2017-10-21 18:40 GMT+02:00 Clément Bœsch :
> > >>
On Sat, Oct 21, 2017 at 09:47:47PM +0200, Carl Eugen Hoyos wrote:
> 2017-10-21 21:43 GMT+02:00 Clément Bœsch :
> > On Sat, Oct 21, 2017 at 09:37:06PM +0200, Carl Eugen Hoyos wrote:
> >> 2017-10-21 18:40 GMT+02:00 Clément Bœsch :
> >>
> >> > Aside from these nitpicks, I'm still concerned about how i
2017-10-21 21:43 GMT+02:00 Clément Bœsch :
> On Sat, Oct 21, 2017 at 09:37:06PM +0200, Carl Eugen Hoyos wrote:
>> 2017-10-21 18:40 GMT+02:00 Clément Bœsch :
>>
>> > Aside from these nitpicks, I'm still concerned about how it's going
>> > to conflict with GIF encoding where the transparent color is
On Sat, Oct 21, 2017 at 09:37:06PM +0200, Carl Eugen Hoyos wrote:
> 2017-10-21 18:40 GMT+02:00 Clément Bœsch :
>
> > Aside from these nitpicks, I'm still concerned about how it's going
> > to conflict with GIF encoding where the transparent color is actually
> > used as a mean of not updating pixe
2017-10-21 18:40 GMT+02:00 Clément Bœsch :
> Aside from these nitpicks, I'm still concerned about how it's going
> to conflict with GIF encoding where the transparent color is actually
> used as a mean of not updating pixels from previous frames.
But is this really related to this patch?
I just t
> Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency
The commit message needs adjustment "lavfi/paletteuse: ..."
[...]
> struct color_node {
> -uint8_t val[3];
> +uint8_t val[4];
> uint8_t palette_id;
> int split;
> in
On Thu, Oct 19, 2017 at 18:00:52 -0400, Bjorn Roche wrote:
> +{ "threshold", "set the alpha threshold for transparency. Above this
> threshold, pixels are considered opaque, below they are considered
> transparent.", OFFSET(trans_thresh), AV_OPT_TYPE_INT, {.i64=128}, 0, 255, },
This seems a
On Fri, Oct 20, 2017 at 12:35:00AM +0200, Carl Eugen Hoyos wrote:
> 2017-10-20 0:00 GMT+02:00 Bjorn Roche :
> > The palettes generated by palettegen include one transparent color.
> > This patch enables paletteuse to identify the transparency in incoming
> > video and tag transparent pixels on outg
2017-10-20 0:00 GMT+02:00 Bjorn Roche :
> The palettes generated by palettegen include one transparent color.
> This patch enables paletteuse to identify the transparency in incoming
> video and tag transparent pixels on outgoing video.
>
> This requires tracking the transparency index in the palet
The palettes generated by palettegen include one transparent color.
This patch enables paletteuse to identify the transparency in incoming
video and tag transparent pixels on outgoing video.
This requires tracking the transparency index in the palette,
establishing an alpha threshold below which a
2017-10-18 0:20 GMT+02:00 Bjorn Roche :
> On Tue, Oct 17, 2017 at 5:27 PM, Carl Eugen Hoyos
> wrote:
>> Remaining comment is:
>> The paletteuse filter does not work correctly on big-endian
>> (my guess is the code makes wrong assumptions about the
>> palette colour-space), I don't think this shou
On Tue, Oct 17, 2017 at 5:27 PM, Carl Eugen Hoyos
wrote:
> 2017-10-17 3:16 GMT+02:00 Carl Eugen Hoyos :
> > 2017-10-10 23:41 GMT+02:00 Bjorn Roche :
> >
> >> +{ "trans_threshold", "set the threshold for alpha values avoce
> which they are considered completely opaque", OFFSET(trans_thresh),
>
2017-10-17 3:16 GMT+02:00 Carl Eugen Hoyos :
> 2017-10-10 23:41 GMT+02:00 Bjorn Roche :
>
>> +{ "trans_threshold", "set the threshold for alpha values avoce which
>> they are considered completely opaque", OFFSET(trans_thresh),
>> AV_OPT_TYPE_INT, {.i64=128}, 0, 255, },
>
> I wonder if "thres
On Mon, Oct 16, 2017 at 9:16 PM, Carl Eugen Hoyos
wrote:
> 2017-10-10 23:41 GMT+02:00 Bjorn Roche :
>
> > +{ "trans_threshold", "set the threshold for alpha values avoce
> which they are considered completely opaque", OFFSET(trans_thresh),
> AV_OPT_TYPE_INT, {.i64=128}, 0, 255, },
>
> I wonde
2017-10-10 21:48 GMT+02:00 Bjorn Roche :
> On Fri, Oct 6, 2017 at 5:23 PM, Carl Eugen Hoyos wrote:
>> Do you think an option to set the value of the transparent
>> colour to something else than 0xFF00 would make sense?
>> And/or another default?
>> You can use ffplay on an output png file to test
2017-10-10 23:41 GMT+02:00 Bjorn Roche :
> +{ "trans_threshold", "set the threshold for alpha values avoce which
> they are considered completely opaque", OFFSET(trans_thresh),
> AV_OPT_TYPE_INT, {.i64=128}, 0, 255, },
I wonder if "threshold" is enough.
No more comments from me, thank you!
The pallettes generated by palettegen include one transparent color.
This patch enables paletteuse to identify the transparency in incoming
video and tag transparent pixels on outgoing video.
This requires tracking the transparency index in the palette,
establishing an alpha threshold below which
On 10/11/2017 3:04 PM, Bjorn Roche wrote:
> Can you explain where I went wrong? Is "Fix for paletteuse to support
> transparency" incorrect or not sufficient? Do you require that I repeat the
> message in the body as well? Or perhaps I invoked my git commands
> incorrectly?
That tells me what the
On Tue, Oct 10, 2017 at 5:56 PM, Derek Buitenhuis <
derek.buitenh...@gmail.com> wrote:
> On 10/10/2017 10:41 PM, Bjorn Roche wrote:
> > Partial fix for https://trac.ffmpeg.org/ticket/4443
> > (Animated GIFs are incorrectly optimized, so they still won’t be output
> > correctly).
> > ---
> > libav
On 10/10/2017 10:41 PM, Bjorn Roche wrote:
> Partial fix for https://trac.ffmpeg.org/ticket/4443
> (Animated GIFs are incorrectly optimized, so they still won’t be output
> correctly).
> ---
> libavfilter/vf_paletteuse.c | 210
>
> 1 file changed, 132
Partial fix for https://trac.ffmpeg.org/ticket/4443
(Animated GIFs are incorrectly optimized, so they still won’t be output
correctly).
---
libavfilter/vf_paletteuse.c | 210
1 file changed, 132 insertions(+), 78 deletions(-)
diff --git a/libavfilter/v
On Sat, Oct 7, 2017 at 9:53 AM, Carl Eugen Hoyos wrote:
> 2017-10-06 23:23 GMT+02:00 Carl Eugen Hoyos :
> > 2017-10-06 22:59 GMT+02:00 Bjorn Roche :
> >
> >> libavfilter/vf_paletteuse.c | 175
> >
> > Works fine for me
>
> I had tested with the sample from ticket #503 yesterday.
>
> Using the fol
On Sat, Oct 7, 2017 at 7:49 AM, Clément Bœsch wrote:
> On Sat, Oct 07, 2017 at 01:48:16PM +0200, Clément Bœsch wrote:
> > > Subject: Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support
> transparency
> >
> > "lavf/paletteuse: add support for transparency&qu
On Sat, Oct 7, 2017 at 7:48 AM, Clément Bœsch wrote:
> > Subject: Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support
> transparency
>
> "lavf/paletteuse: add support for transparency"
>
> On Fri, Oct 06, 2017 at 04:59:55PM -0400, Bjorn Roche wrote:
>
On Fri, Oct 6, 2017 at 5:23 PM, Carl Eugen Hoyos wrote:
> 2017-10-06 22:59 GMT+02:00 Bjorn Roche :
>
> > libavfilter/vf_paletteuse.c | 175
>
> Works fine for me, passes fate, needs a review from Clément.
>
> Do you think an option to set the value of the transparent
> colour to something else th
2017-10-06 23:23 GMT+02:00 Carl Eugen Hoyos :
> 2017-10-06 22:59 GMT+02:00 Bjorn Roche :
>
>> libavfilter/vf_paletteuse.c | 175
>
> Works fine for me
I had tested with the sample from ticket #503 yesterday.
Using the following sample:
http://samples.ffmpeg.org/FLV/flash_with_alpha/300x180-Scr-f8
On Sat, Oct 07, 2017 at 01:48:16PM +0200, Clément Bœsch wrote:
> > Subject: Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support
> > transparency
>
> "lavf/paletteuse: add support for transparency"
>
Sorry, "lavfi", not "lavf".
A
> Subject: Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency
"lavf/paletteuse: add support for transparency"
On Fri, Oct 06, 2017 at 04:59:55PM -0400, Bjorn Roche wrote:
> ---
> libavfilter/vf_paletteuse.c | 175
>
2017-10-06 22:59 GMT+02:00 Bjorn Roche :
> libavfilter/vf_paletteuse.c | 175
Works fine for me, passes fate, needs a review from Clément.
Do you think an option to set the value of the transparent
colour to something else than 0xFF00 would make sense?
And/or another default?
You can use ffplay
---
libavfilter/vf_paletteuse.c | 175
1 file changed, 112 insertions(+), 63 deletions(-)
diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c
index ffd37bf1da..4203543843 100644
--- a/libavfilter/vf_paletteuse.c
+++ b/libavfilter/vf_
32 matches
Mail list logo
