Re: [FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

2018-01-19 Thread Michael Niedermayer
On Thu, Jan 18, 2018 at 03:21:56PM -0800, Nikolas Bowe wrote: > --- > libavformat/matroskadec.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) will apply with the indention and commit message fixed thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF13361

Re: [FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

2018-01-19 Thread Carl Eugen Hoyos
2018-01-19 2:06 GMT+01:00 Niki Bowe : > In the file the fuzzer produced the frame rate is incredibly small > (7.29112e-304). And the msvc documentation seems to indicate it is supported. No more comments from me, please avoid top-posting here. Carl Eugen _

Re: [FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

2018-01-18 Thread Niki Bowe
In the file the fuzzer produced the frame rate is incredibly small (7.29112e-304). I thought %e (or %g if you prefer) produced the most appropriate and readable log message. Also happy to just remove the frame rate from the log if you prefer? On Thu, Jan 18, 2018 at 4:02 PM, Carl Eugen Hoyos wrot

Re: [FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

2018-01-18 Thread Carl Eugen Hoyos
2018-01-19 0:21 GMT+01:00 Nikolas Bowe : > + av_log(matroska->ctx, AV_LOG_WARNING, > + "Invalid frame rate %e. Cannot calculate default > duration.\n", > + track->video.frame_rate); We currently have one ocurence of "%e" in the who

[FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

2018-01-18 Thread Nikolas Bowe
--- libavformat/matroskadec.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 496499b553..cd9e1f56c2 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -2096,8 +2096,16 @@ static in