Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-06 Thread Marton Balint
On Wed, 3 Nov 2021, lance.lmw...@gmail.com wrote: On Wed, Nov 03, 2021 at 01:01:29PM +0200, Maksym Veremeyenko wrote: On 02.11.2021 12:47, Maksym Veremeyenko wrote: > One of latest commit https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e > claim

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-03 Thread lance . lmwang
On Wed, Nov 03, 2021 at 01:01:29PM +0200, Maksym Veremeyenko wrote: > On 02.11.2021 12:47, Maksym Veremeyenko wrote: > > One of latest commit > > https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e > > claim it fixes endless loop on package generation if

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-03 Thread Maksym Veremeyenko
On 02.11.2021 12:47, Maksym Veremeyenko wrote: One of latest commit https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e claim it fixes endless loop on package generation if muxrate specified and copyts used. But actually it does not work properly if

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-03 Thread Maksym Veremeyenko
On 03.11.2021 11:19, lance.lmw...@gmail.com wrote: On Tue, Nov 02, 2021 at 05:36:37PM +0200, Maksym Veremeyenko wrote: On 02.11.2021 16:59, lance.lmw...@gmail.com wrote: [...] +if (!ts->first_dts_checked && dts != AV_NOPTS_VALUE) { +ts->first_pcr += dts * 300; +ts->first_dts

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-03 Thread lance . lmwang
On Tue, Nov 02, 2021 at 05:36:37PM +0200, Maksym Veremeyenko wrote: > On 02.11.2021 16:59, lance.lmw...@gmail.com wrote: > [...] > > > +if (!ts->first_dts_checked && dts != AV_NOPTS_VALUE) { > > > +ts->first_pcr += dts * 300; > > > +ts->first_dts_checked = 1; > > > +} > > >

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-02 Thread Maksym Veremeyenko
On 02.11.2021 16:59, lance.lmw...@gmail.com wrote: [...] +if (!ts->first_dts_checked && dts != AV_NOPTS_VALUE) { +ts->first_pcr += dts * 300; +ts->first_dts_checked = 1; +} + I think it's not same as the old code, the first_pcr will add extra delay if copyts is 0. pr

Re: [FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-02 Thread lance . lmwang
On Tue, Nov 02, 2021 at 12:47:57PM +0200, Maksym Veremeyenko wrote: > One of latest commit > https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e > claim it fixes endless loop on package generation if muxrate specified and > copyts used. But actually it d

[FFmpeg-devel] [PATCH] Fix first_pcr initial update

2021-11-02 Thread Maksym Veremeyenko
One of latest commit https://source.ffmpeg.org/?p=ffmpeg.git;a=commitdiff;h=6f36eb0da71d22aadf8f056f0966bd86656ea57e claim it fixes endless loop on package generation if muxrate specified and copyts used. But actually it does not work properly if *-mpegts_copyts 1* specified: ffmpeg -y -copyt