Re: [FFmpeg-devel] [PATCH] Fix buffer resizing after probe done.

2018-12-20 Thread Artyom Lebedev
On 12/19/18 4:33 PM, Carl Eugen Hoyos wrote: How can we reproduce the assertion failure? I do not have a scenario for ffmpeg command line utility, I have it in a proprietary project based on libav*, here I have custom I/O attached to AVFormatContext, initial buffer was 64K, input is MPEGTS st

Re: [FFmpeg-devel] [PATCH] Fix buffer resizing after probe done.

2018-12-19 Thread Carl Eugen Hoyos
2018-12-19 13:40 GMT+01:00, Artyom Lebedev : > I have this assert fired after probing done How can we reproduce the assertion failure? In general, fixing the crash and (potentially) removing the assert() should be two different things. Carl Eugen ___ f

[FFmpeg-devel] [PATCH] Fix buffer resizing after probe done.

2018-12-19 Thread Artyom Lebedev
I have this assert fired after probing done and frames are normally read: "av_assert0(len >= s->orig_buffer_size);". Buffer size after probing ended up with ~5MB, orig_buffer_size was 64K. This place looks like total mess, it definitely has a bug with incorrect len modification even if buffer w