Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-05 Thread Hendrik Leppkes
On Tue, Jan 5, 2016 at 1:50 PM, Raymond Hilseth wrote: > > > On 04/01/16 17:36, "ffmpeg-devel on behalf of Hendrik Leppkes" > wrote: > >>On Mon, Jan 4, 2016 at 3:58 PM, wrote: >>> From: Raymond Hilseth >>> >>> Signed-off-by: Raymond Hilseth >>> --- >>> libavformat/dashenc.c | 4 ++-- >>> 1 f

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-05 Thread Raymond Hilseth
On 04/01/16 17:36, "ffmpeg-devel on behalf of Hendrik Leppkes" wrote: >On Mon, Jan 4, 2016 at 3:58 PM, wrote: >> From: Raymond Hilseth >> >> Signed-off-by: Raymond Hilseth >> --- >> libavformat/dashenc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavf

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 7:54 PM, Hendrik Leppkes wrote: > rename is used unconditionally in ff_rename as far as I can tell, so it > would probably be OK to remove the unistd.h check in file.c for rename? I would git blame and ask the author if possible first. - Derek

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Hendrik Leppkes
On 04.01.2016 20:10, Derek Buitenhuis wrote: On 1/4/2016 6:05 PM, Ganesh Ajjanagadde wrote: Personally, I think it should be ok to use rename here for now, especially since even projects like Python had trouble with this aspect: https://bugs.python.org/issue8828. Someone with greater Windows exp

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 6:05 PM, Ganesh Ajjanagadde wrote: > Personally, I think it should be ok to use rename here for now, > especially since even projects like Python had trouble with this > aspect: https://bugs.python.org/issue8828. Someone with greater > Windows expertise can then examine the validity of

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Ganesh Ajjanagadde
On Mon, Jan 4, 2016 at 9:12 AM, Derek Buitenhuis wrote: > On 1/4/2016 4:46 PM, Ganesh Ajjanagadde wrote: >> Yes, this is strange. url_move points to file_move, and the only >> system functionality it relies on is rename, available in stdio.h. The >> semantics vary from system to system, with some

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 4:46 PM, Ganesh Ajjanagadde wrote: > Yes, this is strange. url_move points to file_move, and the only > system functionality it relies on is rename, available in stdio.h. The > semantics vary from system to system, with some details specified in > POSIX, but rename itself is standard C:

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Ganesh Ajjanagadde
On Mon, Jan 4, 2016 at 8:36 AM, Hendrik Leppkes wrote: > On Mon, Jan 4, 2016 at 3:58 PM, wrote: >> From: Raymond Hilseth >> >> Signed-off-by: Raymond Hilseth >> --- >> libavformat/dashenc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/dashenc.c b

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Hendrik Leppkes
On Mon, Jan 4, 2016 at 3:58 PM, wrote: > From: Raymond Hilseth > > Signed-off-by: Raymond Hilseth > --- > libavformat/dashenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index 4509ee4..378c4e4 100644 > --- a/lib

[FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread rhi
From: Raymond Hilseth Signed-off-by: Raymond Hilseth --- libavformat/dashenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 4509ee4..378c4e4 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -549,7 +5