Re: [FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-19 Thread wm4
On Fri, 19 Sep 2014 08:19:34 -0500 Daniel Bomar wrote: > What should be tested in configure? IMO take this patch and and if it > breaks some old systems (not sure why it would) have a configure > option to revert this on those systems. I suppose it should test inet_aton, which is apparently why

Re: [FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-19 Thread Carl Eugen Hoyos
Daniel Bomar gmail.com> writes: > What should be tested in configure? You wrote that compilation fails for you with an error, I originally assumed this can be reproduced with current FFmpeg git head (rereading our mail, I am not so sure). If compilation fails, this can be tested in configure

Re: [FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-19 Thread Daniel Bomar
What should be tested in configure? IMO take this patch and and if it breaks some old systems (not sure why it would) have a configure option to revert this on those systems. On Thu, Sep 18, 2014 at 5:39 PM, Carl Eugen Hoyos wrote: > Daniel Bomar gmail.com> writes: > >> This is from /usr/includ

Re: [FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-18 Thread Carl Eugen Hoyos
Daniel Bomar gmail.com> writes: > This is from /usr/include/features.h which is provided by glibc. The > ./configure, make build that ffmpeg uses only generates a warning but > for some reason Chromium's ninja + clang build system generates an > error. Imo, this should be tested in configure.

[FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-18 Thread Daniel Bomar
This is from /usr/include/features.h which is provided by glibc. The ./configure, make build that ffmpeg uses only generates a warning but for some reason Chromium's ninja + clang build system generates an error. /* _BSD_SOURCE and _SVID_SOURCE are deprecated aliases for _DEFAULT_SOURCE. If _

Re: [FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-18 Thread Nicolas George
Le jour du Génie, an CCXXII, Daniel Bomar a écrit : > This actually generated an error trying to build ffmpeg as part of Chromium. Where does the "_DEFAULT_SOURCE" name come from? In the documentation for the glibc, it is flagged as "(BSD)", and thus requires _BSD_SOURCE. By the way, are there st

Re: [FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-18 Thread Carl Eugen Hoyos
Daniel Bomar gmail.com> writes: > /* needed by inet_aton() */ > -#define _SVID_SOURCE > +#define _DEFAULT_SOURCE Won't this break compilation on older systems? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

[FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

2014-09-18 Thread Daniel Bomar
This actually generated an error trying to build ffmpeg as part of Chromium. Signed-off-by: Daniel Bomar --- libavformat/os_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/os_support.c b/libavformat/os_support.c index e8f063a..7a948d8 100644 --- a/libavf