Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

2018-08-21 Thread Michael Niedermayer
On Mon, Aug 20, 2018 at 01:03:31PM -0700, Fredrik Hubinette wrote: > Ok, let's use cast, new patch attached. > > > On Mon, Jul 30, 2018 at 4:53 PM Michael Niedermayer > wrote: > > > On Mon, Jul 30, 2018 at 01:49:24PM -0700, Fredrik Hubinette wrote: > > > Is casting a negative integer to unsigne

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

2018-08-20 Thread Fredrik Hubinette
Ok, let's use cast, new patch attached. On Mon, Jul 30, 2018 at 4:53 PM Michael Niedermayer wrote: > On Mon, Jul 30, 2018 at 01:49:24PM -0700, Fredrik Hubinette wrote: > > Is casting a negative integer to unsigned defined behavior? > > yes > > 6.3.1.3 Signed and unsigned integers > > 2 Otherwis

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

2018-07-30 Thread Michael Niedermayer
On Mon, Jul 30, 2018 at 01:49:24PM -0700, Fredrik Hubinette wrote: > Is casting a negative integer to unsigned defined behavior? yes 6.3.1.3 Signed and unsigned integers 2 Otherwise, if the new type is unsigned, the value is converted by repeatedly adding or subtracting one more than the maxi

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

2018-07-30 Thread Fredrik Hubinette
Is casting a negative integer to unsigned defined behavior? On Wed, Jul 18, 2018 at 3:55 AM Michael Niedermayer wrote: > On Tue, Jul 17, 2018 at 02:37:55PM -0700, Fredrik Hubinette wrote: > > > > > utils.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > e69f1a3a447e331cad7ea85

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

2018-07-18 Thread Michael Niedermayer
On Tue, Jul 17, 2018 at 02:37:55PM -0700, Fredrik Hubinette wrote: > > utils.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > e69f1a3a447e331cad7ea85e28c0ed13e48ce33c > 0001-Avoid-undefined-behavior-when-start_time_text-is-1-6.patch > From d7bd55c3d280c10b990577003a985296f10a2b59

[FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

2018-07-17 Thread Fredrik Hubinette
From d7bd55c3d280c10b990577003a985296f10a2b59 Mon Sep 17 00:00:00 2001 From: Fredrik Hubinette Date: Tue, 17 Jul 2018 14:35:55 -0700 Subject: [PATCH] Avoid undefined behavior when start_time_text is -1<<63 --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git