Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-12 Thread Josh de Kock
On 11/10/2016 22:53, Moritz Barsnick wrote: On Tue, Oct 11, 2016 at 19:32:14 +0100, Josh de Kock wrote: On 11/10/2016 18:24, Alexey Eromenko wrote: *** BLURB HERE *** This commit message isn't very useful, it doesn't describe the change at all. See: https://www.ffmpeg.org/developer.html#Patch

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-12 Thread Ronald S. Bultje
Hi, On Oct 11, 2016 2:40 PM, "Alexey Eromenko" wrote: > > On Tue, Oct 11, 2016 at 8:29 PM, Josh de Kock wrote: > > On 11/10/2016 18:24, Alexey Eromenko wrote: > >> > >> --- > >> libavformat/movenc.c | 14 +- > >> 1 file changed, 9 insertions(+), 5 deletions(-) > >> > >> diff --git a

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 19:32:14 +0100, Josh de Kock wrote: > On 11/10/2016 18:24, Alexey Eromenko wrote: > > *** BLURB HERE *** > > This commit message isn't very useful, it doesn't describe the change at > all. See: > https://www.ffmpeg.org/developer.html#Patches_002fCommitting That's the cove

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
On Tuesday, 11 October 2016, Carl Eugen Hoyos wrote: > Hi! > > > Am 11.10.2016 um 19:24 schrieb Alexey Eromenko >: > > > > -if (track->mode == MODE_MOV > > This change is not acceptable: > The problem only affects mov, not isom. > Mentioning the option name in the existing warning me

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Carl Eugen Hoyos
Hi! > Am 11.10.2016 um 19:24 schrieb Alexey Eromenko : > -if (track->mode == MODE_MOV This change is not acceptable: The problem only affects mov, not isom. Mentioning the option name in the existing warning message is of course a good idea. Carl Eugen

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
>>> +unsigned int timescale_new = (unsigned >>> int)((double)(st->time_base.den) >>> +* 1000 / (double)(st->time_base.num)); >> >> You surely don't need all these casts. > > Unless I'm guaranteed to get int64 on ALL platforms, I don't see > how-to write this code wit

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
On Tue, Oct 11, 2016 at 8:29 PM, Josh de Kock wrote: > On 11/10/2016 18:24, Alexey Eromenko wrote: >> >> --- >> libavformat/movenc.c | 14 +- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >> index 8b4aa5f..0e2fc55 100

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Josh de Kock
On 11/10/2016 18:24, Alexey Eromenko wrote: *** BLURB HERE *** Alexey Eromenko (1): Apple Quicktime fix libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) This commit message isn't very useful, it doesn't describe the change at all. See: https://ww

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Josh de Kock
On 11/10/2016 18:24, Alexey Eromenko wrote: --- libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8b4aa5f..0e2fc55 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5666,16 +566

[FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Alexey Eromenko
*** BLURB HERE *** Alexey Eromenko (1): Apple Quicktime fix libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) -- 2.9.3 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

[FFmpeg-devel] [PATCH] Apple Quicktime fix

2016-10-11 Thread Alexey Eromenko
--- libavformat/movenc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 8b4aa5f..0e2fc55 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5666,16 +5666,20 @@ static int mov_write_header(AVFormatCo