We will upload a new patch with some fixes.
2015-05-01 4:41 GMT+02:00 Michael Niedermayer :
> On Thu, Apr 30, 2015 at 02:37:39PM +0200, Gorilla Maguila wrote:
> > New patch with some fixes:
> >
> > - Corrected style and formatting.
> > - No ugly casts.
> > - New hds_probe function
> > - No forwar
On Thu, Apr 30, 2015 at 02:37:39PM +0200, Gorilla Maguila wrote:
> New patch with some fixes:
>
> - Corrected style and formatting.
> - No ugly casts.
> - New hds_probe function
> - No forward declarations in f4fbox.c. I couldn't get rid of the forward
> declaration in amfmetadata.c due to circula
New patch with some fixes:
- Corrected style and formatting.
- No ugly casts.
- New hds_probe function
- No forward declarations in f4fbox.c. I couldn't get rid of the forward
declaration in amfmetadata.c due to circular dependencies (Ideas welcome)
- Other minor fixes.
TODO:
- Fragment caching
I can't think of a better way of avoiding forward declaration due to the
nested nature of the F4F Boxes and AMF data.
2015-04-28 15:32 GMT+02:00 Clément Bœsch :
> > +static int f4fbox_parse_single_box(AVIOContext *in, void *opaque);
>
> Again, isn't this avoidable?
> +static int amf_metadata_
I will try to fix all the problems, although I'm not the original author of
most of the code, I just added better fragments/segment calculation for
live streams, and other small changes.
2015-04-28 15:32 GMT+02:00 Clément Bœsch :
> On Tue, Apr 28, 2015 at 02:48:42PM +0200, Gorilla Maguila wrote:
On Tue, Apr 28, 2015 at 02:48:42PM +0200, Gorilla Maguila wrote:
[...]
> From 5bb2e85f2e7c4dfeb3569225e263ddc6a4f127cd Mon Sep 17 00:00:00 2001
> From: Developer Mobdro
> Date: Tue, 28 Apr 2015 14:38:35 +0200
> Subject: [PATCH] hds demuxer
>
> ---
> configure | 8 +
> libavform
I will work on it and I will upload a new patch soon.
2015-04-28 15:00 GMT+02:00 Carl Eugen Hoyos :
> Gorilla Maguila gmail.com> writes:
>
> > +static int hds_probe(AVProbeData *p)
> > +{
> > +if(p->filename && av_stristr(p->filename, ".f4m"))
> > +return AVPROBE_SCORE_MAX;
> > +
On Tue, 28 Apr 2015 14:48:42 +0200
Gorilla Maguila wrote:
> From 5bb2e85f2e7c4dfeb3569225e263ddc6a4f127cd Mon Sep 17 00:00:00 2001
> From: Developer Mobdro
> Date: Tue, 28 Apr 2015 14:38:35 +0200
> Subject: [PATCH] hds demuxer
>
> ---
> +mdat->data = av_mallocz(sizeof(uint8_t)*data_size);
Gorilla Maguila gmail.com> writes:
> +static int hds_probe(AVProbeData *p)
> +{
> +if(p->filename && av_stristr(p->filename, ".f4m"))
> +return AVPROBE_SCORE_MAX;
> +return 0;
> +}
Remove this function, instead add ".f4m" as
.extentions to the AVInputFormat.
Carl Eugen
___
Gorilla Maguila gmail.com> writes:
> New patch with some fixes:
Thank you for working on this!
> +if(type != AMF_DATA_TYPE_STRING) {
Please add a space after "if", same below.
> +av_log(NULL, AV_LOG_ERROR, "amfmetadata Expected type 2
Please pass the context to this function and
New patch with some fixes:
- use of av_freep
- use of context in av_log when possible
- corrected else-if format
- improved fragment/segment calculation for live streams
2014-09-18 12:01 GMT+02:00 Gorilla Maguila :
> I'll try to correct the patch and post it back.
>
> 2014-09-17 19:34 GMT+02:00
I'll try to correct the patch and post it back.
2014-09-17 19:34 GMT+02:00 Carl Eugen Hoyos :
> Gorilla Maguila gmail.com> writes:
>
> > http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2014-February/154612.html
> >
> > I attach a new patch with improvements:
>
> I wanted to write an answer with a
Gorilla Maguila gmail.com> writes:
> http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2014-February/154612.html
>
> I attach a new patch with improvements:
I wanted to write an answer with a few minor remarks
but just saw that several issues from the original
review are still valid:
http://thre
After contacting the original author of the the patch posted in:
http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2014-February/154612.html
I attach a new patch with improvements:
- Better codec detection in amfmetata
- Better live streams handling (Get current segment, calculate next
segment..etc
14 matches
Mail list logo
