Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Nicolas George
Julien Vary (12022-07-27): > >Or maybe we could add av_abort() as an alias to av_assert0(0), which > >eventually just calls abort()... > > I agree that if the goal is to bail-out on 'should-not-be-reachable' > code, something that alias av_assert0(0) seems a great idea. > Shall we then give a more

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Julien Vary
>> abort() should generally not be in a reachable part of the code - not >> inside any of the libraries anyway, ffmpeg.c is a different topic. >> If it is reachable with any input files, and not just present to shut >> up compilers, this is a bug and should be addressed to return an error >> i

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Marton Balint
On Wed, 27 Jul 2022, Hendrik Leppkes wrote: On Wed, Jul 27, 2022 at 4:03 PM Julien Vary wrote: Replaced all abort() by av_abort() in the code. On production systems, when dealing with malformed data, avcodec was sometime aborting, with no core/memory dump available to troubleshoot after-th

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Andreas Rheinhardt
Julien Vary: > >> abort() should generally not be in a reachable part of the code - not inside >> any of the libraries anyway, ffmpeg.c is a different topic. >> If it is reachable with any input files, and not just present to shut up >> compilers, this is a bug and should be addressed to return

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Julien Vary
> abort() should generally not be in a reachable part of the code - not inside > any of the libraries anyway, ffmpeg.c is a different topic. > If it is reachable with any input files, and not just present to shut up > compilers, this is a bug and should be addressed to return an error instead.

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Hendrik Leppkes
On Wed, Jul 27, 2022 at 4:03 PM Julien Vary wrote: > > Replaced all abort() by av_abort() in the code. > On production systems, when dealing with malformed data, > avcodec was sometime aborting, with no core/memory dump > available to troubleshoot after-the-fact. > Adding av_abort_set_callback to

Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Nicolas George
Julien Vary (12022-07-27): > Replaced all abort() by av_abort() in the code. > On production systems, when dealing with malformed data, > avcodec was sometime aborting, with no core/memory dump > available to troubleshoot after-the-fact. > Adding av_abort_set_callback to register a custom > functio

[FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().

2022-07-27 Thread Julien Vary
Replaced all abort() by av_abort() in the code. On production systems, when dealing with malformed data, avcodec was sometime aborting, with no core/memory dump available to troubleshoot after-the-fact. Adding av_abort_set_callback to register a custom function (instead of the default straight abor