Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-10 Thread NagaChaitanya Vellanki
Hi Reimar, Will send in a new patch with the improvements for review :-). Thank you, Naga On Wed, Mar 9, 2016 at 11:05 AM, Reimar Döffinger wrote: > On Wed, Mar 09, 2016 at 10:27:29AM -0800, NagaChaitanya Vellanki wrote: > > On Tue, Mar 8, 2016 at 5:33 PM, James Almer wrote: > > > > > On 3/8/2

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-09 Thread Reimar Döffinger
On Wed, Mar 09, 2016 at 10:27:29AM -0800, NagaChaitanya Vellanki wrote: > On Tue, Mar 8, 2016 at 5:33 PM, James Almer wrote: > > > On 3/8/2016 2:21 AM, NagaChaitanya Vellanki wrote: > > > --- > > > libavutil/Makefile | 1 + > > > libavutil/hash.c | 42 +

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-09 Thread Michael Niedermayer
On Wed, Mar 09, 2016 at 10:27:29AM -0800, NagaChaitanya Vellanki wrote: > Ping Michael to review to patch. patch applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing something just because microsoft

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-09 Thread NagaChaitanya Vellanki
Ping Michael to review to patch. Thank you, Naga On Tue, Mar 8, 2016 at 5:33 PM, James Almer wrote: > On 3/8/2016 2:21 AM, NagaChaitanya Vellanki wrote: > > --- > > libavutil/Makefile | 1 + > > libavutil/hash.c | 42 ++ > > tests/fate/li

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-09 Thread NagaChaitanya Vellanki
I wont qualify for GSoC because i am full time employed and a part time student. Thank you, Naga On Sun, Mar 6, 2016 at 3:26 PM, Michael Niedermayer wrote: > On Sun, Mar 06, 2016 at 11:27:59AM -0800, NagaChaitanya Vellanki wrote: > > Please review the patch. > > > > NagaChaitanya Vellanki (1):

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-08 Thread James Almer
On 3/8/2016 2:21 AM, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/hash.c | 42 ++ > tests/fate/libavutil.mak | 4 > tests/ref/fate/hash | 45 + > 4 files cha

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-08 Thread NagaChaitanya Vellanki
Please review the latest patch. the DST_BUF_SIZE is not AV_HASH_MAX_SIZE * 8 since AV_HASH_MAX_SIZE is 64. Thank you, Naga On Sun, Mar 6, 2016 at 9:45 PM, James Almer wrote: > On 3/7/2016 12:26 AM, NagaChaitanya Vellanki wrote: > > --- > > libavutil/Makefile | 1 + > > libavutil/hash.c

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-07 Thread NagaChaitanya Vellanki
--- libavutil/Makefile | 1 + libavutil/hash.c | 42 ++ tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 + 4 files changed, 92 insertions(+) create mode 100644 tests/ref/fate/hash

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread James Almer
On 3/7/2016 12:26 AM, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/hash.c | 45 + > tests/fate/libavutil.mak | 4 > tests/ref/fate/hash | 45 + > 4 files

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
--- libavutil/Makefile | 1 + libavutil/hash.c | 45 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 + 4 files changed, 95 insertions(+) create mode 100644 tests/ref/fate/ha

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
Made changes as suggested by James Almer. NagaChaitanya Vellanki (1): Add tests for functions in hash.c libavutil/Makefile | 1 + libavutil/hash.c | 45 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 ++

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 11:27:59AM -0800, NagaChaitanya Vellanki wrote: > Please review the patch. > > NagaChaitanya Vellanki (1): > Add tests for functions in hash.c btw, if this is a qualification task for GSoC or Outreachy then please add yourself to https://trac.ffmpeg.org/wiki/SponsoringPr

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread James Almer
On 3/6/2016 4:28 PM, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/hash.c | 41 + > tests/fate/libavutil.mak | 4 > tests/ref/fate/hash | 45 + > 4 files chan

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
--- libavutil/Makefile | 1 + libavutil/hash.c | 41 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 + 4 files changed, 91 insertions(+) create mode 100644 tests/ref/fate/hash

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
Please review the patch. NagaChaitanya Vellanki (1): Add tests for functions in hash.c libavutil/Makefile | 1 + libavutil/hash.c | 41 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 +++