Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Steven Liu
Bohan Li 于2021年2月9日周二 上午8:24写道: > > Thank you very much for the reviews and the fixes, Jan! > I went over the fixup commit and I do agree with the patches you proposed. > It looks good to me. > > Just to make sure I don't misunderstand, should I submit a new patch with > the modifications you ment

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Thank you very much for the reviews and the fixes, Jan! I went over the fixup commit and I do agree with the patches you proposed. It looks good to me. Just to make sure I don't misunderstand, should I submit a new patch with the modifications you mentioned, or leave the patch as is and you would

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Jan Ekström
On Thu, Feb 4, 2021 at 11:02 PM Bohan Li wrote: > > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > Excellent! Thank you for moving this forward :) . I noticed various things which I will also notice here

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Jan Ekström
On Mon, Feb 8, 2021 at 10:40 PM Christopher Degawa wrote: > > Quick question as a user that is not entirely related to this patch, would > it be possible to add something like a `ffmpeg ... -libaom-params help -f > null -` or someother way that would print out the options available in the > compil

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Christopher Degawa
Quick question as a user that is not entirely related to this patch, would it be possible to add something like a `ffmpeg ... -libaom-params help -f null -` or someother way that would print out the options available in the compiled libaom? (In the case where we do not have aomenc compiled or it's

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-08 Thread Bohan Li
Gentle ping :) On Thu, Feb 4, 2021 at 1:45 PM Bohan Li wrote: > Thanks for the review! Indeed the buf string does not play any role here. > I have removed it in the new patch. > > Bohan > > On Thu, Feb 4, 2021 at 1:02 PM Bohan Li wrote: > >> This key & value API can greatly help with users who

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-04 Thread Bohan Li
Thanks for the review! Indeed the buf string does not play any role here. I have removed it in the new patch. Bohan On Thu, Feb 4, 2021 at 1:02 PM Bohan Li wrote: > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg o

[FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-04 Thread Bohan Li
This key & value API can greatly help with users who wants to try libaom-av1 specific options that are not supported by ffmpeg options. As was previously discussed in this thread: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2020-October/271658. The commit that added the API to libaom: https:/

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-03 Thread Andreas Rheinhardt
Bohan Li: > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > > As was previously discussed in this thread: > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2020-October/271658. > > The commit that added th

Re: [FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-03 Thread Steven Liu
> 2021年2月4日 上午8:01,Bohan Li 写道: > > This key & value API can greatly help with users who wants to try > libaom-av1 specific options that are not supported by ffmpeg options. > > As was previously discussed in this thread: > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2020-October/271658. >

[FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-03 Thread Bohan Li
This key & value API can greatly help with users who wants to try libaom-av1 specific options that are not supported by ffmpeg options. As was previously discussed in this thread: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2020-October/271658. The commit that added the API to libaom: https:/

[FFmpeg-devel] [PATCH] Add support for the new key & value API in libaom.

2021-02-03 Thread Bohan Li
This key & value API can greatly help with users who wants to try libaom-av1 specific options that are not supported by ffmpeg options. As was previously discussed in this thread: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2020-October/271658. The commit that added the API to libaom: https:/