Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-13 Thread Marton Balint
On Sat, 13 Jul 2019, mikroh...@gmail.com wrote: From: Jernej Fijacko Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle

2019-07-13 Thread Jernej
Thanks for the explanation. I sent a new patch with the original commit message (and additional line break). I hope that everything is fine now. Regards, Jernej On Sat, Jul 13, 2019 at 12:45 AM Moritz Barsnick wrote: > On Sat, Jul 13, 2019 at 00:24:29 +0200, mikroh...@gmail.com wrote: > > From:

[FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-13 Thread mikrohard
From: Jernej Fijacko Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD (720x576) resolution which causes them to either rend

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle

2019-07-12 Thread Moritz Barsnick
On Sat, Jul 13, 2019 at 00:24:29 +0200, mikroh...@gmail.com wrote: > From: Jernej I think you had your full name in here originally. Note that whatever you provide here will be in the repo forever. > > Patch with requested changes. Your original commit text should be in here, not your message t

[FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle

2019-07-12 Thread mikrohard
From: Jernej Patch with requested changes. --- libavcodec/dvbsub.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/libavcodec/dvbsub.c b/libavcodec/dvbsub.c index 8cce702..a8d43d8 100644 --- a/libavcodec/dvbsub.c +++ b/libavcodec/dvbsub.c @@ -247,9 +247,

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-12 Thread Marton Balint
On Fri, 12 Jul 2019, Jernej wrote: Here's the fixed patch. I'm not familiar with providing patches via a mailing list. If replying doesn't work, I'll just use a new git send-mail. Yes, please, preferably with --in-reply-to= Thanks, Marton Signed-off-by: Jernej Fijacko --- libavcodec/dvb

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-12 Thread Jernej
Here's the fixed patch. I'm not familiar with providing patches via a mailing list. If replying doesn't work, I'll just use a new git send-mail. Signed-off-by: Jernej Fijacko --- libavcodec/dvbsub.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/libavcod

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-11 Thread Jernej
To answer your questions... 1.) Yes, 2 is the version. To be honest I didn't really know what it meant. I had a working sample stream & used the same values. But after reading the spec I can see it's only used to signal changes in the display definition segment which means it could be anything bet

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-11 Thread Marton Balint
On Thu, 11 Jul 2019, mikroh...@gmail.com wrote: Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD (720x576) resolution

[FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-11 Thread mikrohard
Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD (720x576) resolution which causes them to either render the subtitles too