>seems to break fate
Ok, I spent some time looking into what's happening, and I've figured what's
causing the failures. The issue isn't that it's producing *invalid* output, but
that it's just *different* output. As I had said, I wrote this patch some time
ago, so I had forgotten a decision I
>$ make SAMPLES=fate-suite fate-rsync
>$ make SAMPLES=fate-suite fate
That explains it. The "Contribute" documentation just says "make fate", so I
didn't realize I wasn't running the entire suite.
I re-ran the tests, and saw a different test fail, being lavf-fate-vp3.ogg.
Looking at the hex data
Lewis Fox:
> Signed-off-by: Lewis Fox
> ---
> This is an implementation for #4448, adding support for embedding attached
> cover art to OGG files. I had a need for the feature for a setup I was using,
> and had written a patch for it about half a year ago. I had forgotten to
> submit it back th
LRFLEW:
>> seems to break fate
>
>> --- ./tests/ref/fate/limited_input_seek-copyts 2020-05-28
>> 14:46:23.971547831 +0200
>> +++ tests/data/fate/limited_input_seek-copyts 2020-06-07
>> 22:10:38.303050886 +0200
>> @@ -1 +1 @@
>> -ffe8a674bdf38e4f650f91963debc654
>> +aae5603508b268cbb456b633
Am So., 7. Juni 2020 um 22:54 Uhr schrieb LRFLEW :
> I had noticed this on Patchwork. It shows errors for "limited_input_seek"
> and "limited_input_seek-copyts". https://patchwork.ffmpeg.org/check/11651/
> However, I've run "make fate" multiple times locally now and it always
> passed for me. Look
>seems to break fate
>--- ./tests/ref/fate/limited_input_seek-copyts 2020-05-28
>14:46:23.971547831 +0200
>+++ tests/data/fate/limited_input_seek-copyts 2020-06-07 22:10:38.303050886
>+0200
>@@ -1 +1 @@
>-ffe8a674bdf38e4f650f91963debc654
>+aae5603508b268cbb456b633b84a48af
>Test limited_inp
Am Sa., 6. Juni 2020 um 23:40 Uhr schrieb Lewis Fox
:
> libavformat/flac_picture.c | 112 +-
> libavformat/flac_picture.h | 6 +-
> libavformat/flacdec.c| 4 +-
> libavformat/flacenc.c| 100 +
Moving flac_write_picture() should be a separate patch.
Carl Eu
On Sat, Jun 06, 2020 at 04:37:54PM -0500, Lewis Fox wrote:
> Signed-off-by: Lewis Fox
> ---
> This is an implementation for #4448, adding support for embedding attached
> cover art to OGG files. I had a need for the feature for a setup I was using,
> and had written a patch for it about half a y
Signed-off-by: Lewis Fox
---
This is an implementation for #4448, adding support for embedding attached
cover art to OGG files. I had a need for the feature for a setup I was using,
and had written a patch for it about half a year ago. I had forgotten to submit
it back then, though. I remembere
