Re: [FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-07 Thread Andreas Rheinhardt
Walter: > I understand. Would it be better to roll back the patch to just adding > S_TEXT/WEBVTT to list of recognized codec ids for now? We would need to add support for the Matroska way first. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-07 Thread Walter
matroska codec id S_TEXT/WEBVTT for WebVTT streams. Walter Wong:> Added the codec id S_TEXT/WEBVTT in order to bring ffmpeg generated files> closer to the matroska spec. The list of matroska codec ids was also> rearranged to push the old codec id (D_WEBVTT/SUBTITLES) to the bottom of>

Re: [FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-07 Thread Andreas Rheinhardt
Walter Wong: > Added the codec id S_TEXT/WEBVTT in order to bring ffmpeg generated files > closer to the matroska spec. The list of matroska codec ids was also > rearranged to push the old codec id (D_WEBVTT/SUBTITLES) to the bottom of > the list so that S_TEXT/WEBVTT is the default codec id for ne

[FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-06 Thread Walter Wong
Added the codec id S_TEXT/WEBVTT in order to bring ffmpeg generated files closer to the matroska spec. The list of matroska codec ids was also rearranged to push the old codec id (D_WEBVTT/SUBTITLES) to the bottom of the list so that S_TEXT/WEBVTT is the default codec id for new mkv files with webv

Re: [FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-06 Thread Walter Wong
Alright, I've updated the patch with the ticket number. Should I apply this fix to the WebM muxer as well? The WebM spec is not clear on what to do in this case. On Sat, 6 Feb 2021 at 22:02, Carl Eugen Hoyos wrote: > > Am So., 7. Feb. 2021 um 03:50 Uhr schrieb Walter Wong : > > > > Added the c

Re: [FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-06 Thread Carl Eugen Hoyos
Am So., 7. Feb. 2021 um 03:50 Uhr schrieb Walter Wong : > > Added the codec id S_TEXT/WEBVTT in order to bring ffmpeg generated files > closer to the matroska spec. The list of matroska codec ids was also > rearranged to push the old codec id (D_WEBVTT/SUBTITLES) to the bottom of > the list so that

[FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-06 Thread Walter Wong
Added the codec id S_TEXT/WEBVTT in order to bring ffmpeg generated files closer to the matroska spec. The list of matroska codec ids was also rearranged to push the old codec id (D_WEBVTT/SUBTITLES) to the bottom of the list so that S_TEXT/WEBVTT is the default codec id for new mkv files with webv