Re: [FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

2022-03-30 Thread Martijn van Beurden
First of all, thanks for reviewing Op wo 30 mrt. 2022 om 12:42 schreef Andreas Rheinhardt : > Can this happen with real encoders or has this file been specifically > crafted? What is the performance impact of this patch on ordinary files? This file has been crafted. It seems unlikely to occur in

Re: [FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

2022-03-30 Thread Andreas Rheinhardt
Martijn van Beurden: > The size of residuals in a FLAC file coding for 24-bit PCM can > exceed the range of a 32-bit signed integer. One pathological > example with residuals exceeding [-2^33,2^33) can be found here: > http://www.audiograaf.nl/misc_stuff/Extreme%20residual%20LPC%20order%2014.flac

[FFmpeg-devel] [PATCH] Add decoding of > 32-bit residuals to FLAC

2022-03-27 Thread Martijn van Beurden
The size of residuals in a FLAC file coding for 24-bit PCM can exceed the range of a 32-bit signed integer. One pathological example with residuals exceeding [-2^33,2^33) can be found here: http://www.audiograaf.nl/misc_stuff/Extreme%20residual%20LPC%20order%2014.flac The theorectical maximum bit