Thanks for your feedback.
@item vps_id_offset
@item sps_id_offset
@item pps_id_offset
Replace the original VPS/SPS/PPS identifier by adding an offset.
Offset sounds just as good to me. Is this clear?
On Wed, Jan 8, 2020 at 4:46 PM Moritz Barsnick wrote:
> On Wed, Jan 08, 2020 at 15:42:09 +0100
On Wed, Jan 08, 2020 at 15:42:09 +0100, Anton Khirnov wrote:
> If negative values are allowed, then 'offset' would be more accurate.
That's the word I was looking for, nice. Even valid if only positive
offsets are allowed. (I understand you implemented wrap-around. Perhaps
sufficient to write that
It's limited to [0 - 16] (positive)
On Wed, Jan 8, 2020 at 4:42 PM Anton Khirnov wrote:
> Quoting Eran Gonen (2020-01-08 15:25:20)
> > I will fix the style and documentation and resubmit.
> > { "increase_vps_id", "Increase the vps id",
> > Is this naming more clear to you?
>
> If negative values
On Wed, Jan 08, 2020 at 16:25:20 +0200, Eran Gonen wrote:
> { "increase_vps_id", "Increase the vps id",
> Is this naming more clear to you?
If that's what it does, then this is indeed clearer to me.
But since it's not boolean, it's a number, it should perhaps reflect
that. I can't come up with so
Quoting Eran Gonen (2020-01-08 15:25:20)
> I will fix the style and documentation and resubmit.
> { "increase_vps_id", "Increase the vps id",
> Is this naming more clear to you?
If negative values are allowed, then 'offset' would be more accurate.
--
Anton Khirnov
___
I will fix the style and documentation and resubmit.
{ "increase_vps_id", "Increase the vps id",
Is this naming more clear to you?
On Wed, Jan 8, 2020 at 4:18 PM Moritz Barsnick wrote:
> On Wed, Jan 08, 2020 at 16:10:12 +0200, Eran Gonen wrote:
> > Advance pps id means advance pps id. What would
On Wed, Jan 08, 2020 at 16:10:12 +0200, Eran Gonen wrote:
> Advance pps id means advance pps id. What would you suggest?
You mean, mathematically speaking, "increase"?
You didn't fix the "if(" -> "if (" style isse.
And as Hendrik mentioned (I missed that originally): The
"hevc_metadata" section
It would, I'll change it.
Thanks,
Eran
On Wed, Jan 8, 2020 at 3:32 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> On Wed, Jan 8, 2020 at 2:18 PM Eran Gonen
> wrote:
>
> > ---
> > libavcodec/h265_metadata_bsf.c | 117 +++--
> > 1 file changed, 111 ins
Advance pps id means advance pps id. What would you suggest?
On Wed, Jan 8, 2020 at 4:04 PM Hendrik Leppkes wrote:
> On Wed, Jan 8, 2020 at 2:18 PM Eran Gonen
> wrote:
> > @@ -547,6 +642,16 @@ static const AVOption h265_metadata_options[] = {
> > OFFSET(crop_bottom), AV_OPT_TYPE_INT,
>
On Wed, Jan 8, 2020 at 2:18 PM Eran Gonen wrote:
> @@ -547,6 +642,16 @@ static const AVOption h265_metadata_options[] = {
> OFFSET(crop_bottom), AV_OPT_TYPE_INT,
> { .i64 = -1 }, -1, HEVC_MAX_HEIGHT, FLAGS },
>
> +{ "advance_vps_id", "Advance the vps id",
> +OFFSET(ad
On Wed, Jan 8, 2020 at 2:18 PM Eran Gonen wrote:
> ---
> libavcodec/h265_metadata_bsf.c | 117 +++--
> 1 file changed, 111 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/h265_metadata_bsf.c
> b/libavcodec/h265_metadata_bsf.c
> index b3a1fda144..796046ac7f 1
---
libavcodec/h265_metadata_bsf.c | 117 +++--
1 file changed, 111 insertions(+), 6 deletions(-)
diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c
index b3a1fda144..796046ac7f 100644
--- a/libavcodec/h265_metadata_bsf.c
+++ b/libavcodec/h265
12 matches
Mail list logo
