Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-18 Thread Claudio Freire
On Fri, Sep 18, 2015 at 3:10 PM, James Almer wrote: > On 9/15/2015 4:24 AM, Claudio Freire wrote: >> This patch refactors the AAC coders to reuse code >> between the MIPS port and the regular, portable C code. >> There were two main functions that had to use >> hand-optimized versions of quantizat

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-18 Thread James Almer
On 9/15/2015 4:24 AM, Claudio Freire wrote: > This patch refactors the AAC coders to reuse code > between the MIPS port and the regular, portable C code. > There were two main functions that had to use > hand-optimized versions of quantization code: > - search_for_quantizers_twoloop > - codebook_

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-16 Thread Claudio Freire
On Wed, Sep 16, 2015 at 12:30 PM, Nedeljko Babic wrote: Patch attached. I thought it was worth a review. It does include lots of copypaste. FTR, I tested MIPS 74Kf and x86_64 with make fate-aac >>> >>> full fate passes on qemu mips here as well! >> >>If

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-16 Thread Nedeljko Babic
>>> >>> >>> Patch attached. >>> >>> I thought it was worth a review. >>> >>> It does include lots of copypaste. >>> >>> FTR, I tested MIPS 74Kf and x86_64 with make fate-aac >> >> full fate passes on qemu mips here as well! > >If there's no objections then, I will be pushing it later today, >before

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-16 Thread Claudio Freire
On Tue, Sep 15, 2015 at 8:11 AM, Michael Niedermayer wrote: > On Tue, Sep 15, 2015 at 04:24:02AM -0300, Claudio Freire wrote: >> This patch refactors the AAC coders to reuse code >> between the MIPS port and the regular, portable C code. >> There were two main functions that had to use >> hand-opt

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-15 Thread Michael Niedermayer
On Tue, Sep 15, 2015 at 04:24:02AM -0300, Claudio Freire wrote: > This patch refactors the AAC coders to reuse code > between the MIPS port and the regular, portable C code. > There were two main functions that had to use > hand-optimized versions of quantization code: > - search_for_quantizers_tw

[FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-15 Thread Claudio Freire
This patch refactors the AAC coders to reuse code between the MIPS port and the regular, portable C code. There were two main functions that had to use hand-optimized versions of quantization code: - search_for_quantizers_twoloop - codebook_trellis_rate Those two were split into their own templa