Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-12-02 Thread Claudio Freire
On Tue, Dec 1, 2015 at 11:12 PM, Claudio Freire wrote: > On Tue, Dec 1, 2015 at 10:47 PM, Michael Niedermayer wrote: >>> libavcodec/aaccoder.c | 60 -- >>> libavcodec/aaccoder_twoloop.h | 136 >>> -- >>> libavcodec/aacenc.c

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-12-01 Thread Claudio Freire
On Tue, Dec 1, 2015 at 10:47 PM, Michael Niedermayer wrote: >> libavcodec/aaccoder.c | 60 -- >> libavcodec/aaccoder_twoloop.h | 136 >> -- >> libavcodec/aacenc.c |2 >> libavcodec/aacenc_is.c| 11 ++- >>

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-12-01 Thread Michael Niedermayer
On Tue, Dec 01, 2015 at 03:35:40AM -0300, Claudio Freire wrote: > On Mon, Nov 30, 2015 at 1:04 PM, Hendrik Leppkes wrote: > > On Mon, Nov 30, 2015 at 4:50 PM, Claudio Freire > > wrote: > >> On Mon, Nov 30, 2015 at 12:27 PM, Rostislav Pehlivanov > >> wrote: > >>> On Sun, 2015-11-29 at 16:54 -030

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-12-01 Thread Rostislav Pehlivanov
On Tue, 2015-12-01 at 03:35 -0300, Claudio Freire wrote: >  > Attached patch does that. > Went over the patch, everything me and other people said has been addressed, so LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-12-01 Thread Hendrik Leppkes
On Tue, Dec 1, 2015 at 7:35 AM, Claudio Freire wrote: > On Mon, Nov 30, 2015 at 1:04 PM, Hendrik Leppkes wrote: >> On Mon, Nov 30, 2015 at 4:50 PM, Claudio Freire >> wrote: >>> On Mon, Nov 30, 2015 at 12:27 PM, Rostislav Pehlivanov >>> wrote: On Sun, 2015-11-29 at 16:54 -0300, Claudio Fre

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-30 Thread Claudio Freire
On Mon, Nov 30, 2015 at 1:04 PM, Hendrik Leppkes wrote: > On Mon, Nov 30, 2015 at 4:50 PM, Claudio Freire > wrote: >> On Mon, Nov 30, 2015 at 12:27 PM, Rostislav Pehlivanov >> wrote: >>> On Sun, 2015-11-29 at 16:54 -0300, Claudio Freire wrote: Before pushing this, I'd like some feedback, >

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-30 Thread Claudio Freire
On Mon, Nov 30, 2015 at 2:20 PM, Rostislav Pehlivanov wrote: > On Mon, 2015-11-30 at 12:50 -0300, Claudio Freire wrote: >> Also I don't see how a static var would help or even be correct here. >> Perhaps you meant something else? > static uint8_t cond1 = param1 && param2; > static uint8_t cond2 =

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-30 Thread Rostislav Pehlivanov
On Mon, 2015-11-30 at 12:50 -0300, Claudio Freire wrote: > Also I don't see how a static var would help or even be correct here. > Perhaps you meant something else? static uint8_t cond1 = param1 && param2; static uint8_t cond2 = param3 && !param4; ...etc return cond1 && cond2; _

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-30 Thread Claudio Freire
On Mon, Nov 30, 2015 at 1:04 PM, Hendrik Leppkes wrote: > On Mon, Nov 30, 2015 at 4:50 PM, Claudio Freire > wrote: >> On Mon, Nov 30, 2015 at 12:27 PM, Rostislav Pehlivanov >> wrote: >>> On Sun, 2015-11-29 at 16:54 -0300, Claudio Freire wrote: Before pushing this, I'd like some feedback, >

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-30 Thread Hendrik Leppkes
On Mon, Nov 30, 2015 at 4:50 PM, Claudio Freire wrote: > On Mon, Nov 30, 2015 at 12:27 PM, Rostislav Pehlivanov > wrote: >> On Sun, 2015-11-29 at 16:54 -0300, Claudio Freire wrote: >>> Before pushing this, I'd like some feedback, >>> especially about >>> the implementation of point 3. I'm not sur

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-30 Thread Claudio Freire
On Mon, Nov 30, 2015 at 12:27 PM, Rostislav Pehlivanov wrote: > On Sun, 2015-11-29 at 16:54 -0300, Claudio Freire wrote: >> Before pushing this, I'd like some feedback, >> especially about >> the implementation of point 3. I'm not sure the AAC encoder >> setting the cutoff in the encoder context l

Re: [FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-30 Thread Rostislav Pehlivanov
On Sun, 2015-11-29 at 16:54 -0300, Claudio Freire wrote: > Before pushing this, I'd like some feedback, > especially about > the implementation of point 3. I'm not sure the AAC encoder > setting the cutoff in the encoder context like this is legal or > desirable. I think setting the cutoff is neces

[FFmpeg-devel] [PATCH] AAC encoder: improve SF range utilization

2015-11-29 Thread Claudio Freire
Attached Before pushing this, I'd like some feedback, especially about the implementation of point 3. I'm not sure the AAC encoder setting the cutoff in the encoder context like this is legal or desirable. It does work quite well, and all attempts to do it otherwise were either very invasive or re