Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-06-04 Thread Wolfgang Lorenz
Am Thu, 4 Jun 2015 03:18:20 +0200 schrieb Michael Niedermayer : > On Sun, May 31, 2015 at 06:35:18PM +0200, Wolfgang Lorenz wrote: > > Am Sat, 30 May 2015 12:58:38 +0200 > > schrieb Hendrik Leppkes : > > > > > On Sat, May 30, 2015 at 12:39 PM, Wolfgang Lorenz wrote: > > > > Am Sat, 30 May 2015 1

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-06-04 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > Also the S302 in fate is identified by a registration > descriptor there should be nothing unreliable in its > detection I don't know if this is related at all but FFmpeg (also) detects Dolby-E as S302, see http://samples.ffmpeg.org/ffmpeg-bugs/trac/tick

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-06-03 Thread Michael Niedermayer
On Sun, May 31, 2015 at 06:35:18PM +0200, Wolfgang Lorenz wrote: > Am Sat, 30 May 2015 12:58:38 +0200 > schrieb Hendrik Leppkes : > > > On Sat, May 30, 2015 at 12:39 PM, Wolfgang Lorenz wrote: > > > Am Sat, 30 May 2015 11:00:18 +0200 > > > schrieb Wolfgang Lorenz : > > > > > > [...] > > > > > > O

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-31 Thread Wolfgang Lorenz
Am Sat, 30 May 2015 12:58:38 +0200 schrieb Hendrik Leppkes : > On Sat, May 30, 2015 at 12:39 PM, Wolfgang Lorenz wrote: > > Am Sat, 30 May 2015 11:00:18 +0200 > > schrieb Wolfgang Lorenz : > > > > [...] > > > > Okay. Now I get the same errors Michael had, after the first version of > > the patch,

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-30 Thread Hendrik Leppkes
On Sat, May 30, 2015 at 12:39 PM, Wolfgang Lorenz wrote: > Am Sat, 30 May 2015 11:00:18 +0200 > schrieb Wolfgang Lorenz : > >> Am Sat, 30 May 2015 06:57:49 + (UTC) >> schrieb Carl Eugen Hoyos : > >> [...] > >> > $ make SAMPLES=fate-suite fate-rsync >> > $ make SAMPLES=fate-suite fate >> >> I s

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-30 Thread Wolfgang Lorenz
Am Sat, 30 May 2015 11:00:18 +0200 schrieb Wolfgang Lorenz : > Am Sat, 30 May 2015 06:57:49 + (UTC) > schrieb Carl Eugen Hoyos : > [...] > > $ make SAMPLES=fate-suite fate-rsync > > $ make SAMPLES=fate-suite fate > > I see. Looks like this is going to take a while. I come back, when I have

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-30 Thread Wolfgang Lorenz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Sat, 30 May 2015 06:57:49 + (UTC) schrieb Carl Eugen Hoyos : > Wolfgang Lorenz gmx.de> writes: > > > Strange. Do you have another configuration? I > > configured ffmpeg via: > > $ ./configure --disable-static --enable-shared > > > --disa

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-29 Thread Carl Eugen Hoyos
Wolfgang Lorenz gmx.de> writes: > Strange. Do you have another configuration? I > configured ffmpeg via: > $ ./configure --disable-static --enable-shared > --disable-debug --enable-debug That looks strange... (But works as expected iirc) > --disable-optimizations --disable-stripping > > I

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-29 Thread Wolfgang Lorenz
Am Sat, 30 May 2015 05:30:30 +0200 schrieb Michael Niedermayer : [...] > --- ./tests/ref/acodec/s302m2015-05-29 00:02:07.530881596 +0200 > +++ tests/data/fate/acodec-s302m2015-05-30 05:29:38.689115803 +0200 > @@ -1,4 +1,2 @@ > 2d1494ad78292dca556fd079ec27f28d *tests/data/fate/acodec-

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-29 Thread Michael Niedermayer
On Sat, May 30, 2015 at 03:54:18AM +0200, Wolfgang Lorenz wrote: > Indeed, this does work too. And it even doesn't break any fates... > At least on my machine. > --- > libavformat/mpegts.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c > index

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-29 Thread Wolfgang Lorenz
Indeed, this does work too. And it even doesn't break any fates... At least on my machine. --- libavformat/mpegts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index aeb2335..cafcc92 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-29 Thread Hendrik Leppkes
On Fri, May 29, 2015 at 10:45 PM, Wolfgang Lorenz wrote: > The patch addresses this problem: > https://lists.ffmpeg.org/pipermail/libav-user/2014-September/007475.html > > What it does is this: > * Except stream type 0x06 as a private stream. (AVMEDIA_TYPE_DATA, > AV_CODEC_ID_NONE) > (It was

Re: [FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-29 Thread Michael Niedermayer
On Fri, May 29, 2015 at 10:45:47PM +0200, Wolfgang Lorenz wrote: > The patch addresses this problem: > https://lists.ffmpeg.org/pipermail/libav-user/2014-September/007475.html > > What it does is this: > * Except stream type 0x06 as a private stream. (AVMEDIA_TYPE_DATA, > AV_CODEC_ID_NONE) >

[FFmpeg-devel] [PATCH] * mpegts demuxer should recognize private streams

2015-05-29 Thread Wolfgang Lorenz
The patch addresses this problem: https://lists.ffmpeg.org/pipermail/libav-user/2014-September/007475.html What it does is this: * Except stream type 0x06 as a private stream. (AVMEDIA_TYPE_DATA, AV_CODEC_ID_NONE) (It was necessary to convince mpegts_set_stream_info(), that AV_CODEC_ID_NONE