Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 11:34 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Dec 22, 2015 at 12:48 PM, Ganesh Ajjanagadde > wrote: >> >> On Tue, Dec 22, 2015 at 8:04 AM, Ganesh Ajjanagadde >> wrote: >> > On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer >> > wrote: >> [...] >> >> >> >> IMHO a

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ronald S. Bultje
Hi, On Tue, Dec 22, 2015 at 12:48 PM, Ganesh Ajjanagadde wrote: > On Tue, Dec 22, 2015 at 8:04 AM, Ganesh Ajjanagadde > wrote: > > On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer > > wrote: > [...] > >> > >> IMHO a exp10 fallback should be implemented using exp2() if that is > faster > >>

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 8:04 AM, Ganesh Ajjanagadde wrote: > On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer > wrote: [...] >> >> IMHO a exp10 fallback should be implemented using exp2() if that is faster >> and available. > > I don't know whether the fallback should use exp or exp2, need to

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Ganesh Ajjanagadde
On Tue, Dec 22, 2015 at 3:35 AM, Michael Niedermayer wrote: > On Mon, Dec 21, 2015 at 07:19:50PM -0800, Ganesh Ajjanagadde wrote: >> exp10 is a function available in GNU libm. Looks like no other common >> libm has it. As such, I am mostly neutral about its inclusion, with a >> very slight bias in

Re: [FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-22 Thread Michael Niedermayer
On Mon, Dec 21, 2015 at 07:19:50PM -0800, Ganesh Ajjanagadde wrote: > exp10 is a function available in GNU libm. Looks like no other common > libm has it. As such, I am mostly neutral about its inclusion, with a > very slight bias in favor since I am actually posting this. > > pros: > 1. It is fas

[FFmpeg-devel] [PATCH][RFC] lavu/libm: add exp10 support

2015-12-21 Thread Ganesh Ajjanagadde
exp10 is a function available in GNU libm. Looks like no other common libm has it. As such, I am mostly neutral about its inclusion, with a very slight bias in favor since I am actually posting this. pros: 1. It is faster than pow, and has less of a chance of going into one of the terribly slow pa