Re: [FFmpeg-devel] [PATCH/RFC] libavcodec/cinepak: Separate decoding from parsing

2019-09-03 Thread Tomas Härdin
tis 2019-09-03 klockan 13:53 +0200 skrev Michael Niedermayer: > On Sun, Sep 01, 2019 at 10:58:27PM +0200, Tomas Härdin wrote: > > libavcodec/cinepak.c| 337 --- > > - > > tests/ref/fate/cvid-palette |1 > > tests/ref/fate/cvid-partial |1 >

Re: [FFmpeg-devel] [PATCH/RFC] libavcodec/cinepak: Separate decoding from parsing

2019-09-03 Thread Michael Niedermayer
On Sun, Sep 01, 2019 at 10:58:27PM +0200, Tomas Härdin wrote: > libavcodec/cinepak.c| 337 > > tests/ref/fate/cvid-palette |1 > tests/ref/fate/cvid-partial |1 > 3 files changed, 215 insertions(+), 124 deletions(-) > 197f986bfb297c5

Re: [FFmpeg-devel] [PATCH/RFC] libavcodec/cinepak: Separate decoding from parsing

2019-09-02 Thread Tomas Härdin
sön 2019-09-01 klockan 23:07 +0200 skrev Carl Eugen Hoyos: > Am So., 1. Sept. 2019 um 22:58 Uhr schrieb Tomas Härdin < > tjop...@acc.umu.se>: > > > Attached patch separates parsing from decoding in the Cinepak decoder. > > It puts in some rather strict checks which are in line with how I've > > fi

Re: [FFmpeg-devel] [PATCH/RFC] libavcodec/cinepak: Separate decoding from parsing

2019-09-01 Thread Carl Eugen Hoyos
Am So., 1. Sept. 2019 um 22:58 Uhr schrieb Tomas Härdin : > Attached patch separates parsing from decoding in the Cinepak decoder. > It puts in some rather strict checks which are in line with how I've > figured the VfW 1.1 decoder works. Parsing is still intermixed with > validation, but the code

[FFmpeg-devel] [PATCH/RFC] libavcodec/cinepak: Separate decoding from parsing

2019-09-01 Thread Tomas Härdin
Hi Attached patch separates parsing from decoding in the Cinepak decoder. It puts in some rather strict checks which are in line with how I've figured the VfW 1.1 decoder works. Parsing is still intermixed with validation, but the code should be much easier to read this way compared to before. Som