Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-10-04 Thread Michael Niedermayer
On Tue, Oct 04, 2016 at 12:22:38AM +0530, Umair Khan wrote: > Hi, > > Patch attached. > > It fixes the fate tests. > However, there's a slight bug in the encoder in handling the last frame. > I'll definitely fix it later. > I hope the patch can be merged in this state. [...] > +/** > + * Quantize

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-10-03 Thread Umair Khan
Hi, On Tue, Oct 4, 2016 at 1:53 AM, Thilo Borgmann wrote: > Hi, > >> Patch attached. >> >> It fixes the fate tests. >> However, there's a slight bug in the encoder in handling the last frame. >> I'll definitely fix it later. >> I hope the patch can be merged in this state. > > no. The last frame

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-10-03 Thread Thilo Borgmann
Hi, > Patch attached. > > It fixes the fate tests. > However, there's a slight bug in the encoder in handling the last frame. > I'll definitely fix it later. > I hope the patch can be merged in this state. no. The last frame has to be handled properly before merging happens. I'm at LinuxCon & EL

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-29 Thread Michael Niedermayer
On Mon, Aug 29, 2016 at 10:47:59PM +0530, Umair Khan wrote: > Hi, > > On Sun, Aug 28, 2016 at 4:26 PM, Michael Niedermayer > wrote: > > On Sun, Aug 28, 2016 at 01:34:46PM +0530, Umair Khan wrote: > >> Hi, > >> > >> Patches attached. :) > >> > >> - Umair > > > >> Changelog |1 + > >> 1 file c

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-29 Thread James Almer
On 8/29/2016 2:17 PM, Umair Khan wrote: >>> +if (HAVE_MMX) >>> >> +ff_window_init_mmx(wctx); >> > >> > breaks build on non x86 as the function declaration / prototype is >> > not there in that case > What should I do with this then? I'm not too aware of how the whole > code works becaus

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-29 Thread Umair Khan
Hi, On Sun, Aug 28, 2016 at 4:26 PM, Michael Niedermayer wrote: > On Sun, Aug 28, 2016 at 01:34:46PM +0530, Umair Khan wrote: >> Hi, >> >> Patches attached. :) >> >> - Umair > >> Changelog |1 + >> 1 file changed, 1 insertion(+) >> d3f30e62d803d967bd5c27dc5dfad278ce5c02e9 >> 0001-Changelog

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-29 Thread Thilo Borgmann
> Am 28.08.2016 um 22:11 schrieb Michael Niedermayer : > >> On Sun, Aug 28, 2016 at 09:50:41PM +0200, Hendrik Leppkes wrote: >> On Sun, Aug 28, 2016 at 9:21 PM, Michael Niedermayer >> wrote: >>> On Sun, Aug 28, 2016 at 12:03:38PM -0300, James Almer wrote: >>> [...] Also, the changelog en

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Michael Niedermayer
On Sun, Aug 28, 2016 at 09:50:41PM +0200, Hendrik Leppkes wrote: > On Sun, Aug 28, 2016 at 9:21 PM, Michael Niedermayer > wrote: > > On Sun, Aug 28, 2016 at 12:03:38PM -0300, James Almer wrote: > > [...] > >> Also, the changelog entry line can be part of the encoder patch, no > >> need to have it

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Hendrik Leppkes
On Sun, Aug 28, 2016 at 9:21 PM, Michael Niedermayer wrote: > On Sun, Aug 28, 2016 at 12:03:38PM -0300, James Almer wrote: > [...] >> Also, the changelog entry line can be part of the encoder patch, no >> need to have it separate. > > actually, i was just thinking having Changelog + version + APIC

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread James Almer
On 8/28/2016 4:21 PM, Michael Niedermayer wrote: > On Sun, Aug 28, 2016 at 12:03:38PM -0300, James Almer wrote: > [...] >> Also, the changelog entry line can be part of the encoder patch, no >> need to have it separate. > > actually, i was just thinking having Changelog + version + APIChanges > ch

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Michael Niedermayer
On Sun, Aug 28, 2016 at 12:03:38PM -0300, James Almer wrote: [...] > Also, the changelog entry line can be part of the encoder patch, no > need to have it separate. actually, i was just thinking having Changelog + version + APIChanges changes separate from the main patch could make sense as these

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread James Almer
On 8/28/2016 7:48 AM, Umair Khan wrote: > On Sun, Aug 28, 2016 at 1:56 PM, Paul B Mahol wrote: >> Hi, >> >> On Sun, Aug 28, 2016 at 10:04 AM, Umair Khan wrote: >> >>> Hi, >>> >>> Patches attached. :) >> >> >> Inline asm is unacceptable to get into master. > > How should that case be handled then

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Michael Niedermayer
On Sun, Aug 28, 2016 at 01:34:46PM +0530, Umair Khan wrote: > Hi, > > Patches attached. :) > > - Umair > Changelog |1 + > 1 file changed, 1 insertion(+) > d3f30e62d803d967bd5c27dc5dfad278ce5c02e9 > 0001-Changelog-Add-entry-for-ALS-encoder.patch > From 020370545a82c8c1304ec9c177a75e27e59b

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Hendrik Leppkes
On Sun, Aug 28, 2016 at 12:48 PM, Umair Khan wrote: > On Sun, Aug 28, 2016 at 1:56 PM, Paul B Mahol wrote: >> Hi, >> >> On Sun, Aug 28, 2016 at 10:04 AM, Umair Khan wrote: >> >>> Hi, >>> >>> Patches attached. :) >> >> >> Inline asm is unacceptable to get into master. > > How should that case be

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Umair Khan
On Sun, Aug 28, 2016 at 1:56 PM, Paul B Mahol wrote: > Hi, > > On Sun, Aug 28, 2016 at 10:04 AM, Umair Khan wrote: > >> Hi, >> >> Patches attached. :) > > > Inline asm is unacceptable to get into master. How should that case be handled then? - Umair _

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Paul B Mahol
Hi, On Sun, Aug 28, 2016 at 10:04 AM, Umair Khan wrote: > Hi, > > Patches attached. :) Inline asm is unacceptable to get into master. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel