Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-09-13 Thread Reimar Döffinger
On Wed, Aug 23, 2017 at 10:26:45PM +0200, Alexander Strasser wrote: > On 2017-08-22 17:23 +, Michael Niedermayer wrote: > > ffmpeg | branch: master | Michael Niedermayer | > > Tue Aug 22 18:36:26 2017 +0200| [a2e444d5bb2e3115d3afcc0cca9d1506c90436a2] > > | committer: Michael Niedermayer > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-09-13 Thread Moritz Barsnick
On Wed, Aug 23, 2017 at 22:26:45 +0200, Alexander Strasser wrote: > > -if ((ret = decode_zbuf(&bp, s->gb.buffer, s->gb.buffer + length) < 0)) > > +if ((ret = decode_zbuf(&bp, s->gb.buffer, s->gb.buffer + length)) < 0) > > IMHO another reason not to do the assignment and the comparison on t

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-08-23 Thread Alexander Strasser
On 2017-08-22 17:23 +, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Tue > Aug 22 18:36:26 2017 +0200| [a2e444d5bb2e3115d3afcc0cca9d1506c90436a2] | > committer: Michael Niedermayer > > avcodec/pngdec: Fix () placement > > Signed-off-by: Michael Niedermayer >