Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 01:13:56PM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-24 18:56 GMT+02:00 Michael Niedermayer : > > aggree, a PRORES_PROFILE_AUTO seems like a good idea > > with it mismatching profile and pixel format can be errors while > > by default the profile can be selected ba

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-30 Thread Christophe Gisquet
Hi, 2014-08-24 18:56 GMT+02:00 Michael Niedermayer : > aggree, a PRORES_PROFILE_AUTO seems like a good idea > with it mismatching profile and pixel format can be errors while > by default the profile can be selected based on the pixel format The attached patch makes it selects either or HQ p

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-24 Thread Michael Niedermayer
On Mon, Aug 18, 2014 at 07:26:32PM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-18 13:40 GMT+02:00 Carl Eugen Hoyos : > > Christophe Gisquet gmail.com> writes: > > If a profile was set, the automatic setting should > > probably not overwrite it. > > (If this is possible.) > > > > But I cons

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-18 Thread Christophe Gisquet
Hi, 2014-08-18 13:40 GMT+02:00 Carl Eugen Hoyos : > Christophe Gisquet gmail.com> writes: > If a profile was set, the automatic setting should > probably not overwrite it. > (If this is possible.) > > But I consider the usecase where a user wants to encode > alpha but at the same time using a pro

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-18 Thread Christophe Gisquet
2014-08-18 19:26 GMT+02:00 Christophe Gisquet : > Hi, And with all patches. -- Christophe From 89b54fbd698eb9c68f0bf30105bcaf72c5575d27 Mon Sep 17 00:00:00 2001 From: Christophe Gisquet Date: Mon, 18 Aug 2014 11:27:50 +0200 Subject: [PATCH] proresenc: force correct profile for alpha Irrespecti

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-18 Thread Carl Eugen Hoyos
Christophe Gisquet gmail.com> writes: > An alternative would be to select the profile based on > the pixel format. What would be the disadvantage in this case? > If a user wants to encode without alpha, he would then > need to change the pixel format as well as specify the > proper profile,

[FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-18 Thread Christophe Gisquet
Hi, Ticket #3846 is about an incorrect profile being used: - The user wants alpha but the profile indicates to software there's no alpha - Also, the encoder still encodes the alpha channel in spite of the profile The attached patch is not the most user-friendly, but is preferred by the encoder au