Re: [FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

2021-12-29 Thread zozobreak
From 0da67d346a7901b572ac9ec5812634576b315d79 Mon Sep 17 00:00:00 2001 From: zourenyi Date: Wed, 29 Dec 2021 17:33:50 +0800 Subject: [PATCH v4] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame' since there is only debug log 'no picture ooo' when droping a pict

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

2021-12-29 Thread zozobreak
uot; PRId64 ") because out of order\n", +                   av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts); +        } else { +            av_log(h->avctx, AV_LOG_DEBUG, "no picture\n"); +        }      }        return 0; --  2.32.0.windows.2

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

2021-12-29 Thread zozobreak
NG, + "drop picture(%c, %d/%" PRId64 ") because out of order\n", + av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts); +} else { +av_log(h->avctx, AV_LOG_DEBUG, "no picture\n");

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

2021-12-29 Thread zozobreak
_WARNING, + "drop picture(%c, %d/%" PRId64 ") because of ooo\n", + av_get_picture_type_char(out->f->pict_type), out->poc, out->f->pts); +} else { +av_log(h->avctx, AV_LOG_DEBUG, "no picture\n"); +} } retu

[FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame'

2021-12-28 Thread zozobreak
since there is only debug log 'no picture ooo' when droping a picture, I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps', FFmpeg keeped silence about this error, so a warning log is much helpfull about this. Signed-off-by: zou