Re: [FFmpeg-devel] [PATCH v2] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-02 Thread zheng qian
On Thu, Nov 2, 2023 at 5:40 PM Gyan Doshi wrote: > > > > On 2023-11-02 01:21 am, Gyan Doshi wrote: > > > > > > On 2023-11-01 08:54 pm, zheng qian wrote: > >> Fix the mistake in the description of `-caption_encoding > >> encoding_scheme` option. >

[FFmpeg-devel] [PATCH v2] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-01 Thread zheng qian
Fix the mistake in the description of `-caption_encoding encoding_scheme` option. Signed-off-by: zheng qian --- doc/decoders.texi | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/doc/decoders.texi b/doc/decoders.texi index eb00e2a9e9..f75364166e 100644 --- a/doc

[FFmpeg-devel] [PATCH 1/1] lavc/libaribcaption: Fix mistake in document decoders.texi

2023-11-01 Thread zheng qian
Fix the mistake in the description of `-caption_encoding encoding_scheme` option. Signed-off-by: zheng qian --- doc/decoders.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/decoders.texi b/doc/decoders.texi index eb00e2a9e9..59279bde24 100644 --- a/doc

[FFmpeg-devel] [PATCH 0/1] Fix document mistake for lavc/libaribcaption

2023-11-01 Thread zheng qian
Hi, I'm fixing a mistake contained in the document for lavc/libaribcaption. This affects the 6.1 release so please also cheery-pick this patch to 6.1. zheng qian (1): lavc/libaribcaption: Fix mistake in document decoders.texi doc/decoders.texi | 4 ++-- 1 file changed, 2 insertions(

[FFmpeg-devel] [PATCH v3 4/4] fftools/ffmpeg: Ignore dts checking for AV_DISPOSITION_URGENT

2021-07-16 Thread zheng qian
Stream with AV_DISPOSITION_URGENT disposition flag could be NOPTS. Signed-off-by: zheng qian --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 1ac2e48600..a3b720748b 100644 --- a/fftools/ffmpeg.c +++ b/fftools

[FFmpeg-devel] [PATCH v3 3/4] avformat/mpegtsenc: Add muxing support for ARIB superimpose stream

2021-07-16 Thread zheng qian
Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 40 +++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 98dac17994..b5d2938c4a 100644 --- a/libavformat/mpegtsenc.c +++ b

[FFmpeg-devel] [PATCH v3 2/4] avformat/mpegts: Recognize ARIB superimpose stream

2021-07-16 Thread zheng qian
Recognize ARIB superimpose stream through ARIB data coding descriptor, and re-use AV_CODEC_ID_ARIB_CAPTION codec id with an extra disposition flag AV_DISPOSITION_URGENT. Signed-off-by: zheng qian --- libavformat/mpegts.c | 23 +++ 1 file changed, 19 insertions(+), 4

[FFmpeg-devel] [PATCH v3 1/4] avformat: Introduce AV_DISPOSITION_URGENT disposition flag for emergency alert

2021-07-16 Thread zheng qian
e to remux ARIB superimpose stream correctly Signed-off-by: zheng qian --- libavformat/avformat.h | 1 + libavformat/dump.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 81d2ac38d0..6c7d3fb3a5 100644 --- a/libavformat/avformat.h ++

[FFmpeg-devel] [PATCH v2 5/5] avcodec/libaribb24: Enable decoding support for arib_superimpose

2021-06-12 Thread zheng qian
ARIB superimpose packet could also be decoded by libaribb24 Signed-off-by: zheng qian --- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libaribb24.c | 14 ++ 3 files changed, 16 insertions(+) diff --git a/configure b/configure index 6bfd98b384

[FFmpeg-devel] [PATCH v2 4/5] fftools/ffmpeg: Ignore PTS checking for arib_superimpose

2021-06-12 Thread zheng qian
arib_superimpose codec doesn't has PTS (AV_NOPTS_VALUE) Signed-off-by: zheng qian --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index e97d879cb3..d60ab49533 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffm

[FFmpeg-devel] [PATCH v2 3/5] avformat/mpegtsenc: Add muxing support for arib_superimpose

2021-06-12 Thread zheng qian
Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 98dac17994..68f69d5df8 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat

[FFmpeg-devel] [PATCH v2 2/5] avformat/mpegts: Recognize arib_superimpose by ARIB data coding descriptor

2021-06-12 Thread zheng qian
Signed-off-by: zheng qian --- libavformat/mpegts.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index a02965bacf..6c5fb53c51 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2106,8

[FFmpeg-devel] [PATCH v2 1/5] avcodec/codec: Add arib_superimpose subtitle codec

2021-06-12 Thread zheng qian
ARIB superimpose stream correctly 2) Let ffmpeg-based player to be able to recognize ARIB superimpose stream then extract binary data and render it onto screen Signed-off-by: zheng qian --- libavcodec/codec_desc.c | 8 libavcodec/codec_id.h | 1 + libavcodec/version.h| 4 ++-- 3 files ch

[FFmpeg-devel] [PATCH 2/5] avformat/mpegts: Recognize arib_superimpose by ARIB data coding descriptor

2021-06-12 Thread zheng qian
Signed-off-by: zheng qian --- libavformat/mpegts.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index a02965bacf..6c5fb53c51 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2106,8

[FFmpeg-devel] [PATCH 1/5] avcodec/codec: Add arib_superimpose subtitle codec

2021-06-12 Thread zheng qian
ARIB superimpose stream correctly 2) Let ffmpeg-based player to be able to recognize ARIB superimpose stream then extract binary data and render it onto screen Signed-off-by: zheng qian --- libavcodec/codec_desc.c | 8 libavcodec/codec_id.h | 1 + libavcodec/version.h| 4 ++-- 3 files ch

[FFmpeg-devel] [PATCH 3/5] avformat/mpegtsenc: Add muxing support for arib_superimpose

2021-06-12 Thread zheng qian
Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 98dac17994..68f69d5df8 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat

[FFmpeg-devel] [PATCH 5/5] avcodec/libaribb24: Enable decoding support for arib_superimpose

2021-06-12 Thread zheng qian
ARIB superimpose packet could also be decoded by libaribb24 Signed-off-by: zheng qian --- libavcodec/allcodecs.c | 1 + libavcodec/libaribb24.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index 623db2a9fa..5d5b536e97

[FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: Ignore PTS checking for arib_superimpose

2021-06-12 Thread zheng qian
arib_superimpose codec doesn't has PTS (AV_NOPTS_VALUE) Signed-off-by: zheng qian --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index e97d879cb3..d60ab49533 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffm

Re: [FFmpeg-devel] [PATCH v4] avformat/mpegtsenc: enable muxing of ARIB captions

2021-06-07 Thread zheng qian
On Tue, Jun 8, 2021 at 2:28 AM Jan Ekström wrote: > > On Mon, Jun 7, 2021 at 8:09 PM Jan Ekström wrote: > > > > From: zheng qian > > > > Writes a general ARIB stream identifier descriptor, as well > > as a data component descriptor w

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-28 Thread zheng qian
On Thu, Apr 29, 2021 at 4:40 AM Marton Balint wrote: > > Thanks, applied the series with slightly modified/extended commit > message based on your earlier commit message. > > Regards, > Marton Thank you! Best regards, zheng ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-27 Thread zheng qian
On Wed, Apr 21, 2021 at 7:04 AM Jan Ekström wrote: > > I think in general I am preferring the "follow the TR" way since I > just heard another implementer generally speaking also ignores > everything else than 0x30/0x87. > > Did not yet add the per-program limitation but poked a bit at it with > h

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-24 Thread zheng qian
On Sun, Apr 25, 2021 at 2:13 AM Marton Balint wrote: > > The order of the patches seems wrong. Patch/3 (or similar) should be > applied first, otherwise you are checking the stream_id provided via side > data, not the stream id actually used. > > Also note that is_dvb_teletext/is_dvb_subtitle migh

[FFmpeg-devel] [PATCH v4 3/4] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-24 Thread zheng qian
, Japan DTV transmits news and alerts through ARIB superimpose that utilizes private_stream_2 still could not be remuxed correctly for now. This patch set fixes the remuxing for private_stream_2 and other stream_id types. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 15

[FFmpeg-devel] [PATCH v4 3/4] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-24 Thread zheng qian
, Japan DTV transmits news and alerts through ARIB superimpose that utilizes private_stream_2 still could not be remuxed correctly for now. This patch set fixes the remuxing for private_stream_2 and other stream_id types. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 15

[FFmpeg-devel] [PATCH v4 1/4] avformat/mpegts: Add missing constants for MPEG-TS stream_id definitions

2021-04-24 Thread zheng qian
Signed-off-by: zheng qian --- libavformat/mpegts.h | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mpegts.h b/libavformat/mpegts.h index 04874e0f42..224282b3ed 100644 --- a/libavformat/mpegts.h +++ b/libavformat/mpegts.h @@ -138,11 +138,19 @@ #define

[FFmpeg-devel] [PATCH v4 2/4] avformat/mpegts: Fix indentation for stream_id constants

2021-04-24 Thread zheng qian
Signed-off-by: zheng qian --- libavformat/mpegts.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/libavformat/mpegts.h b/libavformat/mpegts.h index 224282b3ed..c75ba08f29 100644 --- a/libavformat/mpegts.h +++ b/libavformat/mpegts.h @@ -138,18

[FFmpeg-devel] [PATCH v4 4/4] avformat/mpegtsenc: Fix indentation inside if-clause in mpegts_write_pes()

2021-04-24 Thread zheng qian
Fix indentation caused by the added stream_id judgement Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 180 1 file changed, 90 insertions(+), 90 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index e6fcecbaca

Re: [FFmpeg-devel] [PATCH v3 3/3] avformat/mpegtsenc: Write stream_id into PES after stream_id decision

2021-04-24 Thread zheng qian
On Sat, Apr 24, 2021 at 5:09 PM Mao Hata wrote: > > > v3 patch looks good to me. > Then, since the patch itself is based on ISO_IEC_13818-1, it perhaps has > some (side) effects for ATSC/DVB as well. If possible, you might want to > wait for opinions from ATSC/DVB sides. > > Mao Hata > I will add

[FFmpeg-devel] [PATCH v3 3/3] avformat/mpegtsenc: Write stream_id into PES after stream_id decision

2021-04-22 Thread zheng qian
Since stream_id will have effect on the existences of PES header fields like PTS/DTS, it should be better to guarantee stream_id variable to be identical with exact written value. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 15 --- 1 file changed, 8 insertions(+), 7

[FFmpeg-devel] [PATCH v3 2/3] avformat/mpegtsenc: Fix indentation inside if-clause in mpegts_write_pes()

2021-04-22 Thread zheng qian
Fix indentation caused by the added stream_id judgement Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 180 1 file changed, 90 insertions(+), 90 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index b59dab5174

[FFmpeg-devel] [PATCH v3 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-22 Thread zheng qian
d. For example, Japan DTV transmits news and alerts through ARIB superimpose that utilizes private_stream_2 still could not be remuxed correctly for now. This patch set fixes the remuxing for private_stream_2 and other stream_id types. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 15

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-21 Thread zheng qian
On Thu, Apr 22, 2021 at 12:11 PM Mao Hata wrote: > > PES_packet_length seems to be inaccurate, because "header_len + 3" has > already been added to the variable "len". I'm sorry for that and I'll submit v3 patch set later. Please tell me if there're any other problems. Regards, zheng >

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread zheng qian
On Wed, Apr 21, 2021 at 10:00 AM zheng qian wrote: > > ARIB superimpose should utilize Timing(00) since superimpose > uses Asynchronous_PES, but it belongs to another topic. > > In other words, addtitional_arib_caption_info can be generated by > profile information safely and i

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread zheng qian
On Wed, Apr 21, 2021 at 7:04 AM Jan Ekström wrote: > > I think in general I am preferring the "follow the TR" way since I > just heard another implementer generally speaking also ignores > everything else than 0x30/0x87. > > Did not yet add the per-program limitation but poked a bit at it with > h

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread zheng qian
On Tue, Apr 20, 2021 at 6:46 AM Jan Ekström wrote: > > On Tue, Apr 20, 2021 at 12:11 AM Marton Balint wrote: > > > > > > > > On Mon, 19 Apr 2021, zheng qian wrote: > > > > > Is there anyone who could review this patch? > > > > Jan was inte

[FFmpeg-devel] [PATCH v2 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-19 Thread zheng qian
ritten with PTS/DTS field. For example, Japan DTV transmits news and alerts through ARIB superimpose that utilizes private_stream_2 still could not be remuxed correctly for now. This patch set fixes the remuxing for private_stream_2 and other stream_id types. Signed-off-by: zheng qian -

[FFmpeg-devel] [PATCH v2 3/3] avformat/mpegtsenc: Write stream_id into PES after stream_id decision

2021-04-19 Thread zheng qian
Since stream_id will have effect on the existences of PES header fields like PTS/DTS, it should be better to guarantee stream_id variable to be identical with exact written value. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 15 --- 1 file changed, 8 insertions(+), 7

[FFmpeg-devel] [PATCH v2 2/3] avformat/mpegtsenc: Fix indentation inside if statement in mpegts_write_pes()

2021-04-19 Thread zheng qian
Fix indentation caused by the added stream_id judgement Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 84 - 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 0c543c385b

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-19 Thread zheng qian
IB superimpose that utilizes private_stream_2 still could not be remuxed correctly for now. This patch fixes the remuxing of private_stream_2 and other stream_id types. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 108 ++-- 1 file changed, 60 insert

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-19 Thread zheng qian
On Tue, Apr 20, 2021 at 12:44 AM Mao Hata wrote: > > The reason I created the patch was to fix the problem: when I transcode > a transport stream based on ARIB-STD-B24, the PTS/DTS is removed from > private_stream_1 streams, and, conversely, it is added to private_stream_2. > "ISO/IEC 13818-1 Tabl

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-18 Thread zheng qian
Is there anyone who could review this patch? Best regards, zheng ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-15 Thread zheng qian
On Fri, Apr 16, 2021 at 12:22 AM zheng qian wrote: > + > +// data_component_descriptor, defined in ARIB STD-B10, part > 2, 6.2.20 > +*q++ = 0xFD; // descriptor_tag: ARIB data coding type > descriptor > +*q++ = 3; //

[FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-15 Thread zheng qian
stream_identifier and data_component_id from ARIB profile. arib_caption remuxing could be worked correctly through this patch. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 29 + 1 file changed, 29 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread zheng qian
On Mon, Apr 12, 2021 at 1:10 AM Jan Ekström wrote: > For context, just checked some random sample I had on hand: > > ARIB caption info: DMF: 0xa, reserved: 0x3, timing: 0x1 > > So "both caption streams are selectable/showable when both received > and playing back a recording" (0b1010), reserved bi

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread zheng qian
Consider the remuxed stream could be handled by other clients rather than FFmpeg, e.g. I'm working on HTML5 playback for ISDB television with ARIB captions through mpegts.js + b24.js/aribb24.js. Other ISDB TV clients may also have possibilities to check these fields, probably. It will become more

[FFmpeg-devel] [PATCH v2 2/2] libavformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption

2021-04-09 Thread zheng qian
of arib_caption. After this patch, arib_caption inside the outputted (remuxed) mpegts stream can be recognized correctly as an arib_caption subtitle stream. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/libavfor

[FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-09 Thread zheng qian
other additional information. Signed-off-by: zheng qian --- libavformat/mpegts.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 6e0d9d7496..fd7ea1f504 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -

[FFmpeg-devel] [PATCH v1 2/2] libavformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption

2021-04-06 Thread zheng qian
of arib_caption. After this patch, arib_caption inside the outputted (remuxed) mpegts stream can be recognized correctly as an arib_caption subtitle stream. Signed-off-by: zheng qian --- libavformat/mpegtsenc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/libavfor

[FFmpeg-devel] [PATCH v1 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-06 Thread zheng qian
the profile and other additional information. Signed-off-by: zheng qian --- libavformat/mpegts.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 6e0d9d7496..a6a534a277 100644 --- a/libavformat/mpegts.c +++ b/libavfor