Re: [FFmpeg-devel] [PATCH 1/1] segafilm: fetch duration from the container

2018-04-19 Thread Misty De Meo
On Thu, Apr 19, 2018 at 8:31 PM, James Almer wrote: > > > +film->sample_table[i].duration = AV_RB32(&scratch[12]); > > While for video tracks this field seems to report the same packet > durations that were being calculated pre patch, this field for audio > tracks is always 1. > > Before t

[FFmpeg-devel] [PATCH 0/1] segafilm: fetch duration from the container

2018-04-18 Thread misty
From: Misty De Meo This improves on the previous patch by using the data defined in the container rather than by calculating the duration by iterating over packets. Misty De Meo (1): segafilm: fetch duration from the container libavformat/segafilm.c | 20 +++- 1 file changed

[FFmpeg-devel] [PATCH 1/1] segafilm: fetch duration from the container

2018-04-18 Thread misty
From: Misty De Meo --- libavformat/segafilm.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c index e72c26b144..1529fc385e 100644 --- a/libavformat/segafilm.c +++ b/libavformat/segafilm.c @@ -43,6 +43,7

[FFmpeg-devel] [PATCH 0/1] re: Sega FILM: set dts and duration when demuxing

2018-04-08 Thread misty
From: Misty De Meo I've updated this so it applies on master. This patch is still necessary; the wrong duration is most obvious when remuxing Cinepak from FILM files without reencoding. For example, one sample video I have has a timebase of 30, and most frames last for two ticks. When rem

[FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-04-08 Thread misty
From: Misty De Meo --- libavformat/segafilm.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c index 4c0cca0140..e72c26b144 100644 --- a/libavformat/segafilm.c +++ b/libavformat/segafilm.c @@ -270,6 +270,8 @@ static int

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-06 Thread Misty De Meo
On Thu, Apr 5, 2018 at 2:06 PM, Josh de Kock wrote: > Thanks, pushed. I also clarified with wm4 on IRC that while he was against > it he wasn't blocking the muxer if someone else pushes it. Thank you! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-02 Thread misty
From: Misty De Meo > I assume you copied the demuxer but shouldn't you be here as well? Good point, added! > I honestly think your comment style (i.e. C vs C++) should be consistent > throughout the file, but that's just me. OK, updated all the single-line comments to use

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-02 Thread misty
From: Misty De Meo --- Changelog | 1 + doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 398 ++ libavformat/version.h | 2 +- 6 files changed

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-01 Thread misty
From: Misty De Meo I've resolved the one TODO that remained by adding support for the one other supported video codec in this container. Is there anything else that you'd like to see changed? I understand the concerns about this too niche, but I have been speaking to a number of ot

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-01 Thread misty
From: Misty De Meo --- Changelog | 1 + doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 397 ++ libavformat/version.h | 2 +- 6 files changed

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-26 Thread misty
From: Misty De Meo I reviewed the contributing guide one more time, and noticed I'd missed two items from the new muxer list. Updated the patch with: * Marked Sega FILM as having a muxer in general.texi * Bumped the minor version of libavformat Misty De Meo (1): Add Sega FILM

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-26 Thread misty
From: Misty De Meo --- Changelog | 1 + doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 377 ++ libavformat/version.h | 2 +- 6 files changed

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-23 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 377 ++ 4 files changed, 380 insertions(+) create mode 100644 libavformat/segafilmenc.c diff

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-23 Thread misty
From: Misty De Meo > Just move allocation after all declarations. OK, changed. > Do you check that this condition is set in code? > > I mean, if user set codec for wrong case. Oh, good point. I thought about this, and then realized that for mono audio, there is no difference be

Re: [FFmpeg-devel] [PATCH 0/1] Add Sega FILM muxer

2018-03-22 Thread Misty De Meo
On Thu, Mar 22, 2018 at 3:43 AM, wm4 wrote: > Why? Mainly to modify existing videos or encode new videos for Saturn games. It's particularly useful for fan translation - to mux in new audio, or encode new video for things like credits sequences. ___ ffm

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-21 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 380 ++ 4 files changed, 383 insertions(+) create mode 100644 libavformat/segafilmenc.c diff

[FFmpeg-devel] [PATCH 0/1] Add Sega FILM muxer

2018-03-21 Thread misty
From: Misty De Meo This adds a muxer for the Sega FILM format, which was used by Sega Saturn games in the 1990s. This muxer provides a complete implementation of the FILM format, at least as far as all features I've seen used in the wild, except that it currently doesn't support un

[FFmpeg-devel] [PATCH 0/1] re: Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo OK, requested changes made. Misty De Meo (1): Sega FILM: set dts and duration when demuxing libavformat/segafilm.c | 19 +++ 1 file changed, 19 insertions(+) -- 2.16.2 ___ ffmpeg-devel mailing list ffmpeg

[FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo --- libavformat/segafilm.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavformat/segafilm.c b/libavformat/segafilm.c index 11768823fc..03a639e034 100644 --- a/libavformat/segafilm.c +++ b/libavformat/segafilm.c @@ -270,6 +270,8 @@ static int

[FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/segafilm.c | 21 + 2 files changed, 22 insertions(+) diff --git a/Changelog b/Changelog index 7969b414c4..6b3b2bf7fe 100644 --- a/Changelog +++ b/Changelog @@ -47,6 +47,7 @@ version : - native SBC encoder

Re: [FFmpeg-devel] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo OK, made both requested changes. Misty De Meo (1): Sega FILM: set dts and duration when demuxing Changelog | 1 + libavformat/segafilm.c | 21 + 2 files changed, 22 insertions(+) -- 2.16.2

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-21 Thread Misty De Meo
On Wed, Mar 21, 2018 at 1:32 PM, Carl Eugen Hoyos wrote: > 2018-03-21 14:37 GMT+01:00, Gyan Doshi : > Can you comment on why this 15-year old code was wrong? I think it was de facto unused before now. Since it wasn't passed through to AVPacket it wasn't used by many things, and the Cinepak decode

[FFmpeg-devel] [PATCH 1/1] Sega FILM: set dts and duration when demuxing

2018-03-21 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/segafilm.c | 24 2 files changed, 25 insertions(+) diff --git a/Changelog b/Changelog index 7969b414c4..6b3b2bf7fe 100644 --- a/Changelog +++ b/Changelog @@ -47,6 +47,7 @@ version : - native SBC encoder

[FFmpeg-devel] [PATCH 0/1] Sega FILM: set timestamps when demuxing

2018-03-21 Thread misty
From: Misty De Meo Timestamp information isn't currently set when demuxing Sega FILM videos, which breaks direct stream copy of packets into certain other containers. I've tested with my WIP Sega FILM muxer, which creates valid .CPK files copying packets from existing .CPK files with

Re: [FFmpeg-devel] [PATCH 1/1] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread Misty De Meo
Sorry about that - that was the placeholder title of a commit I squashed into the mpeg commit, and forgot to remove when rebasing. I'll remove it from the commit message. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/list

[FFmpeg-devel] [PATCH 5/6] mpeg: fix use of deprecated struct

2018-01-05 Thread misty
From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index afde768199..ca848cacbb 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -561,8 +561,8 @@ redo: len--; for

[FFmpeg-devel] [PATCH 6/6] psmf: add FATE tests

2018-01-05 Thread misty
From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 --- a/tests/Makefile +++ b/tests

[FFmpeg-devel] [PATCH 2/6] oma: move some constants into libavcodec

2018-01-05 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavf

[FFmpeg-devel] [PATCH 3/6] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread misty
From: Maxim Poliakovski Changes by Misty De Meo : atrac3plus_parser: remove return statements for invalid data atrac3plus_parser: use libavcodec's oma atrac3plus_parser: pass along unexpected data unaltered atrac3plus_parser: adjust bytes_remain type Change by Michael "Bazz&q

[FFmpeg-devel] [PATCH 4/6] Fix detecting ATRAC3 audio from MPS files

2018-01-05 Thread misty
From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for PRIVATE_STREAM_1

[FFmpeg-devel] [PATCH 1/6] fate: add atrac3p conversion test

2018-01-05 Thread misty
From: Misty De Meo --- tests/fate/atrac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index acf79a539c..1707373890 100644 --- a/tests/fate/atrac.mak +++ b/tests/fate/atrac.mak @@ -31,6 +31,10 @@ FATE_ATRAC3P += fate-atrac3p-2 fate

[FFmpeg-devel] [PATCH 0/6] Fix detecting ATRAC3 audio from MPS files

2018-01-05 Thread misty
From: Misty De Meo > this looks a bit odd > shouldnt this test more than 4 bits of startcode ? Yeah, that was a misreading on my part of the original patch. I need a different approach. I think I've found something that should work, though. I was talking to Jan about this

Re: [FFmpeg-devel] [PATCH 1/1] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread Misty De Meo
> so this is unfinished code that work in progress ? > if so, what is missing ? > if not, then please write a better commit message Sorry about that - that was the placeholder title of a commit I squashed into the mpeg commit, and forgot to remove when rebasing. I'll remove it from the commit mess

[FFmpeg-devel] [PATCH 2/2] aiff: add explicit goto got_sound

2018-01-05 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/aiffdec.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Changelog b/Changelog index 3d966c202b..63007a259d 100644 --- a/Changelog +++ b/Changelog @@ -33,6 +33,7 @@ version : - deconvolve video filter - entropy video

[FFmpeg-devel] [PATCH 0/2] adpcm: consume remainder after consuming XA chunks

2018-01-05 Thread misty
From: Misty De Meo > the initialization to 0 is unneeded OK - updated in the included patch. I've also included a second patch which adds an explicit goto and break in aiffdec, on top of the patch you already applied, and the Changelog entry that I forgot to include in that patch. I

[FFmpeg-devel] [PATCH 1/2] adpcm: consume remainder after consuming XA chunks

2018-01-05 Thread misty
From: Misty De Meo --- libavcodec/adpcm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index be206c55ba..cd3bbd33c2 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1115,6 +1115,7 @@ static int adpcm_decode_frame(AVCodecContext

[FFmpeg-devel] [PATCH 1/3] aiff: add support for XA ADPCM

2018-01-03 Thread misty
From: Misty De Meo Certain AIFF files encode XA ADPCM compressed audio using a chunk with the tag `APCM`. Aside from this custom chunk type, they're otherwise standard AIFF files. I've only observed these files in the Sega Saturn game Sonic Jam so far. --- libavformat/aiffdec.c | 7

[FFmpeg-devel] [PATCH 0/3] aiff: add support for XA ADPCM

2018-01-03 Thread misty
From: Misty De Meo This patchset adds support for the `APCM` chunk type in AIFF, which is used to store CD-ROM XA ADPCM audio. The only application I currently know of which uses this is the Sega Saturn game Sonic Jam, but there might be others. I've included a new fate test for this; here&

[FFmpeg-devel] [PATCH 2/3] adpcm: consume remainder after consuming XA chunks

2018-01-03 Thread misty
From: Misty De Meo --- libavcodec/adpcm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index be206c55ba..50ffba0db6 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1115,6 +1115,7 @@ static int adpcm_decode_frame(AVCodecContext

[FFmpeg-devel] [PATCH 3/3] fate: add xa-aiff test

2018-01-03 Thread misty
From: Misty De Meo --- tests/fate/adpcm.mak | 3 +++ tests/ref/fate/adpcm-xa-aiff | 51 2 files changed, 54 insertions(+) create mode 100644 tests/ref/fate/adpcm-xa-aiff diff --git a/tests/fate/adpcm.mak b/tests/fate/adpcm.mak index

[FFmpeg-devel] [PATCH 0/1] mpeg: add experimental support for PSMF audio.

2018-01-01 Thread misty
From: Misty De Meo Fixed by adjusting the type of `bytes_remain` to `uint16_t`, since that's the type returned by the `AV_RB16` macro that it's assigned from. Maxim Poliakovski (1): mpeg: add experimental support for PSMF audio. libavcodec/Makefile| 1 + libavcodec/a

[FFmpeg-devel] [PATCH 1/1] mpeg: add experimental support for PSMF audio.

2018-01-01 Thread misty
From: Maxim Poliakovski Changes by Misty De Meo : atrac3plus_parser: remove return statements for invalid data atrac3plus_parser: use libavcodec's oma atrac3plus_parser: pass along unexpected data unaltered atrac3plus_parser: adjust bytes_remain type Change by Michael "Bazz&q

[FFmpeg-devel] [PATCH 1/1] psmf: add FATE tests

2018-01-01 Thread misty
From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 --- a/tests/Makefile +++ b/tests

[FFmpeg-devel] [PATCH 0/1] psmf: add FATE tests

2018-01-01 Thread misty
From: Misty De Meo Haha, that shows me for copy/pasting from the other tests! Adjusted the name to something PSMF-specific so it doesn't collide; confirmed both sets of tests pass now. Updated patch included. Misty De Meo (1): psmf: add FATE tests tests/Makefile | 1 + tests

[FFmpeg-devel] [PATCH 3/6] mpeg: add experimental support for PSMF audio.

2017-12-31 Thread misty
From: Maxim Poliakovski Changes by Misty De Meo : atrac3plus_parser: remove return statements for invalid data atrac3plus_parser: use libavcodec's oma atrac3plus_parser: pass along unexpected data unaltered Change by Michael "Bazz" Bazzinotti : atrac3plus_parser: don't a

[FFmpeg-devel] [PATCH 5/6] mpeg: fix use of deprecated struct

2017-12-31 Thread misty
From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index a366ece0ed..210424faf3 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -547,8 +547,8 @@ redo: len--; for

[FFmpeg-devel] [PATCH 0/6] mpeg: add experimental support for PSMF audio.

2017-12-31 Thread misty
From: Misty De Meo I think this version of the patch should address the issue. If frames can't be parsed, the original data is passed through unaltered. From what I can tell about the RIFF WAVE .at3 files, they don't use the format being parsed at all and don't require parsing. W

[FFmpeg-devel] [PATCH 6/6] psmf: add FATE tests

2017-12-31 Thread misty
From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 --- a/tests/Makefile +++ b/tests

[FFmpeg-devel] [PATCH 4/6] Fix detecting ATRAC3 audio from MPS files

2017-12-31 Thread misty
From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for PRIVATE_STREAM_1

[FFmpeg-devel] [PATCH 2/6] oma: move some constants into libavcodec

2017-12-31 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavf

[FFmpeg-devel] [PATCH 1/6] fate: add atrac3p conversion test

2017-12-31 Thread misty
From: Misty De Meo --- tests/fate/atrac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index acf79a539c..1707373890 100644 --- a/tests/fate/atrac.mak +++ b/tests/fate/atrac.mak @@ -31,6 +31,10 @@ FATE_ATRAC3P += fate-atrac3p-2 fate

[FFmpeg-devel] [PATCH 1/1] fate: add atrac3p conversion test

2017-12-29 Thread misty
From: Misty De Meo --- tests/fate/atrac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index acf79a539c..1707373890 100644 --- a/tests/fate/atrac.mak +++ b/tests/fate/atrac.mak @@ -31,6 +31,10 @@ FATE_ATRAC3P += fate-atrac3p-2 fate

[FFmpeg-devel] [PATCH 0/1] mpeg: add experimental support for PSMF audio.

2017-12-29 Thread misty
From: Misty De Meo Thanks for pointing this out. I hadn't had a separate .at3 file to test with, and didn't realize that this broke regular ATRAC3P files. I've added a new fate test which detects this regression; it passes on master and fails in the MPEG-ATRAC3 branch. I'l

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-26 Thread Misty De Meo
I originally left this patch alone since it was another person's commit; I can squash the fixes for that into this commit if you prefer, though. On Tue, Dec 26, 2017 at 8:39 AM, Michael Niedermayer wrote: > On Mon, Dec 25, 2017 at 10:28:30AM +0800, mi...@brew.sh wrote: >> From: Maxim Poliakovski

[FFmpeg-devel] [PATCH 3/5] Fix detecting ATRAC3 audio from MPS files

2017-12-26 Thread misty
From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for PRIVATE_STREAM_1

[FFmpeg-devel] [PATCH 5/5] psmf: add FATE tests

2017-12-26 Thread misty
From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 --- a/tests/Makefile +++ b/tests

[FFmpeg-devel] [PATCH 2/5] mpeg: add experimental support for PSMF audio.

2017-12-26 Thread misty
From: Maxim Poliakovski Changes by Misty De Meo : atrac3plus_parser: remove return statements for invalid data atrac3plus_parser: use libavcodec's oma Signed-off-by: Misty De Meo --- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libav

[FFmpeg-devel] [PATCH 1/5] oma: move some constants into libavcodec

2017-12-26 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavf

[FFmpeg-devel] [PATCH 4/5] mpeg: fix use of deprecated struct

2017-12-26 Thread misty
From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index a366ece0ed..210424faf3 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -547,8 +547,8 @@ redo: len--; for

[FFmpeg-devel] [PATCH 0/5] mpeg: add experimental support for PSMF audio.

2017-12-26 Thread misty
From: Misty De Meo I checked in with IRC and got some suggestions on the best way to handle both of these. I've updated the patchset with the changes you requested. The media files referenced by the tests are here: https://public.drac.at/6.MPS http://samples.ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Misty De Meo
On Tue, Dec 26, 2017 at 8:42 AM, Michael Niedermayer wrote: > returning errors from the parse function will cause assertion failure at: > > Assertion index > -0x2000 failed at libavcodec/parser.c:185 > > [...] What would be the preferred way to handle that? ___

Re: [FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-25 Thread Misty De Meo
On Tue, Dec 26, 2017 at 8:39 AM, Michael Niedermayer wrote: > This fails to build without the next patch I originally left this patch alone since it was another person's commit; I can squash the fixes for that into this commit if you prefer, though. ___

[FFmpeg-devel] [PATCH 6/6] psmf: add FATE tests

2017-12-24 Thread misty
From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 --- a/tests/Makefile +++ b/tests

[FFmpeg-devel] [PATCH 5/6] mpeg: fix use of deprecated struct

2017-12-24 Thread misty
From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index a366ece0ed..210424faf3 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -547,8 +547,8 @@ redo: len--; for

[FFmpeg-devel] [PATCH 4/6] Fix detecting ATRAC3 audio from MPS files

2017-12-24 Thread misty
From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for PRIVATE_STREAM_1

[FFmpeg-devel] [PATCH 0/6] oma: move some constants into libavcodec

2017-12-24 Thread misty
From: Misty De Meo > Code in header files which gets inlined doesn't need an ff_ prefix. Sounds good! I've updated the patchset to strip the ff_ prefix from the oma consts from the headers. The full updated patchset is included. Maxim Poliakovski (1): mpeg: add experimental sup

[FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

2017-12-24 Thread misty
From: Maxim Poliakovski --- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/atrac3plus_parser.c | 153 + libavformat/mpeg.c | 27 +++- 4 files changed, 181 insertions(+), 1 deletion(-) create mod

[FFmpeg-devel] [PATCH 3/6] atrac3plus_parser: use libavcodec's oma

2017-12-24 Thread misty
From: Misty De Meo --- libavcodec/atrac3plus_parser.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/atrac3plus_parser.c b/libavcodec/atrac3plus_parser.c index 01fcad4c45..f58f3d58ef 100644 --- a/libavcodec/atrac3plus_parser.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 1/6] oma: move some constants into libavcodec

2017-12-24 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavf

[FFmpeg-devel] [PATCH 1/1] psmf: add FATE tests

2017-12-24 Thread misty
From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 --- a/tests/Makefile +++ b/tests

[FFmpeg-devel] [PATCH 0/1] Fix detecting ATRAC3 audio from MPS files

2017-12-24 Thread misty
From: Misty De Meo > I think this might be worth a small fate test, assuming small samples > can be found and shared. Good idea. I've added a fate test, using one PSMF sample and one MPS sample. Here are URLs to the files: https://public.drac.at/6.MPS http://samples.ffmp

[FFmpeg-devel] [PATCH 3/5] atrac3plus_parser: use libavcodec's oma

2017-12-23 Thread misty
From: Misty De Meo --- libavcodec/Makefile| 2 +- libavcodec/atrac3plus_parser.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index e0e3f1ebac..0e1c6d53ea 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile

[FFmpeg-devel] [PATCH 5/5] mpeg: fix use of deprecated struct

2017-12-23 Thread misty
From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index a366ece0ed..210424faf3 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -547,8 +547,8 @@ redo: len--; for

[FFmpeg-devel] [PATCH 4/5] Fix detecting ATRAC3 audio from MPS files

2017-12-23 Thread misty
From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for PRIVATE_STREAM_1

[FFmpeg-devel] [PATCH 1/5] oma: move some constants into libavcodec

2017-12-23 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavf

[FFmpeg-devel] [PATCH 0/5] oma: move some constants into libavcodec

2017-12-23 Thread misty
From: Misty De Meo > I believe such an internal change doesn't deserve a Changelog entry. Sure; I've updated the patch set to remove that change from the Changelog. Maxim Poliakovski (1): mpeg: add experimental support for PSMF audio. Misty De Meo (4): oma: move some c

[FFmpeg-devel] [PATCH 2/5] mpeg: add experimental support for PSMF audio.

2017-12-23 Thread misty
From: Maxim Poliakovski --- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/atrac3plus_parser.c | 153 + libavformat/mpeg.c | 27 +++- 4 files changed, 181 insertions(+), 1 deletion(-) create mod

[FFmpeg-devel] [PATCH 1/1] oma: move some constants into libavcodec

2017-12-22 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavf

[FFmpeg-devel] [PATCH 0/1] oma: move some constants into libavcodec

2017-12-22 Thread misty
From: Misty De Meo Thanks for the feedback! I checked in with #ffmpeg-devel on IRC, and they suggested simply making them static consts in the headers since they're small enough. Updated patch is included. Misty De Meo (1): oma: move some constants into libavcodec Chan

[FFmpeg-devel] [PATCH 3/5] atrac3plus_parser: use libavcodec's oma

2017-12-22 Thread misty
From: Misty De Meo --- libavcodec/Makefile| 2 +- libavcodec/atrac3plus_parser.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index e0e3f1ebac..0e1c6d53ea 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile

[FFmpeg-devel] [PATCH 2/5] mpeg: add experimental support for PSMF audio.

2017-12-22 Thread misty
From: Maxim Poliakovski --- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/atrac3plus_parser.c | 153 + libavformat/mpeg.c | 27 +++- 4 files changed, 181 insertions(+), 1 deletion(-) create mod

[FFmpeg-devel] [PATCH 0/5] Sony MPEG with ATRAC-3 audio support, trac ticket #3233

2017-12-22 Thread misty
From: Misty De Meo This is based on Maxim Poliakovski's patch from this 2014 email: https://ffmpeg.org/pipermail/ffmpeg-devel/2014-December/166169.html This patchset is updated based on Michael Niedermayer's feedback. I've also included an improvement which ensures support for

[FFmpeg-devel] [PATCH 5/5] mpeg: fix use of deprecated struct

2017-12-22 Thread misty
From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index a366ece0ed..210424faf3 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -547,8 +547,8 @@ redo: len--; for

[FFmpeg-devel] [PATCH 1/5] oma: move some constants into libavcodec

2017-12-22 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavf

[FFmpeg-devel] [PATCH 4/5] Fix detecting ATRAC3 audio from MPS files

2017-12-22 Thread misty
From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for PRIVATE_STREAM_1