Re: [FFmpeg-devel] [PATCH] avformat/mpegts: correctly skip TP_extra_header in m2ts

2024-11-30 Thread llyyr
On 8/8/24 1:44 AM, llyyr wrote: On 6/7/24 1:29 PM, Hendrik Leppkes wrote: On Fri, Jun 7, 2024 at 9:47 AM Hendrik Leppkes wrote: On Mon, May 27, 2024 at 3:47 PM llyyr wrote: instead of just resyncing and skipping a bunch of TS packets, leading to a loss of frames. Before this, a stray

[FFmpeg-devel] [PATCH 2/2] avformat/mov: handle stream position resets

2024-10-26 Thread llyyr
If the stream position has been reset, clear fragment index, the index entries and the current sample and search for the next root. Co-authored-by: llyyr --- libavformat/mov.c | 37 + 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/hls: always return keyframe if not AVSEEK_FLAG_ANY

2024-10-26 Thread llyyr
Co-authored-by: llyyr --- libavformat/hls.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 62473a15ddb5..4d02faa9e49a 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2350,8 +2350,10 @@ static int hls_read_packet

[FFmpeg-devel] [PATCH 0/2] Originally posted on the ML here https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/261343.html Fixes: https://trac.ffmpeg.org/ticket/7359

2024-10-26 Thread llyyr
vectronic (2): avformat/hls: always return keyframe if not AVSEEK_FLAG_ANY avformat/mov: handle stream position resets libavformat/hls.c | 8 +--- libavformat/mov.c | 37 + 2 files changed, 38 insertions(+), 7 deletions(-) base-commit: fe219446565e

[FFmpeg-devel] [PATCH] lavfi/vf_libplacebo: move deprecated field inside PL_API_VER check

2024-08-13 Thread llyyr
Set equivalent new option instead. Deprecated upstream in libplacebo v7.346. --- libavfilter/vf_libplacebo.c | 8 1 file changed, 8 insertions(+) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index be9000aa8ea7..e4e750d4edfa 100644 --- a/libavfilter/vf_libplaceb

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: correctly skip TP_extra_header in m2ts

2024-08-07 Thread llyyr
On 6/7/24 1:29 PM, Hendrik Leppkes wrote: On Fri, Jun 7, 2024 at 9:47 AM Hendrik Leppkes wrote: On Mon, May 27, 2024 at 3:47 PM llyyr wrote: instead of just resyncing and skipping a bunch of TS packets, leading to a loss of frames. Before this, a stray byte with the value of 0x47 in

[FFmpeg-devel] [PATCH] avformat/mpegts: correctly skip TP_extra_header in m2ts

2024-05-27 Thread llyyr
immediately go into mpegts_resync, and incorrectly detect the stray 0x47 in the TP_extra_header at 0x302 as the new sync byte. Fix this by correctly skipping the first 4 bytes if the source packet is 192 bytes. Signed-off-by: llyyr --- libavformat/mpegts.c | 12 +++- 1 file changed, 11

Re: [FFmpeg-devel] [PATCH v2] lavc/vp9: reset segmentation fields when segmentation isn't enabled

2024-05-23 Thread llyyr
On 5/23/24 2:13 PM, Andreas Rheinhardt wrote: llyyr.pub...@gmail.com: From: llyyr Fields under the segmentation switch are never reset on a new frame, and retain the value from the previous frame. This bugs out a bunch of hwaccel drivers when segmentation is disabled but update_map isn&#

[FFmpeg-devel] [PATCH v2] lavc/vp9: reset segmentation fields when segmentation isn't enabled

2024-05-23 Thread llyyr . public
From: llyyr Fields under the segmentation switch are never reset on a new frame, and retain the value from the previous frame. This bugs out a bunch of hwaccel drivers when segmentation is disabled but update_map isn't reset because they don't ignore values behind switches. This c

[FFmpeg-devel] [PATCH] lavc/vp9: reset segmentation fields when segmentation isn't enabled

2024-05-23 Thread llyyr . public
From: llyyr Fields under the segmentation switch are never reset on a new frame, and retain the value from the previous frame. This bugs out a bunch of hwaccel drivers when segmentation is disabled but update_map isn't reset because they don't ignore values behind switches. This c

[FFmpeg-devel] [PATCH] lavc/vp9: reset segmentation fields when segmentation isn't enabled

2024-05-23 Thread llyyr . public
From: llyyr Fields under the segmentation switch are never reset on a new frame, and retain the value from the previous frame. This bugs out a bunch of hwaccel drivers when segmentation is disabled but update_map isn't reset because they don't ignore values behind switches. This c

[FFmpeg-devel] [PATCH v2] lavc/vp9: reset segmentation fields when segmentation isn't enabled

2024-05-23 Thread llyyr
fields if segmentation.enabled is 0, but d3d11va still displays blocky artifacts. [1] https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavcodec/vp8.c#l811 [2] https://github.com/mpv-player/mpv/issues/13533 [3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27816 Signed-off

[FFmpeg-devel] [PATCH v2] lavc/vp9: reset segmentation fields when segmentation isn't enabled

2024-05-23 Thread llyyr
fields if segmentation.enabled is 0, but d3d11va still displays blocky artifacts. [1] https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavcodec/vp8.c#l811 [2] https://github.com/mpv-player/mpv/issues/13533 [3] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27816 Signed-off

[FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files

2024-05-14 Thread llyyr . public
From: llyyr ab77b878f1 attempted to fix the issue of broken packets being sent to the decoder by implementing logic that kept attempting to PTS-step backwards until it reached a valid point, however applying this heuristic meant that in files that had no valid points (such as HEVC videos shot on

[FFmpeg-devel] [PATCH] lavc/vp9: set update_map to 0 when segmentation.enabled is 0

2024-02-28 Thread llyyr
/git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavcodec/vp8.c#l811 ** https://github.com/mpv-player/mpv/issues/13533 *** https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27816 Signed-off-by: llyyr --- libavcodec/vp9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vp9.c b/l

Re: [FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files

2024-02-26 Thread llyyr
On 9/23/23 16:40, llyyr wrote: ab77b878f1 attempted to fix the issue of broken packets being sent to the decoder by implementing logic that kept attempting to PTS-step backwards until it reached a valid point, however applying this heuristic meant that in files that had no valid points (such as

Re: [FFmpeg-devel] [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API

2024-02-20 Thread llyyr
On 2/11/24 20:45, Lynne wrote: Most of this patch was written by Dave Airlie , with some additions by me. Tested and verified that this works with https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27424 ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix matrix coefficients exposed by codec context

2024-02-20 Thread llyyr
On 2/20/24 23:58, Jan Ekström wrote: `colorspace` in avcodec terms means `matrix coefficients`. --- libavcodec/av1dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index 7ffa7821e9..7debc4deda 100644 --- a/libavcodec/av1dec.c ++

[FFmpeg-devel] [PATCH] avformat/subtitles: check for double BOM in UTF-16 files

2023-09-23 Thread llyyr
While these files certainly aren't the norm, and might not even be considered valid by many programs, there are plenty of older ASS tracks in UTF-16 LE/BE encoding that contain double BOMs. This patch teaches ff_text_init_avio about double BOMs and makes it check for them in UTF-16 LE/BE files. Th

[FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files

2023-09-23 Thread llyyr
ab77b878f1 attempted to fix the issue of broken packets being sent to the decoder by implementing logic that kept attempting to PTS-step backwards until it reached a valid point, however applying this heuristic meant that in files that had no valid points (such as HEVC videos shot on iPhones), we'd

Re: [FFmpeg-devel] [RFC PATCH 1/2] libavdevice/pipewiregrab: add pipewire based grab

2023-09-22 Thread llyyr
On 9/21/23 00:10, Abhishek Ojha wrote: This is an proof of concept for pipewire grab to enable screen capture on wayland. Add a new Linux capture based on [1] PipeWire and the [2] Desktop portal. This new capture starts by asking the Desktop portal for a screencapture session.There are quite a fe

[FFmpeg-devel] [PATCH v2 2/2] hevc_ps: fix fixed_rate check

2023-09-10 Thread llyyr
Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb Since fc429d785e9e24c5520ce716d4bc3b5547e581eb splits the fixed_rate flag into general and within_cvs, check for both. --- libavcodec/hevc_ps.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/h

[FFmpeg-devel] [PATCH v2 1/2] hevc_ps: fix cpb_cnt_minus1 initialization

2023-09-10 Thread llyyr
Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb cpb_cnt used to be initialized to 1 before fc429d785e9e24c5520ce716d4bc3b5547e581eb so cpb_cnt_minus1 should be initialized to 0. Also add +1 to the decode_sublayer_hrd call to account for the change to the offset --- libavcodec/hevc_ps.c | 6 ++---

[FFmpeg-devel] [PATCH] hevc_ps: fix cpb_cnt_minus1 initialization and fixed_rate check

2023-09-10 Thread llyyr
Fixes: fc429d785e9e24c5520ce716d4bc3b5547e581eb cpb_cnt was initialized to 1 before fc429d785e9e24c5520ce716d4bc3b5547e581eb, so cpb_cnt_minus1 should be initialized to 0 instead of 1. Since we split fixed_rate into a general flag and a within_cvs_flag now, check for both in conditional. --- lib