We are not currently able to force mov_text subtitles by setting
-disposition:s:0 +forced or equivalent.
Should this setting actually result in forced subtitles or is this a
misapprehension of the meaning of this setting?
Thanks
___
ffmpeg-devel mailing
VLC and similar players.
Copy AVStream disposition to AVCodecContext and use to set
DISPLAY_FLAG_ALL_SAMPLES_FORCED in movtextenc.c.
Signed-off-by: facefunk
---
fftools/ffmpeg_mux_init.c | 5 +
libavcodec/avcodec.h | 11 +++
libavcodec/movtextenc.c | 41
Wow! Thanks!
That really works. I had no idea we could just play with timescale like
that.
On Wed, 20 Jul 2022 at 13:41, "zhilizhao(赵志立)"
wrote:
>
>
> > On Jul 20, 2022, at 8:18 PM, facefunk wrote:
> >
> > It's commonly the case with forced subtitl
It's commonly the case with forced subtitle tracks that samples are more
than INT_MAX microseconds (35m47.48s) apart. This being the case, packet
duration will be deemed out of range by check_pkt and the packet dts set to
an incorrect value, even if pkt->duration is actually valid.
I had begun wor
I see what I did wrong. -v or --reroll-count are arguments to git
format-patch so obviously aren't applied by git send-email when providing a
preformatted patch, which I did. My mistake.
On Mon, 18 Jul 2022 at 18:48, Leo Izen wrote:
> On 7/18/22 12:08, facefunk wrote:
> > We are
VLC and similar players.
Copy AVStream disposition to AVCodecContext and use to set
DISPLAY_FLAG_ALL_SAMPLES_FORCED in movtextenc.c.
Signed-off-by: facefunk
---
fftools/ffmpeg_opt.c| 5 +
libavcodec/avcodec.h| 11 +++
libavcodec/movtextenc.c | 41
Okay, great! Thanks for reviewing.
I've addressed your points as well as a few tweaks in the spirit of preserving
the abstraction boundary.
Would the attached patch revision be acceptable?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://
Thanks for the advice. I did --reroll-count=2 but it doesn't seem to have
worked.
On Mon, 18 Jul 2022 at 18:48, Leo Izen wrote:
> On 7/18/22 12:08, facefunk wrote:
> > We are not currently able to force mov_text subtitles by setting
> -disposition:s:0 +forced or equivalen
Signed-off-by: facefunk
---
libavutil/opt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavutil/opt.h b/libavutil/opt.h
index 461b5d3b6b..f250579b29 100644
--- a/libavutil/opt.h
+++ b/libavutil/opt.h
@@ -175,8 +175,8 @@
* above, put the following into the
Signed-off-by: facefunk
---
libavcodec/movtextenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c
index d2550585e8..6f54e2a64c 100644
--- a/libavcodec/movtextenc.c
+++ b/libavcodec/movtextenc.c
@@ -732,7 +732,7 @@ static
VLC and similar players.
Copy AVStream disposition to AVCodecContext and use to set
DISPLAY_FLAG_ALL_SAMPLES_FORCED in movtextenc.c.
Signed-off-by: facefunk
---
fftools/ffmpeg_opt.c| 5 +
libavcodec/avcodec.h| 16
libavcodec/movtextenc.c | 41
We are not currently able to force mov_text subtitles by setting
-disposition:s:0 +forced or equivalent. By setting the forced flags in
movtextenc as specifid in
https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html
subtitles can be forced as expected in
Signed-off-by: facefunk
---
fftools/ffmpeg_opt.c| 5 +
libavcodec/avcodec.h| 16
libavcodec/movtextenc.c | 41 -
3 files changed, 61 insertions(+), 1 deletion(-)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index
Signed-off-by: facefunk
---
libavcodec/movtextenc.c | 2 +-
libavutil/opt.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c
index 728338f2cc..40cdaa3a81 100644
--- a/libavcodec/movtextenc.c
+++ b/libavcodec
t would be greatly appreciated.
Love your work!
Kind regards,
facefunk
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
15 matches
Mail list logo
