Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: use color description for h264 and hevc

2020-10-28 Thread Zivkovic, Milos
, color_trc and colorspace are not unspecified. Additionally, I'll add it as mfxExtBuffer to q->extparam_internal only if ColourDescriptionPresent is set. Regards, Miloš On Wed, Oct 28, 2020 at 9:02 PM Mark Thompson wrote: > > On 10/10/2020 18:27, Zivkovic, Milos wrote: > > H

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: use color description for h264 and hevc

2020-10-28 Thread Zivkovic, Milos
Hello, I've attached an updated patch that properly sets the mfxExtVideoSignalInfo::VideoFullRange flag. On Sat, Oct 10, 2020 at 7:27 PM Zivkovic, Milos wrote: > > Hello, > > I've attached a patch that forwards the color description from > AVCodecContext to mfxExtVid

[FFmpeg-devel] [PATCH] avcodec/qsvenc: use color description for h264 and hevc

2020-10-10 Thread Zivkovic, Milos
Hello, I've attached a patch that forwards the color description from AVCodecContext to mfxExtVideoSignalInfo. It has been discussed on the #ffmpeg and #ffmpeg-devel IRC channel a couple of times in the last few days. 0001-avcodec-qsvenc-use-color-description-for-h264-and-hevc.patch Description:

[FFmpeg-devel] [PATCH] avcodec/qsvenc: clear mfx frame type in submit_frame

2020-10-10 Thread Zivkovic, Milos
Hello, I've attached a patch that clears the mfxEncodeCtrl::FrameType field. Since QSVFrames are reused, this field can affect not only the frame it was supposed to affect, but also the subsequent ones. It would be enough to force a keyframe only once and that QSVFrame will have the FrameType fie

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-07-03 Thread Zivkovic, Milos
Thanks. Regards, Milos On Fri, Jul 3, 2020 at 12:55 AM Marton Balint wrote: > > > > On Sun, 28 Jun 2020, Marton Balint wrote: > > > > > > > On Mon, 22 Jun 2020, Zivkovic, Milos wrote: > > > >> Hello, > >> > >> I've attached

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-22 Thread Zivkovic, Milos
Hello, I've attached another patch with the latest changes. Sorry for sending it as an attachment again, I'll figure something out for the future patches. Anyhow, this patch removes the reordering and the unused HANC constant. It also checks if PSC is in order and renames the option to "enable_kl

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-18 Thread Zivkovic, Milos
Hello, > Please in the future send patches as in-line rather than attachments. git send-email wasn't working for this email. I attached the patch only after asking on #ffmpeg-devel IRC channel if it was okay. Is simply pasting the patch contents enough? > This is referencing the incorrect specif

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-17 Thread Zivkovic, Milos
Hello, I've attached a new patch with the proposed changes. Thanks, Milos 0001-avdevice-decklink_dec-extracting-and-outputing-klv.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Zivkovic, Milos
> > > Thanks, I found the issue. > Glad to hear it. Regards, Milos On Mon, Jun 15, 2020 at 10:58 PM Marton Balint wrote: > > > On Mon, 15 Jun 2020, Zivkovic, Milos wrote: > > > I'll submit the patch with the proposed changes once that build issue is >

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Zivkovic, Milos
g/z/zTJn_9 Thanks, Milos On Mon, Jun 15, 2020 at 9:20 PM Marton Balint wrote: > > > On Mon, 15 Jun 2020, Zivkovic, Milos wrote: > > > Hello, > > > > I appreciate the comments. > > > > Missing docs for the new option. > >> > > > >

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-15 Thread Zivkovic, Milos
following what the other code that adds streams does. AV_OPT_TYPE_BOOL > I'll change that asap. Thanks, Milos On Sun, Jun 14, 2020 at 4:27 PM Marton Balint wrote: > > On Tue, 9 Jun 2020, Zivkovic, Milos wrote: > > > Hello, > > > > I've attached a patch

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: extracting and outputing klv from vanc

2020-06-09 Thread Zivkovic, Milos
Hello, I've attached a patch that adds support for extraction of KLV data from SDI VANC. Code is enabled with a special *output_klv* option and is otherwise unused. This was tested with an off the shelf UDP -> SDI decoder that preserves KLV and inserts them in VANC, following the guidelines in MI