Re: [FFmpeg-devel] [PATCH] checkasm/hevc_mc : add hevc_mc for checkasm

2018-04-27 Thread Yingming Fan
Thank you for your review. > On Apr 17, 2018, at 15:29, Shengbin Meng <mailto:shengbinm...@gmail.com>> wrote: > > > >> On Apr 9, 2018, at 10:12, Yingming Fan > <mailto:yingming...@gmail.com>> wrote: >> >> From: Yingming Fan mailto:yingming

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_mc : add hevc_mc for checkasm

2018-04-12 Thread Yingming Fan
Hello, Any review? Yingming Fan > On Apr 9, 2018, at 10:12 AM, Yingming Fan wrote: > > From: Yingming Fan > > --- > Hi, there. > I plane to submit our arm32 neon codes for qpel and epel. > While before this i will submit hevc_mc checkasm codes. > This hevc_mc chec

Re: [FFmpeg-devel] [PATCH] 8-bit hevc decoding optimization on aarch64 with neon

2018-04-08 Thread Yingming Fan
using checkasm. Yingming Fan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] checkasm/hevc_mc : add hevc_mc for checkasm

2018-04-08 Thread Yingming Fan
From: Yingming Fan --- Hi, there. I plane to submit our arm32 neon codes for qpel and epel. While before this i will submit hevc_mc checkasm codes. This hevc_mc checkasm codes check every qpel and epel function, including 8 10 and 12 bit. Passed test by using 'checkasm --test=he

[FFmpeg-devel] [PATCH v3] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-27 Thread Yingming Fan
From: Meng Wang Signed-off-by: Meng Wang --- This v3 patch removed unused codes 'stride_dst /= sizeof(uint8_t);' compared to v1. V1 have this codes because we referred to hevc dsp template codes. Also removed type cast like 'uint8_t *dst = (uint8_t *)_dst;' compared to v2. As FFmpeg hevc decod

[FFmpeg-devel] [PATCH v2] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-22 Thread Yingming Fan
From: Meng Wang Signed-off-by: Meng Wang --- This v2 patch remove unused codes 'stride_dst /= sizeof(uint8_t);' compared to v1. V1 have this codes because we referred to hevc dsp template codes. As FFmpeg hevc decoder have no SAO neon optimization, we add sao_band and sao_edge neon codes in t

Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-18 Thread Yingming Fan
Hi, is there any review about this patch? What’s your option about wrapper we used in this patch. Yingming Fan > On 11 Mar 2018, at 8:59 PM, Yingming Fan wrote: > > >> On 11 Mar 2018, at 8:54 PM, Carl Eugen Hoyos wrote: >> >> 2018-03-08 8:03 GMT+01:00 Yingmin

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_idct : update test bit depth from 8 9 and 10 to 8 10 and 12

2018-03-18 Thread Yingming Fan
Hi, is there any review? This patch has been going on for a week. Yingming Fan > On 11 Mar 2018, at 10:17 AM, Yingming Fan wrote: > > Hi, there. Is there any comment? I think i did the right fix. > > Yingming Fan > >> On 8 Mar 2018, at 4:17 PM, Hendrik Leppkes wro

Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-11 Thread Yingming Fan
> On 11 Mar 2018, at 8:54 PM, Carl Eugen Hoyos wrote: > > 2018-03-08 8:03 GMT+01:00 Yingming Fan : >> From: Meng Wang > >> +stride_dst /= sizeof(uint8_t); >> +stride_src /= sizeof(uint8_t); > > FFmpeg requires sizeof(uint8_t) to be 1, plea

Re: [FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-10 Thread Yingming Fan
. Yingming Fan > On 8 Mar 2018, at 3:03 PM, Yingming Fan wrote: > > From: Meng Wang > > Signed-off-by: Meng Wang > --- > As FFmpeg hevc decoder have no SAO neon optimization, we add sao_band and > sao_edge neon codes in this patch. > I have already submit a patch call

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_idct : update test bit depth from 8 9 and 10 to 8 10 and 12

2018-03-10 Thread Yingming Fan
Hi, there. Is there any comment? I think i did the right fix. Yingming Fan > On 8 Mar 2018, at 4:17 PM, Hendrik Leppkes wrote: > > On Thu, Mar 8, 2018 at 9:16 AM, Paul B Mahol wrote: >> On 3/8/18, Yingming Fan wrote: >>> From: Yingming Fan >>> >>&

[FFmpeg-devel] [PATCH] checkasm/hevc_idct : update test bit depth from 8 9 and 10 to 8 10 and 12

2018-03-07 Thread Yingming Fan
From: Yingming Fan --- We have 8 10 and 12 SIMD codes, but previous checkasm hevc_idct only test 8 and 10 bit depth. tests/checkasm/hevc_idct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/checkasm/hevc_idct.c b/tests/checkasm/hevc_idct.c index eea712101d

[FFmpeg-devel] [PATCH] avcodec/arm/hevcdsp_sao : add NEON optimization for sao

2018-03-07 Thread Yingming Fan
From: Meng Wang Signed-off-by: Meng Wang --- As FFmpeg hevc decoder have no SAO neon optimization, we add sao_band and sao_edge neon codes in this patch. I have already submit a patch called 'checkasm/hevc_sao : add hevc_sao for checkasm' several days ago. Results below was printed by hevc_sao

[FFmpeg-devel] [PATCH v2] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-06 Thread Yingming Fan
From: Yingming Fan --- Previous patch test 8 9 and 10 bit depth, because i consult codes from hevc_idct and hevc_add_res. While this patch test 8 10 and 12 bit depth like what VP9 does. I will submit another patch fix these issue in hevc_idct and hevc_add_res. This patch also refined

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-06 Thread Yingming Fan
Hi James, I agree with what you said, we should test 8 10 and 12 bit. But i noticed that hevc_idct and hevc_add_res also not test 12 bit. I think we should also add 12 bit for these checkasm codes. 2018-03-06 21:55 GMT+08:00 James Almer : > On 3/3/2018 12:15 AM, Yingming Fan wr

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-06 Thread Yingming Fan
patch? Yingming Fan > On 3 Mar 2018, at 8:38 PM, Martin Vignali wrote: > > Works for me on MacOs 10.12 (x86_64 and x86_32). > > Martin > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.o

[FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-02 Thread Yingming Fan
m/hevc_sao.c b/tests/checkasm/hevc_sao.c new file mode 100644 index 00..e2a0a54e9b --- /dev/null +++ b/tests/checkasm/hevc_sao.c @@ -0,0 +1,158 @@ +/* + * Copyright (c) 2018 Yingming Fan + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-02 Thread Yingming Fan
Thank you for your remind and i have already sent another patch fix the issue. Yingming Fan > On 3 Mar 2018, at 2:23 AM, Martin Vignali wrote: > > 2018-03-02 12:48 GMT+01:00 Yingming Fan <mailto:yingming...@gmail.com>>: > >> If you want to test checkasm of hev

Re: [FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-02 Thread Yingming Fan
If you want to test checkasm of hevc_sao, please use `checkasm --test=hevc_sao`, or `checkasm --test=hevc_sao --bench`. > On 2 Mar 2018, at 7:03 PM, Yingming Fan wrote: > > --- > tests/checkasm/Makefile | 2 +- > tests/checkasm/checkasm.c | 1 + > tests/checkas

[FFmpeg-devel] [PATCH] checkasm/hevc_sao : add hevc_sao for checkasm

2018-03-02 Thread Yingming Fan
.c new file mode 100644 index 00..e2a0a54e9b --- /dev/null +++ b/tests/checkasm/hevc_sao.c @@ -0,0 +1,158 @@ +/* + * Copyright (c) 2018 Yingming Fan + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or modify + * it under the terms of the GN

[FFmpeg-devel] add hevc_sao for checkasm

2018-03-02 Thread Yingming Fan
Hi there. We are working on add some neon optimization for hevc decoder. But before submit neon codes i'd like to submit some checkasm codes. First one will be checkasm codes of SAO. Yingming Fan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [GSoC] Patch which add simple P frame support for ffv1

2015-04-23 Thread Yingming Fan
12:03:38AM +0800, Yingming Fan wrote: > > Hi, everyone. > > > > This is my GSoC qualification task, add simple P frame for ffv1. > > > > P frame will work when you add -level 4. > > > > eg. ffmpeg -pix_fmt yuv420p -s -i xx.yuv -vcodec ffv1 -level

[FFmpeg-devel] [GSoC] Patch which add simple P frame support for ffv1

2015-04-23 Thread Yingming Fan
Hi, everyone. This is my GSoC qualification task, add simple P frame for ffv1. P frame will work when you add -level 4. eg. ffmpeg -pix_fmt yuv420p -s -i xx.yuv -vcodec ffv1 -level 4 test.nut Notice: Only support yuv colorspace and 8 bit currently, i will support these in later time. Othe