Re: [FFmpeg-devel] [PATCH v2] lavfi/qsvvpp: Copy frame props before modify it

On Ma, 2024-11-25 at 11:18 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > The changes to output frame props in query_frame overlapped since > 578ac59887. Move the copy frame props before the changes. > > Signed-off-by: Fei Wang > --- >  libavfilter/qsvvpp.c | 23 +

Re: [FFmpeg-devel] [PATCH] lavfi/qsvvpp: Copy frame props before modify it

On Vr, 2024-11-22 at 13:18 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > The changes to output frame props in query_frame overlapped since > b14ed6ea58. Move the copy frame props before the changes. I can't find commit b14ed6ea58, could you double check the bad commit ?

Re: [FFmpeg-devel] [PATCH v4 1/8] lavc/vaapi_dec: Create VA parameters dynamically

On Wo, 2024-10-30 at 01:15 +, Xiang, Haihao wrote: > On Ma, 2024-10-28 at 16:55 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Signed-off-by: Fei Wang > > --- > >  libavcodec/vaapi_decode.c | 34 +---

Re: [FFmpeg-devel] [PATCH v4 1/8] lavc/vaapi_dec: Create VA parameters dynamically

On Ma, 2024-10-28 at 16:55 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_decode.c | 34 +- >  libavcodec/vaapi_decode.h |  7 ++- >  2 files changed, 27 insertions(+), 14 deletions(-) > >

Re: [FFmpeg-devel] [PATCH v3 7/8] lavc/vvc_dec: Add hardware decode API

On Wo, 2024-09-25 at 10:15 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/vvc/dec.c  | 90 --- >  libavcodec/vvc/dec.h  |  4 ++ >  libavcodec/vvc/refs.c |  6 +++ >  3 files changed, 87 inser

Re: [FFmpeg-devel] [PATCH v2] avcodec/vaapi_encode: fix compilation without CONFIG_VAAPI_1

On Wo, 2024-10-09 at 04:48 +0200, Ingo Brückl wrote: > FFmpeg 7.1 as well as the latest development branch do not compile: > >   In function 'vaapi_encode_h264_init_picture_params': >   libavcodec/vaapi_encode_h264.c:470:9: error: 'ctx' undeclared LGTM, applied Thanks Haihao ___

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode: fix compilation without CONFIG_VAAPI_1

On Di, 2024-10-08 at 22:34 +0200, Ingo Brückl wrote: > FFHWBaseEncodeContext   *base_ctx = avctx->priv_data; > +    VAAPIEncodeContext   *ctx = avctx->priv_data; Please add this between #if !CONFIG_VAAPI_1 and #endif too. BTW we are considering to remove the support for libv

Re: [FFmpeg-devel] mediacodec and qsv not really hwaccels ?

On Di, 2024-09-24 at 00:53 +0300, Andrew Randrianasulu wrote: > I tried to trivially add qsv/mediacodec decode to cinelerra-gg, but > discovered that I can't use it like vaapi/vdpau/cuda because (?) > qsv/mediacodec not listed in > > ffmpeg/libavcodec/hwconfig.h > and (for h264) in > ffmpeg/libavc

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h265: fix missing slice_block_cols assignment

On Vr, 2024-09-20 at 01:12 +, Wang, Fei W wrote: > On Thu, 2024-09-19 at 20:01 +0200, Marvin Scholz wrote: > > Instead of assigning to unit_opts.slice_block_cols, the > > slice_block_cols > > value from the context was incorrectly assigned to slice_block_rows. > > > > Regression from 12f158ca8

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Fix encode fail since 9db68ed0

On Vr, 2024-09-13 at 10:45 +0200, Lynne via ffmpeg-devel wrote: > On 13/09/2024 05:15, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Signed-off-by: Fei Wang > > --- > >   libavcodec/vaapi_encode_av1.c | 2 +- > >   1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: Fix potential use of uninitialized value

On Wo, 2024-09-11 at 09:37 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_encode.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c > index 0058

Re: [FFmpeg-devel] [PATCH 1/2] doc/av1_qsv: Fix typo

On Ma, 2024-08-26 at 09:40 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  doc/encoders.texi | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/encoders.texi b/doc/encoders.texi > index 496852faeb..1035be0052 10064

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: Remove duplicate include header file

On Ma, 2024-08-26 at 09:41 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/qsvenc.h | 2 -- >  libavcodec/qsvenc_av1.c | 2 -- >  2 files changed, 4 deletions(-) > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > inde

Re: [FFmpeg-devel] [PATCH v2] lavc/qsvdec: Add vvc_mp4toannexb bsf for QSV VVC decoder

On Do, 2024-08-15 at 10:19 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Fix error: > $ ffmpeg -hwaccel qsv -i input.mp4 -f null - > .. > [vvc_qsv @ 026890D966C0] Error decoding stream header: unknown error (-1) > [vvc_qsv @ 026890D966C0] Error decoding header > >

Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: Add vvc_mp4toannexb bsf for QSV VVC decoder

On Di, 2024-08-13 at 16:01 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Fix error: > $ ffmpeg -hwaccel qsv -i input.mp4 -f null - > .. > [vvc_qsv @ 026890D966C0] Error decoding stream header: unknown error (-1) > [vvc_qsv @ 026890D966C0] Error decoding header > >

Re: [FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_vaapi: Add option to allow to specify vendor id when init hw device

On Ma, 2024-08-05 at 02:14 +, Xiang, Haihao wrote: > On Vr, 2024-07-26 at 09:05 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Vendor id will help to select desired device in case of kernel driver is > > unknow or unsupported, for v

Re: [FFmpeg-devel] [PATCH 1/3] lavu/hwcontext_vaapi: Add option to allow to specify vendor id when init hw device

On Vr, 2024-07-26 at 09:05 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Vendor id will help to select desired device in case of kernel driver is > unknow or unsupported, for vendor may support different kernel driver on > different platforms. > > Signed-off-by: Fei Wang

Re: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: Make it possible to send multiple slice params buffers

On Di, 2024-07-30 at 11:31 +0200, Sebastian Ramacher wrote: > On 2024-05-07 06:59:51 +0000, Xiang, Haihao wrote: > > On So, 2024-04-28 at 09:26 +0200, David Rosca wrote: > > > --- > > >  libavcodec/vaapi_av1.c    | 2 +- > > >  libavcodec/vaapi_decode.c | 3 ++-

Re: [FFmpeg-devel] [PATCH] avcodec/av1_vaapi: Enable AV1Profile2 VAAPI support.

On Di, 2024-07-30 at 16:02 -0400, David (Ming Qiang) Wu via ffmpeg-devel wrote: > AV1Profile2 VAAPI is supported and tested on AMD VCN5. > > Signed-off-by: David (Ming Qiang) Wu > --- >  libavcodec/av1dec.c   | 3 +++ >  libavcodec/vaapi_decode.c | 3 +++ >  2 files changed, 6 insertions(+) >

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/qsvdec: Add VVC decoder

On Vr, 2024-07-26 at 04:43 +, Xiang, Haihao wrote: > On Vr, 2024-06-14 at 16:28 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Signed-off-by: Fei Wang > > --- > >  Changelog  | 1 + > >  configure

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: Derive bind flag from frame type if no valid surface

On Ma, 2024-07-29 at 15:27 +, Tong Wu wrote: -Original Message- From: ffmpeg-devel mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of fei.w.wang-at-intel@ffmpeg.org Sent: 2024年7月23日 9:27 To: ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/qsvdec: Add VVC decoder

On Vr, 2024-06-14 at 16:28 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  Changelog  | 1 + >  configure  | 1 + >  doc/decoders.texi  | 2 +- >  libavcodec/allcodecs.c | 1 + >  libavcodec/qsv.c   | 4 >  li

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_{decode, av1}: Fix memory leak in fail codepath

On Ma, 2024-07-01 at 16:36 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_av1.c    | 9 + >  libavcodec/vaapi_decode.c | 5 +++-- >  2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/vaapi_

Re: [FFmpeg-devel] [PATCH v2] doc/examples/vaapi_encode: Try to check fwrite() for failure

On Di, 2024-07-02 at 01:47 +0200, Michael Niedermayer wrote: > Fixes: CID1604548 Unused value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  doc/examples/vaapi_encode.c | 4 >  1 file changed, 4 insertions(+) > > diff --git a/doc/examples/vaapi_encode.c b

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/vaapi_h264: Do not store our error code in VASliceParameterBufferH264

On So, 2024-07-07 at 20:47 +0200, Michael Niedermayer wrote: > I am not sure this is possible (thus this requires review) > > Fixes: CID1604570 Overflowed constant > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  libavcodec/vaapi_h264.c | 6 +- >  1 file cha

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/qsvvpp: Remove unreachable code

On Di, 2024-06-11 at 23:59 +0200, Michael Niedermayer wrote: > Fixes: CID1598548 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  libavfilter/qsvvpp.c | 5 - >  1 file changed, 5 deletions(-) > > diff --git a/libavfilter/qsvvpp.c b/libavf

Re: [FFmpeg-devel] [PATCH v5 1/2] configure, lavu, lavc, lavfi: Remove libva 1.x support

On Wo, 2024-06-05 at 21:13 +0100, Mark Thompson wrote: > libva 2.0 was released in 2017 and the 2.x versions are included in all > supported distributions nowadays.  Various features no longer need any > configure check after this change, including all codecs except AV1. > Note that the libva versi

[FFmpeg-devel] [PATCH] lavu/hwcontext_vulkan: Support write on drm frame

From: Haihao Xiang Otherwise nothing is written into the destination when a write mapping is requested. For example, a vulkan frame mapped from a drm frame (which is wrapped as a vaapi frame in the example) is used as the output of scale_vulkan filter, it always gets a green screen without this

Re: [FFmpeg-devel] [PATCH v2] lavc/vaapi_h264: Fix merging fields in DPB with missing references

On Wo, 2024-05-08 at 17:41 +0200, David Rosca wrote: > If there are missing references, h264 decode does error concealment > by copying previous refs which means there will be duplicated surfaces. > Check long_ref and frame_idx in addition to surface when looking for > the other field to avoid tryi

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/vaapi_decode: Make it possible to send multiple slice params buffers

On Wo, 2024-05-08 at 09:11 +0200, David Rosca wrote: > --- > v2: No changes > >  libavcodec/vaapi_av1.c    | 2 +- >  libavcodec/vaapi_decode.c | 3 ++- >  libavcodec/vaapi_decode.h | 1 + >  libavcodec/vaapi_h264.c   | 2 +- >  libavcodec/vaapi_hevc.c   | 4 ++-- >  libavcodec/vaapi_mjpeg.c  | 2 +- >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: fix keyframes

On Vr, 2024-05-24 at 13:20 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > MFX_FRAMETYPE_IDR is ORed to the frame type for AVC and HEVC keyframes, > and MFX_FRAMETYPE_I is taken as keyframe flag for other codecs when > getting the output surface from the SDK, hence we may

Re: [FFmpeg-devel] [PATCH 07/17] qsv: Initialize impl_value

On Ma, 2024-05-27 at 01:52 +0200, Michael Niedermayer wrote: > Fixes: The warnings from CID1598553 Uninitialized scalar variable > > Passing partly initialized structs is ugly and asking for hard to reproduce > bugs, > I do not know if this actually fixes a bug or just avoids the uninitialized > f

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc: respect user's setting for keyframes

From: Haihao Xiang For example: ./ffmpeg -hwaccel qsv -i input.mp4 -force_key_frames:v source -c:v hevc_qsv -f null - Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 3df355ce

[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: fix keyframes

From: Haihao Xiang MFX_FRAMETYPE_IDR is ORed to the frame type for AVC and HEVC keyframes, and MFX_FRAMETYPE_I is taken as keyframe flag for other codecs when getting the output surface from the SDK, hence we may mark the output frame as keyframe accordingly. Signed-off-by: Haihao Xiang --- li

Re: [FFmpeg-devel] [PATCH 1/4] lavc/qsvenc: rename the skip_frame private option to qsv_skip_frame

On Do, 2024-05-23 at 11:03 +0200, Anton Khirnov wrote: > It conflicts with the AVCodecContext option of the same name. > --- The skip_frame option in AVCodecContext is for decoding only, may we not use this option for encoding ? >  libavcodec/qsvenc.h | 2 +- >  1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: update HDR side data on output AVFrame for AV1 decoding

On Wo, 2024-05-22 at 12:15 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > The SDK may provide HDR metadata for HDR streams via mfxExtBuffer > attached on output mfxFrameSurface1 > > Signed-off-by: Haihao Xiang > --- >  

Re: [FFmpeg-devel] [PATCH v1 1/2] lavc/qsvdec: Allow decoders to export crop information

On Ma, 2024-05-20 at 10:05 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- >  libavcodec/qsvdec.c | 6 +- >  1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c > index a51ddace62..12cf6

[FFmpeg-devel] [PATCH] libavcodec/x86/vvc/vvc_sad: fix assembler error

From: Haihao Xiang X86ASMlibavcodec/x86/vvc/vvc_sad.o libavcodec/x86/vvc/vvc_sad.asm:85: error: invalid number of operands libavcodec/x86/vvc/vvc_sad.asm:87: error: invalid number of operands Signed-off-by: Haihao Xiang --- libavcodec/x86/vvc/vvc_sad.asm | 4 ++-- 1 file changed, 2 inserti

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc_av1: accept HDR metadata if have

From: Haihao Xiang The sdk av1 encoder can accept HDR metadata via mfxEncodeCtrl::ExtParam. Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_av1.c | 73 + 1 file changed, 73 insertions(+) diff --git a/libavcodec/qsvenc_av1.c b/libavcodec/qsvenc_av1.c i

[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: update HDR side data on output AVFrame for AV1 decoding

From: Haihao Xiang The SDK may provide HDR metadata for HDR streams via mfxExtBuffer attached on output mfxFrameSurface1 Signed-off-by: Haihao Xiang --- libavcodec/qsvdec.c | 48 - 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/libavco

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: fix GCC 14.1 warnings

On Ma, 2024-05-20 at 02:37 +, Wu, Tong1 wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Oleg > > Tolmatcev > > Sent: Saturday, May 18, 2024 3:39 AM > > To: ffmpeg-devel@ffmpeg.org > > Subject: [FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: fix GCC 14.1 warnings > > > >

Re: [FFmpeg-devel] [PATCH 2/2] lavc/qsvenc_av1: accept HDR metadata if have

On Di, 2024-05-21 at 08:35 +0200, Andreas Rheinhardt wrote: > Xiang, Haihao: > > From: Haihao Xiang > > > > The sdk av1 encoder can accept HDR metadata via mfxEncodeCtrl::ExtParam. > > > > Signed-off-by: Haihao Xiang > >

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc_av1: accept HDR metadata if have

From: Haihao Xiang The sdk av1 encoder can accept HDR metadata via mfxEncodeCtrl::ExtParam. Signed-off-by: Haihao Xiang --- libavcodec/qsvenc_av1.c | 75 + 1 file changed, 75 insertions(+) diff --git a/libavcodec/qsvenc_av1.c b/libavcodec/qsvenc_av1.c i

[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: update HDR side data on output AVFrame for AV1 decoding

From: Haihao Xiang The SDK may provides HDR metadata for HDR streams via mfxExtBuffer attached on output mfxFrameSurface1 Signed-off-by: Haihao Xiang --- libavcodec/qsvdec.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/libavc

Re: [FFmpeg-devel] [PATCH v2] lavc/vaapi_decode: Reject decoding of frames with no slices

On Ma, 2024-05-13 at 09:38 +0200, David Rosca wrote: > Matches other hwaccels. > --- > v2: AVERROR > >  libavcodec/vaapi_decode.c | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index 8e9f647c20..7c91d50f7b 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH] lavu/version: fix minor version

On Vr, 2024-05-17 at 13:05 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > The latest version should be 59.18.100 since commit 01c5f4ad > > $ git diff 01c5f4ad~1..HEAD doc/APIchanges > ... > +2024-05-10 - x - lavu 59.18.100 - cpu.h > +  Add AV_CPU_FLAG_RV_Z

[FFmpeg-devel] [PATCH] lavu/version: fix minor version

From: Haihao Xiang The latest version should be 59.18.100 since commit 01c5f4ad $ git diff 01c5f4ad~1..HEAD doc/APIchanges ... +2024-05-10 - x - lavu 59.18.100 - cpu.h + Add AV_CPU_FLAG_RV_ZVBB. + Signed-off-by: Haihao Xiang --- libavutil/version.h | 2 +- 1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_decode: Reject decoding of frames with no slices

On Vr, 2024-05-10 at 11:55 +0200, David Rosca wrote: > Matches other hwaccels. > --- >  libavcodec/vaapi_decode.c | 5 + >  1 file changed, 5 insertions(+) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index 8e9f647c20..3c4030c073 100644 > --- a/libavcodec/vaapi_decod

Re: [FFmpeg-devel] [PATCH v2 9/9] lavfi/qsvvpp: require a dynamic frame pool for output if possible

On Wo, 2024-05-08 at 14:03 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Signed-off-by: Haihao Xiang > --- >  libavfilter/qsvvpp.c | 52 >  1 file changed, 29 insertions(+), 23 deletions(-) > > diff --git a/libavfilte

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/qsvdec: Check av_image_get_buffer_size() for failure

On Ma, 2024-05-13 at 03:20 +0200, Michael Niedermayer wrote: > Fixes: CID1477406 Improper use of negative value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  libavcodec/qsvdec.c | 9 ++--- >  1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/3] lavc/vaapi_encode_av1: implement write_extra_header callback

On Ma, 2024-04-15 at 10:07 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > This can be used to insert a metadata OBU to the stream later. > > Signed-off-by: Haihao Xiang > --- >  libavcodec/vaapi_encode_av1.c | 42 ++- >  1 file chan

Re: [FFmpeg-devel] [PATCH v4 1/5] configure: Remove libva 1.x support

On Di, 2024-05-07 at 21:25 +0100, Mark Thompson wrote: > On 07/05/2024 06:27, Xiang, Haihao wrote: > > On So, 2024-05-05 at 20:01 +0100, Mark Thompson wrote: > > > libva 2.0 was released in 2017 and the 2.x versions are included in all > > > supported distributions now

[FFmpeg-devel] [PATCH v2 8/9] lavfi/qsvvpp: use the right mfxFrameInfo when dynamic frame pool is used

From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavfilter/qsvvpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 10d970652e..c4c338b36b 100644 --- a/libavfilter/qsvvpp.c +++ b/libavfilter/qsvvpp.c @@ -308,7 +308,7 @@ s

[FFmpeg-devel] [PATCH v2 9/9] lavfi/qsvvpp: require a dynamic frame pool for output if possible

From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavfilter/qsvvpp.c | 52 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index c4c338b36b..1c9773df09 100644 --- a/libavfilter/qsvvpp.c +

[FFmpeg-devel] [PATCH v2 7/9] lavc/qsvdec: require a dynamic frame pool if possible

From: Haihao Xiang This allows a downstream element stores more frames from qsv decoders and fixes error in get_buffer(). $ ffmpeg -hwaccel qsv -hwaccel_output_format qsv -i input.mp4 -vf reverse -f null - [vist#0:0/h264 @ 0x562248f12c50] Decoding error: Cannot allocate memory [h264_qsv @ 0x562

[FFmpeg-devel] [PATCH v2 6/9] lavc/qsvenc: use the right info for encoding

From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index d881c11160..3df355ce78 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -745,8 +745,

[FFmpeg-devel] [PATCH v2 5/9] lavc/qsv: fix the mfx allocator to support dynamic frame pool

From: Haihao Xiang When the external allocator is used for dynamic frame allocation, only video memory is supported, the SDK doesn't lock/unlock the memory block via Lock()/Unlock() calls. Signed-off-by: Haihao Xiang --- libavcodec/qsv.c | 68 +++- 1

[FFmpeg-devel] [PATCH v2 4/9] lavu/hwcontext_qsv: add support for dynamic frame pool in qsv_map_to

From: Haihao Xiang Make it work with the source which has a dynamic frame pool. Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 131 +- 1 file changed, 129 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontex

[FFmpeg-devel] [PATCH v2 3/9] lavu/hwcontext_qsv: add support for dynamic frame pool in qsv_frames_derive_to

From: Haihao Xiang Make it work with the source which has a dynamic frame pool. Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 61 ++- 1 file changed, 54 insertions(+), 7 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext

[FFmpeg-devel] [PATCH v2 2/9] lavu/hwcontext_qsv: create dynamic frame pool if required

From: Haihao Xiang When AVHWFramesContext.initial_pool_size is 0, a dynamic frame pool is required. We may support this under certain conditions, e.g. oneVPL 2.9+ support dynamic frame allocation, we needn't provide a fixed frame pool in the mfxFrameAllocator.Alloc callback. Signed-off-by: Haiha

[FFmpeg-devel] [PATCH v2 1/9] lavu/hwcontext_qsv: update AVQSVFramesContext to support dynamic frame pool

From: Haihao Xiang Add AVQSVFramesContext.info and update the description. Signed-off-by: Haihao Xiang --- doc/APIchanges| 3 +++ libavutil/hwcontext_qsv.c | 4 ++-- libavutil/hwcontext_qsv.h | 27 +-- libavutil/version.h | 2 +- 4 files changed, 31

Re: [FFmpeg-devel] [PATCH 1/2] lavc/vaapi_decode: Make it possible to send multiple slice params buffers

On So, 2024-04-28 at 09:26 +0200, David Rosca wrote: > --- >  libavcodec/vaapi_av1.c    | 2 +- >  libavcodec/vaapi_decode.c | 3 ++- >  libavcodec/vaapi_decode.h | 1 + >  libavcodec/vaapi_h264.c   | 2 +- >  libavcodec/vaapi_hevc.c   | 4 ++-- >  libavcodec/vaapi_mjpeg.c  | 2 +- >  libavcodec/vaapi_mp

Re: [FFmpeg-devel] [PATCH v4 1/5] configure: Remove libva 1.x support

On So, 2024-05-05 at 20:01 +0100, Mark Thompson wrote: > libva 2.0 was released in 2017 and the 2.x versions are included in all > supported distributions nowadays.  Various features no longer need any > configure check after this command, including all codecs except AV1. > Note that the libva vers

Re: [FFmpeg-devel] [PATCH 2/2] lavc/qsvenc: add support for oneVPL string API

On Do, 2024-02-29 at 13:34 +0800, Xiang, Haihao wrote: > From: "Mandava, Mounika" > > A new option -qsv_params is added, where is a :-separated > list of key=value parameters. > > Example: > $ ffmpeg -y -f lavfi -i testsrc -vf "format=nv12" -

Re: [FFmpeg-devel] [PATCH 1/9] lavu/hwcontext_qsv: update AVQSVFramesContext to support dynamic frame pool

On Do, 2024-05-02 at 20:35 +0100, Mark Thompson wrote: > On 28/04/2024 08:39, Xiang, Haihao wrote: > > From: Haihao Xiang > > > > Add AVQSVFramesContext.info and update the description. > > > > Signed-off-by: Haihao Xiang > > --- > >  doc/

Re: [FFmpeg-devel] [PATCH 5/6] vaapi_av1: Fix force_integer_mv value

On Sa, 2024-04-27 at 16:30 +0100, Mark Thompson wrote: > --- >  libavcodec/vaapi_av1.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c > index 1f563483b9..f61bf63098 100644 > --- a/libavcodec/vaapi_av1.c > +++ b/libavcodec/va

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_hevc: Don't require exact profiles

On So, 2024-04-28 at 15:14 +0100, Mark Thompson wrote: > On 24/04/2024 14:45, Xiang, Haihao wrote: > > On Ma, 2024-04-22 at 22:23 +0100, Mark Thompson wrote: > > > Rather than turning the constraint flags into a single profile and then > > > searching for that profile

[FFmpeg-devel] [PATCH 8/9] lavfi/qsvvpp: use the right mfxFrameInfo when dynamic frame pool is used

From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavfilter/qsvvpp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 8c92fec0c1..6814d8add8 100644 --- a/libavfilter/qsvvpp.c +++ b/libavfilter/qsvvpp.c @@ -308,7 +308,7 @@ s

[FFmpeg-devel] [PATCH 7/9] lavc/qsvdec: require a dynamic frame pool if possible

From: Haihao Xiang This allows a downstream element stores more frames from qsv decoders and fixes error in get_buffer(). $ ffmpeg -hwaccel qsv -hwaccel_output_format qsv -i input.mp4 -vf reverse -f null - [vist#0:0/h264 @ 0x562248f12c50] Decoding error: Cannot allocate memory [h264_qsv @ 0x562

[FFmpeg-devel] [PATCH 9/9] lavfi/qsvvpp: require a dynamic frame pool for output if possible

From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavfilter/qsvvpp.c | 52 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 6814d8add8..f3897823db 100644 --- a/libavfilter/qsvvpp.c +

[FFmpeg-devel] [PATCH 6/9] lavc/qsvenc: use the right info for encoding

From: Haihao Xiang Signed-off-by: Haihao Xiang --- libavcodec/qsvenc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 018d193495..ca1a88e49f 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -744,8 +744,

[FFmpeg-devel] [PATCH 5/9] lavc/qsv: fix the mfx allocator to support dynamic frame pool

From: Haihao Xiang When the external allocator is used for dynamic frame allocation, only video memory is supported, the SDK doesn't lock/unlock the memory block via Lock()/Unlock() calls. Signed-off-by: Haihao Xiang --- libavcodec/qsv.c | 68 +++- 1

[FFmpeg-devel] [PATCH 4/9] lavu/hwcontext_qsv: add support for dynamic frame pool in qsv_map_to

From: Haihao Xiang Make it work with the source which has a dynamic frame pool. Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 131 +- 1 file changed, 129 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontex

[FFmpeg-devel] [PATCH 3/9] lavu/hwcontext_qsv: add support for dynamic frame pool in qsv_frames_derive_to

From: Haihao Xiang Make it work with the source which has a dynamic frame pool. Signed-off-by: Haihao Xiang --- libavutil/hwcontext_qsv.c | 61 ++- 1 file changed, 54 insertions(+), 7 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext

[FFmpeg-devel] [PATCH 2/9] lavu/hwcontext_qsv: create dynamic frame pool if required

From: Haihao Xiang When AVHWFramesContext.initial_pool_size is 0, a dynamic frame pool is required. We may support this under certain conditions, e.g. oneVPL 2.9+ support dynamic frame allocation, we needn't provide a fixed frame pool in the mfxFrameAllocator.Alloc callback. Signed-off-by: Haiha

[FFmpeg-devel] [PATCH 1/9] lavu/hwcontext_qsv: update AVQSVFramesContext to support dynamic frame pool

From: Haihao Xiang Add AVQSVFramesContext.info and update the description. Signed-off-by: Haihao Xiang --- doc/APIchanges| 3 +++ libavutil/hwcontext_qsv.c | 4 ++-- libavutil/hwcontext_qsv.h | 28 +--- libavutil/version.h | 4 ++-- 4 files changed,

Re: [FFmpeg-devel] [PATCH] lavfi/qsv: Copy metadata fields from the given input

On Do, 2024-04-25 at 13:18 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Currently it always copies the metadata fields from the last input when > there are multiple inputs for the filter. For example, the metadata > fields from input1 are copied to the output for ove

Re: [FFmpeg-devel] [PATCH v4] lavu/hwcontext_vaapi: Use vaMapBuffer2 for mapping image buffers

On Do, 2024-04-25 at 09:33 +0200, David Rosca wrote: > On Fri, Nov 24, 2023 at 8:27 AM Xiang, Haihao wrote: > > > > On Vr, 2023-10-27 at 22:25 +0200, David Rosca wrote: > > > This allows some optimizations in driver, such as not having to read > > > back

[FFmpeg-devel] [PATCH] lavfi/qsv: Copy metadata fields from the given input

From: Haihao Xiang Currently it always copies the metadata fields from the last input when there are multiple inputs for the filter. For example, the metadata fields from input1 are copied to the output for overlay_qsv filter, however for regular overlay filters, the metadata fields from input0 a

Re: [FFmpeg-devel] [PATCH v3 1/4] lavu: Remove libva 1.x support

On Ma, 2024-04-22 at 22:41 +0100, Mark Thompson wrote: > libva 2.0 was released in 2017 and the 2.x versions are included in all > supported distributions nowadays. > --- > Rebased. > > I think we can also drop the other quirks?  They are for the proprietary media > SDK driver (which I think is de

Re: [FFmpeg-devel] [PATCH 1/2] lavc/h265_profile_level: Expand profile compatibility checking

On Ma, 2024-04-22 at 22:22 +0100, Mark Thompson wrote: > Replace existing get_profile() with find_profile(), which finds the > lowest compatible profile rather than requiring an exact match. > --- >  libavcodec/h265_profile_level.c | 73 + >  libavcodec/h265_profile_l

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_hevc: Don't require exact profiles

On Ma, 2024-04-22 at 22:23 +0100, Mark Thompson wrote: > Rather than turning the constraint flags into a single profile and then > searching for that profile (and failing if it doesn't match any profile > exactly), instead search all supported profiles and use the first one > which supports the giv

Re: [FFmpeg-devel] [PATCH 2/5] doc/examples/qsv_transcode: Simplify loop

On Wo, 2024-04-24 at 03:45 +0200, Michael Niedermayer wrote: > Fixes: CID1428858(2/2) Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  doc/examples/qsv_transcode.c | 4 +--- >  1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/d

Re: [FFmpeg-devel] [PATCH 5/5] doc/examples/qsv_transcode: Initialize pointer before free

On Wo, 2024-04-24 at 03:45 +0200, Michael Niedermayer wrote: > Fixees: CID1517023 Uninitialized pointer read > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  doc/examples/qsv_transcode.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

Re: [FFmpeg-devel] [PATCH 4/5] doc/examples/qsv_transcode: Simplify str_to_dict() loop

On Wo, 2024-04-24 at 03:45 +0200, Michael Niedermayer wrote: > Fixes: CID1517022 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- >  doc/examples/qsv_transcode.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/doc/exa

Re: [FFmpeg-devel] [PATCH v1] lavc/qsvdec: Use FFmpeg default 1/25 framerate if can't derive it from bitstream

On Do, 2024-04-18 at 16:15 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Fix error: > $ ffmpeg -hwaccel qsv -i input.h265 -f null - > ... > [null @ 0x55da1a629200] Application provided invalid, non monotonically > increasing dts to muxer in stream 0: 3 >= 3 > > Signed-off

Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_qsv: Make qsv hardware transfers thread safe

On Wo, 2024-04-17 at 09:46 -0500, Mark Samuelson wrote: > The QSV hardware context currently uses pthreads to lock initilization, > which is not available on windows builds.  Instead, use the AVMutex > object.  Also lock uses of the realigned_upload_frame and > realigned_download_frame objects, so

Re: [FFmpeg-devel] [PATCH] lavc/vp9: Fix regression introduced in 0ba05857

On Di, 2024-04-23 at 14:14 +0200, Andreas Rheinhardt wrote: > Xiang, Haihao: > > From: Haihao Xiang > > > > It is possible that ff_progress_frame_await() is called but > > ff_progress_frame_report() isn't called when a hardware acceleration > > method is us

[FFmpeg-devel] [PATCH] lavc/vp9: Fix regression introduced in 0ba05857

From: Haihao Xiang It is possible that ff_progress_frame_await() is called but ff_progress_frame_report() isn't called when a hardware acceleration method is used, so a thread for vp9 decoding might get stuck. Signed-off-by: Haihao Xiang --- libavcodec/vp9.c | 2 +- 1 file changed, 1 insertion

[FFmpeg-devel] [PATCH] configure: Fix typo

From: Haihao Xiang Otherwise there are link errors: LD ffprobe_g /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to `ff_dovi_rpu_generate' /usr/bin/ld: libavcodec/libavcodec.so: undefined reference to `ff_dovi_configure' collect2: error: ld returned 1 exit status Signed-off-by: H

Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_qsv: Make qsv hardware transfers thread safe

On Sa, 2024-04-13 at 07:57 -0500, Mark Samuelson wrote: > The QSV hardware context currently uses pthreads to lock initilization, > which is not available on windows builds.  Instead, use the AVMutex > object.  Also lock uses of the realigned_upload_frame and > realigned_download_frame objects, so

[FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_av1: insert HDR_CLL metadata if have

From: Haihao Xiang Only look for HDR_CLL on key frame on the output. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode_av1.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c index 4077d21202..b868f5b66a 100

[FFmpeg-devel] [PATCH 2/3] lavc/vaapi_encode_av1: Insert HDR_MDCV metadata if have

From: Haihao Xiang Only look for HDR_MDVC on key frame on the output. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode_av1.c | 46 +++ 1 file changed, 46 insertions(+) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c index 4b417

[FFmpeg-devel] [PATCH 1/3] lavc/vaapi_encode_av1: implement write_extra_header callback

From: Haihao Xiang This can be used to insert a metadata OBU to the stream later. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode_av1.c | 42 ++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaa

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/tonemap_vaapi: By default use bt709 for output frame

On Ma, 2024-03-18 at 16:12 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > By default don't use the color properties from input frame as output > frame properties when performing HDR to SDR conversion > > Signed-off-by: Haihao Xiang > --- >  doc/f

Re: [FFmpeg-devel] [PATCH 1/3] lavfi: Add pad_vaapi filter

On Ma, 2024-03-18 at 14:06 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Signed-off-by: Haihao Xiang > --- >  configure  |   1 + >  doc/filters.texi   |  77 ++ >  libavfilter/Makefile   |   1 + >  libavfilter/allfilters.c 

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/vaapi_decode: Use dynamic frame pool if possible

On Wo, 2024-04-10 at 11:01 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > libva2 doesn't require a fixed surface-array any more, so we may use > dynamic frame pool for decoding when libva2 is available, which allows a > downstream element stores more frames from VAAP

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag

On Di, 2024-03-05 at 16:02 +0800, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill > the reference_pic_flag with is_reference variable instead of 0 for B > frames. > > Signed-off-by: Tong Wu > --- >  libavcodec/

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/vaapi_encode_h265: Map HEVC AV REXT profile to VA REXT profile

On Ma, 2024-03-18 at 12:21 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > There is no Main8/10 profile defined in HEVC REXT profiles. Use Main12 > which is compatible with 8/10bit. > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_encode_h265.c | 4 ++-- >  1 file chan

[FFmpeg-devel] [PATCH v2 2/2] lavfi/vaapi_vpp: Use dynamic frame pool in outlink if possible

From: Haihao Xiang This can avoid to exhaust the buffers within outlink when libva2 is available. For example: $ ffmpeg -hwaccel_output_format vaapi -hwaccel vaapi -i input.mp4 \ -vf 'scale_vaapi=w=720:h=480' -c:v hevc_vaapi -f null - ... [vf#0:0 @ 0x55acad91f400] Error while filtering: Cannot a

  1   2   3   4   5   6   7   8   9   10   >