Re: [FFmpeg-devel] [PATCH] vaapi_encode: explicitly free buffers after vaEndPicture

2016-06-08 Thread Will Kelleher
On 06/08, Will Kelleher wrote: > > That works for me. I can update the patch with that warning. Thanks! > Updated patch attached. >From 3229edf9e52dfd61580209630f20ddef3e39e78e Mon Sep 17 00:00:00 2001 From: Will Kelleher Date: Tue, 7 Jun 2016 20:49:48 -0500 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] vaapi_encode: explicitly free buffers after vaEndPicture

2016-06-08 Thread Will Kelleher
On 06/08, Mark Thompson wrote: > On 08/06/16 21:02, Will Kelleher wrote: > > On 06/08, Mark Thompson wrote: > >> On 08/06/16 18:23, Will Kelleher wrote: > >>> Hi all - > >>> > >>> I'm experiencing some significant heap growth when encoding

Re: [FFmpeg-devel] [PATCH] vaapi_encode: explicitly free buffers after vaEndPicture

2016-06-08 Thread Will Kelleher
On 06/08, Mark Thompson wrote: > On 08/06/16 18:23, Will Kelleher wrote: > > Hi all - > > > > I'm experiencing some significant heap growth when encoding with VAAPI on > > my Ivy Bridge hardware. Based on what I'm seeing from Massif, it seems like &

[FFmpeg-devel] [PATCH] vaapi_encode: explicitly free buffers after vaEndPicture

2016-06-08 Thread Will Kelleher
Hi all - I'm experiencing some significant heap growth when encoding with VAAPI on my Ivy Bridge hardware. Based on what I'm seeing from Massif, it seems like the parameter buffers allocated in vaapi_encode_make_param_buffer are leaking. I came across this thread [1] that indicates that vaEndPic

Re: [FFmpeg-devel] [PATCH v2] hevc: Fix memory leak related to a53_caption data

2016-05-10 Thread Will Kelleher
On 04/08, Will Kelleher wrote: > > The leak is...continuous. We only noticed it during long running decode > operations because the amount is small, but it definitely adds up. > Hi all, I finally got some time to revisit this. In the simple case where we are not decoding the HE

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > On Fri, Apr 08, 2016 at 04:17:56PM -0500, Will Kelleher wrote: > > On 04/08, Michael Niedermayer wrote: > > > > > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > > > parsed, and then fr

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > > > The a53_caption buffer is normally realloc'd when each sei_nal is > > parsed, and then freed after it gets written to the output frame's > > side data in hevc_frame_start. > > and if an error happens between it leaks ? > If an error occurred after sei

Re: [FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
On 04/08, Michael Niedermayer wrote: > On Fri, Apr 08, 2016 at 10:05:13AM -0500, Will Kelleher wrote: > > Signed-off-by: Will Kelleher > > --- > > libavcodec/hevc_parser.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/h

[FFmpeg-devel] [PATCH] hevc: Fix memory leak related to a53_caption data

2016-04-08 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/hevc_parser.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/hevc_parser.c b/libavcodec/hevc_parser.c index 4625e61..5558afc 100644 --- a/libavcodec/hevc_parser.c +++ b/libavcodec/hevc_parser.c @@ -202,6 +202,9 @@ static inline int

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-12 Thread Will Kelleher
On 01/12, Hamza Shahid wrote: > Hi Will, > > I think we addressed all the review comments in this patch. Which are as > follows: > > 1. Remove inline asm for color conversion and replace with swscale, which I > did. > 2. Replace static variables with #defines, which I did. > 3. Remove unnecessary

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-12 Thread Will Kelleher
On 01/09, ha...@mayartech.com wrote: > From: "ha...@mayartech.com" > > This commit adds a hardware accelerated H.264 encoder which utilizes > libVA (open source implementation of VA-API). Information about libva > is available at: https://en.wikipedia.org/wiki/Video_Acceleration_API > This encode

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Will Kelleher
On 12/14, Nicolas George wrote: > Le quartidi 24 frimaire, an CCXXIV, Hendrik Leppkes a écrit : > > It can be both, ffmpeg also has a mode to forward the source types, if > > the user really wants that. But its of course not on by default. > > Ok. Then I suggest to fix the commit message: the scen

Re: [FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-14 Thread Will Kelleher
> The > WK> result will be improved transcoding quality at scene change boundaries. > > WK> Signed-off-by: Will Kelleher > WK> --- > WK> libavcodec/qsvenc.c | 11 +++ > WK> 1 file changed, 11 insertions(+) > > WK> diff --git a/libavcodec/qsvenc

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Don't clear input pict_type if force_key_frames is source

2015-12-11 Thread Will Kelleher
On 12/11, Michael Niedermayer wrote: > On Fri, Dec 11, 2015 at 09:47:29AM -0600, Will Kelleher wrote: > > The current behavior doesn't forward non-IDR I-frames to the encoder. > > would this not turn every I-type non keyframe into a key frame > effectively? > a

[FFmpeg-devel] [PATCH 1/2] qsvenc: Use scene-change hints from source frame if available

2015-12-11 Thread Will Kelleher
Since adaptive_i support is broken, this allows the QSV encoder to use scene- change hints from the input stream if force_key_frames = source is used. The result will be improved transcoding quality at scene change boundaries. Signed-off-by: Will Kelleher --- libavcodec/qsvenc.c | 11

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Don't clear input pict_type if force_key_frames is source

2015-12-11 Thread Will Kelleher
The current behavior doesn't forward non-IDR I-frames to the encoder. Signed-off-by: Will Kelleher --- ffmpeg.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index a866f72..61739a4 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -1141,7 +1141,6 @@ s

Re: [FFmpeg-devel] [PATCH] qsvenc: Add adaptive_i and adaptive_b toggles

2015-11-30 Thread Will Kelleher
On 11/29, Hendrik Leppkes wrote: > > These options were added in a merge from Libav, no further action > seems to be required. > Oh, good! I should probably note for the record that these toggles don't always/ever work. I was testing on Ivy Bridge hardware and the toggles are "accepted" by the A

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-30 Thread Will Kelleher
2924120d78 Mon Sep 17 00:00:00 2001 From: Will Kelleher Date: Tue, 27 Oct 2015 12:08:45 -0500 Subject: [PATCH] qsvenc: write a53 caption data to SEI Signed-off-by: Will Kelleher --- libavcodec/qsv_internal.h | 3 +++ libavcodec/qsvenc.c | 39 +--- libavcodec/q

Re: [FFmpeg-devel] [PATCH] qsvenc: Add adaptive_i and adaptive_b toggles

2015-11-12 Thread Will Kelleher
> Scene change detection ? > and > Content dependant B frame insertion > > And if people agree then please someone submit a patch with it > ill apply it > New patch. >From 983fb04e74c133de350da41bd5961f8c840ff327 Mon Sep 17 00:00:00 2001 From: Will Kelleher Date: T

Re: [FFmpeg-devel] [PATCH] qsvenc: Add adaptive_i and adaptive_b toggles

2015-11-12 Thread Will Kelleher
> Scene change detection ? > and > Content dependant B frame insertion > > And if people agree then please someone submit a patch with it > ill apply it > This sounds good to me. I will update the patch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-11 Thread Will Kelleher
Ivan, Here is an updated patch. Let me know if this is what you were thinking. will >From bbe29adf8eedf7944241c7e5e2704a2c8163faf5 Mon Sep 17 00:00:00 2001 From: Will Kelleher Date: Tue, 27 Oct 2015 12:08:45 -0500 Subject: [PATCH] qsvenc: write a53 caption data to SEI --- libavcodec/qsv

[FFmpeg-devel] [PATCH] hevc: Fix a53 caption extraction

2015-11-11 Thread Will Kelleher
Just realized my previous patch doesn't work quite right. I uploaded a better sample file that actually has visible captions to /incoming/hevc_cc.ts. I tested with that file doing hevc->x264 and it works. This is basically an exact copy of the existing h264 logic. will Signed-off-

[FFmpeg-devel] [PATCH] qsvenc: Add adaptive_i and adaptive_b toggles

2015-11-10 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/qsvenc.c | 2 ++ libavcodec/qsvenc.h | 2 ++ libavcodec/qsvenc_h264.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index df1f777..5e6ace1 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-09 Thread Will Kelleher
On 11/7/15, 12:07 PM, "ffmpeg-devel on behalf of Michael Niedermayer" wrote: >On Sat, Nov 07, 2015 at 02:17:12PM +, Will Kelleher wrote: >> On 11/7/15, 5:10 AM, "ffmpeg-devel on behalf of Michael Niedermayer" >> wrote: >> >> >>

Re: [FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-09 Thread Will Kelleher
On 11/7/15, 12:32 PM, "ffmpeg-devel on behalf of Ivan Uskov" wrote: >Hello Will, > >Saturday, November 7, 2015, 5:29:15 PM, you wrote: > >WK> --- >WK> libavcodec/qsvenc.c | 114 >WK> +-- >WK> libavcodec/qsvenc.h | 2 +- >WK> libavcodec/q

Re: [FFmpeg-devel] Intel QuickSync Video

2015-11-09 Thread Will Kelleher
On 11/6/15, 2:34 PM, "ffmpeg-devel on behalf of Sevan Gelici" wrote: >@Will Kelleher >CPU: >http://ark.intel.com/products/75122/Intel-Core-i7-4770-Processor-8M-Cache-up-to-3_90-GHz >MediaSDK: Intel-linux-media-ocl_generic_16.4.2.1-39163_64bit.tar.

[FFmpeg-devel] [PATCH] qsvenc: write a53 caption data to SEI

2015-11-07 Thread Will Kelleher
--- libavcodec/qsvenc.c | 114 +-- libavcodec/qsvenc.h | 2 +- libavcodec/qsvenc_h264.c | 2 +- 3 files changed, 113 insertions(+), 5 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index df1f777..0ee45f9 100644 --- a/l

Re: [FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-07 Thread Will Kelleher
On 11/7/15, 5:10 AM, "ffmpeg-devel on behalf of Michael Niedermayer" wrote: >On Fri, Nov 06, 2015 at 02:48:46PM -0600, Will Kelleher wrote: >> Signed-off-by: Will Kelleher >> --- >> libavcodec/hevc.c | 10 +++ >> libavcodec/hevc.h |

[FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-06 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/hevc.c | 10 +++ libavcodec/hevc.h | 4 +++ libavcodec/hevc_sei.c | 80 +++ 3 files changed, 94 insertions(+) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 4b3f199..1fa5283 100644

[FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-06 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/hevc.c | 10 +++ libavcodec/hevc.h | 4 +++ libavcodec/hevc_sei.c | 80 +++ 3 files changed, 94 insertions(+) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 4b3f199..1fa5283 100644

Re: [FFmpeg-devel] Intel QuickSync Video

2015-11-06 Thread Will Kelleher
> Hello, > > I try to transcode with quick sync, but it doesn't work. > I did follow: https://ffmpeg.org/general.html#Intel-QuickSync-Video > > > I get this error > [h264_qsv @ 0x3017580] Error initializing an internal MFX session > Error while opening encoder for output stream #0:0 - maybe inco

[FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-06 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/hevc.c | 10 +++ libavcodec/hevc.h | 4 +++ libavcodec/hevc_sei.c | 79 +++ 3 files changed, 93 insertions(+) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 4b3f199..1fa5283 100644

[FFmpeg-devel] [PATCH] hevc: extract SEI caption data

2015-11-05 Thread Will Kelleher
Signed-off-by: Will Kelleher --- libavcodec/hevc.c | 10 +++ libavcodec/hevc.h | 4 +++ libavcodec/hevc_sei.c | 79 +++ 3 files changed, 93 insertions(+) diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c index 4b3f199..1fa5283 100644