Hello,
Would it be possible to merge this patch?
Thanks,
Vitaly
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subje
On Fri, Jan 17, 2025 at 3:12 PM James Almer wrote:
> On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote:
> > My confusion here is that it looks like ffmpeg developers care about UB,
> I
> > see from time to time large cleanups, but there are a bunch of unfixed
>
19:12, Vitaly Buka via ffmpeg-devel wrote:
> > UBSAN by default is just prints a mesage and
> > moves on. This hides a few UBs in fate-suite.
> >
> > Signed-off-by: Vitaly Buka
> > ---
> > configure | 4 ++--
> > libavcodec/aacen
On Thu, Jan 16, 2025 at 11:12 AM Vitaly Buka wrote:
> Signed-off-by: Vitaly Buka
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index 9cfc78b414..6fcbddad3c 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -43,
`POS(1,` and `POS(2,` may trigger UBSAN report:
"runtime error: applying non-zero offset 304 to null pointer"
Looks like values are not used without `chroma_format_idc`,
so maybe there is no other issues than the UB.
Can't reproduce with "fate".
Signed-off-by: Vitaly B
I assume "recover" mode is there unintentionally.
"-fno-sanitize-recover" helps to keep the code clean.
On Thu, Jan 16, 2025 at 11:13 AM Vitaly Buka wrote:
> UBSAN by default is just prints a mesage and
> moves on. This hides a few UBs in fate-suite.
>
UBSAN by default is just prints a mesage and
moves on. This hides a few UBs in fate-suite.
Signed-off-by: Vitaly Buka
---
configure | 4 ++--
libavcodec/aacenc_pred.c | 1 +
libavcodec/ffv1dec.c | 1 +
libavcodec/ffv1enc_template.c | 1 +
libavcodec/get_bits.h
Signed-off-by: Vitaly Buka
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index 9cfc78b414..6fcbddad3c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -43,3 +43,4 @@
/tools/python/__pycache__/
/libavcodec/vulkan/*.c
/libavfilter/vulkan/*.c
+/fate-suite
Also the patch makes this code consistent with mpeg4videodec.c
---
libavcodec/mpeg4videoenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c
index f6a5992df7..2cd5a8c015 100644
--- a/libavcodec/mpeg4videoenc.c
+++ b/l
ping
On Fri, Oct 6, 2017 at 4:20 PM, Vitaly Buka wrote:
> Signed-off-by: Vitaly Buka
> ---
> libavformat/movenc.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 2838286141..e70500ae2c 100644
> --- a/liba
Signed-off-by: Vitaly Buka
---
libavformat/movenc.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 2838286141..e70500ae2c 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -5354,6 +5354,10 @@ static int
What else can I do yo make it accepted?
On Sun, Aug 20, 2017 at 11:56 AM, Vitaly Buka wrote:
> Signed integer overflow is undefined behavior.
> Detected with clang and -fsanitize=signed-integer-overflow
>
> Signed-off-by: Vitaly Buka
> ---
> libavcodec/utils.c| 2
Signed integer overflow is undefined behavior.
Detected with clang and -fsanitize=signed-integer-overflow
Signed-off-by: Vitaly Buka
---
libavcodec/utils.c| 2 +-
libavformat/aviobuf.c | 2 ++
libavformat/mov.c | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a
Signed integer overflow is undefined behavior.
Detected with clang and -fsanitize=signed-integer-overflow
Signed-off-by: Vitaly Buka
---
libavcodec/utils.c| 2 +-
libavformat/aviobuf.c | 2 ++
libavformat/mov.c | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a
Looks like libavcodec/ has more LL or ll than INT64_C.
Should I update the patch?
On Sat, Aug 19, 2017 at 11:35 PM, Hendrik Leppkes
wrote:
> On Sun, Aug 20, 2017 at 3:19 AM, Vitaly Buka
> wrote:
> > Signed integer overflow is undefined behavior.
> > Detected with clang and
Signed integer overflow is undefined behavior.
Detected with clang and -fsanitize=signed-integer-overflow
Signed-off-by: Vitaly Buka
---
libavcodec/utils.c| 2 +-
libavformat/aviobuf.c | 3 +++
libavformat/mov.c | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a
Signed integer overflow is undefined behavior.
Detected with clang and -fsanitize=signed-integer-overflow
Signed-off-by: Vitaly Buka
---
libavcodec/utils.c| 2 +-
libavformat/aviobuf.c | 2 ++
libavformat/mov.c | 2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a
en Hoyos
wrote:
> 2017-08-18 8:14 GMT+02:00 Vitaly Buka >:
> > Signed integer overflow is undefined behavior.
> > Detected with clang and -fsanitize=signed-integer-overflow
>
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -5572,7 +5572,7 @@ st
On Fri, Aug 18, 2017 at 1:11 AM, Tomas Härdin wrote:
> On 2017-08-18 08:14, Vitaly Buka wrote:
>
>> Signed integer overflow is undefined behavior.
>> Detected with clang and -fsanitize=signed-integer-overflow
>>
>> Signed-off-by: Vitaly Buka
>>
Signed integer overflow is undefined behavior.
Detected with clang and -fsanitize=signed-integer-overflow
Signed-off-by: Vitaly Buka
---
libavcodec/utils.c| 2 +-
libavformat/aviobuf.c | 4 +++-
libavformat/mov.c | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a
20 matches
Mail list logo
