Re: [FFmpeg-devel] [PATCH v5 2/2] avformat/riffdec: warn on invalid sample rate

On Wed, Feb 12, 2025 at 5:01 PM Viraaj Raulgaonkar wrote: > > On Mon, Feb 3, 2025 at 9:55 AM Viraaj Raulgaonkar > wrote: > > > > If strict_std_compliance < FF_COMPLIANCE_STRICT, warn the user of the > > invalid sample rate instead of returning an error. In certain

Re: [FFmpeg-devel] [PATCH v5 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

On Mon, Feb 3, 2025 at 9:55 AM Viraaj Raulgaonkar wrote: > > Change the type of logctx from void* to AVFormatContext*. This is in > preparation for the next commit. > --- > libavformat/riff.h| 2 +- > libavformat/riffdec.c | 14 +++--- > 2 files changed, 8 inser

Re: [FFmpeg-devel] [PATCH v5 2/2] avformat/riffdec: warn on invalid sample rate

On Mon, Feb 3, 2025 at 9:55 AM Viraaj Raulgaonkar wrote: > > If strict_std_compliance < FF_COMPLIANCE_STRICT, warn the user of the > invalid sample rate instead of returning an error. In certain cases the > sample rate can get decoded later on. > > Fixes Trac Ticket #11361.

[FFmpeg-devel] [PATCH v5 2/2] avformat/riffdec: warn on invalid sample rate

If strict_std_compliance < FF_COMPLIANCE_STRICT, warn the user of the invalid sample rate instead of returning an error. In certain cases the sample rate can get decoded later on. Fixes Trac Ticket #11361. --- libavformat/riffdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) dif

[FFmpeg-devel] [PATCH v5 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

Change the type of logctx from void* to AVFormatContext*. This is in preparation for the next commit. --- libavformat/riff.h| 2 +- libavformat/riffdec.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/riff.h b/libavformat/riff.h index a93eadfec

Re: [FFmpeg-devel] [PATCH v4 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

On Mon, Feb 3, 2025 at 12:56 AM Andreas Rheinhardt wrote: > > Viraaj Raulgaonkar: > > Change the type of logctx from void* to AVFormatContext*, since all > > calls to ff_get_wav_header() pass an AVFormatContext* anyway. > > This change makes it appear as if it were

[FFmpeg-devel] [PATCH v4 2/2] avformat/riffdec: warn on invalid sample rate

If strict_std_compliance < FF_COMPLIANCE_STRICT, then warn the user of the invalid sample rate instead of returning an error. In certain cases the sample rate can get decoded later on during demux. Fixes Trac Ticket #11361. --- libavformat/riffdec.c | 7 +-- 1 file changed, 5 insertions(+), 2

[FFmpeg-devel] [PATCH v4 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

Change the type of logctx from void* to AVFormatContext*, since all calls to ff_get_wav_header() pass an AVFormatContext* anyway. --- libavformat/riff.h| 2 +- libavformat/riffdec.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/riff.h b/libavf

Re: [FFmpeg-devel] [PATCH v3] avformat/riffdec: warn on invalid sample rate

On Fri, Jan 31, 2025 at 3:33 PM Marton Balint wrote: > > > > On Fri, 31 Jan 2025, Viraaj Raulgaonkar wrote: > > > On Fri, Jan 31, 2025 at 4:49 AM Marton Balint wrote: > >> > >> > >> > >> On Thu, 30 Jan 2025, Viraaj Raulgaonkar wrote: &g

Re: [FFmpeg-devel] [PATCH v3] avformat/riffdec: warn on invalid sample rate

On Fri, Jan 31, 2025 at 4:49 AM Marton Balint wrote: > > > > On Thu, 30 Jan 2025, Viraaj Raulgaonkar wrote: > > > If std_strict_compliance < FF_COMPLIANCE_STRICT, then warn the user of > > the invalid sample rate instead of returning an error. This allows the &g

[FFmpeg-devel] [PATCH v3] avformat/riffdec: warn on invalid sample rate

If std_strict_compliance < FF_COMPLIANCE_STRICT, then warn the user of the invalid sample rate instead of returning an error. This allows the sample rate to be decoded in certain cases. Fixes Trac Ticket #11361. --- libavformat/riffdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-

Re: [FFmpeg-devel] [PATCH v2] avformat/riffdec: warn on invalid sample rate

Hi Marton, On Mon, Jan 27, 2025 at 1:25 AM Marton Balint wrote: > > > > On Sun, 26 Jan 2025, Viraaj Raulgaonkar wrote: > > > Instead of returning an error for invalid sample rates, warn the user > > and set sample_rate to INT_MAX. This allows the sample rate to be &

[FFmpeg-devel] [PATCH v2] avformat/riffdec: warn on invalid sample rate

Instead of returning an error for invalid sample rates, warn the user and set sample_rate to INT_MAX. This allows the sample rate to be decoded in certain cases. Fixes Trac Ticket #11361. --- libavformat/riffdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/riffdec: remove invalid sample rate check

Hi On Sat, Jan 25, 2025 at 6:56 AM Michael Niedermayer wrote: > > On Sat, Jan 25, 2025 at 02:19:52AM +0100, Michael Niedermayer wrote: > > Hi > > > > On Tue, Jan 21, 2025 at 05:30:05PM +0530, Viraaj Raulgaonkar wrote: > > > Sample rates up to 2^31 - 1 are consi

[FFmpeg-devel] [PATCH] avformat/riffdec: remove invalid sample rate check

Sample rates up to 2^31 - 1 are considered valid, while greater values are invalid. Removing the check potentially allows the sample rate to be decoded in all cases instead of halting demux for values greater than 2^31 - 1. Fixes Trac ticket #11361. --- libavformat/riffdec.c | 5 - 1 file ch