[FFmpeg-devel] [PATCH v3] avformat/mov: Add support for demuxing still HEIC images

2023-10-04 Thread Vignesh Venkatasubramanian via ffmpeg-devel
/content/images Also add a couple of fate tests with samples from https://github.com/nokiatech/heif_conformance/tree/master/conformance_files Partially fixes trac ticket #6521. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h| 2 + libavformat/mov.c

[FFmpeg-devel] [PATCH v2] avformat/mov: Add support for demuxing still HEIC images

2023-10-03 Thread Vignesh Venkatasubramanian via ffmpeg-devel
/content/images Partially fixes trac ticket #6521. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 2 ++ libavformat/mov.c | 41 - 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index

[FFmpeg-devel] [PATCH] avformat/mov: Disallow more than one meta box for AVIF

2023-10-03 Thread Vignesh Venkatasubramanian via ffmpeg-devel
This is not allowed per the spec. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 294c864fbd..a8f57f9281 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4892,6 +4892,8

[FFmpeg-devel] [PATCH] avcodec/svt-av1: Set force_key_frames only when gop_size == 1

2023-10-03 Thread Vignesh Venkatasubramanian via ffmpeg-devel
SVT-AV1 does not support requesting keyframes at arbitrary points by setting pic_type to EB_AV1_KEY_PICTURE. So set force_key_frames to 1 only when gop_size == 1. Please see the comments in https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 for a bit more details. Signed-off-by: Vignesh

[FFmpeg-devel] [PATCH] avcodec/svt-av1: Set pic_type only when gop_size == 1

2023-09-27 Thread Vignesh Venkatasubramanian via ffmpeg-devel
cases, setting this has no effect. * Set force_key_frames to 1 only when gop_size == 1, this is needed for pic_type request above to work. Please see the comments in https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 for a bit more details. Signed-off-by: Vignesh Venkatasubramanian

[FFmpeg-devel] [PATCH] avformat/mov: Add support for demuxing still HEIC images

2023-09-26 Thread Vignesh Venkatasubramanian via ffmpeg-devel
/content/images Partially fixes trac ticket #6521. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 2 ++ libavformat/mov.c | 38 +- 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index

[FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

2023-06-26 Thread Vignesh Venkatasubramanian
frames are keyframes. SVT-AV1 Bug: https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 Example command: ffmpeg -f lavfi -i testsrc=duration=1:size=64x64:rate=30 -c:v libsvtav1 -g 1 -y test.webm Before: Only first frame is keyframe. After: All frames are keyframes. Signed-off-by: Vignesh

Re: [FFmpeg-devel] [PATCH 3/5] avformat/mov: Better check for duplicate iloc

2023-04-25 Thread Vignesh Venkatasubramanian
On Mon, Apr 17, 2023 at 4:18 PM Michael Niedermayer wrote: > > On Mon, Apr 17, 2023 at 12:36:26PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-04-17 00:25:16) > > > Fixes: memleak > > > Fixes: > > > 45982/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6674082962997248 >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-13 Thread Vignesh Venkatasubramanian
On Thu, Jan 12, 2023 at 8:40 PM "zhilizhao(赵志立)" wrote: > > > > > On Jan 13, 2023, at 04:45, Vignesh Venkatasubramanian > > wrote: > > > > The HEIF specification permits specifying the looping behavior of > > animated sequences by using the Ed

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-12 Thread Vignesh Venkatasubramanian
produced files. * Chrome is able to play back the produced files. [1] https://github.com/AOMediaCodec/libavif/commit/4d2776a3af53ae1aefdaed463b75ba12fd9cf8c2 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 35 +++ libavformat/movenc.h | 1 + 2

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-12 Thread Vignesh Venkatasubramanian
On Fri, Jan 6, 2023 at 1:45 AM "zhilizhao(赵志立)" wrote: > > > > > On Jan 6, 2023, at 01:34, Vignesh Venkatasubramanian > > wrote: > > > > On Thu, Jan 5, 2023 at 1:45 AM "zhilizhao(赵志立)" > > wrote: > >> > >>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-05 Thread Vignesh Venkatasubramanian
On Thu, Jan 5, 2023 at 1:45 AM "zhilizhao(赵志立)" wrote: > > > > > On Jan 5, 2023, at 06:16, Vignesh Venkatasubramanian > > wrote: > > > > The HEIF specification permits specifying the looping behavior of > > animated sequences by using the EditLi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Add movie_timescale option to AVIF

2023-01-05 Thread Vignesh Venkatasubramanian
On Thu, Jan 5, 2023 at 1:34 AM "zhilizhao(赵志立)" wrote: > > > > > On Jan 5, 2023, at 06:16, Vignesh Venkatasubramanian > > wrote: > > > > Allow specifying the movie_timescale options to AVIF ouptut. > > > > This also makes sure that when mov

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-04 Thread Vignesh Venkatasubramanian
produced files. * Chrome is able to play back the produced files. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 35 +++ libavformat/movenc.h | 1 + 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/libavformat/movenc.c b/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: Add movie_timescale option to AVIF

2023-01-04 Thread Vignesh Venkatasubramanian
movie headers after this change (instead of writing 0). Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7d49892283..36c76f7f60 100644 --- a/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-25 Thread Vignesh Venkatasubramanian
On Tue, Oct 25, 2022 at 11:28 AM James Zern wrote: > > Signed-off-by: James Zern > --- > libavcodec/libaomdec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c > index 378d638a89..53982559d9 100644 > --- a/libavcode

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-20 Thread Vignesh Venkatasubramanian
On Tue, Sep 20, 2022 at 12:38 PM James Zern wrote: > > On Mon, Sep 19, 2022 at 4:03 PM Vignesh Venkatasubramanian > wrote: > > > > According to the HEIF specification Section 7.5.3.1, tracks with > > It might be worth adding ISO/IEC 23008-12 for added precision. >

[FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-20 Thread Vignesh Venkatasubramanian
terize and re-use the existing function. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c8b2e141cb..754f95912a 100644 --- a/libavfor

[FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-19 Thread Vignesh Venkatasubramanian
sting function. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c8b2e141cb..754f95912a 100644 --- a/libavformat/movenc.c +++ b/l

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add -min-gf-interval

2022-09-19 Thread Vignesh Venkatasubramanian
On Tue, Sep 13, 2022 at 5:28 PM James Zern wrote: > > this maps to the vpxenc argument with the same name and the > VP9E_SET_MIN_GF_INTERVAL codec control > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 11 +++ > libavcodec/version.h |

Re: [FFmpeg-devel] [PATCH] avcodec/libvpx: fix assembling vp9 packets with alpha channel

2022-08-23 Thread Vignesh Venkatasubramanian
On Sun, Aug 21, 2022 at 10:21 AM James Almer wrote: > > There's no warranty that vpx_codec_encode() will generate a list with the same > amount of packets for both the yuv planes encoder and the alpha plane encoder, > so queueing packets based on what the main encoder returns will fail when the >

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-28 Thread Vignesh Venkatasubramanian
Stores the item ids of all the items found in the file and processes the primary item at the end of the meta box. This patch does not change any behavior. It sets up the code for parsing alpha channel (and possibly images with 'grid') in follow up patches. Signed-off-b

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-28 Thread Vignesh Venkatasubramanian
On Wed, Jul 27, 2022 at 12:40 PM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > Stores the item ids of all the items found in the file and > > processes the primary item at the end of the meta box. This patch > > does not change any behavior. It sets

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-27 Thread Vignesh Venkatasubramanian
On Tue, Jul 26, 2022 at 12:02 PM James Zern wrote: > > On Fri, Jul 22, 2022 at 11:21 AM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Jul 13, 2022 at 9:12 AM Vignesh Venkatasubramanian > > wrote: > > > > > > On Mon, Jul 11, 2022 at 3:25 PM Ja

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-27 Thread Vignesh Venkatasubramanian
Stores the item ids of all the items found in the file and processes the primary item at the end of the meta box. This patch does not change any behavior. It sets up the code for parsing alpha channel (and possibly images with 'grid') in follow up patches. Signed-off-b

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-22 Thread Vignesh Venkatasubramanian
On Wed, Jul 13, 2022 at 9:12 AM Vignesh Venkatasubramanian wrote: > > On Mon, Jul 11, 2022 at 3:25 PM James Zern > wrote: > > > > On Thu, Jun 30, 2022 at 2:04 PM Vignesh Venkatasubramanian > > wrote: > > > > > > Stores the item ids of all the it

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: Add support for fixed size grid

2022-07-13 Thread Vignesh Venkatasubramanian
On Wed, Jul 13, 2022 at 9:08 AM Paul B Mahol wrote: > > > It is merged already. Oops, sorry about that. Thanks for merging! -- Vignesh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscri

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-13 Thread Vignesh Venkatasubramanian
On Mon, Jul 11, 2022 at 3:25 PM James Zern wrote: > > On Thu, Jun 30, 2022 at 2:04 PM Vignesh Venkatasubramanian > wrote: > > > > Stores the item ids of all the items found in the file and > > processes the primary item at the end of the meta box. This patch > >

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-07-13 Thread Vignesh Venkatasubramanian
Stores the item ids of all the items found in the file and processes the primary item at the end of the meta box. This patch does not change any behavior. It sets up the code for parsing alpha channel (and possibly images with 'grid') in follow up patches. Signed-off-b

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: Add support for fixed size grid

2022-07-13 Thread Vignesh Venkatasubramanian
On Wed, Jun 29, 2022 at 10:15 AM Vignesh Venkatasubramanian wrote: > > On Wed, Jun 29, 2022 at 12:24 AM Paul B Mahol wrote: > > > > > > > > On Wed, Jun 29, 2022 at 9:21 AM Paul B Mahol wrote: > >> > >> > >> > >> On Tu

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-12 Thread Vignesh Venkatasubramanian
On Tue, Jul 5, 2022 at 9:54 AM Anton Khirnov wrote: > > Quoting Vignesh Venkatasubramanian (2022-07-02 23:15:35) > > > As for encoding, not fully sure how it should be integrated, if any > > > encoders actually at this moment do proper alpha coding, or do all API > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-03 Thread Vignesh Venkatasubramanian
On Sun, Jul 3, 2022 at 5:18 AM Jan Ekström wrote: > > On Sun, Jul 3, 2022 at 12:15 AM Vignesh Venkatasubramanian > wrote: > > > > On Sat, Jul 2, 2022 at 12:35 PM Jan Ekström wrote: > > > > > > On Sat, Jul 2, 2022 at 7:32 PM Vignesh Venkatasubramanian >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-02 Thread Vignesh Venkatasubramanian
On Sat, Jul 2, 2022 at 12:35 PM Jan Ekström wrote: > > On Sat, Jul 2, 2022 at 7:32 PM Vignesh Venkatasubramanian > wrote: > > > > On Sat, Jul 2, 2022 at 2:35 AM Anton Khirnov wrote: > > > > > > Quoting Vignesh Venkatasubramanian (2022-06-30 23:04:34) &g

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-07-02 Thread Vignesh Venkatasubramanian
On Sat, Jul 2, 2022 at 2:35 AM Anton Khirnov wrote: > > Quoting Vignesh Venkatasubramanian (2022-06-30 23:04:34) > > Parse the alpha channel for still AVIF images and expose it as a > > separate track. This is the simplest way of supporting AVIF alpha > > channel in a

[FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

2022-06-30 Thread Vignesh Venkatasubramanian
with a single command. For example: ffmpeg -i image_with_alpha.avif -filter_complex alphamerge image_with_alpha.png Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 66 ++ 2 files changed, 67 insertions

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Rework the AVIF parser to handle multiple items

2022-06-30 Thread Vignesh Venkatasubramanian
Stores the item ids of all the items found in the file and processes the primary item at the end of the meta box. This patch does not change any behavior. It sets up the code for parsing alpha channel (and possibly images with 'grid') in follow up patches. Signed-off-b

Re: [FFmpeg-devel] [PATCH] avfilter/xstack: Add support for fixed size grid

2022-06-29 Thread Vignesh Venkatasubramanian
On Wed, Jun 29, 2022 at 12:24 AM Paul B Mahol wrote: > > > > On Wed, Jun 29, 2022 at 9:21 AM Paul B Mahol wrote: >> >> >> >> On Tue, Jun 28, 2022 at 9:01 PM Vignesh Venkatasubramanian >> wrote: >>> >>> Add a short hand parameter

[FFmpeg-devel] [PATCH] avfilter/xstack: Add support for fixed size grid

2022-06-29 Thread Vignesh Venkatasubramanian
instead of specific x/y co-ordinate for each stream. Also updating the filter documentation to explain the new option. Signed-off-by: Vignesh Venkatasubramanian --- doc/filters.texi | 22 ++-- libavfilter/vf_stack.c | 81 +++--- 2 files changed, 88

[FFmpeg-devel] [PATCH] avfilter/xstack: Add support for fixed size grid

2022-06-28 Thread Vignesh Venkatasubramanian
instead of specific x/y co-ordinate for each stream. Also updating the filter documentation to explain the new option. Signed-off-by: Vignesh Venkatasubramanian --- doc/filters.texi | 19 +-- libavfilter/vf_stack.c | 73 -- 2 files changed, 81

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-28 Thread Vignesh Venkatasubramanian
On Tue, Jun 28, 2022 at 11:21 AM James Zern wrote: > > On Mon, Jun 13, 2022 at 9:32 AM Vignesh Venkatasubramanian > wrote: > > > > On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian > > wrote: > > > > > > On T

[FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-28 Thread Vignesh Venkatasubramanian
tests: 1) demuxing of still image with 1 item - this test will pass regardlesss of this patch. 2) demuxing of still image with 2 items - this test will fail without this patch and will pass with patch applied. Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-27 Thread Vignesh Venkatasubramanian
On Mon, Jun 27, 2022 at 9:48 AM James Almer wrote: > > On 6/27/2022 1:43 PM, Vignesh Venkatasubramanian wrote: > > On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian > > wrote: > >> > >> On Mon, Jun 13, 2022 at 10:17 AM James Zern > >> wrote

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-27 Thread Vignesh Venkatasubramanian
On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian wrote: > > On Mon, Jun 13, 2022 at 9:32 AM Vignesh Venkatasubramanian > wrote: > > > > On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian > > wrote: > > > > > > On T

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-27 Thread Vignesh Venkatasubramanian
On Tue, Jun 21, 2022 at 10:12 AM Vignesh Venkatasubramanian wrote: > > On Mon, Jun 13, 2022 at 10:17 AM James Zern > wrote: > > > > On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian > > wrote: > > > > > > AVIF specification allows for alph

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-21 Thread Vignesh Venkatasubramanian
On Mon, Jun 13, 2022 at 9:32 AM Vignesh Venkatasubramanian wrote: > > On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian > wrote: > > > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > > > > > > > > > On 2022-06-08 1

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-21 Thread Vignesh Venkatasubramanian
On Mon, Jun 13, 2022 at 10:17 AM James Zern wrote: > > On Wed, Jun 1, 2022 at 11:06 AM Vignesh Venkatasubramanian > wrote: > > > > AVIF specification allows for alpha channel as an auxiliary item (in > > case of still images) or as an auxiliary track (in case of

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-13 Thread Vignesh Venkatasubramanian
On Fri, Jun 10, 2022 at 10:34 AM Vignesh Venkatasubramanian wrote: > > On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > &

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-13 Thread Vignesh Venkatasubramanian
On Mon, Jun 6, 2022 at 9:29 AM Vignesh Venkatasubramanian wrote: > > On Wed, Jun 1, 2022 at 12:47 PM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Jun 1, 2022 at 11:52 AM xyesbee wrote: > > > > > > Why can it not accept it as one but two distinct

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-10 Thread Vignesh Venkatasubramanian
On Fri, Jun 10, 2022 at 10:33 AM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > Update the still AVIF parser to only read the primary item. With this > > patch, AVIF still images with exif/icc/alpha channel will no longer > > fail to parse. > > >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-10 Thread Vignesh Venkatasubramanian
On Thu, Jun 9, 2022 at 12:50 AM Gyan Doshi wrote: > > > > On 2022-06-08 10:51 pm, Vignesh Venkatasubramanian wrote: > > On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > >> On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > >> wrote: > >>

[FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-10 Thread Vignesh Venkatasubramanian
tests: 1) demuxing of still image with 1 item - this test will pass regardlesss of this patch. 2) demuxing of still image with 2 items - this test will fail without this patch and will pass with patch applied. Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-08 Thread Vignesh Venkatasubramanian
On Thu, Jun 2, 2022 at 1:35 PM James Zern wrote: > > On Wed, Jun 1, 2022 at 1:38 PM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > > > > > > On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian &

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-06 Thread Vignesh Venkatasubramanian
On Wed, Jun 1, 2022 at 12:47 PM Vignesh Venkatasubramanian wrote: > > On Wed, Jun 1, 2022 at 11:52 AM xyesbee wrote: > > > > Why can it not accept it as one but two distinct streams? Why the extra > > hurdle of alphaextract? YUVA pixel format exists though. > > Yes

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-06-01 Thread Vignesh Venkatasubramanian
On Wed, Jun 1, 2022 at 10:30 AM James Zern wrote: > > On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > wrote: > > > > Update the still AVIF parser to only read the primary item. With this > > patch, AVIF still images with exif/icc/alpha channel will

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-01 Thread Vignesh Venkatasubramanian
ally make things any better. If you have a better solution, please let me know and I can update this. > Original Message > On Jun 1, 2022, 11:35 PM, Vignesh Venkatasubramanian wrote: > > > AVIF specification allows for alpha channel as an auxiliary item (in > >

[FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-01 Thread Vignesh Venkatasubramanian
me 2) Firefox (only still AVIF, no animation support) Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 188 +-- libavformat/movenc.h | 4 +- 2 files changed, 130 insertions(+), 62 deletions(-) diff --git a/libavformat/movenc.

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-06-01 Thread Vignesh Venkatasubramanian
On Wed, Jun 1, 2022 at 10:52 AM James Zern wrote: > > On Wed, May 18, 2022 at 2:56 PM Vignesh Venkatasubramanian > wrote: > > > > AVIF specification allows for alpha channel as an auxillary item (in > > auxiliary > Done. > > case of still images) or as an

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-05-31 Thread Vignesh Venkatasubramanian
On Thu, May 19, 2022 at 9:08 AM Vignesh Venkatasubramanian wrote: > > On Wed, May 18, 2022 at 7:36 PM Bang He wrote: > > > > error happened: > > > > ./ffmpeg -i alpha.png -filter_complex [0:v]alphaextract[a] -map 0 -map [a] > > -still-picture 1 avif_with_al

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-31 Thread Vignesh Venkatasubramanian
On Wed, May 18, 2022 at 10:37 AM Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > images. Expose that in the ffmpeg's wrapper. This is especially > useful for encoding still AVIF images. > > Signed-off-by: Vig

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-05-31 Thread Vignesh Venkatasubramanian
On Thu, May 19, 2022 at 9:13 AM Vignesh Venkatasubramanian wrote: > > On Mon, May 16, 2022 at 9:59 AM Vignesh Venkatasubramanian > wrote: > > > > Update the still AVIF parser to only read the primary item. With this > > patch, AVIF still images with exif/icc/alpha chan

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-05-19 Thread Vignesh Venkatasubramanian
On Mon, May 16, 2022 at 9:59 AM Vignesh Venkatasubramanian wrote: > > Update the still AVIF parser to only read the primary item. With this > patch, AVIF still images with exif/icc/alpha channel will no longer > fail to parse. > > For example, this patch enables parsing of

Re: [FFmpeg-devel] [PATCH] avformat/img2: Add support for AVIF mux in image2

2022-05-19 Thread Vignesh Venkatasubramanian
On Thu, May 19, 2022 at 1:55 AM Gyan Doshi wrote: > > > > On 2022-05-19 09:57 am, Gyan Doshi wrote: > > > > > > On 2022-05-18 01:06 am, James Zern wrote: > >> On Mon, May 16, 2022 at 10:40 AM Vignesh Venkatasubramanian > >> wrote: >

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-05-19 Thread Vignesh Venkatasubramanian
l-picture" flag was added in ab05e9a7f2. Please make sure that you are sync'ed past that to pick up that option. > On Thu, May 19, 2022 at 5:56 AM Vignesh Venkatasubramanian < > vigneshv-at-google@ffmpeg.org> wrote: > > > AVIF specification allows for alpha channel

[FFmpeg-devel] [PATCH] avformat/movenc: Support alpha channel for AVIF

2022-05-18 Thread Vignesh Venkatasubramanian
me 2) Firefox (only still AVIF, no animation support) Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 185 +-- libavformat/movenc.h | 4 +- 2 files changed, 128 insertions(+), 61 deletions(-) diff --git a/libavformat/movenc.

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 1 + 1 file changed, 1 insertion(+) diff --

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
On Wed, May 18, 2022 at 10:01 AM James Almer wrote: > > > > On 5/18/2022 1:39 PM, Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > > images. Expose that in the ffmpeg's wrapper. This is especially > > us

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-18 Thread Vignesh Venkatasubramanian
On Wed, May 18, 2022 at 2:29 AM Gyan Doshi wrote: > > > > On 2022-05-17 11:54 pm, Vignesh Venkatasubramanian wrote: > > libaom added an usage=allintra mode for doing better with still > > images. Expose that in the ffmpeg's wrapper. This is especially > > us

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode

2022-05-17 Thread Vignesh Venkatasubramanian
libaom added an usage=allintra mode for doing better with still images. Expose that in the ffmpeg's wrapper. This is especially useful for encoding still AVIF images. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 7 +-- 1 file changed, 5 insertions(+), 2 dele

[FFmpeg-devel] [PATCH] avformat/img2: Add support for AVIF mux in image2

2022-05-16 Thread Vignesh Venkatasubramanian
Add support for AVIF muxing in the image2 muxer. Tested with this example: ffmpeg -lavfi testsrc=duration=1:size=320x320 -g 1 -flags global_header -c:v libaom-av1 -f image2 img-%2d.avif Signed-off-by: Vignesh Venkatasubramanian --- libavformat/img2enc.c | 4 +++- 1 file changed, 3 insertions

[FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-05-16 Thread Vignesh Venkatasubramanian
trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 41 + 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index cf36f04d5b..f05c2d9c28 100644

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-12 Thread Vignesh Venkatasubramanian
(only still images, firefox does not support animated AVIF yet). 3) Verified to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-12 Thread Vignesh Venkatasubramanian
On Thu, May 12, 2022 at 3:27 AM Gyan Doshi wrote: > > > > On 2022-05-11 10:55 pm, Gyan Doshi wrote: > > > > > > On 2022-05-11 10:24 pm, Vignesh Venkatasubramanian wrote: > >> On Wed, May 4, 2022 at 10:15 AM Vignesh Venkatasubramanian > >> wrote:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-11 Thread Vignesh Venkatasubramanian
On Wed, May 4, 2022 at 10:15 AM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specification: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -av

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-05-09 Thread Vignesh Venkatasubramanian
On Mon, May 2, 2022 at 2:39 PM Vignesh Venkatasubramanian wrote: > > On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian > wrote: > > > > Update the still AVIF parser to only read the primary item. With this > > patch, AVIF still images with exif/icc/alpha chan

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-04 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verified to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-04 Thread Vignesh Venkatasubramanian
On Wed, May 4, 2022 at 10:10 AM "zhilizhao(赵志立)" wrote: > > > > > On May 5, 2022, at 12:45 AM, Vignesh Venkatasubramanian > > wrote: > > > >>> > >>> -mov_write_track_udta_tag(pb, mov, st); > >>> +if (trac

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-04 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verified to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-04 Thread Vignesh Venkatasubramanian
On Tue, May 3, 2022 at 7:46 PM "zhilizhao(赵志立)" wrote: > > Thanks for the review! > > > On May 3, 2022, at 5:35 AM, Vignesh Venkatasubramanian > > wrote: > > > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF

Re: [FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-05-02 Thread Vignesh Venkatasubramanian
On Sun, Apr 24, 2022 at 11:35 AM Vignesh Venkatasubramanian wrote: > > Update the still AVIF parser to only read the primary item. With this > patch, AVIF still images with exif/icc/alpha channel will no longer > fail to parse. > > For example, this patch enables parsing of

[FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-05-02 Thread Vignesh Venkatasubramanian
Fixing Trac ticket #7621 [1] https://aomediacodec.github.io/av1-avif Signed-off-by:: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 054903e6e2..0411773bbf 100644 --- a

[FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-05-02 Thread Vignesh Venkatasubramanian
Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c | 7 +-- libavformat/av1.h | 4

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-02 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verified to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-05-02 Thread Vignesh Venkatasubramanian
On Mon, May 2, 2022 at 10:28 AM James Zern wrote: > > On Wed, Apr 13, 2022 at 1:40 PM Vignesh Venkatasubramanian > wrote: > > > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specification: https://aomediacodec.github.io/av1-avif >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-29 Thread Vignesh Venkatasubramanian
On Thu, Apr 21, 2022 at 9:38 AM Vignesh Venkatasubramanian wrote: > > On Wed, Apr 13, 2022 at 2:35 PM Vignesh Venkatasubramanian > wrote: > > > > On Wed, Apr 13, 2022 at 2:04 PM Andreas Rheinhardt > > wrote: > > > > > > Vignesh Venkatasubramanian: &g

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-24 Thread Vignesh Venkatasubramanian
On Thu, Apr 21, 2022 at 9:16 AM Vignesh Venkatasubramanian wrote: > > On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: > > > > > > > > On 2022-04-20 09:54 am, Gyan Doshi wrote: > > > > > > > > > On 2022-04-20 02:49 am, Paul B Mah

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-24 Thread Vignesh Venkatasubramanian
I thought I had already done this. I have sent another patch to do this: http://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295648.html > > Regards, > Gyan > > On 2022-04-23 12:29 am, Vignesh Venkatasubramanian wrote: > > Add support for parsing AVIF still images. This patches supp

[FFmpeg-devel] [PATCH] avformat/mov: Add avif to list of supported extensions

2022-04-24 Thread Vignesh Venkatasubramanian
AVIF still and animations are now supported by the MOV parser. Add the "avif" extension to the list of supported extensions to AVInputFormat. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavform

[FFmpeg-devel] [PATCH] avformat/mov: Only read the primary item for AVIF

2022-04-24 Thread Vignesh Venkatasubramanian
trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 41 + 2 files changed, 22 insertions(+), 20 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index cf36f04d5b..f05c2d9c28 100644

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-22 Thread Vignesh Venkatasubramanian
image.avif image.png Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 141 + 2 files changed, 142 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-22 Thread Vignesh Venkatasubramanian
On Thu, Apr 21, 2022 at 9:18 PM Gyan Doshi wrote: > > > > On 2022-04-21 09:46 pm, Vignesh Venkatasubramanian wrote: > > On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: > >> > >> > >> On 2022-04-20 09:54 am, Gyan Doshi wrote: > >>> > &

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-21 Thread Vignesh Venkatasubramanian
On Wed, Apr 13, 2022 at 2:35 PM Vignesh Venkatasubramanian wrote: > > On Wed, Apr 13, 2022 at 2:04 PM Andreas Rheinhardt > wrote: > > > > Vignesh Venkatasubramanian: > > > On Mon, Mar 21, 2022 at 1:46 PM Andreas Rheinhardt > > > wrote: > > >>

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-21 Thread Vignesh Venkatasubramanian
On Thu, Apr 21, 2022 at 2:08 AM Gyan Doshi wrote: > > > > On 2022-04-20 09:54 am, Gyan Doshi wrote: > > > > > > On 2022-04-20 02:49 am, Paul B Mahol wrote: > >> On Tue, Apr 19, 2022 at 10:57 PM Vignesh Venkatasubramanian < > >> vigneshv-at-googl

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-19 Thread Vignesh Venkatasubramanian
image.avif image.png Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 137 + 2 files changed, 138 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-19 Thread Vignesh Venkatasubramanian
On Tue, Apr 19, 2022 at 1:18 PM Paul B Mahol wrote: > > > > On Mon, Mar 28, 2022 at 9:12 PM Vignesh Venkatasubramanian > wrote: >> >> Add support for parsing AVIF still images. This patches supports >> AVIF still images that have exactly 1 item (i.e.) no alpha

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-04-18 Thread Vignesh Venkatasubramanian
On Mon, Mar 28, 2022 at 12:11 PM Vignesh Venkatasubramanian wrote: > > Add support for parsing AVIF still images. This patches supports > AVIF still images that have exactly 1 item (i.e.) no alpha channel. > Essentially, we will have to parse the "iloc" box and populate >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
On Wed, Apr 13, 2022 at 2:04 PM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > On Mon, Mar 21, 2022 at 1:46 PM Andreas Rheinhardt > > wrote: > >> > >> Vignesh Venkatasubramanian: > >>> Add an AVIF muxer by re-using the existing

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
On Wed, Apr 13, 2022 at 2:01 PM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specification: https://aomediacodec.github.io/av1-avif > > > > Sample usage for still image:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
On Wed, Apr 13, 2022 at 10:22 AM James Zern wrote: > > On Mon, Mar 28, 2022 at 1:49 PM Vignesh Venkatasubramanian > wrote: > > > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-av

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verified to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

  1   2   >