Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Valerii Zapodovnikov
вт, 8 июн. 2021 г., 19:57 Thilo Borgmann : > Am 08.06.21 um 18:52 schrieb Valerii Zapodovnikov: > > Oh, so it worked on patchwork? Strnge, okay then. No need to. > > Please read [1] and [2]. Please keep all old text and do inline-commenting. > > -Thilo > No. &

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Valerii Zapodovnikov
Oh, so it worked on patchwork? Strnge, okay then. No need to. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-06-08 Thread Valerii Zapodovnikov
Plese resend it in new thread but rename it to .txt. thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "u

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-08 Thread Valerii Zapodovnikov
Wait a second. SDL_SetYUVConversionMode does not support 444? You are setting it to mode = SDL_YUV_CONVERSION_AUTOMATIC if it is 444, which I suppose works on just the size of frame? Then this cannot be fixed, I suppose? There is a workround above, as I said. ___

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-08 Thread Valerii Zapodovnikov
BTW, who knows how to show warnings on make job on patchwork? Only if make fate fails you can see it, but not otherwise. Also, md5 warnings, when you are going to fix those?? https://patchwork.ffmpeg.org/project/ffmpeg/patch/CAPUCmECSxQwMtttmRqTC-JtOpcfUB9SVQ8ZPZOHULFL9=2d...@mail.gmail.com/ _

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-08 Thread Valerii Zapodovnikov
вт, 8 июн. 2021 г., 5:28 Michael Bradshaw : > I'll just chime in and say: > > FIXME comments aren't that helpful. It would be more helpful to av_log when > you detect you've hit an unsupported situation. > How should I know what are unsupported situations? I mean sure, sYCC (BT.709 primaries with

Re: [FFmpeg-devel] [PATCH 05/35] avdevice/dshow: set no-seek flags

2021-06-08 Thread Valerii Zapodovnikov
Just resend them (without any -v2). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 05/35] avdevice/dshow: set no-seek flags

2021-06-07 Thread Valerii Zapodovnikov
Actually I do not know how well will this work. Did you ever play any stream? Even if you play it without forcing seeking you are allowed to search forth due to how latency works. That problem with latency was only fixed in CMAF. ONE must to accelerate decoding forward in time to get low latency.

Re: [FFmpeg-devel] [PATCH 24/35] avutil/opt: AVOptionRange gains is_set field.

2021-06-07 Thread Valerii Zapodovnikov
Ah, yes, that is AVColorRange, sorry. :( Haha. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 24/35] avutil/opt: AVOptionRange gains is_set field.

2021-06-07 Thread Valerii Zapodovnikov
Actually it is commonly understood all over the world that limited range is the default when not present. All video in the world except Dolby Vision profile 5 (if using IPTPQc2) is limited range. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH 01/35] avdevice/dshow: implement option to use device video timestamps

2021-06-07 Thread Valerii Zapodovnikov
Who knows what BS code "TODO figure out math. For now just drop them." means? Is PTS of the mentioned there can be even theoretically valid or not? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-07 Thread Valerii Zapodovnikov
Can you merge my mxfdec patch? Thank you. Maybe all my oldest patches too, except XYZ patch to libopenjpeg, that is WIP, since openjpeg did not even merge yet or did a release to support that wrapper option. Listen, it is commonly known that ffplay is broken, Carl agrees. MPV is not broken and is

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-07 Thread Valerii Zapodovnikov
You are **very** wrong. This is YCbCr 101: 420 has all the same colors as 444 does. Just if one pixel is fixated the entagled pixels have less than all possible colors. This is also not corners issues, it is reproducable on one color all over the plane. Again, the workaround is to use ffplay -vf s

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-07 Thread Valerii Zapodovnikov
I cannot clarify it further, the issue is there on trac. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsub

Re: [FFmpeg-devel] [PATCH] fate: fix input arguments for fate-unknown_layout-ac3

2021-06-07 Thread Valerii Zapodovnikov
Do you know what command to use with http://fate-suite.ffmpeg.org/dolby_e/16-11.pcm? I used -ac 6, but I dunno everything else I used was not giving perfect sound (-f s16le -ac 6 was most important to at least get something playable). Sigh. Also I suppose sample rate will not be 48000 since it is

[FFmpeg-devel] [PATCH] fftools/ffplay: 240M matrix is not the same as BT.601

2021-06-07 Thread Valerii Zapodovnikov
Signed-off-by: Valerii Zapodovnikov --- fftools/ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 0be1d90bf9..53bd9362fa 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -963,12 +963,12 @@ static void

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-06-07 Thread Valerii Zapodovnikov
So I am resending still with that comment and a typo fixed to "ffplay". I also found this: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20180501194013.9552-8-one...@gmail.com/ It way be nice to apply that too, but then again my problem is not that.

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-07 Thread Valerii Zapodovnikov
In my case https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210607063205.180031-1-val.zapod...@gmail.com/ v1 failed to apply due to https://github.com/FFmpeg/FFmpeg/commit/575e52272d42f4278c6620f1a999c41425db2094 I suppose in your case it is https://github.com/FFmpeg/FFmpeg/commit/8bcce5673a267

[FFmpeg-devel] [PATCH v2] Revert "avformat/dashenc: Disable writing CODECS tag for HEVC streams"

2021-06-06 Thread Valerii Zapodovnikov
This reverts commit d6d407d2d758b404af0ce6a8ff46bf164db020a1. Hack not needed after a2b1dd0ce301450a47c972745a6b33c4c273aa5d. Will fix #7480 and #8904. This will include e.g. CODECS="hvc1.2.4.L123.B0" into m3u8. Signed-off-by: Valerii Zapodovnikov --- libavformat/dashenc.c | 6 +---

Re: [FFmpeg-devel] [PATCH v2 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-06 Thread Valerii Zapodovnikov
So there are 4 formats two for le and 2 for be? Oogh. Do you know which one is used for dshow? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_ciescope: Handle black as very dark neutral gray

2021-06-06 Thread Valerii Zapodovnikov
вс, 6 июн. 2021 г., 18:35 Michael Niedermayer : > On Sun, Jun 06, 2021 at 04:50:41PM +0300, Valerii Zapodovnikov wrote: > > I am sorry, what??? > > If that is intended as a review comment, please compose > a english sentance which represents what you are trying to convey. >

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -fpsmin to clamp output framerate

2021-06-06 Thread Valerii Zapodovnikov
So did you fix your gmail account? Also, what happened to FATE? Broken? BTW, I just logged in my nvidia account through apple id and that email was marked as spam too, but because of my filter it was not send into spam! Cool :) ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH v2 13/22] lavfi/scale_qsv: add more input / output pixel formats

2021-06-06 Thread Valerii Zapodovnikov
I hope it is the case since there was a problem with Intel P010 in Intel. #8055, comment 1, sample_YUV_intel10bits(P010LE).7z I still do not know what pixel format to force to decode that sample :) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

2021-06-06 Thread Valerii Zapodovnikov
Actually it is not my patch (as should be obvious as From: is not me) and *NO* changes in API/ABI of openjpeg are happening with upsream patch. As for your ABI... There is only one correct way to manipulate openjpeg API, if you did that wrong, it is your problem. Standard thing: "unexpected that u

Re: [FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

2021-06-06 Thread Valerii Zapodovnikov
Did you even read the commit message? You need to apply a patch to openjpeg itself. Sigh. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ.

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_ciescope: Handle black as very dark neutral gray

2021-06-06 Thread Valerii Zapodovnikov
I am sorry, what??? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-06-06 Thread Valerii Zapodovnikov
AVFrame->color_range? But even if I were using full range file (I do not) that would force BT.601 full range matrix (that is JPEG matrix) and I have the opposite here, BT.709 is forced. I suppose the problem can be checked with simple printf of frame->colorspace with that sample that uses BT.601.

[FFmpeg-devel] [PATCH] avcodec/libopenjpeg: Interpret cinema profiles as XYZ

2021-06-05 Thread Valerii Zapodovnikov
From: Rémi Achard Patch should be applied to decode XYZ samples with not native decoder in ffmpeg (-c:v libopenjpeg, not -c:v jpeg2000). jpeg2000 works already. Now, this is AFAIK a patch that should be applied after upstream's patch: https://github.com/uclouvain/openjpeg/pull/1200 Please note th

[FFmpeg-devel] [PATCH v3] lavc/aomdec: Allow RGB decoding

2021-06-05 Thread Valerii Zapodovnikov
: Valerii Zapodovnikov --- libavcodec/libaomdec.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 6e7324a832..156e644263 100644 --- a/libavcodec/libaomdec.c +++ b/libavcodec/libaomdec.c @@ -134,15 +134,27

Re: [FFmpeg-devel] [PATCH v2] lavc/aomdec: Allow RGB decoding

2021-06-05 Thread Valerii Zapodovnikov
Forgot git commit -s, since it is more than 10 lines and not documentation changes it should be required. Sorry, also I will not add Co-authored-by: Carl <> since his patch was too flawed. Like really!? Oogh. ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

[FFmpeg-devel] [PATCH] avformat/mxfdec: fixed jp2k_rsiz and 170M matrix

2021-06-05 Thread Valerii Zapodovnikov
Again. 240M matrix is different from BT.601! And 170M is the same as BT.601. It is primaries that are the same in 240M and 170M, as for jp2k_rsiz see page 17 of ST 422:2019. IT WAS THERE since 2006. This wrong jp2k_rsiz is a copy-paste of header_open_partition_key. --- libavformat/mxf.c| 2 +-

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-06-05 Thread Valerii Zapodovnikov
I am sorry, what? It converts to 420 always? Wow? But you are right. This is a problem that colors are wrong after YUV444 - > YUV420 -> RGB. It selects BT.709 matrix even if BT.601 matrix is requested, this can be fixed by "ffplay -vf scale=in_color_matrix=auto,format=gbrp" or just by using mpv. Ma

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: fixed jp2k_rsiz and 240M matrix

2021-06-05 Thread Valerii Zapodovnikov
Of course it is a PeRfEct copy paste, I should have mentioned that (and I asked Rémi to send the patch about RSIZ for XYZ, BTW). Also what this patch actually fixes is encoding 170M, not 240M. Will fix that too. Also should note that SMPTE ST 422:2019 is now free of charge. Yeah! __

Re: [FFmpeg-devel] [PATCH] lavfi/signature: fix always true expression

2021-06-05 Thread Valerii Zapodovnikov
пн, 24 мая 2021 г., 4:00 Valerii Zapodovnikov : > Otherwise since "==" has higher precedence, mode is never checked. > --- > libavfilter/signature_lookup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/signature_lookup.c > b

[FFmpeg-devel] [PATCH] avformat/mxfdec: fixed jp2k_rsiz and 240M matrix

2021-06-05 Thread Valerii Zapodovnikov
Again. 240M matrix is different from BT.601! And 170M is the same as BT.601. It is primaries that are the same in 240M and 170M, as for jp2k_rsiz see page 10 of S422M-2006. Yes, IT IS THERE. --- libavformat/mxf.c| 2 +- libavformat/mxfdec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: [FFmpeg-devel] [PATCH] avformat/hls Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2021-06-05 Thread Valerii Zapodovnikov
BTW, what about #7359? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-05 Thread Valerii Zapodovnikov
That did work, cool. https://patchwork.ffmpeg.org/project/ffmpeg/patch/capucmebbw-rkt3mw5berkg3cqa+-akryfahclfc36mh2ybn...@mail.gmail.com/ BTW, will have to look into patchwork's patchwork (D:)) whether they fixed .patch extensions. Apparently not. Also everything in "Re:" cannot contain a patch.

[FFmpeg-devel] [PATCH] Revert "avformat/dashenc: Disable writing CODECS tag for HEVC streams"

2021-06-05 Thread Valerii Zapodovnikov
This reverts commit d6d407d2d758b404af0ce6a8ff46bf164db020a1. Hack not needed after a2b1dd0ce301450a47c972745a6b33c4c273aa5d. Will fix #7480 and #8904. This will include e.g. CODECS="hvc1.2.4.L123.B0" into m3u8. Signed-off-by: Valerii Zapodovnikov --- libavformat/dashenc.c | 6 +---

[FFmpeg-devel] [PATCH] avformat/mov.c: trun atom sample should be logged from 0

2021-06-05 Thread Valerii Zapodovnikov
Just like for stss atom. Suggested-By: Nick Ryan --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c088c9f515..1be2783556 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4936,11 +4936,11 @@ static int

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-05 Thread Valerii Zapodovnikov
Nope, still is not seen. Try to send .txt in new thread. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subjec

Re: [FFmpeg-devel] [PATCH] avformat/nut: add support for P010 pixel format

2021-06-05 Thread Valerii Zapodovnikov
GEN=1 is nice, but why diff is no longer working on patchwork itself? See: https://patchwork.ffmpeg.org/check/18368/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH] avformat/nut: add support for P010 pixel format

2021-06-05 Thread Valerii Zapodovnikov
Okay, I will send a patch to just raw.c to check it out, if it will not work I will send against http://lists.mplayerhq.hu/pipermail/nut-devel/2020-December/thread.html Again, who can do FATE hashes for me? Please? ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-05 Thread Valerii Zapodovnikov
Sure, please resend and change status on your old patch as superseeded on patchwork. Sigh. As for maintainer, LGTM from me (interesting, is just saying those 4 latters enough to get patchwork flag of it?). So if you can push while not being the mainteiner, please do it, the coding acceptions here a

Re: [FFmpeg-devel] [PATCH] avformat/hls Implement support for using AVSEEK_FLAG_BACKWARD when seeking

2021-06-05 Thread Valerii Zapodovnikov
You forgot to mention #6850. Also you patch was not seen by patchwork. Please use "git send-email -v2 -1" to send v2 patch. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vis

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-04 Thread Valerii Zapodovnikov
v2 is done by "git send-email -v2 -1" not what you did here. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "u

[FFmpeg-devel] [PATCH v2] lavc/aomdec: Allow RGB decoding

2021-06-04 Thread Valerii Zapodovnikov
Yes, RGB is signalled by Identity matrix if and only if XYZ is not in transfer. XYZ primaires are just normal primaries that can be used for normal RGB, no problem, so I do not check for them. No need to test for sRGB primaries (that is AVCOL_PRI_BT709), as ffplay does not know what that is (is not

Re: [FFmpeg-devel] [PATCH] avfilter/vf_hqdn3d: fix left shift of negative numbers

2021-06-04 Thread Valerii Zapodovnikov
пн, 24 мая 2021 г., 6:42 Valerii Zapodovnikov : > --- > libavfilter/vf_hqdn3d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c > index 8d71ae316d..bd3eb2d01c 100644 > --- a/libavfilter/vf_hqdn3d.

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-04 Thread Valerii Zapodovnikov
Yeah, 0 to 3, but this is 4. We are counting from 0, not from 1. So that would be some kind of fifth profile. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or emai

Re: [FFmpeg-devel] [PATCH] avdevice/avdevice: Deprecate AVDevice Capabilities API

2021-06-04 Thread Valerii Zapodovnikov
You may want to wait for at least some review and then of course, Andreas, for example, sometimes sends 200 patch series. https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201203003628.778278-6-andreas.rheinha...@gmail.com/ ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH v2] avformat/avio: fixed AVSEEK_FORCE and documentation

2021-06-03 Thread Valerii Zapodovnikov
Always true expression: we would have returned on line 265, if whence were SEEK_END we would've already returned. Because of short circuiting force will never be checked. Was broken since 7a6fe01f99cb95797ba59134f44bb1a5e792. That is 11 years! Also fixed other commit that did confuse ORing / pa

Re: [FFmpeg-devel] [PATCH] ffmpeg: add -fpsmin to clamp output framerate

2021-06-03 Thread Valerii Zapodovnikov
It is not going to work. His email is marked as spam here in gmail for android, so it looks like it is globally banned in google and because you clever guys use gmail for patchwork, i.e. ffmpegpatchwo...@gmail.com but you did not set to send all spam into main folder, like I always do, see https://

Re: [FFmpeg-devel] libavcodec: r12b decoder

2021-06-03 Thread Valerii Zapodovnikov
You patch did not apply on patchwork and thus did not make fate tests. Please use .txt extension on the patch (BTW, what a joke) or use git send-email. It is also very funny that gmail for android recognises patch as video. Wht? ___ ffmpeg-devel maili

Re: [FFmpeg-devel] [PATCH] avformat/nut: add support for P010 pixel format

2021-06-03 Thread Valerii Zapodovnikov
The bigger problem are FATE hashes. I am not able to fill them here. As to send patches against another repo, I can do that, no problem with --subject-prefix="PATCH nut". Also, I do not see a problem with the spec, the spec says that it has priority, not the code. I am not doing this patch for nut

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-02 Thread Valerii Zapodovnikov
HDR10+ test bitstream https://www.webmproject.org/vp9/levels/ BTW, who knows what is Profile 4 VP9 (i.e. VP9.4)? https://stackoverflow.com/questions/61413665 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/nut: add support for P010 pixel format

2021-06-02 Thread Valerii Zapodovnikov
I don't really care about your nut container, FATE just complains that something in raw.c is not in nut.c. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

[FFmpeg-devel] [PATCH v2] avcodec/dpxenc: stop hardcoding color trc/primaries

2021-06-01 Thread Valerii Zapodovnikov
Updated FATE hashes and added gamma 2.8. Also please note that FATE samples are useless. I also fixed gamma 2.2 to System M. Also this does not do YCbCr stuff, so no matrices are here. Fixes more or less #6023, except for printing density stuff. Co-authored-by: Paul B Mahol --- libavcodec/dpxenc

[FFmpeg-devel] [PATCH] avformat/nut: add support for P010 pixel format

2021-05-31 Thread Valerii Zapodovnikov
This is used for dshow, though may be swapped endianness there. Fixes #8454. fate-pixdesc-p010le and be will have to be updated. --- libavcodec/raw.c | 3 +++ libavformat/nut.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/libavcodec/raw.c b/libavcodec/raw.c index 079d5c5d10..7efc0156ca

[FFmpeg-devel] [PATCH] avcodec/audiotoolboxdec: Fix decoding 24 Bit ALAC

2021-05-31 Thread Valerii Zapodovnikov
"avctx->bits_per_raw_sample" always returns 0. Tested with 24 Bit ALAC. The result is bit-perfect. Fix #7287. Co-authored-by: Davis --- libavcodec/audiotoolboxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c ind

[FFmpeg-devel] [PATCH] avcodec/audiotoolboxdec: Fix decoding 24 Bit ALAC "avctx->bits_per_raw_sample" always returns 0. Tested with 24 Bit ALAC. The result is bit-perfect. Fix #7287.

2021-05-31 Thread Valerii Zapodovnikov
Co-authored-by: Davis --- libavcodec/audiotoolboxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index cbd381ef12..c7e1760645 100644 --- a/libavcodec/audiotoolboxdec.c +++ b/libavcodec/audiotoolboxdec.c @@ -303,

[FFmpeg-devel] [PATCH v3] pixfmt: fixed wrong fix of comment

2021-05-31 Thread Valerii Zapodovnikov
This mostly reverts 785bfb1d7bb8de567c3aac1d9cc369b55ac9fb7b. But I also added some clarifications so that nobody mixes primaries with matrix again. SMPTE 240 and 170 primaires are the same, while matrix coeff. are different, because 240 is derived from 170's new primaries and white point while 170

[FFmpeg-devel] [PATCH v2] pixfmt: fixed wrong fix of comment

2021-05-31 Thread Valerii Zapodovnikov
This mostly reverts 785bfb1d7bb8de567c3aac1d9cc369b55ac9fb7b. But I also added some clarifications so that nobody mixes primaries with matrix again. SMPTE 240 and 170 primaires are the same, while matrix coeff. are different, because 240 is derived from 170's new primaries and white point while 170

[FFmpeg-devel] [PATCH 2/2] fftools/ffprobe: 240M matrix is not the same as BT.601

2021-05-25 Thread Valerii Zapodovnikov
--- fftools/ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 0be1d90bf9..53bd9362fa 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -963,12 +963,12 @@ static void set_sdl_yuv_conversion_mode(AVFrame *frame) if

[FFmpeg-devel] [PATCH 1/2] pixfmt: fixed wrong fix of comment

2021-05-25 Thread Valerii Zapodovnikov
This mostly reverts 785bfb1d7bb8de567c3aac1d9cc369b55ac9fb7b. But I also added some clarifications so that nobody mixes primaries with matrix again. SMPTE 240 and 170 primaires are the same, while matrix coeff. are different, because 240 is derived from 170's new primaries and white point while 170

[FFmpeg-devel] [PATCH v2] avcodec/j2kenc: fixed help for jpeg2000 dwt53

2021-05-24 Thread Valerii Zapodovnikov
Now with cosmetics and two new defines. --- libavcodec/j2kenc.c | 16 libavcodec/jpeg2000.h | 4 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c index 82ad3284b5..4d5022db26 100644 --- a/libavcodec/j2kenc.c +++ b/li

[FFmpeg-devel] [PATCH] avformat/avio: fixed AVSEEK_FORCE and documentation

2021-05-23 Thread Valerii Zapodovnikov
Always true expression: we would have returned on line 265. Because of short curcuiting force will never be checked. --- libavformat/avio.h| 1 - libavformat/aviobuf.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index d022820a6

[FFmpeg-devel] [PATCH] avfilter/vf_hqdn3d: fix left shift of negative numbers

2021-05-23 Thread Valerii Zapodovnikov
--- libavfilter/vf_hqdn3d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_hqdn3d.c b/libavfilter/vf_hqdn3d.c index 8d71ae316d..bd3eb2d01c 100644 --- a/libavfilter/vf_hqdn3d.c +++ b/libavfilter/vf_hqdn3d.c @@ -179,7 +179,7 @@ static void precalc_coefs(double dis

[FFmpeg-devel] [PATCH] avfilter/src_movie: fix always true expression

2021-05-23 Thread Valerii Zapodovnikov
Introduced in c1f9734f977f59bc0034096afbe8e43e40d93a5d. We are in if (movie->seek_point > 0) but seek_point is timestamp. --- libavfilter/src_movie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index 54f6738f9a..105d1b7b54 1

[FFmpeg-devel] [PATCH] lavfi/signature: fix always true expression

2021-05-23 Thread Valerii Zapodovnikov
Otherwise since "==" has higher precedence, mode is never checked. --- libavfilter/signature_lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index 272c717c77..85e879d224 100644 --- a/libavfilter/signature_

[FFmpeg-devel] [PATCH] lavfi/signature: fix always true expression

2021-05-23 Thread Valerii Zapodovnikov
Otherwise since "==" has higher precedence, mode is never checked. --- libavfilter/signature_lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index 272c717c77..85e879d224 100644 --- a/libavfilter/signature_

[FFmpeg-devel] [PATCH] libavformat/hlsenc: typos in comments

2021-05-19 Thread Valerii Zapodovnikov
--- libavformat/hlsenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 5db7a744b4..151ef6ec8f 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -178,7 +178,7 @@ typedef struct VariantStream { unsigned in

[FFmpeg-devel] [PATCH] avcodec/j2kenc: fixed help for jpeg2000 dwt53

2021-05-19 Thread Valerii Zapodovnikov
--- libavcodec/j2kenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/j2kenc.c b/libavcodec/j2kenc.c index 82ad3284b5..0b27f9adf5 100644 --- a/libavcodec/j2kenc.c +++ b/libavcodec/j2kenc.c @@ -1813,7 +1813,7 @@ static const AVOption options[] = { { "tile_heigh

[FFmpeg-devel] [PATCH 2/2] libavcodec/dpxenc: change transfer/primaries to BT.709

2021-05-19 Thread Valerii Zapodovnikov
--- libavcodec/dpxenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/dpxenc.c b/libavcodec/dpxenc.c index fa8b7d5ddc..db5ed4e328 100644 --- a/libavcodec/dpxenc.c +++ b/libavcodec/dpxenc.c @@ -219,8 +219,8 @@ static int encode_frame(AVCodecContext *avctx, AVPac

[FFmpeg-devel] [PATCH 1/2] avformat/pmpdec: AAC has been supported for a long time

2021-05-19 Thread Valerii Zapodovnikov
--- libavformat/pmpdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/pmpdec.c b/libavformat/pmpdec.c index ce8e89515a..a327f7f6de 100644 --- a/libavformat/pmpdec.c +++ b/libavformat/pmpdec.c @@ -82,7 +82,6 @@ static int pmp_header(AVFormatContext *s) audio_codec_id = AV