Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2019-01-25 Thread Uwe Freese
blocking it? Please let me know, or please find some time to submit the patch to the repo (which I can't do). As already written, I'd continue with the discussed indentation patch right after that. Regards, Uwe Am 10.01.19 um 20:52 schrieb Uwe Freese: Hello, just a kind reminder. - What i

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2019-01-10 Thread Uwe Freese
Hello, just a kind reminder. - What is the next step, is there anything more I should improve, check, modify,...? For me, the filter works as intended. @Nicolas: Can you answer my remaining three questions below, please? Regards, Uwe Am 02.01.19 um 23:34 schrieb Uwe Freese: Hello, Here&#

[FFmpeg-devel] logo detection

2019-01-03 Thread Uwe Freese
Hello, By the way, you would not be interested in developing a logo-detection filter, per chance? Something that detects is a certain rectangle is likely to contain a logo and computes its bounding box. Currently, I don't need it so much, but nonetheless I though a bit about it: 1) Is there

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2019-01-02 Thread Uwe Freese
to simplify finding the right @var{x}, @var{y}, @var{w}, and @var{h} parameters. diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 065d093641..f489c6a586 100644 --- a/libavfilter/vf_delogo.c +++ b/libavfilter/vf_delogo.c @@ -2,6 +2,7 @@ * Copyright (c) 2002 Jindrich Makovicka *

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2019-01-02 Thread Uwe Freese
Hi, just an info: code didn't compile, don't know why I didn't see this... New patch is in work... Regards, Uwe Am 01.01.19 um 22:14 schrieb Uwe Freese: Hello, here's a new version of the patch. Thanks for the infos. I used the raw output of a small test video (where

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2019-01-01 Thread Uwe Freese
ogo.c b/libavfilter/vf_delogo.c index 065d093641..45f2f9cd3f 100644 --- a/libavfilter/vf_delogo.c +++ b/libavfilter/vf_delogo.c @@ -2,6 +2,7 @@ * Copyright (c) 2002 Jindrich Makovicka * Copyright (c) 2011 Stefano Sabatini * Copyright (c) 2013, 2015 Jean Delvare + * Copyright (c) 2018, 2019

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-29 Thread Uwe Freese
be glad about comments and reviews. - Let me know what should be changed and I'll create a new patch in some days. Regards, Uwe Am 28.12.18 um 00:08 schrieb Carl Eugen Hoyos: 2018-12-27 22:02 GMT+01:00, Uwe Freese : Am 27.12.18 um 20:25 schrieb Carl Eugen Hoyos: I have now added

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-27 Thread Uwe Freese
Hello, Am 27.12.18 um 20:25 schrieb Carl Eugen Hoyos: I have now added as error handling: av_log(inlink->src, AV_LOG_ERROR, "More planes in frame than expected.\n"); return AVERROR(ENOMEM); Is this ok, or how should this be implemented instead? Not sure I understand: How can plane get >= MA

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-27 Thread Uwe Freese
; return AVERROR(ENOMEM); Is this ok, or how should this be implemented instead? + * Copyright (c) 2019 Uwe Freese Considering you authored it in 2018, this is forward-looking. ;-) I thought it would take some days to review and when the code is integrated finally, it is already 2019. Sh

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Uwe Freese
Hello, attached you can find a new patch, with no trailing spaces and avoiding additional indentation in existing code. Regards, Uwe Am 26.12.18 um 16:48 schrieb Uwe Freese: Hello, so now I've taken the time to integrate the alternative interpolation algorithm 'uglarm'

Re: [FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Uwe Freese
Hello, so now I've taken the time to integrate the alternative interpolation algorithm 'uglarm' into the delogo filter. Please do not re-indent existing code in this patch as this makes reviewing the changes more difficult Parts of the previous code are now in an "if" statement block (functi

[FFmpeg-devel] [PATCH] delogo filter: new "uglarm" interpolation mode added

2018-12-26 Thread Uwe Freese
changed, 247 insertions(+), 83 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index 065d093641..12b4c5d2df 100644 --- a/libavfilter/vf_delogo.c +++ b/libavfilter/vf_delogo.c @@ -2,6 +2,7 @@ * Copyright (c) 2002 Jindrich Makovicka * Copyright (c) 2011 Stef

Re: [FFmpeg-devel] Add alternative delogo algorithm for my donation

2018-12-12 Thread uwe . freese
Hello Kyle, You should also try vf_removelogo. It is supposedly better than the more simple vf_delogo. I tried (with a box in a PNG mask as logo cover). That is no alternative both quality wise and from usability point of view: 1. It gave me blurry borders with several pixels widths from outs

[FFmpeg-devel] Add alternative delogo algorithm for my donation

2018-12-11 Thread uwe . freese
Hello, I would like that the delogo filter is improved by an alternative way of removing the logo. It's the "UGLARM" mode known from Virtual Dub's DeLogo filter and ffdshow. I used it many years (under Windows), but now moving to Linux miss it using ffmpeg as encoding tool. Since an ffmpeg d