Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-10-02 Thread Urvang Joshi
Hi, Max value for both the tile rows and tile columns is 64 (so the max log2 value would be 6). This is consistent in the public header: https://aomedia.googlesource.com/aom/+/master/aom/aomcx.h#291 and spec: https://aomediacodec.github.io/av1-spec/av1-spec.pdf (see page 7). On Fri, Aug 31, 2018

[FFmpeg-devel] Issue with native WebP muxer in ffmpeg

2015-10-01 Thread Urvang Joshi
Hi ffmpeg folks, This is based on a report on WebP issue tracker: https://code.google.com/p/webp/issues/detail?id=266 Looks like ffmpeg's native WebP muxer always sets ALPHA_FLAG to be true in VP8X chunk: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/webpenc.c#L110 (Even for a completel

Re: [FFmpeg-devel] [PATCH] WebP native muxer bugfix: frames should have alpha blending off

2015-06-25 Thread Urvang Joshi
On Thu, May 28, 2015 at 8:30 PM Michael Niedermayer wrote: > On Thu, May 28, 2015 at 05:52:35PM +0000, Urvang Joshi wrote: > > On Wed, May 27, 2015 at 5:33 PM Michael Niedermayer > > wrote: > > > > > On Wed, May 27, 2015 at 03:10:05PM -0700, Urvang Joshi wrote: &

[FFmpeg-devel] [PATCH] WebP native muxer bugfix: frames should have alpha blending off

2015-05-27 Thread Urvang Joshi
All the frames that the native muxer gets are fully reconstructed frames, and they should not be alpha-blended with the previous frames. As per the WebP container spec https://developers.google.com/speed/webp/docs/riff_container#animation, ANMF chunk should specify blending method = do not blend (

Re: [FFmpeg-devel] WebP muxer: support packet containing animated WebP

2015-05-20 Thread Urvang Joshi
On Wed, May 20, 2015 at 12:39 PM Michael Niedermayer wrote: > On Wed, May 20, 2015 at 01:56:17AM +0000, Urvang Joshi wrote: > > This is 1st out of 3 patches. > > Attached. > > > webpenc.c | 63 > +- > &g

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
On Thu, Apr 16, 2015 at 3:09 PM James Almer wrote: > On 16/04/15 4:18 PM, Urvang Joshi wrote: > > Hi, > > Here's the patch without whitespace changes. > > > > Thanks, > > Urvang > > This patch doesn't apply cleanly. Looks like something wei

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hi, Here's the patch without whitespace changes. Thanks, Urvang On Thu, Apr 16, 2015 at 11:50 AM Urvang Joshi wrote: > Hi Michael, > Sorry for my misunderstanding earlier. > I was told offline that the usual practice in FFmpeg is to land the > non-whitespace diff first, follo

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Joshi wrote: > Hello Michael, > > On Thu, Apr 16, 2015 at 5:26 AM Michael Niedermayer > wrote: > >> On Thu, Apr 16, 2015 at 12:28:22AM +, Urvang Joshi wrote: >> > Hi, >> > Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you sug

Re: [FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP

2015-04-16 Thread Urvang Joshi
Hello Michael, On Thu, Apr 16, 2015 at 5:26 AM Michael Niedermayer wrote: > On Thu, Apr 16, 2015 at 12:28:22AM +0000, Urvang Joshi wrote: > > Hi, > > Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I > > also updated the patch to wor