Re: [FFmpeg-devel] avformat/lrcdec: fix losing opening bracket

2018-07-18 Thread Umair Khan
On Sat, Jul 14, 2018 at 8:37 PM Michael Niedermayer wrote: > > On Fri, Jul 13, 2018 at 01:34:47PM +0530, Umair Khan wrote: > > On Wed, Jul 11, 2018 at 11:07 PM Michael Niedermayer > > wrote: > > > > > > On Tue, Jul 10, 2018 at 08:10:00PM +0530, Umair Khan wrot

Re: [FFmpeg-devel] avformat/lrcdec: fix losing opening bracket

2018-07-13 Thread Umair Khan
On Wed, Jul 11, 2018 at 11:07 PM Michael Niedermayer wrote: > > On Tue, Jul 10, 2018 at 08:10:00PM +0530, Umair Khan wrote: > > Hi, > > > > Patch attached. > > > > -Umair > > > lrcdec.c |3 +++ > > 1 file changed, 3 insertions(+) >

[FFmpeg-devel] avformat/lrcdec: fix losing opening bracket

2018-07-10 Thread Umair Khan
Hi, Patch attached. -Umair 0001-avformat-lrcdec-fix-losing-opening-bracket.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] ALS encoder

2018-03-06 Thread Umair Khan
On Tue, Mar 6, 2018 at 8:14 PM, Paul B Mahol wrote: > On 3/5/18, Oleg Khokhlov wrote: >> Hi all. >> >> I am student and my name is Oleg. I work on qualification task for GSoC >> 2018. >> I should implement float-point support to als encoder. > > Isn't that a little too much for qualification task

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-14 Thread Umair Khan
Hi, On Wed, Nov 15, 2017 at 4:20 AM, Carl Eugen Hoyos wrote: > 2017-11-14 23:48 GMT+01:00 Carl Eugen Hoyos : >> 2017-11-13 21:07 GMT+01:00 Thilo Borgmann : >>> Am 13.11.17 um 21:06 schrieb Thilo Borgmann: >>>> Am 13.11.17 um 20:02 schrieb Umair Khan: >>>>

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Umair Khan
Hi, On Tue, Nov 14, 2017 at 4:05 AM, Carl Eugen Hoyos wrote: > 2017-11-13 6:41 GMT+01:00 Umair Khan : >> Hi, >> >> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >>> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>>> Hi, >>>> &

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-13 Thread Umair Khan
Hi, On Mon, Nov 13, 2017 at 11:06 PM, Thilo Borgmann wrote: > Hi, > >> On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: >>> 2017-11-12 20:30 GMT+01:00 Umair Khan : >>>> Hi, >>>> >>>> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen H

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Umair Khan
Hi, On Mon, Nov 13, 2017 at 1:09 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:30 GMT+01:00 Umair Khan : >> Hi, >> >> On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos >> wrote: >>> 2017-11-12 20:05 GMT+01:00 Umair Khan : >>> >>>

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Umair Khan
Hi, On Mon, Nov 13, 2017 at 12:45 AM, Carl Eugen Hoyos wrote: > 2017-11-12 20:05 GMT+01:00 Umair Khan : > >> The attached patch fixes the address sanitizer issue. > > Breaks compilation here, how did you test? > > libavcodec/alsdec.c: In function ‘decode_var_block_data

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-12 Thread Umair Khan
Hi, On Sat, Nov 4, 2017 at 3:11 AM, Thilo Borgmann wrote: > Am 03.11.17 um 21:13 schrieb Paul B Mahol: >> On 11/3/17, Thilo Borgmann wrote: >>> Am 02.11.17 um 21:32 schrieb Umair Khan: >>>> Hi, >>>> >>>> On Fri, Oct 20, 2017 at

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-11-02 Thread Umair Khan
Hi, On Fri, Oct 20, 2017 at 1:44 AM, Ronald S. Bultje wrote: > > Hi, > > On Thu, Oct 19, 2017 at 4:03 PM, Umair Khan wrote: > > > I tried decoding the file in both the cases and I don't see any > > address related error in the console while decoding. Following

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-19 Thread Umair Khan
Hi Ronald, On Sun, Oct 15, 2017 at 12:21 AM, Ronald S. Bultje wrote: > Hi Umair, > > On Sat, Oct 14, 2017 at 1:43 PM, Umair Khan wrote: > >> On Sat, Oct 14, 2017 at 8:02 PM, Ronald S. Bultje >> wrote: >> > Hi Umair, >> > >> > On Sat, Oct 1

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Umair Khan
On Sat, Oct 14, 2017 at 8:02 PM, Ronald S. Bultje wrote: > Hi Umair, > > On Sat, Oct 14, 2017 at 9:59 AM, Umair Khan wrote: > >> I tested the file which Michael sent. The thing is that I'm getting >> error in decoding that file in both the cases, with or witho

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Umair Khan
On Sat, Oct 14, 2017 at 7:29 PM, Umair Khan wrote: > Hi, > > On Sat, Sep 23, 2017 at 8:45 PM, Michael Niedermayer > wrote: >> >> On Fri, Sep 22, 2017 at 01:54:27PM +0530, Umair Khan wrote: >> > On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: >> > &

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-10-14 Thread Umair Khan
Hi, On Sat, Sep 23, 2017 at 8:45 PM, Michael Niedermayer wrote: > > On Fri, Sep 22, 2017 at 01:54:27PM +0530, Umair Khan wrote: > > On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: > > > On 9/21/17, Umair Khan wrote: > > >> Hi Ronald, > > >> &g

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-22 Thread Umair Khan
On Thu, Sep 21, 2017 at 6:30 PM, Paul B Mahol wrote: > On 9/21/17, Umair Khan wrote: >> Hi Ronald, >> >> On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje >> wrote: >>> Hi Umair, >>> >>> On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: &

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-21 Thread Umair Khan
Hi Ronald, On Mon, Sep 11, 2017 at 10:27 PM, Ronald S. Bultje wrote: > Hi Umair, > > On Mon, Sep 11, 2017 at 4:06 AM, Umair Khan wrote: > >> On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: >> > On 9/10/17, Umair Khan wrote: >> >> On Sun,

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-11 Thread Umair Khan
On Sun, Sep 10, 2017 at 10:30 PM, Paul B Mahol wrote: > On 9/10/17, Umair Khan wrote: >> On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann >> wrote: >>> >>> Hi, >>> >>> > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297

Re: [FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-10 Thread Umair Khan
On Sun, Sep 10, 2017 at 9:52 PM, Thilo Borgmann wrote: > > Hi, > > > This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 > > this is yet another iteration of > > http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/213005.html I see. I was keepnig reference codec as the source of truth.

[FFmpeg-devel] libavcodec/als: remove check for predictor order of a block

2017-09-10 Thread Umair Khan
Hi, This patch fixes this bug - https://trac.ffmpeg.org/ticket/5297 I suggest removing the check because opt_order can be larger than block_length for the last frames. I checked this in reference codec as well. opt_order is larger than block_length for last 2 frames. Hence, I don't think there's

Re: [FFmpeg-devel] GSoC 2017

2017-01-31 Thread Umair Khan
On Mon, Jan 30, 2017 at 11:44 PM, Thilo Borgmann wrote: > Am 30.01.17 um 18:41 schrieb Umair Khan: >> On Wed, Jan 25, 2017 at 5:45 PM, Thilo Borgmann >> wrote: >>> Am 25.01.17 um 06:14 schrieb Umair Khan: >>>> On Wed, Jan 25, 2017 at 7:45 AM, Michael Niederma

Re: [FFmpeg-devel] GSoC 2017

2017-01-30 Thread Umair Khan
On Wed, Jan 25, 2017 at 5:45 PM, Thilo Borgmann wrote: > Am 25.01.17 um 06:14 schrieb Umair Khan: >> On Wed, Jan 25, 2017 at 7:45 AM, Michael Niedermayer >> wrote: >>> >>> On Mon, Jan 23, 2017 at 03:39:09PM +0100, Michael Niedermayer wrote: >>&

Re: [FFmpeg-devel] GSoC 2017

2017-01-24 Thread Umair Khan
On Wed, Jan 25, 2017 at 7:45 AM, Michael Niedermayer wrote: > > On Mon, Jan 23, 2017 at 03:39:09PM +0100, Michael Niedermayer wrote: > > Hi all > > > > GSoC 2017 mentor org registration has opened a few days ago > > > > Our current ideas page lists just a single mentor and single sugestion > > htt

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-10-03 Thread Umair Khan
Okay!! I'm on it. I should be able to fix it. - Umair >> On Mon, Sep 12, 2016 at 12:53 PM, Umair Khan wrote: >> >>> Hi, >>> >>> Sorry for late reply. I was travelling a bit. >>> Attached is the patch which includes the following changes than

Re: [FFmpeg-devel] [PATCH] fate/als: add floating point decoding test

2016-09-12 Thread Umair Khan
On Thu, Sep 8, 2016 at 10:24 PM, Michael Niedermayer wrote: > On Sun, Jul 17, 2016 at 07:25:31PM +0530, Umair Khan wrote: >> On Sun, Jul 17, 2016 at 1:50 PM, Thilo Borgmann >> wrote: >> > Hi, >> > >> >> From e172e333807b4b3b2558a1ffa735ade79a3f3e

[FFmpeg-devel] MAINTAINERS: Add myself for alsdec

2016-08-29 Thread Umair Khan
Hi, Patch attached. - Umair 0001-MAINTAINERS-Add-myself-for-alsdec.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-29 Thread Umair Khan
Hi, On Sun, Aug 28, 2016 at 4:26 PM, Michael Niedermayer wrote: > On Sun, Aug 28, 2016 at 01:34:46PM +0530, Umair Khan wrote: >> Hi, >> >> Patches attached. :) >> >> - Umair > >> Changelog |1 + >> 1 file changed, 1 insertion(+) >&

Re: [FFmpeg-devel] [GSoC] avcodec/als: Add ALS encoder

2016-08-28 Thread Umair Khan
On Sun, Aug 28, 2016 at 1:56 PM, Paul B Mahol wrote: > Hi, > > On Sun, Aug 28, 2016 at 10:04 AM, Umair Khan wrote: > >> Hi, >> >> Patches attached. :) > > > Inline asm is unacceptable to get into master. How sho

Re: [FFmpeg-devel] avformat/movenc: allow rewriting extradata

2016-08-19 Thread Umair Khan
Hi, On Fri, Aug 19, 2016 at 4:46 AM, Michael Niedermayer wrote: > On Thu, Aug 18, 2016 at 11:21:00AM +0530, Umair Khan wrote: >> Hi, >> >> On Thu, Aug 18, 2016 at 2:10 AM, Umair Khan wrote: >> > On Thu, Aug 18, 2016 at 1:28 AM, James Almer wrote: >> >&

Re: [FFmpeg-devel] Outreachy 2016 december

2016-08-18 Thread Umair Khan
On Wed, Aug 17, 2016 at 9:54 PM, Michael Niedermayer wrote: > On Wed, Aug 17, 2016 at 09:16:16PM +0530, Umair Khan wrote: >> Hi, >> >> On Wed, Aug 17, 2016 at 5:33 PM, Michael Niedermayer >> wrote: >> > On Fri, Jul 22, 2016 at 07:18:13PM +0200, Michael Nie

Re: [FFmpeg-devel] avformat/movenc: allow rewriting extradata

2016-08-18 Thread Umair Khan
Hi, On Thu, Aug 18, 2016 at 2:10 AM, Umair Khan wrote: > On Thu, Aug 18, 2016 at 1:28 AM, James Almer wrote: >> On 8/17/2016 3:59 PM, Umair Khan wrote: >>> Hi, >>> >>> Patch attached. >>> >>> I hope this is the cleanest solution. :) &

Re: [FFmpeg-devel] avformat/movenc: allow rewriting extradata

2016-08-17 Thread Umair Khan
On Thu, Aug 18, 2016 at 1:28 AM, James Almer wrote: > On 8/17/2016 3:59 PM, Umair Khan wrote: >> Hi, >> >> Patch attached. >> >> I hope this is the cleanest solution. :) >> >> - Umair >> >> >> patch.diff >> >> >&g

Re: [FFmpeg-devel] [PATCH] ffmpeg: Update muxer extradata after flushing encoders

2016-08-17 Thread Umair Khan
Hi, On Wed, Aug 17, 2016 at 10:44 PM, Umair Khan wrote: > Hi, > > On Wed, Aug 17, 2016 at 3:43 PM, Paul B Mahol wrote: >> On 8/17/16, Michael Niedermayer wrote: >>> This is needed for encoders which store a final sample count or checksum in >>> extradata >&

[FFmpeg-devel] avformat/movenc: allow rewriting extradata

2016-08-17 Thread Umair Khan
Hi, Patch attached. I hope this is the cleanest solution. :) - Umair From be04357d54897173b1776ed92ab8347b3cdffd46 Mon Sep 17 00:00:00 2001 From: Umair Khan Date: Thu, 18 Aug 2016 00:27:42 +0530 Subject: [PATCH] avformat/movenc: allow rewriting extradata Signed-off-by: Umair Khan

Re: [FFmpeg-devel] [PATCH] ffmpeg: Update muxer extradata after flushing encoders

2016-08-17 Thread Umair Khan
Hi, On Wed, Aug 17, 2016 at 3:43 PM, Paul B Mahol wrote: > On 8/17/16, Michael Niedermayer wrote: >> This is needed for encoders which store a final sample count or checksum in >> extradata >> >> alternatively every encoder as well as muxer can implement >> AV_PKT_DATA_NEW_EXTRADATA support >> t

Re: [FFmpeg-devel] Outreachy 2016 december

2016-08-17 Thread Umair Khan
Hi, On Wed, Aug 17, 2016 at 5:33 PM, Michael Niedermayer wrote: > On Fri, Jul 22, 2016 at 07:18:13PM +0200, Michael Niedermayer wrote: >> On Wed, Jul 06, 2016 at 11:25:21PM +0200, Michael Niedermayer wrote: >> > Hi all >> > >> > The next Outreachy round starts soon >> > FFmpeg has till august 22

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-12 Thread Umair Khan
Hi, On Mon, Aug 8, 2016 at 11:09 PM, Carl Eugen Hoyos wrote: > 2016-08-08 19:10 GMT+02:00 Umair Khan : >> Attached the 3 separate patches. > > Which other codecs could use mlz decompression in the future? > Which other codecs could use IEEE 754 single floating point > soft

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-08 Thread Umair Khan
On Mon, Aug 8, 2016 at 11:09 PM, Carl Eugen Hoyos wrote: > 2016-08-08 19:10 GMT+02:00 Umair Khan : >> Attached the 3 separate patches. > > Which other codecs could use mlz decompression in the future? > Which other codecs could use IEEE 754 single floating point > soft float

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-08 Thread Umair Khan
Hi, On Sat, Aug 6, 2016 at 10:35 PM, Thilo Borgmann wrote: > Am 06.08.16 um 17:26 schrieb Umair Khan: >> On Fri, Aug 5, 2016 at 9:27 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> 2016-08-05 16:57 GMT+02:00 Umair Khan : >>>> Updated patch at

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-06 Thread Umair Khan
On Fri, Aug 5, 2016 at 9:27 PM, Carl Eugen Hoyos wrote: > Hi! > > 2016-08-05 16:57 GMT+02:00 Umair Khan : >> Updated patch attached. > > The Changelog hunk of your patch indicates that the patch should be split. > (Or the change to Changelog could be wrong.) I don&#x

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-05 Thread Umair Khan
Hi, On Fri, Aug 5, 2016 at 6:59 PM, Umair Khan wrote: > On Fri, Aug 5, 2016 at 6:59 PM, Thilo Borgmann wrote: >> Am 05.08.16 um 14:29 schrieb Umair Khan: >>> On Fri, Aug 5, 2016 at 5:48 PM, Thilo Borgmann >>> wrote: >>>> Am 05.08.16 um 11:45 schrieb Mi

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-05 Thread Umair Khan
On Fri, Aug 5, 2016 at 6:59 PM, Thilo Borgmann wrote: > Am 05.08.16 um 14:29 schrieb Umair Khan: >> On Fri, Aug 5, 2016 at 5:48 PM, Thilo Borgmann >> wrote: >>> Am 05.08.16 um 11:45 schrieb Michael Niedermayer: >>>> On Fri, Jul 29, 2016 at 08:33:13PM +0530,

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-08-05 Thread Umair Khan
On Fri, Aug 5, 2016 at 5:48 PM, Thilo Borgmann wrote: > Am 05.08.16 um 11:45 schrieb Michael Niedermayer: >> On Fri, Jul 29, 2016 at 08:33:13PM +0530, Umair Khan wrote: >>> On Thu, Jul 28, 2016 at 7:12 PM, Umair Khan wrote: >>>> On Thu, Jul 28, 2016 at 2:25 P

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-29 Thread Umair Khan
On Thu, Jul 28, 2016 at 7:12 PM, Umair Khan wrote: > On Thu, Jul 28, 2016 at 2:25 PM, Thilo Borgmann > wrote: >> Am 28.07.16 um 08:28 schrieb Umair Khan: >>> On Thu, Jul 28, 2016 at 12:22 AM, Clément Bœsch wrote: >>>> On Wed, Jul 27, 2016 at 07:48

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-28 Thread Umair Khan
On Thu, Jul 28, 2016 at 2:25 PM, Thilo Borgmann wrote: > Am 28.07.16 um 08:28 schrieb Umair Khan: >> On Thu, Jul 28, 2016 at 12:22 AM, Clément Bœsch wrote: >>> On Wed, Jul 27, 2016 at 07:48:56PM +0200, Thilo Borgmann wrote: >>>>> @@ -1803,6 +2057,34

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-27 Thread Umair Khan
On Thu, Jul 28, 2016 at 12:22 AM, Clément Bœsch wrote: > On Wed, Jul 27, 2016 at 07:48:56PM +0200, Thilo Borgmann wrote: >> > @@ -1803,6 +2057,34 @@ static av_cold int decode_init(AVCodecContext >> > *avctx) >> > ctx->raw_buffer = av_mallocz_array(avctx->channels * >> > channel_size,

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-27 Thread Umair Khan
On Wed, Jul 27, 2016 at 1:27 PM, Umair Khan wrote: > On Wed, Jul 27, 2016 at 1:28 PM, Thilo Borgmann > wrote: >> Hi, >> >>>> [...] >>>>> @@ -1678,6 +1931,7 @@ static av_cold int decode_init(AVCodecContext >>>>> *avctx) >>>

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-27 Thread Umair Khan
On Wed, Jul 27, 2016 at 1:28 PM, Thilo Borgmann wrote: > Hi, > >>> [...] @@ -1678,6 +1931,7 @@ static av_cold int decode_init(AVCodecContext *avctx) { unsigned int c; unsigned int channel_size; +unsigned int i; int num_buffers, ret; ALSDe

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-26 Thread Umair Khan
On Tue, Jul 26, 2016 at 4:52 AM, Michael Niedermayer wrote: > On Mon, Jul 25, 2016 at 10:13:38PM +0530, Umair Khan wrote: >> On Sun, Jul 24, 2016 at 1:47 AM, Umair Khan wrote: >> > >> > HI, >> > >> > On Fri, Jul 22, 2016 at 9:19 PM, Michael Niedermaye

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-25 Thread Umair Khan
On Sun, Jul 24, 2016 at 1:47 AM, Umair Khan wrote: > > HI, > > On Fri, Jul 22, 2016 at 9:19 PM, Michael Niedermayer > wrote: > > On Fri, Jul 22, 2016 at 06:22:30PM +0530, Umair Khan wrote: > >> On Thu, Jul 21, 2016 at 6:18 PM, Michael Niedermayer > >> wrot

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-23 Thread Umair Khan
HI, On Fri, Jul 22, 2016 at 9:19 PM, Michael Niedermayer wrote: > On Fri, Jul 22, 2016 at 06:22:30PM +0530, Umair Khan wrote: >> On Thu, Jul 21, 2016 at 6:18 PM, Michael Niedermayer >> wrote: >> > On Sun, Jul 17, 2016 at 12:06:03AM +0530, Umair Khan wrote: &

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-22 Thread Umair Khan
On Thu, Jul 21, 2016 at 6:18 PM, Michael Niedermayer wrote: > On Sun, Jul 17, 2016 at 12:06:03AM +0530, Umair Khan wrote: >> Hi, >> >> Patch attached. >> >> - Umair > >> libavcodec/Makefile |

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-21 Thread Umair Khan
On Thu, Jul 21, 2016 at 6:18 PM, Michael Niedermayer wrote: > On Sun, Jul 17, 2016 at 12:06:03AM +0530, Umair Khan wrote: >> Hi, >> >> Patch attached. >> >> - Umair > >> libavcodec/Makefile |

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-20 Thread Umair Khan
On Tue, Jul 19, 2016 at 11:17 PM, Umair Khan wrote: > > Updated patch. > > On Tue, Jul 19, 2016 at 8:19 PM, Thilo Borgmann > wrote: > > Am 19.07.16 um 15:42 schrieb Umair Khan: > >> On Tue, Jul 19, 2016 at 5:20 PM, Thilo Borgmann > >> wrote: > &

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-19 Thread Umair Khan
Updated patch. On Tue, Jul 19, 2016 at 8:19 PM, Thilo Borgmann wrote: > Am 19.07.16 um 15:42 schrieb Umair Khan: >> On Tue, Jul 19, 2016 at 5:20 PM, Thilo Borgmann >> wrote: >>> Am 19.07.16 um 09:22 schrieb Umair Khan: >>>> On Tue, Jul 19, 2016 at 12:29 PM,

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-19 Thread Umair Khan
On Tue, Jul 19, 2016 at 5:20 PM, Thilo Borgmann wrote: > Am 19.07.16 um 09:22 schrieb Umair Khan: >> On Tue, Jul 19, 2016 at 12:29 PM, Paul B Mahol wrote: >>> >>> On 7/19/16, Umair Khan wrote: >>>> On Tue, Jul 19, 2016 at 3:08 AM, Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-19 Thread Umair Khan
On Tue, Jul 19, 2016 at 12:29 PM, Paul B Mahol wrote: > > On 7/19/16, Umair Khan wrote: > > On Tue, Jul 19, 2016 at 3:08 AM, Michael Niedermayer > > wrote: > >> On Mon, Jul 18, 2016 at 11:42:48PM +0530, Umair Khan wrote: > >>> On Sun, Jul 17, 2016 at 3:

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-18 Thread Umair Khan
On Tue, Jul 19, 2016 at 3:08 AM, Michael Niedermayer wrote: > On Mon, Jul 18, 2016 at 11:42:48PM +0530, Umair Khan wrote: >> On Sun, Jul 17, 2016 at 3:38 PM, Michael Niedermayer >> wrote: >> > On Sun, Jul 17, 2016 at 11:54:49AM +0200, Michael Niedermayer wrote: >>

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-18 Thread Umair Khan
On Sun, Jul 17, 2016 at 3:38 PM, Michael Niedermayer wrote: > On Sun, Jul 17, 2016 at 11:54:49AM +0200, Michael Niedermayer wrote: >> On Sun, Jul 17, 2016 at 09:00:48AM +0530, Umair Khan wrote: >> > Hi, >> > >> > On Sun, Jul 17, 2016 at 12:25 AM, Th

Re: [FFmpeg-devel] [PATCH] fate/als: add floating point decoding test

2016-07-17 Thread Umair Khan
On Sun, Jul 17, 2016 at 1:50 PM, Thilo Borgmann wrote: > Hi, > >> From e172e333807b4b3b2558a1ffa735ade79a3f3e36 Mon Sep 17 00:00:00 2001 >> From: Umair Khan >> Date: Sun, 17 Jul 2016 13:05:49 +0530 >> Subject: [PATCH 1/1] fate/als: add floating point decoding test &

[FFmpeg-devel] [PATCH] fate/als: add floating point decoding test

2016-07-17 Thread Umair Khan
Hi, Patch attached. - Umair From e172e333807b4b3b2558a1ffa735ade79a3f3e36 Mon Sep 17 00:00:00 2001 From: Umair Khan Date: Sun, 17 Jul 2016 13:05:49 +0530 Subject: [PATCH 1/1] fate/als: add floating point decoding test Signed-off-by: Umair Khan --- tests/fate/als.mak | 3 +++ 1 file changed

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-16 Thread Umair Khan
Hi, On Sun, Jul 17, 2016 at 12:25 AM, Thilo Borgmann wrote: > Hi, > >> From 70e65b26cc3f84c9c664c30808b43a5e1cf16eaa Mon Sep 17 00:00:00 2001 >> From: Umair Khan >> Date: Sat, 16 Jul 2016 23:52:39 +0530 >> Subject: [PATCH 1/1] avcodec/alsdec: implement floating po

[FFmpeg-devel] [PATCH] avcodec/alsdec: implement floating point decoding

2016-07-16 Thread Umair Khan
Hi, Patch attached. - Umair From 70e65b26cc3f84c9c664c30808b43a5e1cf16eaa Mon Sep 17 00:00:00 2001 From: Umair Khan Date: Sat, 16 Jul 2016 23:52:39 +0530 Subject: [PATCH 1/1] avcodec/alsdec: implement floating point decoding It conforms to RM22 version of the reference codec. Signed-off-by

Re: [FFmpeg-devel] avcodec/als: floating point support in ALS decoder

2016-07-16 Thread Umair Khan
On Sat, Jul 16, 2016 at 3:50 AM, Michael Niedermayer wrote: > On Wed, Jul 06, 2016 at 10:58:40AM +0530, Umair Khan wrote: >> On Sat, Jun 25, 2016 at 10:52 PM, Umair Khan wrote: >> > Hi, >> > >> > Patch attached. >> >> I'm working on fixing so

Re: [FFmpeg-devel] avcodec/als: floating point support in ALS decoder

2016-07-05 Thread Umair Khan
On Sat, Jun 25, 2016 at 10:52 PM, Umair Khan wrote: > Hi, > > Patch attached. I'm working on fixing some other bugs in the decoder and hence I'd like to withdraw this patch from the list. Umair ___ ffmpeg-devel mailing list ffmp

[FFmpeg-devel] avcodec/als: floating point support in ALS decoder

2016-06-25 Thread Umair Khan
Hi, Patch attached. Umair From 56281948ec484c19dd9009c861ded38905e1b786 Mon Sep 17 00:00:00 2001 From: Umair Khan Date: Sat, 25 Jun 2016 22:48:02 +0530 Subject: [PATCH] avcodec/als: floating point support in ALS decoder Signed-off-by: Umair Khan --- libavcodec/Makefile | 2

Re: [FFmpeg-devel] Doubts regarding SoftFloat

2016-06-01 Thread Umair Khan
Hi, On Thu, Jun 2, 2016 at 4:02 AM, Moritz Barsnick wrote: > To expand on Michael's comments: > > On Tue, May 31, 2016 at 21:02:01 +0530, Umair Khan wrote: >> I replaced floats in my code with SoftFloat and the results weren't as >> expected. > > Why did

[FFmpeg-devel] Doubts regarding SoftFloat

2016-05-31 Thread Umair Khan
Hi all, I replaced floats in my code with SoftFloat and the results weren't as expected. I also had some doubts the way it is written. 1. The biggest one is why is the mantissa part of FLOAT_1 defined as 0x2000 here - https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/softfloat.h#L41. If

Re: [FFmpeg-devel] Masked LZ Decompression

2016-05-22 Thread Umair Khan
On Sun, May 22, 2016 at 11:11 PM, Paul B Mahol wrote: > On 5/22/16, Umair Khan wrote: >> On Fri, May 20, 2016 at 11:53 PM, Paul B Mahol wrote: >>> On 5/20/16, Umair Khan wrote: >>>> Hi, >>>> >>>> I'm working on implementing floating

Re: [FFmpeg-devel] Masked LZ Decompression

2016-05-22 Thread Umair Khan
On Fri, May 20, 2016 at 11:53 PM, Paul B Mahol wrote: > On 5/20/16, Umair Khan wrote: >> Hi, >> >> I'm working on implementing floating point support in the ALS decoder. >> In this I've to use masked LZ decompression. I've written the code for >> m

[FFmpeg-devel] Masked LZ Decompression

2016-05-20 Thread Umair Khan
Hi, I'm working on implementing floating point support in the ALS decoder. In this I've to use masked LZ decompression. I've written the code for myself for masked lz decompression using the help from the reference software. Although, I'm not yet sure if an implementation of masked LZ is already t

[FFmpeg-devel] [PATCH] avcodec/alsdec: Fix bitstream reading

2016-04-26 Thread Umair Khan
According to the latest ISO specification pdf, the byte align should be according to the patch. Tested the change with all the sample ALS files. This doesn't produce any bug. From 7af5076eabc28a441ed90f920bf1a6a1e0855c3f Mon Sep 17 00:00:00 2001 From: Umair Khan Date: Wed, 27 Apr 2016 09:

Re: [FFmpeg-devel] [PATCH][GSoC] Implement floating point decoding in ALS

2016-04-21 Thread Umair Khan
>> This patch is the second qualification task of my project. >> The patch isn't final yet. >> I've got it reviewed by Thilo Borgmann and now sending it here. > > this is not what I meant to be done. The complete patch is not yet ready for > a list review - it does not make sense for anyone on thi

[FFmpeg-devel] [PATCH][GSoC] Implement floating point decoding in ALS

2016-04-21 Thread Umair Khan
e encoded file having floating point sample data which I use for testing. Umair From cdaf469a9832812755924485e7f83a465652612a Mon Sep 17 00:00:00 2001 From: Umair Khan Date: Sat, 16 Apr 2016 17:56:13 +0530 Subject: [PATCH] Implement floating point decoding in ALS Signed-off-by: Umair Khan

[FFmpeg-devel] [PATCH] avcodec/alsdec: fix max bits in ltp prefix code

2016-03-11 Thread Umair Khan
The maximum number of bits int the prefix code for p(0) is 4. By setting it as 3, we were missing the last 0 bit. This fixes bug #4715 present on the trac. Signed-off-by: Umair Khan --- libavcodec/alsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alsdec.c b

[FFmpeg-devel] [PATCH] avcodec/alsdec: treat quant_cof as a signed value

2016-03-05 Thread Umair Khan
Signed-off-by: Umair Khan --- libavcodec/alsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index ebd364e..0043512 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -729,7 +729,7 @@ static int read_var_block_data

Re: [FFmpeg-devel] [PATCH] fix seek_timestamp flag

2016-02-09 Thread Umair Khan
> This seems wrong, the original codes intent was not to handle the > seek_timestamp but the start time, which you just replace? I'm sorry I got the problem. But, why aren't we handling o->seek_timestamp anywhere in the code ? ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH] fix seek_timestamp flag

2016-02-09 Thread Umair Khan
I didn't test the original code if it was actually creating issue or not, but this looks better to me. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] fix seek_timestamp flag

2016-02-09 Thread Umair Khan
Signed-off-by: Umair Khan --- ffmpeg_opt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index 669976b..011a10b 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -164,6 +164,7 @@ static void init_options(OptionsContext *o) o

[FFmpeg-devel] [PATCH] docs: explain properly how -fs works

2016-01-31 Thread Umair Khan
Signed-off-by: Umair Khan --- doc/ffmpeg.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 7d3266a..e02807c 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -297,7 +297,9 @@ see @ref{time duration syntax,,the Time duration

Re: [FFmpeg-devel] [PATCH] docs: explain properly how -fs works

2016-01-31 Thread Umair Khan
On Sun, Jan 31, 2016 at 8:04 PM, Carl Eugen Hoyos wrote: > Umair Khan gmail.com> writes: > >> +Set the file size limit, expressed in bytes. No more bytes are written >> +after the limit is exceeded. > > Does this explain that the file size is never smaller than > t

[FFmpeg-devel] [PATCH] docs: explain properly how -fs works

2016-01-31 Thread Umair Khan
Umair Khan (1): docs: explain properly how -fs works doc/ffmpeg.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.5.0 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] docs: explain properly how -fs works

2016-01-31 Thread Umair Khan
--- doc/ffmpeg.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 7d3266a..07b7759 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -297,7 +297,8 @@ see @ref{time duration syntax,,the Time duration section in the ffmpeg-utils(1)