Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Ensure klv->key is initialized

2025-07-24 Thread Tomas Härdin
tor 2025-07-24 klockan 00:51 +0200 skrev Marton Balint: > > > On Wed, 23 Jul 2025, Tomas Härdin wrote: > > > ons 2025-07-23 klockan 13:45 +0200 skrev Michael Niedermayer: > > > Fixes: read of uninitialized memory > > > Fixes: 391916474/clusterfuzz-testcase-mi

Re: [FFmpeg-devel] [PATCH v2] avformat/mxfenc: Ensure frame offset in valid range

2025-07-24 Thread Tomas Härdin
ons 2025-07-23 klockan 00:32 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Fix assert failure. > Fix #11666. > > Signed-off-by: Zhao Zhili > --- >  libavformat/mxfenc.c | 48 Looks fine /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Ensure klv->key is initialized

2025-07-23 Thread Tomas Härdin
ons 2025-07-23 klockan 13:45 +0200 skrev Michael Niedermayer: > Fixes: read of uninitialized memory > Fixes: 391916474/clusterfuzz-testcase-minimized- > ffmpeg_dem_MXF_fuzzer-4935250956845056 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] what AVCodecID to use for copying full vanc data between .mxf and .mcc

2025-07-23 Thread Tomas Härdin
tis 2025-07-22 klockan 13:56 -0700 skrev Jacob Lifshay: > On July 22, 2025 5:21:24 AM PDT, "Tomas Härdin" > > * combining 436M and video essence to a full frame for playout > iirc ffmpeg architecturally doesn't support merging a 608 stream into > video side data sin

Re: [FFmpeg-devel] what AVCodecID to use for copying full vanc data between .mxf and .mcc

2025-07-22 Thread Tomas Härdin
mån 2025-07-07 klockan 21:12 -0700 skrev Jacob Lifshay: > I'm currently writing a .mcc muxer, it currently translates from eia- > 608/708 to full vanc packets before outputting a .mcc file: > https://github.com/programmerjake/FFmpeg/tree/add-mcc-mux > > I want to add the ability to the mxf and mcc

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: Ensure keyframe offset in valid range

2025-07-22 Thread Tomas Härdin
ons 2025-07-16 klockan 11:57 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Fix assert failure. > Fix #11666. Saw this ticket, but I was busy with other things and forgot about it > @@ -2100,9 +2111,17 @@ static void > mxf_write_index_table_segment(AVFormatContext *s) > avio_w8(pb,

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-18 Thread Tomas Härdin
ons 2025-06-18 klockan 05:55 +0200 skrev Michael Niedermayer: > What you suggest or hint toward to me, in plain english sounds like, > drop the ffmpeg command line tool because it would otherwise need to > have NLE support. I am not suggesting that. As many others have been pointing out recently,

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-18 Thread Tomas Härdin
fre 2025-06-13 klockan 13:03 + skrev Marcos Del Sol: > Tomas Härdin: > > tis 2025-06-10 klockan 11:42 + skrev Marcos Del Sol: > > > WebVTT is supposed to be an extensible format. > > > > The syntax says otherwise. Why the W3C feels the need to specify a >

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-17 Thread Tomas Härdin
fre 2025-06-13 klockan 20:07 +0530 skrev Gyan Doshi: > > > On 2025-06-13 04:25 pm, Tomas Härdin wrote: > > The present level of > > edit list support could be reimplemented by just fiddling with the > > -ss > > and -t options. That is, the ffmpeg CLI could automa

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-17 Thread Tomas Härdin
fre 2025-06-13 klockan 18:19 +0200 skrev Michael Niedermayer: > Hi > > On Fri, Jun 13, 2025 at 04:53:14PM +0200, Tomas Härdin wrote: > > fre 2025-06-13 klockan 16:21 +0200 skrev Michael Niedermayer: > > > > 3) remove edit list hacks from all demuxers, especially mov.c &

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-17 Thread Tomas Härdin
fre 2025-06-13 klockan 20:27 +0530 skrev Gyan Doshi: > > > On 2025-06-13 08:23 pm, Tomas Härdin wrote: > > For now I'll probably dummy out elst support and the associated > > tests > > just to make progress on segmented indexes. > > Does `-ignore_editl

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Tomas Härdin
> Derek did this in 2018: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2018-March/227437.html Interesting. I didn't think to use side data for it. Putting the edit lists in AVStream seems wrong. They belong to AVFormatContext. Else we can't support ganged or alternate packages in MXF (OP1b, OP1c

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Tomas Härdin
fre 2025-06-13 klockan 16:21 +0200 skrev Michael Niedermayer: > > 3) remove edit list hacks from all demuxers, especially mov.c > > +1 (with ABI +2 bump) I'm not sure why a (major?) bump would be necessary. Are removal of options a major bump, not a minor one? Either way, we could make the option

Re: [FFmpeg-devel] [PATCH 1/2] lavf/webvttenc: avio_flush() output

2025-06-13 Thread Tomas Härdin
tis 2025-06-10 klockan 00:17 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > Hi > > > > These two patches are a bit of a warmup for another pass at > > streamable > > subtitles. FATE passes. > > > > /Tomas > > > Users who

[FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Tomas Härdin
Hi In my fiddling with fragmented indexes in mov.c I ran cross mov_fix_index(), which has been in the codebase since September 2016. The intent of this function is to implement limited support for edit lists (elst). More rudely one could say it implements half-assed support for edit lists. Besides

Re: [FFmpeg-devel] [PATCHv3 1/8] avcodec/g728_template: do_hybrid_window() template

2025-06-09 Thread Tomas Härdin
mån 2025-06-09 klockan 20:06 +1000 skrev Peter Ross: > +static void convolve(float *tgt, const float *src, int len, int n) > +{ > +    for (; n >= 0; n--) > +    tgt[n] = ff_scalarproduct_float_c(src, src - n, len); > + > +} This should probably use an FFT since this implementation is O(n²). T

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-09 Thread Tomas Härdin
fre 2025-06-06 klockan 22:22 +0200 skrev Marcos Del Sol Vives: > > > El 6 de junio de 2025 21:43:58 CEST, "Tomas Härdin" > escribió: > > > > Sounds like the demuxer correctly rejected some broken files > > > > The WebVTT standard does not call fo

[FFmpeg-devel] [PATCH 2/2] lavf/srtenc: avio_flush() output

2025-06-09 Thread Tomas Härdin
From c879c0b8a810a53e1d424edb129a1aba2df1b9d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Mon, 9 Jun 2025 22:03:12 +0200 Subject: [PATCH 2/2] lavf/srtenc: avio_flush() output This make streaming srt possible --- libavformat/srtenc.c | 1 + 1 file changed, 1 insertion(+)

[FFmpeg-devel] [PATCH 1/2] lavf/webvttenc: avio_flush() output

2025-06-09 Thread Tomas Härdin
Hi These two patches are a bit of a warmup for another pass at streamable subtitles. FATE passes. /Tomas From c5b1e1774e5d4e720295e6cb589eb7699e0ddaa3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 16 May 2025 14:07:00 +0200 Subject: [PATCH 1/2] lavf/webvttenc: avio_fl

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-06 Thread Tomas Härdin
tis 2025-05-27 klockan 10:40 + skrev Marcos Del Sol via ffmpeg- devel: > A note on this change: I found some .vtt files while using yt-dlp > that follow > a draft version of the WebVTT standard (probably > https://www.w3.org/2013/07/webvtt.html) that use "Region:" for > regions instead > of "RE

Re: [FFmpeg-devel] [FEATURE PROPOSAL] Extracting codec-level data to binary files

2025-06-06 Thread Tomas Härdin
ons 2025-05-21 klockan 15:34 +0200 skrev Timothée: > Hello, > > I am interested in expanding ffmpeg's capabilities to extract > low-level data from video codecs. Specifically, I'd like to implement > functionality that would allow exporting frame data, macroblock > information, quantization tables

Re: [FFmpeg-devel] [RFC] Cherry picks vs merges

2025-06-04 Thread Tomas Härdin
sön 2025-06-01 klockan 21:23 +0200 skrev Michael Niedermayer: > And the "explicit license notice" you refer to is this: > > "All Librempeg modifications, and any new files not available in > FFmpeg, are licensed under GPL v2, >  unless stated otherwise." > > And it IS stated otherwise in these fi

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-31 Thread Tomas Härdin
mån 2025-03-10 klockan 09:57 -0400 skrev Devin Heitmueller: > On Mon, Mar 10, 2025 at 5:57 AM Tomas Härdin wrote: > > > > Muxing together captions from different sources is pretty painful, > > > since you have to parse/decompose the 708 stream and recombine streams >

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-31 Thread Tomas Härdin
mån 2025-03-31 klockan 11:55 -0400 skrev Devin Heitmueller: > Hello Tomas, > > On Mon, Mar 31, 2025 at 11:24 AM Tomas Härdin wrote: > > > > Did you report this to libcaption's devs? > > Respectfully, libcaption is essentially a dead project.  The main repo >

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-11 Thread Tomas Härdin
tis 2025-03-04 klockan 10:13 -0500 skrev Devin Heitmueller: > On Tue, Mar 4, 2025 at 4:02 AM Tomas Härdin wrote: > > > > Even if the captions are intended to > > > serve other countries, the country code will stay the same (defining > > > the country code for ind

Re: [FFmpeg-devel] [PATCH] doc/metadata.texi: Start documenting keys

2025-03-05 Thread Tomas Härdin
tis 2025-03-04 klockan 12:36 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > +@item ref-frame-config @tab @tab @tab > > +@item reverb @tab S @tab argo_cvg @tab > > The first is libvp9enc-only, the second argo_cvg only. IMO it is > better > to document this at the do

Re: [FFmpeg-devel] [PATCH] doc/metadata.texi: Start documenting keys

2025-03-04 Thread Tomas Härdin
ons 2025-02-19 klockan 16:42 +0100 skrev Tomas Härdin: > Hi > > Rather than continue the RFC thread for this, I decided to submit a > patch that begins the process of documenting metadata keys. > > There's quite a lot of keys used in the codebase, and this patch does >

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-04 Thread Tomas Härdin
mån 2025-03-03 klockan 14:12 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > >  #include "libavutil/mem.h" > >  #include "atsc_a53.h" > > +#include "itut35.h" > >  #include "get_bits.h" > >   > > Proper alphabetic

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-04 Thread Tomas Härdin
mån 2025-03-03 klockan 08:55 -0500 skrev Devin Heitmueller: > On Mon, Mar 3, 2025 at 7:25 AM Tomas Härdin wrote: > > > > Looking at CTA-708 at the moment and noticed this. In the future we > > might want to make it possible for the user to set the country > > code. &

[FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-03 Thread Tomas Härdin
Looking at CTA-708 at the moment and noticed this. In the future we might want to make it possible for the user to set the country code. This patch makes finding usage of the US country code easier Running FATE at the moment, but I don't expected it to fail from this kind of change. /Tomas From 4

Re: [FFmpeg-devel] [PATCH 1/8] avformat/http: Return EIO for prematurely broken connection

2025-02-26 Thread Tomas Härdin
tis 2025-02-18 klockan 15:43 +0100 skrev Tomas Härdin: > Based on replies so far it seems no one is objecting to the following > patches: > > * [PATCH 1/8] avformat/http: Return EIO for prematurely broken connection > * [PATCH 2/8] libavcodec/wmadec: Return AVERROR_INVALIDDATA on

Re: [FFmpeg-devel] I've written a filter in Rust

2025-02-26 Thread Tomas Härdin
mån 2025-02-24 klockan 16:51 +0200 skrev Rémi Denis-Courmont: > Hi, > > Le 23 février 2025 23:30:03 GMT+02:00, "Tomas Härdin" > a écrit : > > lör 2025-02-22 klockan 14:57 +0200 skrev Rémi Denis-Courmont: > > > Le perjantaina 21. helmikuuta 2025, 20.0

Re: [FFmpeg-devel] I've written a filter in Rust

2025-02-26 Thread Tomas Härdin
sön 2025-02-23 klockan 22:51 +0100 skrev Michael Niedermayer: > Hi > > On Sun, Feb 23, 2025 at 10:30:03PM +0100, Tomas Härdin wrote: > > lör 2025-02-22 klockan 14:57 +0200 skrev Rémi Denis-Courmont: > > > Le perjantaina 21. helmikuuta 2025, 20.02.16 UTC+2 Tomas Härdin a é

Re: [FFmpeg-devel] I've written a filter in Rust

2025-02-26 Thread Tomas Härdin
; > mailto:ffmpeg-devel-bounces@ff > > > > mpeg.org>> On Behalf Of > > > > Michael Niedermayer > > > > Sent: Freitag, 21. Februar 2025 14:22 > > > > To: FFmpeg development discussions and patches > > > de...@ffmpeg.org<mailto:de...@ffmpeg

Re: [FFmpeg-devel] I've written a filter in Rust

2025-02-23 Thread Tomas Härdin
lör 2025-02-22 klockan 14:57 +0200 skrev Rémi Denis-Courmont: > Le perjantaina 21. helmikuuta 2025, 20.02.16 UTC+2 Tomas Härdin a écrit : > > The above said, I'm not against Rust. It has some nice properties. But > > it does not seem very "stable" so far. Perhaps

Re: [FFmpeg-devel] I've written a filter in Rust

2025-02-21 Thread Tomas Härdin
fre 2025-02-21 klockan 14:18 +0100 skrev Lynne: > On 20/02/2025 14:06, Leandro Santiago wrote: > > > - 1: I managed to reuse lots of high quality code, available on > > crates (the repository of Rust packages), preventing me of needing > > to write hairy math heavy code. I personally suck in maths

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-21 Thread Tomas Härdin
tor 2025-02-20 klockan 22:08 +0100 skrev Michael Niedermayer: > On Thu, Feb 13, 2025 at 10:29:33PM +0100, Tomas Härdin wrote: > > Might be better to leverage afl-fuzz since it is more wily in its > > tricks to provoke different program behavior. Then exit(1) whenever > >

Re: [FFmpeg-devel] I've written a filter in Rust

2025-02-21 Thread Tomas Härdin
tor 2025-02-20 klockan 23:49 +0100 skrev Michael Niedermayer: > Hi > > On Thu, Feb 20, 2025 at 02:06:47PM +0100, Leandro Santiago wrote: > > [insert meme here] > [...] > > I also recorded a video showing the filter in action [7]. > [... > > [7] https://youtu.be/U_y4-NnaINg > > cool, it doesnt det

[FFmpeg-devel] [PATCH] doc/metadata.texi: Start documenting keys

2025-02-19 Thread Tomas Härdin
Hi Rather than continue the RFC thread for this, I decided to submit a patch that begins the process of documenting metadata keys. There's quite a lot of keys used in the codebase, and this patch does not cover all of them. But it should give the general idea. I follow a similar approach to that

Re: [FFmpeg-devel] [RFC] Documenting metadata keys, informative (non-copied) metadata

2025-02-19 Thread Tomas Härdin
tis 2025-02-18 klockan 18:35 +0100 skrev Marvin S.: > > > On 18 Feb 2025, at 17:56, Tomas Härdin wrote: > > > tor 2025-02-13 klockan 12:54 +0100 skrev Tomas Härdin: > > > Hi > > > > > > In the samples_md5 patch discussion Michael wanted the propose

Re: [FFmpeg-devel] [RFC] Documenting metadata keys, informative (non-copied) metadata

2025-02-18 Thread Tomas Härdin
tor 2025-02-13 klockan 12:54 +0100 skrev Tomas Härdin: > Hi > > In the samples_md5 patch discussion Michael wanted the proposed key > to > be documented. But it turns out we don't have any documentation for > metadata keys! So I'm starting this thread to talk about it

Re: [FFmpeg-devel] [PATCH] avcodec/codec_internal: remove unnecessary avcodec.h include

2025-02-18 Thread Tomas Härdin
sön 2025-02-16 klockan 17:50 -0300 skrev James Almer: > Signed-off-by: James Almer > --- >  libavcodec/codec_internal.h | 5 ++--- >  1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/codec_internal.h > b/libavcodec/codec_internal.h > index 5b2db74590..01033f4705 100644 >

Re: [FFmpeg-devel] [PATCH 1/8] avformat/http: Return EIO for prematurely broken connection

2025-02-18 Thread Tomas Härdin
Based on replies so far it seems no one is objecting to the following patches: * [PATCH 1/8] avformat/http: Return EIO for prematurely broken connection * [PATCH 2/8] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors * [PATCH 4/8] avformat/flacdec: Return correct error-codes on read

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-13 Thread Tomas Härdin
tor 2025-02-13 klockan 13:03 +0100 skrev Michael Niedermayer: > On Thu, Feb 13, 2025 at 12:40:24PM +0100, Tomas Härdin wrote: > > ons 2025-02-12 klockan 23:03 +0100 skrev Michael Niedermayer: > > > On Wed, Feb 12, 2025 at 12:03:37PM +0100, Tomas Härdin wrote: > > > >

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 23:07 + skrev Soft Works: > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Timo > > Rothenpieler > > Sent: Mittwoch, 12. Februar 2025 22:33 > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [RFC] Experiment: enable github pull > > r

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 22:16 + skrev Soft Works: > > > I think people should be able to use a procedure they are > > > familiar with. > > > Is it possible to create PRs from a fork on GitHub? We explicitly don't want that. Also github doesn't federate. None of these git hosting sites do I thin

[FFmpeg-devel] [RFC] Documenting metadata keys, informative (non-copied) metadata

2025-02-13 Thread Tomas Härdin
Hi In the samples_md5 patch discussion Michael wanted the proposed key to be documented. But it turns out we don't have any documentation for metadata keys! So I'm starting this thread to talk about it. I reckon we create a new file called doc/metadata_keys.texi with a table listing keys and where

Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 22:55 +0100 skrev Michael Niedermayer: > Hi > On Wed, Feb 12, 2025 at 11:56:16AM +0100, Tomas Härdin wrote: > > tor 2025-02-06 klockan 16:07 +0100 skrev Michael Niedermayer: > > > Hi Tomas > > > > > > On Wed, Feb 05, 2025

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-13 Thread Tomas Härdin
ons 2025-02-12 klockan 23:03 +0100 skrev Michael Niedermayer: > On Wed, Feb 12, 2025 at 12:03:37PM +0100, Tomas Härdin wrote: > > tor 2025-02-06 klockan 15:58 +0100 skrev Michael Niedermayer: > > > Hi Tomas > > > > > > On Wed, Feb 05, 2025 at 03:24:24PM +010

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-12 Thread Tomas Härdin
ons 2025-02-12 klockan 12:49 +0100 skrev Nicolas George: > Tomas Härdin (HE12025-02-12): > > This is aristocracy, not democracy. > > Why do you believe democracy would be a good model for a Libre > Software > project? The title of the thread includes the word "democrat

Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-12 Thread Tomas Härdin
ons 2025-02-12 klockan 13:27 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > ons 2025-02-12 klockan 12:14 +0100 skrev Andreas Rheinhardt: > > > Tomas Härdin: > > > > > > > > > > > > ___

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-02-12 Thread Tomas Härdin
ons 2025-01-29 klockan 21:33 +0100 skrev Michael Niedermayer: >     Make Voting Power Proportional to Contributions >     Fair Representation: Allocate voting power based on > contributions, ensuring that those who dedicate substantial time and > effort to the project have a stronger voice than

Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-12 Thread Tomas Härdin
ons 2025-02-12 klockan 12:14 +0100 skrev Andreas Rheinhardt: > Tomas Härdin: > > > > > > ___ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > &

Re: [FFmpeg-devel] [RFC] GSoC 2025 SDR Cleanup

2025-02-12 Thread Tomas Härdin
ons 2025-02-12 klockan 02:21 +0100 skrev Michael Niedermayer: > Hi all > > Ive added SDR to our GSoC 2025 page as there was just a single > project > on that page and the page needs to be more complete yesterday > > If people are against this say this NOW do not wait until we have > accepted > a

Re: [FFmpeg-devel] [PATCH 6/8] GOL-1361: Remove invalid CTTS sample_offset check

2025-02-12 Thread Tomas Härdin
ons 2025-02-05 klockan 15:22 +0100 skrev Tomas Härdin: > I trust that ticket #385 has a FATE test these days Just tested the file in said ticket and it transcodes fine with this patch applied. /Tomas ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-12 Thread Tomas Härdin
tor 2025-02-06 klockan 15:58 +0100 skrev Michael Niedermayer: > Hi Tomas > > On Wed, Feb 05, 2025 at 03:24:24PM +0100, Tomas Härdin wrote: > > Seems reasonable to me and passes FATE > > > > /Tomas > > >  avformat.h   |    2 +- > >  format.c |    8 +

Re: [FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-12 Thread Tomas Härdin
tor 2025-02-06 klockan 16:07 +0100 skrev Michael Niedermayer: > Hi Tomas > > On Wed, Feb 05, 2025 at 03:20:09PM +0100, Tomas Härdin wrote: > > > > >  libavformat/flacdec.c |    6 ++ > >  tests/ref/fate/cover-art-aiff-id3v2-remux |    5 +++--

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mxfenc: Make write_desc return int

2025-02-05 Thread Tomas Härdin
tis 2024-11-12 klockan 18:49 +0100 skrev Tomas Härdin: > fre 2024-11-08 klockan 11:29 +0100 skrev Tomas Härdin: > > Passes fate-mxf > > Will push in a day or two .. or a month or two. Tested and pushed. /Tomas ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check edit unit for overflow in mxf_set_current_edit_unit()

2025-02-05 Thread Tomas Härdin
ons 2025-02-05 klockan 12:56 +0100 skrev Michael Niedermayer: > Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be > represented in type 'long' > Fixes: 392672068/clusterfuzz-testcase-minimized- > ffmpeg_dem_MXF_fuzzer-6232335892152320 > > Found-by: continuous fuzzing process > http

Re: [FFmpeg-devel] [PATCH 6/7] avformat: add s337m support in mpegts, wav and mxf stereo tracks

2025-02-05 Thread Tomas Härdin
ons 2024-12-04 klockan 15:14 +0100 skrev ffnicol...@sfr.fr: > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -634,7 +634,7 @@ static int mxf_get_d10_aes3_packet(AVIOContext *pb, > AVStream *st, AVPacket *pkt, > for (; end_ptr - buf_ptr >= st->codecpar->ch_layout.nb_channels * 4;

[FFmpeg-devel] [PATCH 8/8] Make mime-type award a bonus probe score

2025-02-05 Thread Tomas Härdin
Seems reasonable to me and passes FATE /Tomas From ecc3459990f2871fd907f96fe66362b8fea41bd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Zeb=C3=BChr?= Date: Tue, 21 Nov 2023 14:16:49 +0100 Subject: [PATCH 8/8] Make mime-type award a bonus probe score This changes the default behaviour of ffm

[FFmpeg-devel] [PATCH 7/8] avformat/mp3dec: Subtract known padding from duration

2025-02-05 Thread Tomas Härdin
From 6dca5b958693588d74081e8fa29f05a5f257c841 Mon Sep 17 00:00:00 2001 From: Ulrik Mikaelsson Date: Tue, 22 Aug 2023 13:55:14 +0200 Subject: [PATCH 7/8] avformat/mp3dec: Subtract known padding from duration When an Info-tag is present, marking initial and trailing samples as padding, those sampl

[FFmpeg-devel] [PATCH 6/8] GOL-1361: Remove invalid CTTS sample_offset check

2025-02-05 Thread Tomas Härdin
I trust that ticket #385 has a FATE test these days /Tomas From 8c105c5953c494402749eb27d2eb6a7a2393f855 Mon Sep 17 00:00:00 2001 From: ekir Date: Tue, 18 Apr 2023 17:31:43 +0200 Subject: [PATCH 6/8] GOL-1361: Remove invalid CTTS sample_offset check We checked in this places: * In 8.6.1.3 of ISO

[FFmpeg-devel] [PATCH 4/8] avformat/flacdec: Return correct error-codes on read-failure

2025-02-05 Thread Tomas Härdin
From c81e350d5419cf02f029ce006d94f257bc18fb97 Mon Sep 17 00:00:00 2001 From: Ulrik Date: Thu, 26 Jan 2023 17:51:02 +0100 Subject: [PATCH 4/8] avformat/flacdec: Return correct error-codes on read-failure Forward errors from `avio_read` directly. When `avio_read` sees EOF before expected bytes ca

[FFmpeg-devel] [PATCH 5/8] rtmp: Set correct message stream id when writing as server

2025-02-05 Thread Tomas Härdin
This one is difficult to test. Any ideas? /Tomas From c8689abcbf9bf85e1f7775a347b6bc994679cb77 Mon Sep 17 00:00:00 2001 From: Jonathan Murray Date: Thu, 31 Mar 2022 16:23:17 +0200 Subject: [PATCH 5/8] rtmp: Set correct message stream id when writing as server rtmp_write is used both for writing

[FFmpeg-devel] [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata

2025-02-05 Thread Tomas Härdin
From e1c4dfa4cc7a574f6fac76c11591547d3cd90ad2 Mon Sep 17 00:00:00 2001 From: Mattias Wadman Date: Mon, 11 Oct 2021 15:38:13 +0200 Subject: [PATCH 3/8] libavformat/flacdec: Export samples md5 as metadata Will be used by mal to compare metadat md5 with decoded samples md5. Part of fixing https://

[FFmpeg-devel] [PATCH 2/8] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors

2025-02-05 Thread Tomas Härdin
From 18a64198487582e9ef3246e7490d919ee19af595 Mon Sep 17 00:00:00 2001 From: Jonathan Murray Date: Wed, 9 Jun 2021 12:00:24 +0200 Subject: [PATCH 2/8] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors WMA files that fail to decode due to incoherent block lengths and frame lengths

[FFmpeg-devel] [PATCH 1/8] avformat/http: Return EIO for prematurely broken connection

2025-02-05 Thread Tomas Härdin
Rebased and trimmed down Spotify patchset. Does not include the mfra or ID3v2 stuff since those are turning out to be bigger tasks /Tomas From c808ca473529ca952c42f00d12aa50ade38850d8 Mon Sep 17 00:00:00 2001 From: Ulrik Date: Mon, 27 Jul 2020 11:46:56 +0200 Subject: [PATCH 1/8] avformat/http: Re

Re: [FFmpeg-devel] [PATCH 1/6] lavf/mov: Always try to parse mfra if file contains moof boxes

2024-12-16 Thread Tomas Härdin
mån 2024-12-16 klockan 16:23 +0100 skrev Tomas Härdin: > Updated patchset. Patches 1-2 could maybe be squashed > > The end result of these patches is that fragmented files probe much > faster over HTTP. The final patch is just a small optimization to > movenc Darn, this breaks fa

Re: [FFmpeg-devel] [PATCH 5/6] Add more FATE tests for fragmented MP4

2024-12-16 Thread Tomas Härdin
mån 2024-12-16 klockan 16:27 +0100 skrev Tomas Härdin: > Two reference files. One with sidx+mfra, the other with only mfra Forgot the FATE refs. Updated patch attached /Tomas From f6d28d84413f2f674cfac86d4ed0868e8afb604b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date:

[FFmpeg-devel] [PATCH 6/6] lavf/movenc: Write version 0 (32-bit) traf if possible

2024-12-16 Thread Tomas Härdin
From 2698fc4b53e482adfe09781d90aa936a567524aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Mon, 16 Dec 2024 14:15:12 +0100 Subject: [PATCH 6/6] lavf/movenc: Write version 0 (32-bit) traf if possible This results in smaller files. Update fate-movenc accordingly. --- libav

[FFmpeg-devel] [PATCH 4/6] lavf/mov: Do not set bit_rate unless all fragment headers have been read

2024-12-16 Thread Tomas Härdin
Without this we get a bogus bitrate whenever we rely on mfra With this patch we could potentially drop -use_mfra_for /Tomas From 7484bb3b83e23b152e1cabb7b00bdceff0a217e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Mon, 16 Dec 2024 16:15:10 +0100 Subject: [PATCH 4/6] lavf/

[FFmpeg-devel] [PATCH 3/6] lavf/mov: Parse and verify the whole mfro box

2024-12-16 Thread Tomas Härdin
This avoid a seek on some files that might accidentally have a seemingly valid mfra offset /Tomas From 23f1ddc8ae4064f6d03efd54fb9da5ca9fc450ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 11 Dec 2024 14:56:31 +0100 Subject: [PATCH 3/6] lavf/mov: Parse and verify the

[FFmpeg-devel] [PATCH 2/6] lavf/mov: Read duration when parsing mfra

2024-12-16 Thread Tomas Härdin
Hopefully I got the calls to mov_switch_root() right. mov_read_default() just ends up calling mov_read_moof() twice on the first moof /Tomas From bbcff7581177b25b03e0f53ebb4732b7f10f0616 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Mon, 16 Dec 2024 15:25:44 +0100 Subject:

[FFmpeg-devel] [PATCH 1/6] lavf/mov: Always try to parse mfra if file contains moof boxes

2024-12-16 Thread Tomas Härdin
Updated patchset. Patches 1-2 could maybe be squashed The end result of these patches is that fragmented files probe much faster over HTTP. The final patch is just a small optimization to movenc /Tomas From 357be61ac65149b826769c07a7a3dbb7af7164db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20

[FFmpeg-devel] [PATCH] Add FATE test for the number of seeks performed when probing fragmented MP4

2024-12-13 Thread Tomas Härdin
ons 2024-12-11 klockan 15:41 +0100 skrev Tomas Härdin: > ons 2024-12-11 klockan 15:24 +0100 skrev Tomas Härdin: > > Hi > > > > This patchset addresses the issues Spotify has been having reading > > fragmented MP4 over HTTP. The issue is that mov.c does hundreds of >

Re: [FFmpeg-devel] [PATCH 1/3] lavf/mov: Always try to parse mfra if file contains moof boxes

2024-12-11 Thread Tomas Härdin
ons 2024-12-11 klockan 15:24 +0100 skrev Tomas Härdin: > Hi > > This patchset addresses the issues Spotify has been having reading > fragmented MP4 over HTTP. The issue is that mov.c does hundreds of > seeks unless -use_mfra_for is set to something other than auto. > H

[FFmpeg-devel] [PATCH 2/3] lavf/mov: Always try to parse mfra

2024-12-11 Thread Tomas Härdin
This one is perhaps a bit dubious, but on frags.mp4 it saves a seek. I have no strong feelings on this patch, it just struck me as far simpler to always read mfra I checked the ISO/IEC spec and mfra may be present in any file that is isom branded. Usually it is only present for fragmented files I

[FFmpeg-devel] [PATCH 3/3] lavf/mov: Parse and verify the whole mfro box

2024-12-11 Thread Tomas Härdin
This saves a seek on files that don't have mfra but where the last 4 bytes happen to seeem valid It just struck me that we could tighten the bound on mfra_size, because it has to be at least 24 /Tomas From ccf83120683dcbcaba9191c058b820e516392b11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H

Re: [FFmpeg-devel] ID3v2 demuxer

2024-11-27 Thread Tomas Härdin
ons 2024-11-27 klockan 08:34 +0100 skrev Anton Khirnov: > > It's just an essence stream. > > You spent too much time around MXF, consider exorcism. I assume this > piece of jargon means "raw/elementary stream", correct me if I'm > wrong. Blasphemy. But yes, it is MXF parlance for that. It also us

Re: [FFmpeg-devel] ID3v2 demuxer

2024-11-26 Thread Tomas Härdin
sön 2024-11-24 klockan 02:37 +0100 skrev Michael Niedermayer: > Hi > > On Fri, Nov 22, 2024 at 03:50:18PM +0100, Anton Khirnov wrote: > > Quoting Tomas Härdin (2024-11-22 10:51:21) > > > Hi all > > > > > > So after looking at options for how to better

Re: [FFmpeg-devel] ID3v2 demuxer

2024-11-22 Thread Tomas Härdin
fre 2024-11-22 klockan 15:50 +0100 skrev Anton Khirnov: > Quoting Tomas Härdin (2024-11-22 10:51:21) > > Hi all > > > > So after looking at options for how to better deal with ID3v2 I'm > > leaning towards creating a demuxer for it. I'm writing this before

[FFmpeg-devel] ID3v2 demuxer

2024-11-22 Thread Tomas Härdin
Hi all So after looking at options for how to better deal with ID3v2 I'm leaning towards creating a demuxer for it. I'm writing this before going any further with it to get some feedback A proper demuxer would change things up especially for mp3, since a lot of files that now probe as "mp3" with

Re: [FFmpeg-devel] [PATCH 03/15] libaformat/mp3dec: Register the MIME type "audio/mpeg" to the mp3 decoder.

2024-11-20 Thread Tomas Härdin
ons 2024-11-13 klockan 15:28 +0100 skrev Tomas Härdin: > tis 2024-10-29 klockan 15:45 +0100 skrev Tomas Härdin: > > Reasonable enough > > > > Spotify comments > > > > mp3 input misdetected as mpeg ps and fails to decode > > > > Po

Re: [FFmpeg-devel] [REQUEST] Remove me from GA

2024-11-20 Thread Tomas Härdin
tis 2024-11-19 klockan 14:19 + skrev Derek Buitenhuis: > I do not have faith things can improve as long as Fabrice controls > the the trademark and domain name and only speak to Michael I've pointed out before on this list that this is a very low bus factor*. We're going to need a mechanism to

Re: [FFmpeg-devel] [PATCH 04/15] libavcodec/wmadec: Return AVERROR_INVALIDDATA on decoding errors

2024-11-20 Thread Tomas Härdin
> Needs a sample. Actually, returning more sensible errors makes sense on its own even without a sample. However: > @@ -879,8 +881,10 @@ static int wma_decode_superframe(AVCodecContext *avctx, > AVFrame *frame, > return AVERROR_INVALIDDATA; > > if ((s->last_supe

Re: [FFmpeg-devel] [PATCH 13/15] avformat/mov: Add more moov and moov child heuristic checks

2024-11-20 Thread Tomas Härdin
tis 2024-10-29 klockan 15:50 +0100 skrev Tomas Härdin: > This makes me feel we should probably just rely on mfra An update on this: it seems 6.x fixes this issue for Spotify. It seems "-use_mfra_for pts" now does what they need, but I need confirmation on that. If this is the case

Re: [FFmpeg-devel] [PATCH 05/15] libavformat/flacdec: Export samples md5 as metadata

2024-11-20 Thread Tomas Härdin
tis 2024-10-29 klockan 16:01 +0100 skrev Tomas Härdin: > tis 2024-10-29 klockan 11:57 -0300 skrev James Almer: > > On 10/29/2024 11:47 AM, Tomas Härdin wrote: > > > Could maybe use some kind of compile-time assert that > > > FLAC_STREAMINFO_SIZE == MD5_BYTE_SIZE +

Re: [FFmpeg-devel] [PATCH 01/15] libavformat: Increase probe buffer to 16MB

2024-11-18 Thread Tomas Härdin
tor 2024-11-14 klockan 01:26 +0100 skrev Michael Niedermayer: > On Wed, Nov 13, 2024 at 03:26:40PM +0100, Tomas Härdin wrote: > > ons 2024-11-13 klockan 14:40 +0100 skrev Michael Niedermayer: > > > Hi > > > > > > On Tue, Oct 29, 2024 at 03:44:30PM +0100, Tomas

Re: [FFmpeg-devel] [PATCH 03/15] libaformat/mp3dec: Register the MIME type "audio/mpeg" to the mp3 decoder.

2024-11-13 Thread Tomas Härdin
tis 2024-10-29 klockan 15:45 +0100 skrev Tomas Härdin: > Reasonable enough > > Spotify comments > > mp3 input misdetected as mpeg ps and fails to decode > > Possible other solutions: >     • Improve mp3 probe code to give higher score >     • Improve

Re: [FFmpeg-devel] [PATCH 01/15] libavformat: Increase probe buffer to 16MB

2024-11-13 Thread Tomas Härdin
ons 2024-11-13 klockan 14:40 +0100 skrev Michael Niedermayer: > Hi > > On Tue, Oct 29, 2024 at 03:44:30PM +0100, Tomas Härdin wrote: > > Needs a sample. An option or setting for probe size might be a good > > idea > > > > Spotify comments > > --

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mxfenc: Make write_desc return int

2024-11-12 Thread Tomas Härdin
fre 2024-11-08 klockan 11:29 +0100 skrev Tomas Härdin: > Passes fate-mxf Will push in a day or two /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or em

Re: [FFmpeg-devel] [PATCH 11/15] avformat/flacdec:Return correct error-codes on read-failure

2024-11-08 Thread Tomas Härdin
ons 2024-10-30 klockan 11:44 +0100 skrev Tomas Härdin: > I also made some test files to demonstrate the differences in behavior. > What's being addressed here is early termination of the file. One thing > to bikeshed over is whether to return AVERROR_EOF or > AVERROR_INVALIDDATA

Re: [FFmpeg-devel] [RFC] libpostproc splitout

2024-11-08 Thread Tomas Härdin
tor 2024-11-07 klockan 00:11 +0100 skrev Michael Niedermayer: > Hi all > > Should libpostproc be split out into a seperate source repository ? > > Several people did over the years want libpostproc removed, and such > a task was part of the submitted and approved STF 2024 projects. > But when i r

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-11-08 Thread Tomas Härdin
tor 2024-10-31 klockan 20:02 +0100 skrev Marton Balint: > > > On Tue, 29 Oct 2024, Tomas Härdin wrote: > > > tis 2024-10-29 klockan 12:21 -0300 skrev James Almer: > > > > From ce4b1dfb97530b242f899e5d1686f98fa83a7698 Mon Sep 17 00:00:00 > > > > 2001 &

[FFmpeg-devel] [PATCH 2/2] lavf/mxfenc: Return AVERROR(EINVAL) in mxf_write_jpeg2000_subdesc() is pixfmt not set

2024-11-08 Thread Tomas Härdin
Also passes fate-mxf /Tomas From 164175d6f7e2e1eab767c129d953e6e9ebbfc94d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 8 Nov 2024 11:26:24 +0100 Subject: [PATCH 2/2] lavf/mxfenc: Return AVERROR(EINVAL) in mxf_write_jpeg2000_subdesc() is pixfmt not set --- libavform

[FFmpeg-devel] [PATCH 1/2] lavf/mxfenc: Make write_desc return int

2024-11-08 Thread Tomas Härdin
Passes fate-mxf /Tomas From 8f221258a9e5328c4a03fef6e8eab18ce20ce4f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 8 Nov 2024 11:24:05 +0100 Subject: [PATCH 1/2] lavf/mxfenc: Make write_desc return int This enables returning AVERRORs --- libavformat/mxfenc.c | 61 +++

Re: [FFmpeg-devel] [PATCH] lavf/mxfenc: Use nb_components, not av_pix_fmt_count_planes()

2024-11-08 Thread Tomas Härdin
tor 2024-10-31 klockan 09:57 +0100 skrev Tomas Härdin: > tis 2024-10-29 klockan 08:48 -0700 skrev Pierre-Anthony Lemieux: > > LGTM > > Will push later today Wups, forgot to. Pushed now though /Tomas ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] root access voting

2024-11-06 Thread Tomas Härdin
lör 2024-11-02 klockan 12:34 +0100 skrev Michael Niedermayer: > Hi > > At teh current videolan developer days there where several surprise votes on > FFmpegs > infractructure. And to the best of my knowledge no remote participation > and no recording. > > So let me try to reply to the idea of th

Re: [FFmpeg-devel] [RFC] libavutil split out

2024-10-31 Thread Tomas Härdin
tor 2024-10-31 klockan 01:08 +0100 skrev Michael Niedermayer: > Hi > > Theres a problem with libavutil, or maybe more than one > > a library implementing a codec that tries do use libavutil and itself > is > used by libavcodec. Creates a (build) dependancy like this > libavutil -> libmycodec -> l

  1   2   3   4   5   6   7   8   9   10   >