Re: [FFmpeg-devel] [PATCH 2/2] lavfi/showinfo: support regions of interest sidedata

2019-03-09 Thread Thomas Xu
+for (int index = 0; index < nb_rois; index++) { +av_log(ctx, AV_LOG_INFO, "index: %d, region: (%d %d)/(%d %d), qp offset: %d/%d", + index, roi->left, roi->top, roi->right, roi->bottom, roi->qoffset.num, roi->qoffset.den); +} pointer roi never ++, it always point to t

Re: [FFmpeg-devel] avcodec/vaapi_h264: skip decode if pic has no slices

2019-03-09 Thread Thomas Xu
should we return AVERROR_INVALIDDATA instead of -1? thanks On Sat, Mar 9, 2019 at 8:25 PM Peter F wrote: > From 816e9156235a5d7d895b09c0235c9f8f1f7703e7 Mon Sep 17 00:00:00 2001 > From: xbmc > Date: Sat, 26 Jan 2019 19:48:35 +0100 > Subject: [PATCH] avcodec/vaapi_h264: skip decode if pic has no