Hi,
On Tue, Dec 10, 2024, at 19:29, Anton Khirnov wrote:
> Hi,
> Quoting Thomas Guillem via ffmpeg-devel (2024-11-29 11:44:21)
>> avcodec_get_hw_frames_parameters(), called by the user from get_format,
>> is allocating ctx->internal->hwaccel_priv_data. But the hardware
&g
Ping.
On Fri, Nov 29, 2024, at 11:44, Thomas Guillem via ffmpeg-devel wrote:
> avcodec_get_hw_frames_parameters(), called by the user from get_format,
> is allocating ctx->internal->hwaccel_priv_data. But the hardware
> decoding setup may fail on the user side and it may fallb
Sorry for the spam. "avcodec: uninit hwaccel in case of software decoder" is a
better version.
On Fri, Nov 29, 2024, at 09:37, Thomas Guillem via ffmpeg-devel wrote:
> This patch is an alternative to the patch "avcodec: add
> avcodec_reset_hw_frames_parameters():
>
>
avcodec_get_hw_frames_parameters(), called by the user from get_format,
is allocating ctx->internal->hwaccel_priv_data. But the hardware
decoding setup may fail on the user side and it may fallback to software
decoding. In that case, ctx->internal->hwaccel_priv_data is still
allocated but not used
Or you can check the alternative patch: "avcodec/pthread_frame: rework assert"
On Thu, Nov 28, 2024, at 16:57, Thomas Guillem via ffmpeg-devel wrote:
> usage example:
>
> AVBufferRef *hwframes_ref;
> int ret = avcodec_get_hw_frames_parameters
This patch is an alternative to the patch "avcodec: add
avcodec_reset_hw_frames_parameters():
On Fri, Nov 29, 2024, at 09:34, Thomas Guillem via ffmpeg-devel wrote:
> avcodec_get_hw_frames_parameters(), called by the user from get_format,
> is allocating ctx->internal->hwaccel_p
avcodec_get_hw_frames_parameters(), called by the user from get_format,
is allocating ctx->internal->hwaccel_priv_data. But the hardware
decoding setup may fail on the user side and it may fallback to software
decoding. In that case, ctx->internal->hwaccel_priv_data is still
allocated but not used
usage example:
AVBufferRef *hwframes_ref;
int ret = avcodec_get_hw_frames_parameters(ctx, hwdev_ref, hwfmt,
&hwframes_ref);
...
ret = av_hwframe_ctx_init(hwframes_ref);
if (ret < 0)
{
av_buffer_unref(&hwframes_ref);
Happy monthly anniversary to my not very interesting patch.
FYI, OpenSuse applied it for their ffmpeg build...
On Mon, Oct 14, 2024, at 10:54, Thomas Guillem via ffmpeg-devel wrote:
> Ping.
>
> On Mon, Oct 7, 2024, at 17:43, Thomas Guillem via ffmpeg-devel wrote:
>> Fixes the f
Thanks !
On Wed, Oct 30, 2024, at 14:34, Zhao Zhili wrote:
>> On Oct 30, 2024, at 21:19, Thomas Guillem via ffmpeg-devel
>> wrote:
>>
>> Happy monthly anniversary to my not very interesting patch.
>>
>> FYI, OpenSuse applied it for their ffmpeg b
Ping.
On Mon, Oct 7, 2024, at 17:43, Thomas Guillem via ffmpeg-devel wrote:
> Fixes the following assert:
>
> [7f1df83d17e0] vaapi generic error:
> avcodec_get_hw_frames_parameters failed: -22
> Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel &&
> !
Fixes the following assert:
[7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters
failed: -22
Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel &&
!dst->internal->hwaccel_priv_data) failed at libavcodec/pthread_frame.c:349
Reproduced from VLC with VAAPI, when fallbacking
On Mon, Oct 7, 2024, at 17:12, Rémi Denis-Courmont wrote:
> Le 30 septembre 2024 17:27:46 GMT+09:00, Thomas Guillem via
> ffmpeg-devel a écrit :
>>Fixes the following assert:
>>
>>[7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters
>>
Ping.
On Mon, Sep 30, 2024, at 13:44, Thomas Guillem via ffmpeg-devel wrote:
> cf. https://trac.ffmpeg.org/ticket/11013
>
>
> On Mon, Sep 30, 2024, at 10:27, Thomas Guillem via ffmpeg-devel wrote:
>> Fixes the following assert:
>>
>> [7f1
cf. https://trac.ffmpeg.org/ticket/11013
On Mon, Sep 30, 2024, at 10:27, Thomas Guillem via ffmpeg-devel wrote:
> Fixes the following assert:
>
> [7f1df83d17e0] vaapi generic error:
> avcodec_get_hw_frames_parameters failed: -22
> Assertion p_dst->hwaccel_threadsafe
Fixes the following assert:
[7f1df83d17e0] vaapi generic error: avcodec_get_hw_frames_parameters
failed: -22
Assertion p_dst->hwaccel_threadsafe || (!dst->hwaccel &&
!dst->internal->hwaccel_priv_data) failed at libavcodec/pthread_frame.c:349
Reproduced from VLC with VAAPI, when fallbacking
On Tue, Sep 12, 2023, at 15:11, Andreas Rheinhardt wrote:
> Thomas Guillem via ffmpeg-devel:
>> Same than the previous commit but with FF_DECODE_ERROR_DECODE_SLICES
>>
>> Fix the following data-race:
>>
>> WARNING: ThreadSanitizer: data race (pid=55935)
>&
Set the FF_DECODE_ERROR_CONCEALMENT_ACTIVE flags on the AVFrane before
outputing it. Store in in the H264Picture in the meantime, where it
won't be read/write by other threads.
Fix the following data-race:
WARNING: ThreadSanitizer: data race (pid=55134)
Write of size 4 at 0x7b507f78 by thre
Same than the previous commit but with FF_DECODE_ERROR_DECODE_SLICES
Fix the following data-race:
WARNING: ThreadSanitizer: data race (pid=55935)
Write of size 4 at 0x7b509378 by thread T1 (mutexes: write M608):
#0 decode_nal_units src/libavcodec/h264dec.c:742 (ffmpeg+0xb19dd6)
#1 h
This will allow to fix data-races when ff_er_frame_end() is called after
ff_thread_finish_setup()
---
libavcodec/error_resilience.c | 12 ++--
libavcodec/error_resilience.h | 2 +-
libavcodec/h263dec.c | 6 --
libavcodec/h264dec.c | 3 ++-
libavcodec/mpeg12dec.c
20 matches
Mail list logo
