Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-04-07 Thread Thomas Guilbert
ing patch. I also understand if our use case is unusual and that one may assume that s->metadata is always NULL. On Thu, Apr 6, 2017 at 11:32 PM, wm4 wrote: > On Thu, 6 Apr 2017 14:07:53 -0700 > Thomas Guilbert wrote: > > > The patch didn't show up as prope

Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-04-06 Thread Thomas Guilbert
avformat/mp3dec.c @@ -349,6 +349,7 @@ static int mp3_read_header(AVFormatContext *s) int ret; int i; +av_dict_free(&s->metadata); s->metadata = s->internal->id3v2_meta; s->internal->id3v2_meta = NULL; -- 2.12.2.564.g063fe858b8-goog On Fri, Mar 31, 201

[FFmpeg-devel] Fix leaked dictionary in mp3dec

2017-03-31 Thread Thomas Guilbert
Commit '65862f57ad2f7f49d715f334a9d892e0b20d42f1' overwrites s->metada with s->internal->id3v2_meta, which leaks an AVDictionary* if s->metada was not null. Please excuse any formatting problems in this email, this is my first time uploading a patch :) Thank you, Thomas RnJvbSBmY2VkNWFiMGUwOWY1Mj

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Fix hang with slice threads

2017-03-10 Thread Thomas Guilbert
Thank you! On Thu, Mar 9, 2017 at 5:20 PM, Michael Niedermayer wrote: > On Thu, Mar 09, 2017 at 08:17:37PM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Thu, Mar 9, 2017 at 8:12 PM, Michael Niedermayer > > > wrote: > > > > > From: Th