Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Populate packet duration using stts atom instead of guessing

2024-11-21 Thread Thierry Foucu
On Wed, Nov 20, 2024, 7:24 PM James Almer wrote: > From: Darren Mo > > Fixes tickets #7855 and #11312. > > Co-authored-by: James Almer > Signed-off-by: James Almer > --- > This is an alternative, better approach to the same issue. > > libavformat/isom.h| 3 + > l

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: set packet duration in fragmented input

2024-11-21 Thread Thierry Foucu
On Wed, Nov 20, 2024, 12:27 PM James Almer wrote: > From: Thierry Foucu > > Fixes ticket #11312. > > Signed-off-by: James Almer > --- > libavformat/isom.h | 1 + > libavformat/mov.c | 4 > 2 files changed, 5 insertions(+) > > diff --git a/libavformat/is

Re: [FFmpeg-devel] [PATCH] aacdec: padding skip improvements

2023-10-06 Thread Thierry Foucu
ntation is padding 1600 samples. > > - Derek > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpe

Re: [FFmpeg-devel] [RFC PATCH 1/3] aacdec: always skip the first 2048 samples if there's no side data

2023-09-12 Thread Thierry Foucu
fe735b5824c7d10ba42932a17d786db50e3b2d4), and it's only for > faac. > It's less of a guess, as most encoders to use the FIL extension to signal > themselves. > _______ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > htt

[FFmpeg-devel] [PATCH] motion_est: fixed signed_integer_overflow when computing score

2022-11-09 Thread Thierry Foucu
--- libavcodec/motion_est.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index d17ffe42b4..95978d95dd 100644 --- a/libavcodec/motion_est.c +++ b/libavcodec/motion_est.c @@ -1571,7 +1571,7 @@ void ff_estimate_b_frame_motion(Mp

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-28 Thread Thierry Foucu
On Sun, Feb 27, 2022 at 3:54 AM Paul B Mahol wrote: > On Fri, Feb 25, 2022 at 10:08 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 11:50 PM Paul B Mahol wrote: > > > > > On Thu, Feb 24, 2022 at 11:21 PM Thierry Foucu > wrote: > > > > > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-25 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 11:50 PM Paul B Mahol wrote: > On Thu, Feb 24, 2022 at 11:21 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 2:19 PM Thierry Foucu wrote: > > > > > > > > > > > On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote:

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 2:19 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote: > >> On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu wrote: >> >> > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: >> > >> &g

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote: > On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: > > > > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu > wrote: > > > > > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol wrote: > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu wrote: > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol wrote: > > > > > ffmpeg | branch: master | Paul B Mahol | Thu Feb 2

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early

2022-02-24 Thread Thierry Foucu
return AVERROR(ENOMEM); > ___ > ffmpeg-cvslog mailing list > ffmpeg-cvs...@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog > > To unsubscribe, visit link above, or email > ffmpeg-cvslog-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] vf_paletteuse: fix color cache lookup for Bayer dithering mode.

2022-01-14 Thread Thierry Foucu
be, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > -- Thierry Foucu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visi

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

2021-07-27 Thread Thierry Foucu
--- libavcodec/mpeg12dec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index b27ed5bd6d..858dca660c 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1340,9 +1340,11 @@ static int mpeg1_decode_picture(

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

2021-07-27 Thread Thierry Foucu
On Fri, Jul 23, 2021 at 2:13 PM Michael Niedermayer wrote: > On Thu, Jul 22, 2021 at 11:08:51AM -0700, Thierry Foucu wrote: > > --- > > libavcodec/mpeg12dec.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/mpe

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

2021-07-22 Thread Thierry Foucu
--- libavcodec/mpeg12dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index b27ed5bd6d..269619540a 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1341,8 +1341,11 @@ static int mpeg1_decode_picture(AV

Re: [FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

2021-07-22 Thread Thierry Foucu
On Wed, Jul 21, 2021 at 6:19 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Thierry Foucu: > > --- > > libavcodec/mpeg12dec.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/mpeg12dec.c b/liba

Re: [FFmpeg-devel] libavcodec/mpeg12dec.c: Check return value of init_get_bits

2021-07-21 Thread Thierry Foucu
On Mon, Jul 19, 2021 at 3:50 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Thierry Foucu: > > --- > > libavcodec/mpeg12dec.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/mpeg12dec.c b/liba

[FFmpeg-devel] [PATCH] libavcodec/mpeg12dec.c: Switch to init_get_bits8 and checks return value

2021-07-21 Thread Thierry Foucu
--- libavcodec/mpeg12dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index b27ed5bd6d..a786e48054 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1341,8 +1341,11 @@ static int mpeg1_decode_picture(AV

[FFmpeg-devel] libavcodec/mpeg12dec.c: Check return value of init_get_bits

2021-07-19 Thread Thierry Foucu
--- libavcodec/mpeg12dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index b27ed5bd6d..edca202f0e 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -1341,8 +1341,11 @@ static int mpeg1_decode_picture(AV

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-06-14 Thread Thierry Foucu
On Mon, Jun 14, 2021 at 12:09 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Thierry Foucu: > > On Fri, Jun 4, 2021 at 10:18 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Michael Fabian 'Xaymar'

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Allow changing the time stamp precision via option

2021-06-14 Thread Thierry Foucu
000}, > >>> mkv->time_base); > >>> + > >>> if (mkv->is_dash && nb_tracks != 1) > >>> return AVERROR(EINVAL); > >>> @@ -2826,6 +2844,7 @@ static const AVOption options[] = { > >>>

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Thierry Foucu
least) Because in the block header, there is a timestamp relative to Cluster timestamp (signed int16) which cannot represent 3 On Wed, Jan 13, 2021 at 12:02 PM James Almer wrote: > On 1/13/2021 2:46 PM, Thierry Foucu wrote: > > By default the time code scale in a MKV file in millisec

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Thierry Foucu
> have to work around to recover the original timestamp based on framerate > to reduce jitter (mpv does this!). > +1 on this, but I'm worry, we could break a lot of decoder which may not follow the correct timecodescale (Which we found out in our system a while back) > Also

[FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Add option to set timecodescale

2021-01-13 Thread Thierry Foucu
By default the time code scale in a MKV file in millisecond. With this option we can set the time code scale to microsecond or nanoseconds for very high frame rate. --- libavformat/matroskaenc.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskaenc

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-12-03 Thread Thierry Foucu
On Wed, Nov 18, 2020 at 12:09 PM Thierry Foucu wrote: > --- > libavformat/mov.c | 8 ++-- > tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 + > tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov | 1 + > tests/ref/

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-27 Thread Thierry Foucu
ping? On Wed, Nov 18, 2020 at 12:09 PM Thierry Foucu wrote: > --- > libavformat/mov.c | 8 ++-- > tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 + > tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov | 1 + > tes

Re: [FFmpeg-devel] [PATCH] libavformat/avidec: Extract more metadata from the header

2020-11-23 Thread Thierry Foucu
On Wed, Nov 11, 2020 at 7:39 AM Anton Khirnov wrote: > Quoting Thierry Foucu (2020-11-07 00:10:17) > > --- > > libavformat/avidec.c | 17 + > > 1 file changed, 17 insertions(+) > > > > diff --git a/libavformat/avidec.c b/libavformat/avidec.c

[FFmpeg-devel] [PATCH] libavformat/avidec.c: remove duplicated conversion

2020-11-23 Thread Thierry Foucu
ff_riff_info_conv deals with riff metadata already, so, not need to add those metadata in avi_metadata_conv --- libavformat/avidec.c | 8 1 file changed, 8 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 7e527e15ee..75a76b995d 100644 --- a/libavformat/avidec.c

[FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-18 Thread Thierry Foucu
--- libavformat/mov.c | 8 ++-- tests/ref/fate/hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 + tests/ref/fate/hapqa-extract-nosnappy-to-hapq-mov | 1 + tests/ref/fate/mov-zombie | 2 +- tests/ref/fate/rgb24-mkv

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-18 Thread Thierry Foucu
On Wed, Nov 18, 2020 at 10:56 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Thierry Foucu: > > --- > > libavformat/mov.c | 24 +-- > > ...hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 + > > .../fa

[FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-18 Thread Thierry Foucu
--- libavformat/mov.c | 24 +-- ...hapqa-extract-nosnappy-to-hapalphaonly-mov | 1 + .../fate/hapqa-extract-nosnappy-to-hapq-mov | 1 + tests/ref/fate/mov-zombie | 2 +- tests/ref/fate/rgb24-mkv | 4 ++-- 5

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-18 Thread Thierry Foucu
On Wed, Nov 18, 2020 at 12:30 AM Gyan Doshi wrote: > > > On 18-11-2020 12:16 pm, Thierry Foucu wrote: > > On Tue, Nov 17, 2020 at 9:54 PM Gyan Doshi wrote: > > > >> > >> On 18-11-2020 02:41 am, Thierry Foucu wrote: > >>> --- > >>>

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-17 Thread Thierry Foucu
On Tue, Nov 17, 2020 at 9:54 PM Gyan Doshi wrote: > > > On 18-11-2020 02:41 am, Thierry Foucu wrote: > > --- > > libavformat/mov.c | 24 ++-- > > 1 file changed, 22 insertions(+), 2 deletions(-) > > > > diff --git a/libavfor

[FFmpeg-devel] [PATCH] libavformat/mov.c: export vendor id as metadata

2020-11-17 Thread Thierry Foucu
--- libavformat/mov.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2b90e31170..1f9163d658 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2095,6 +2095,8 @@ static void mov_parse_stsd_video(MOVCo

[FFmpeg-devel] [PATCH] libavformat/matroskaenc: move a warning log to debug log

2020-11-06 Thread Thierry Foucu
At high frame rate, the message "Starting new cluster due to timestamp" happens too often. Moving to debug to reduce the warning log --- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 233c472

[FFmpeg-devel] [PATCH] libavformat/avidec: Extract more metadata from the header

2020-11-06 Thread Thierry Foucu
--- libavformat/avidec.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 578cf68ce1..7e527e15ee 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -110,6 +110,15 @@ static const char avi_headers[][8] = { stati

Re: [FFmpeg-devel] [PATCH] libavformat/rmdec.c: Fix Use-of-uninitialized-value in ff_codec_get_id

2020-09-16 Thread Thierry Foucu
On Mon, Sep 14, 2020 at 10:49 AM Thierry Foucu wrote: > In case the pb does not contain 4 bytes, the buf[256] will not be > initialize before we pass it to ff_codec_get_id > --- > libavformat/rmdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

[FFmpeg-devel] [PATCH] libavformat/rmdec.c: Fix Use-of-uninitialized-value in ff_codec_get_id

2020-09-14 Thread Thierry Foucu
In case the pb does not contain 4 bytes, the buf[256] will not be initialize before we pass it to ff_codec_get_id --- libavformat/rmdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index a36e693ab2..220aa8aee2 100644 --- a/libavfor

[FFmpeg-devel] [PATCH] libavformat/ffmetadecc.c: Fix Use-of-uninitialized-value

2020-08-20 Thread Thierry Foucu
Check the return value of sscanf as it can return -1(EOF), for example when the first char in the line is 0x00 --- libavformat/ffmetadec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/ffmetadec.c b/libavformat/ffmetadec.c index 45c92f1ff6..0ea89fe3f3 10064

[FFmpeg-devel] [PATCH] libavformat/r3d.c: Fix Use-of-uninitialized-value in filename.

2020-08-19 Thread Thierry Foucu
While reading the filename tag, it mays return a EOF and we are still copying the file with uninitialized value. --- libavformat/r3d.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/r3d.c b/libavformat/r3d.c index 7aa0c5a2c3..d013b8c30e 100644 --- a/libavformat

[FFmpeg-devel] [PATCH] libavformat/r3d.c: Fix Use-of-uninitialized-value in filename.

2020-08-19 Thread Thierry Foucu
While reading the filename tag, it mays return a EOF and we are still copying the file with uninitialized value. --- libavformat/r3d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/r3d.c b/libavformat/r3d.c index 7aa0c5a2c3..7ba589530d 100644 --- a/libavformat/r3d

Re: [FFmpeg-devel] [PATCH] avformat/mpeg: Check avio_read() return value in get_pts()

2020-08-14 Thread Thierry Foucu
On Fri, Aug 14, 2020, 4:08 PM Michael Niedermayer wrote: > Found-by: Thierry Foucu > Fixes: Use-of-uninitialized-value > Signed-off-by: Michael Niedermayer > --- > libavformat/mpeg.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfor

[FFmpeg-devel] [PATCH] libavformat/mpeg.c: Initialize the buffer uses to read the PTS.

2020-08-13 Thread Thierry Foucu
Fixed an Use-of-uninitialized-value --- libavformat/mpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index 265b2bd1ad..15a768e6e8 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -146,7 +146,7 @@ static int mpegps_read_he

Re: [FFmpeg-devel] Create and populate AVStream side data packet with contents of ISOBMFF edit list entries

2020-07-29 Thread Thierry Foucu
> > > > +/** > > + * ISO media file edit list side data packet > > + * The structure is repeated for each entry in the edit list > > + * The number of entries can be calculated > > + * by dividing the packet size by the entry size > >

Re: [FFmpeg-devel] [PATCH] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
On Thu, Jun 4, 2020 at 11:52 AM James Almer wrote: > On 6/4/2020 3:40 PM, Thierry Foucu wrote: > > target_dec_fuzzer is checking for the avpkt.data pointer but if the > > png parser cannot combine the frame, the poutbuf is not set and so, the > > avpkt.da

[FFmpeg-devel] [PATCH 3/3] libavcodec/bmp_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
the target_dec_fuzzer is checking for the avpkt.data pointer but if the bmp parser cannot combine the frame, the poutbuf is not set. --- libavcodec/bmp_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/bmp_parser.c b/libavcodec/bmp_parser.c index cd65f02a2e..700bf27af1 100644

[FFmpeg-devel] [PATCH 2/3] libavcodec/mlp_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
the target_dec_fuzzer is checking for the avpkt.data pointer but if the mlp parser cannot combine the frame, the poutbuf is not set. --- libavcodec/mlp_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mlp_parser.c b/libavcodec/mlp_parser.c index 5d2ddc5a70..e7162f4aa8 100644

[FFmpeg-devel] [PATCH 1/3] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
the target_dec_fuzzer is checking for the avpkt.data pointer but if the png parser cannot combine the frame, the poutbuf is not set. --- libavcodec/png_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/png_parser.c b/libavcodec/png_parser.c index 74f2964118..9ec8551a1b 100644

[FFmpeg-devel] [PATCH] libavcodec/png_parser.c: fix a use_of_uninitialized_value in target_dec_fuzzer.

2020-06-04 Thread Thierry Foucu
target_dec_fuzzer is checking for the avpkt.data pointer but if the png parser cannot combine the frame, the poutbuf is not set and so, the avpkt.data is not initialized. --- libavcodec/png_parser.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/png_parser.c b/l

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-15 Thread Thierry Foucu
On Thu, May 14, 2020 at 12:26 PM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 14/05/2020 18:19, Thierry Foucu wrote: > > Looking at > > > https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/Metadata/Metadata.html > > The spec does

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-14 Thread Thierry Foucu
On Thu, May 14, 2020 at 5:09 AM Derek Buitenhuis wrote: > On 11/05/2020 17:35, Thierry Foucu wrote: > > If you have a file with multiple Metadata Keys, the second time you parse > > the keys, you will re-alloc c->meta_keys without freeing the old one. > > This change wi

Re: [FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-13 Thread Thierry Foucu
On Mon, May 11, 2020 at 9:35 AM Thierry Foucu wrote: > If you have a file with multiple Metadata Keys, the second time you parse > the keys, you will re-alloc c->meta_keys without freeing the old one. > This change will avoid parsing all the consecutive Metadata keys. > --- >

[FFmpeg-devel] [PATCH] [libavformat/mov.c] Read the QT Metadata Keys only once

2020-05-11 Thread Thierry Foucu
If you have a file with multiple Metadata Keys, the second time you parse the keys, you will re-alloc c->meta_keys without freeing the old one. This change will avoid parsing all the consecutive Metadata keys. --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

[FFmpeg-devel] [PATCH] [libavformat/moc.c] Read the QT Metadata Keys only once

2020-05-07 Thread Thierry Foucu
If you have a file with multiple Metadata Keys, the second time you parse the keys, you will re-alloc c->meta_keys without freeing the old one. This change will avoid parsing all the consecutive Metadata keys. --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

Re: [FFmpeg-devel] [PATCH 1/9] libavutil: add API for exporting video frame quantizers

2020-05-07 Thread Thierry Foucu
n/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thierry Foucu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavc/sbc: Remove bool usage

2020-04-02 Thread Thierry Foucu
On Thu, Apr 2, 2020 at 11:18 AM Thierry Foucu wrote: > > > On Thu, Apr 2, 2020 at 11:11 AM Derek Buitenhuis < > derek.buitenh...@gmail.com> wrote: > >> On 02/04/2020 17:47, Moritz Barsnick wrote: >> > I though this was the practical argument?: >> >

Re: [FFmpeg-devel] [PATCH]lavc/sbc: Remove bool usage

2020-04-02 Thread Thierry Foucu
(Sorry, I am not familiar with PPC...) > > - Derek > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmp

Re: [FFmpeg-devel] [PATCH]lavc/sbc: Remove bool usage

2020-04-01 Thread Thierry Foucu
; > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thierry Foucu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Check if we can seek before writing the end of the ebml of the segment.

2020-03-12 Thread Thierry Foucu
Thanks Andreas On Wed, Mar 11, 2020 at 5:35 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Thierry Foucu: > > On Wed, Mar 11, 2020 at 10:13 AM Andreas Rheinhardt < > > andreas.rheinha...@gmail.com> wrote: > > > >> Thierry Foucu: >

[FFmpeg-devel] [PATCH] configure: Add llviddsp to mvha select

2020-03-12 Thread Thierry Foucu
--- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 8b17134944..6ceb0c7af4 100755 --- a/configure +++ b/configure @@ -2791,6 +2791,7 @@ msmpeg4v3_encoder_select="h263_encoder" mss2_decoder_select="mpegvideo qpeldsp vc1_decoder" mts2_decoder_select="mss34

Re: [FFmpeg-devel] [PATCH] configure: Add llviddsp to mvha deps

2020-03-12 Thread Thierry Foucu
___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thierry Foucu

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Check if we can seek before writing the end of the ebml of the segment.

2020-03-11 Thread Thierry Foucu
On Wed, Mar 11, 2020 at 10:13 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Thierry Foucu: > > --- > > libavformat/matroskaenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/matroskaenc.

[FFmpeg-devel] [PATCH] configure: Add llviddsp to mvha deps

2020-03-10 Thread Thierry Foucu
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8b17134944..2d2e4d8817 100755 --- a/configure +++ b/configure @@ -2790,7 +2790,7 @@ msmpeg4v3_decoder_select="h263_decoder" msmpeg4v3_encoder_select="h263_encoder" mss2_decoder_select="m

[FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: Check if we can seek before writing the end of the ebml of the segment.

2020-03-10 Thread Thierry Foucu
--- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 42f21eae8b..cf436f9e3e 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -2630,7 +2630,7 @@ static int mkv_write_tra

Re: [FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

2020-02-26 Thread Thierry Foucu
n-Baptiste Kempf - President > +33 672 704 734 > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-03 Thread Thierry Foucu
On Fri, Jan 3, 2020 at 1:56 PM Nicolas George wrote: > Thierry Foucu (12020-01-03): > > So, right now, we cannot build ffmpeg with optimization on Mac Os 10.15. > > Can't you pass the option as extra-cflags to configure? It should work, > until a proper fix is proposed

Re: [FFmpeg-devel] [PATCH] Workaround to build ffmpeg on MacOs 10.15

2020-01-03 Thread Thierry Foucu
> To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- --- Thierry Foucu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo

[FFmpeg-devel] [PATCH] [libdav1d.c]: Add options for spatial layers.

2019-11-27 Thread Thierry Foucu
Disable by default to output all the layers, to match libaomdec wrapper. Add option to select the operating point for the spatial layers. Update the documentation with the new options. --- doc/decoders.texi | 6 ++ libavcodec/libdav1d.c | 8 2 files changed, 14 insertions(+) diff

Re: [FFmpeg-devel] [PATCH] [libdav1d.c]: Add options for spatial layers.

2019-11-27 Thread Thierry Foucu
On Wed, Nov 27, 2019 at 4:02 PM James Almer wrote: > On 11/27/2019 9:00 PM, Moritz Barsnick wrote: > > On Wed, Nov 27, 2019 at 09:21:28 -0800, Thierry Foucu wrote: > >> +@item oppoint > >> +Select an operating point of a scalable AV1 bitstream (0 - 32) > > [...

[FFmpeg-devel] [PATCH] [libdav1d.c]: Add options for spatial layers.

2019-11-27 Thread Thierry Foucu
Disable by default to output all the layers, to match libaomdec wrapper. Add option to select the operating point for the spatial layers. Update the documentation with the new options. --- doc/decoders.texi | 6 ++ libavcodec/libdav1d.c | 8 2 files changed, 14 insertions(+) diff

Re: [FFmpeg-devel] [PATCH] [libdav1d.c]: Add options for spatial layers.

2019-11-25 Thread Thierry Foucu
On Wed, Nov 20, 2019 at 9:55 AM Thierry Foucu wrote: > > > On Thu, Nov 14, 2019 at 9:36 AM Thierry Foucu wrote: > >> Disable by default to output all the layers, to match libaomdec wrapper. >> Add option to select the operating point for the spatial layers. >> ---

Re: [FFmpeg-devel] [PATCH] [libdav1d.c]: Add options for spatial layers.

2019-11-20 Thread Thierry Foucu
On Thu, Nov 14, 2019 at 9:36 AM Thierry Foucu wrote: > Disable by default to output all the layers, to match libaomdec wrapper. > Add option to select the operating point for the spatial layers. > --- > libavcodec/libdav1d.c | 8 > 1 file changed, 8 insertions(+) &

Re: [FFmpeg-devel] [PATCH] [libdav1d.c]: Add option to output all the spatial layers.

2019-11-14 Thread Thierry Foucu
On Thu, Nov 14, 2019 at 11:33 AM Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 14, 2019 at 2:12 PM Andrey Semashev > > wrote: > > > I think there needs to be some consistency across different lavc > > decoders. If we consider that lavc should produce one decoded frame per > > one encoded one, ev

[FFmpeg-devel] [PATCH] [libdav1d.c]: Add options for spatial layers.

2019-11-14 Thread Thierry Foucu
Disable by default to output all the layers, to match libaomdec wrapper. Add option to select the operating point for the spatial layers. --- libavcodec/libdav1d.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index cf4b178f1d..ea4ef641bf

Re: [FFmpeg-devel] [PATCH] [libdav1d.c]: Add option to output all the spatial layers.

2019-11-14 Thread Thierry Foucu
On Thu, Nov 14, 2019 at 9:20 AM James Almer wrote: > On 11/14/2019 2:15 PM, Thierry Foucu wrote: > > Set the option to false by default, to match libaomdec wrapper. > > --- > > libavcodec/libdav1d.c | 4 > > 1 file changed, 4 insertions(+) > > > &g

[FFmpeg-devel] [PATCH] [libdav1d.c]: Add option to output all the spatial layers.

2019-11-14 Thread Thierry Foucu
Set the option to false by default, to match libaomdec wrapper. --- libavcodec/libdav1d.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index cf4b178f1d..5efa8eeb48 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/libdav1d.c @@ -40,6 +40,7

Re: [FFmpeg-devel] [PATCH 2/2] [monvenc] Add extra padding when allocating trk->vos_data

2019-09-26 Thread Thierry Foucu
On Thu, Sep 26, 2019 at 11:00 AM James Almer wrote: > On 9/26/2019 2:58 PM, Thierry Foucu wrote: > > trk->vos_data is mostly used to store the extradata from the codec. > > Most encoder when storing their extradata, are allocating with padding. > > But the current code

Re: [FFmpeg-devel] [PATCH] aformat/movenc: add missing padding to output track extradata

2019-09-26 Thread Thierry Foucu
On Wed, Sep 25, 2019 at 10:30 AM James Almer wrote: > Fixes ticket #8183. > > Signed-off-by: James Almer > --- > libavformat/movenc.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index c824ff5ba1..e328387

[FFmpeg-devel] [PATCH 2/2] [monvenc] Add extra padding when allocating trk->vos_data

2019-09-26 Thread Thierry Foucu
trk->vos_data is mostly used to store the extradata from the codec. Most encoder when storing their extradata, are allocating with padding. But the current code was ignoring the padding, which could causes heap-buffer-overflow --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: Avoid inlink fifo build up.

2019-09-08 Thread Thierry Foucu
ping? On Wed, Aug 28, 2019 at 7:14 PM Nikolas Bowe wrote: > When duplicating frames we need to schedule for activation again, > otherwise frames can build up in the inlink fifo. > --- > libavfilter/vf_fps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_

Re: [FFmpeg-devel] [PATCH] [cbs_h2645]: Used av_realloc instead of av_malloc

2019-08-28 Thread Thierry Foucu
On Tue, Aug 27, 2019 at 6:39 AM Paul B Mahol wrote: > Probably OK > Thanks Paul. Any change to have someone to push it? Cheers > > On Mon, Aug 26, 2019 at 10:51 PM Thierry Foucu wrote: > > > Follow the description of av_realloc, the memory needs to be alloca

[FFmpeg-devel] [PATCH] [cbs_h2645]: Used av_realloc instead of av_malloc

2019-08-26 Thread Thierry Foucu
Follow the description of av_realloc, the memory needs to be allocated by av_realloc. --- libavcodec/cbs_h2645.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 69ea6dc6bb..8da8421e47 100644 --- a/libavcodec/cbs_h2645.c +++

[FFmpeg-devel] [PATCH] Check if we do have also a filter_complex filter.

2019-03-27 Thread Thierry Foucu
Right now, the code check for no filter description, but if we use a filter_complex, the code will use the AVFrame.duration which could be wrong in case of using fps filter. How to reproduce the problem: ffmpeg -f lavfi -i testsrc=duration=1 -vf fps=fps=50 -vsync 1 -f null - output 50 frames ffmp

Re: [FFmpeg-devel] [PATCH] libaomenc: Add support for tiles

2018-10-26 Thread Thierry Foucu
On Mon, Oct 22, 2018 at 3:45 PM Mark Thompson wrote: > Adds an option to specify the number of tile rows and columns, then uses > a uniform tiling if possible and otherwise a fixed tiling with equal-sized > tiles to fill the frame. > > Also adds -tile-columns and -tile-rows options to make tiling

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-26 Thread Thierry Foucu
On Wed, Oct 24, 2018 at 4:02 AM Rostislav Pehlivanov wrote: > On Sat, 20 Oct 2018 at 00:50, James Almer wrote: > > > Originally written by Ronald S. Bultje, with fixes, optimizations and > > improvements by James Almer. > > > > Signed-off-by: James Almer > > --- > > Updated to work with libdav1

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

2017-11-14 Thread Thierry Foucu
On Tue, Nov 14, 2017 at 3:23 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 11/14/2017 10:11 PM, Sasi Inguva wrote: > > I don't know if the patch can be made more generic to work for all > > demuxers, because this patch requires that PTS of all packets be > available > > in the hea

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
On Wed, Oct 25, 2017 at 4:36 PM, Michael Niedermayer wrote: > On Wed, Oct 25, 2017 at 04:21:28PM -0700, Thierry Foucu wrote: > > On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos > > wrote: > > > > > 2017-10-25 20:38 GMT+02:00 Thierry Foucu : > > > >

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
On Wed, Oct 25, 2017 at 2:43 PM, Carl Eugen Hoyos wrote: > 2017-10-25 20:38 GMT+02:00 Thierry Foucu : > > > Without the patch, the decoder will return only 29 frames > > Isn't that the correct and expected output? > Not sure what you mean by correct. There are only 29

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
On Wed, Oct 25, 2017 at 4:59 AM, Michael Niedermayer wrote: > On Tue, Oct 24, 2017 at 06:42:54PM -0700, Thierry Foucu wrote: > > Changed the return value when no VOD were encoded in Mpeg4 bistream. > > And if we do have already a decoded frames and we are not in xvid_packed >

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-25 Thread Thierry Foucu
Derek, On Wed, Oct 25, 2017 at 9:43 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 10/25/2017 2:42 AM, Thierry Foucu wrote: > > Changed the return value when no VOD were encoded in Mpeg4 bistream. > > And if we do have already a decoded frames and we a

[FFmpeg-devel] (no subject)

2017-10-24 Thread Thierry Foucu
Michael, the following patch seems to work. I restricted the change to N_VOP (from xvid) frame. I tried to match it with what the xvidcore decoder does for such packets. What do you think? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://

[FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-24 Thread Thierry Foucu
Changed the return value when no VOD were encoded in Mpeg4 bistream. And if we do have already a decoded frames and we are not in xvid_packed mode, output the existing decoded frame instead of nothing. --- libavcodec/h263dec.c | 9 - libavcodec/mpeg4videodec.c | 2 +- libavcodec/mpeg

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-24 Thread Thierry Foucu
Michael, what do you think of this patch? I tried to reflect what the xvid decoder does for those N_VOP frame and in case it is not packed. On Tue, Oct 24, 2017 at 6:42 PM, Thierry Foucu wrote: > Changed the return value when no VOD were encoded in Mpeg4 bistream. > And if we d

Re: [FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Thierry Foucu
On Thu, Oct 19, 2017 at 3:43 PM, Michael Niedermayer wrote: > On Thu, Oct 19, 2017 at 09:51:05AM -0700, Thierry Foucu wrote: > > Instead of returning nothing when we detect the xvid skipped frame, we > > could return the last decoded frame, if we do have one. > > FRAME_SKIP

[FFmpeg-devel] [PATCH] libavcodec/h263dec.c: Duplicate the last decoded frame when xvid marks the packet as skipped.

2017-10-19 Thread Thierry Foucu
Instead of returning nothing when we detect the xvid skipped frame, we could return the last decoded frame, if we do have one. --- libavcodec/h263dec.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/h263dec.c b/libavcodec/h263dec.c index bcb2b08bb0..e1667bcb

[FFmpeg-devel] [PATCH 2/2] vf_fps: Fix memory leak introduced by eea64ef4

2017-09-15 Thread Thierry Foucu
--- libavfilter/vf_fps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 09fc66a73c..1e5d07e31c 100644 --- a/libavfilter/vf_fps.c +++ b/libavfilter/vf_fps.c @@ -171,6 +171,7 @@ static int request_frame(AVFilterLink *outlink)

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-15 Thread Thierry Foucu
On Fri, Sep 15, 2017 at 8:24 AM, Carl Eugen Hoyos wrote: > 2017-09-15 17:13 GMT+02:00 Thierry Foucu : > > >> Too fast to reply again, my bad. It's indeed a GCC bug. > > > > Sorry about it. I'm glad you found the problem. > > I suspect the comment above

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-15 Thread Thierry Foucu
p 15, 2017 at 02:44:59AM +0200, Michael Niedermayer wrote: > > > >> On Tue, Sep 12, 2017 at 06:45:57PM -0700, Thierry Foucu wrote: > > > >>> Fix ticket #2674 > > > >>> Tested with examples from ticket 2674. > > > >>> ---

Re: [FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-14 Thread Thierry Foucu
On Tue, Sep 12, 2017 at 6:45 PM, Thierry Foucu wrote: > Fix ticket #2674 > Tested with examples from ticket 2674. > --- > Sorry Michael, I forgot to configure using --enable-gpl. > Please find new patch. > > > ping? > libavfilte

[FFmpeg-devel] [PATCH] vf_fps: when reading EOF, using current_pts to duplicate the last frame if needed.

2017-09-12 Thread Thierry Foucu
Fix ticket #2674 Tested with examples from ticket 2674. --- Sorry Michael, I forgot to configure using --enable-gpl. Please find new patch. libavfilter/vf_fps.c | 44 +++- tests/ref/fate/filter-fps| 6 ++ tests/ref/fate/filter-fps-r

  1   2   >