2020年8月6日(木) 19:39 Jan Ekström :
>
> Cheers. Applied as cc6c56f5d900f86167f6592215e613a69341858a .
>
> Thanks for noticing that this was broken and sending out a patch.
It's my pleasure!
> > > P.S. Top-posting is frowned upon on this mailing list, so please reply
> > > in-line or underneath in th
2020年8月6日(木) 7:24 Jan Ekström :
>
> Sorry, decided to take a look at the logic but didn't have the time to
> actually test it locally.
Thank you for replying. It sounds good for me.
> I have now tested it locally and it works as expected with the
> following test cases:
> and chromaoffset 0 (sti
Thank you for the review!
It is my first time to send a patch. So I was relieved to hear that.
Is it OK to wait to merge?
Best Regards,
Takio
2020年8月5日(水) 6:00 Jan Ekström :
>
> On Tue, Jul 28, 2020 at 3:30 PM Takio Yamaoka wrote:
> >
> > An initial value of `AVCodecContext
Hi devel,
Is there anyone who can review this?
Thanks,
Takio
2020年7月28日(火) 21:42 Takio Yamaoka :
>
> I forgot to sign-off to patch, so I've resent the same patch.
> This patch is bug fix to handle chromaoffset parameter for libx264.
>
> Best Regards,
> Takio
>
> 2020
I forgot to sign-off to patch, so I've resent the same patch.
This patch is bug fix to handle chromaoffset parameter for libx264.
Best Regards,
Takio
2020年7月28日(火) 21:22 Takio Yamaoka :
>
> An initial value of `AVCodecContext::chromaoffset` is zero,
> then it causes to block
number.
To fix above, it changes ...
- a value of `X264Context::chroma_offset` to 0 as no setting
- due to x264's default value
- conditional statement to import `-chromaoffset`
Signed-off-by: Takio Yamaoka
---
libavcodec/libx264.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
An initial value of `AVCodecContext::chromaoffset` is zero,
then it causes to block `-chromaoffset` setting as result.
In addition, even though a negative number of `chromaoffset`
is meaningful, `X264Context::chroma_offset` is initialized
with `-1` as no setting and ignored if it is negative number
