Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated

2025-07-29 Thread Steven Liu
Cai Fan 于2025年7月30日 周三11:43写道: > Signed-off-by: Cai Fan > --- > libavformat/img2enc.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c > index 41638d92b8..f7d983ec54 100644 > --- a/libavformat/img2enc.c > +++ b/libavformat/img2enc.c > @@

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated

2025-07-29 Thread Steven Liu
Cai Fan 于2025年7月29日周二 10:23写道: > > Signed-off-by: Cai Fan > --- > libavformat/img2enc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c > index 672cfe18fd..f7d983ec54 100644 > --- a/libavformat/img2enc.c > +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated

2025-07-28 Thread Steven Liu
Cai Fan 于2025年7月28日周一 11:45写道: > > Signed-off-by: Cai Fan > --- > libavformat/img2enc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c > index 41638d92b8..672cfe18fd 100644 > --- a/libavformat/img2enc.c > +++ b/libavformat/img2enc.c > @

Re: [FFmpeg-devel] [PATCH v4 01/11] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-07-21 Thread Steven Liu
Jack Lau 于2025年7月21日周一 19:30写道: > > mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, > preventing “No route to host” errors on devices without IPv6 connectivity. > > Signed-off-by: Jack Lau > --- > libavformat/whip.c | 17 - > 1 file changed, 16 insertions(+), 1 de

Re: [FFmpeg-devel] [PATCH v4 02/11] avformat/whip: fix typos

2025-07-21 Thread Steven Liu
Jack Lau 于2025年7月21日周一 19:31写道: Hi Jack, > > Remove redundant "WHIP: " prefix in log context > since it already add whip context. > > Fix grammers in whip options descriptions > > Signed-off-by: Jack Lau > --- > libavformat/whip.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/volume: add volume scaling utilities.

2025-07-21 Thread Steven Liu
于2025年7月21日周一 20:13写道: > > From: zhanquan cen Hi Zhanquan Cen, > > --- > volume.c | 168 +++ > volume.h | 44 +++ > 2 files changed, 212 insertions(+) > create mode 100644 volume.c > create mode 100644 volume.h > > diff --git a/v

Re: [FFmpeg-devel] [POLL] [VOTE] code.ffmpeg.org

2025-07-13 Thread Steven Liu
Marvin Scholz 于2025年7月14日周一 06:22写道: > > F (see below for my reasoning) F. looks reasonable > > While I would be fine with either outcome, and had helped extensively for the > GitLab migration of VLC and at that time was quite convinced its the best > solution > out there, my opinion on this has

Re: [FFmpeg-devel] [PATCH v2 3/4] avformat/tls_openssl: remove all redundant "TLS: " in log with AVClass

2025-07-11 Thread Steven Liu
Jack Lau 于2025年7月11日周五 21:22写道: > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index ffd9cd51d2..a519c8c880 100644 > --- a/libavf

Re: [FFmpeg-devel] [PATCH v2 2/4] avformat/tls_openssl: fix dtls_handshake return code

2025-07-11 Thread Steven Liu
Jack Lau 于2025年7月11日周五 21:22写道: > > If the handshake is still in progress, dtls_handshake should > return a positive status code. > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavformat/tls_openssl.

Re: [FFmpeg-devel] [PATCH v2 1/4] avformat/tls_openssl: add record trace function

2025-07-11 Thread Steven Liu
Jack Lau 于2025年7月11日周五 21:21写道: > > Signed-off-by: Jack Lau > --- > libavformat/tls_openssl.c | 51 +-- > 1 file changed, 49 insertions(+), 2 deletions(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index 2a01fb387d..8639ac9758 100

Re: [FFmpeg-devel] [RFC PATCH] avformat: remove HLS protocol

2025-07-09 Thread Steven Liu
Steven Liu 于2025年7月10日周四 04:42写道: > > > > Timo Rothenpieler 于2025年7月9日 周三23:33写道: >> >> On 7/9/2025 3:28 PM, Marvin Scholz wrote: >> > >> > >> > On 9 Jul 2025, at 11:18, Steven Liu wrote: >> > >> >> Marvin Scholz 于2025年7月9日周

Re: [FFmpeg-devel] [RFC PATCH] avformat: remove HLS protocol

2025-07-09 Thread Steven Liu
Timo Rothenpieler 于2025年7月9日 周三23:33写道: > On 7/9/2025 3:28 PM, Marvin Scholz wrote: > > > > > > On 9 Jul 2025, at 11:18, Steven Liu wrote: > > > >> Marvin Scholz 于2025年7月9日周三 03:14写道: > >> Hi Marvin, > >> > >>> > >>&g

Re: [FFmpeg-devel] [RFC PATCH] avformat: remove HLS protocol

2025-07-09 Thread Steven Liu
Marvin Scholz 于2025年7月9日周三 03:14写道: Hi Marvin, > > The use of this protocol was already discouraged and warned about > for years with the recommendation to use the HLS demuxer instead. What about make deprecated warning to users and remove it next major version? > --- > doc/protocols.texi |

Re: [FFmpeg-devel] [PATCH 12/18] avformat/udp: separate rx and tx fifo

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 01:04写道: > > --- > libavformat/udp.c | 49 +++ > 1 file changed, 28 insertions(+), 21 deletions(-) > > diff --git a/libavformat/udp.c b/libavformat/udp.c > index 7d64ff07ed..e02eff0f33 100644 > --- a/libavformat/udp.c > ++

Re: [FFmpeg-devel] [PATCH 10/18] avformat/tls: fix udp init

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 01:09写道: > > --- > libavformat/tls.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/libavformat/tls.c b/libavformat/tls.c > index f888970969..bd9c05e6dc 100644 > --- a/libavformat/tls.c > +++ b/libavformat/tls.c > @@ -81,7 +81,

Re: [FFmpeg-devel] [PATCH 09/18] avformat/udp: don't override 0 localport

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 01:09写道: > > --- > libavformat/udp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/udp.c b/libavformat/udp.c > index c1ebdd1222..30f075de8e 100644 > --- a/libavformat/udp.c > +++ b/libavformat/udp.c > @@ -780,7 +780,7 @@ static

Re: [FFmpeg-devel] [PATCH 07/18] avformat/tls: don't use http_proxy for udp sockets

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 01:09写道: > > --- > libavformat/tls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/tls.c b/libavformat/tls.c > index 018b24cd48..5ec4cca58a 100644 > --- a/libavformat/tls.c > +++ b/libavformat/tls.c > @@ -114,7 +114,7 @@ int ff

Re: [FFmpeg-devel] [PATCH 06/18] avformat/tls: use non protocol specific error message

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 00:59写道: > > --- > libavformat/tls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/tls.c b/libavformat/tls.c > index da53835200..018b24cd48 100644 > --- a/libavformat/tls.c > +++ b/libavformat/tls.c > @@ -137,7 +137,7 @@ int ff

Re: [FFmpeg-devel] [PATCH 05/18] avformat/whip: fix format string for printing size_t

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 00:59写道: > > --- > libavformat/whip.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 7cd3f48ba9..71c667cd31 100644 > --- a/libavformat/whip.c > +++ b/libavformat/whip.c > @@ -926,7 +926,

Re: [FFmpeg-devel] [PATCH 04/18] avformat/whip: remove redundant WHIP: prefix from all logging

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 00:58写道: > > --- > libavformat/whip.c | 150 ++--- > 1 file changed, 75 insertions(+), 75 deletions(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index a1cf8aff1b..7cd3f48ba9 100644 > --- a/libavformat/whip.c >

Re: [FFmpeg-devel] [PATCH 03/18] avformat/whip: don't leak options dict

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 00:57写道: > > --- > libavformat/whip.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index a6cdccc21c..a1cf8aff1b 100644 > --- a/libavformat/whip.c > +++ b/libavformat/whip.c > @@ -1303,6 +1303,7 @@ next_packet: >

Re: [FFmpeg-devel] [PATCH 02/18] avformat/whip: use av_dict_set_int for int

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 00:57写道: > > --- > libavformat/whip.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 5fdbd6949d..a6cdccc21c 100644 > --- a/libavformat/whip.c > +++ b/libavformat/whip.c > @@ -1221,7 +

Re: [FFmpeg-devel] [PATCH 01/18] avformat/Makefile: don't hardcode openssl for whip muxer

2025-07-03 Thread Steven Liu
Timo Rothenpieler 于2025年7月3日周四 00:57写道: > > --- > libavformat/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/Makefile b/libavformat/Makefile > index 2e73f1325e..816eb9be4a 100644 > --- a/libavformat/Makefile > +++ b/libavformat/Makefile > @@ -639,7 +

Re: [FFmpeg-devel] [PATCH v2 5/6] avformat/whip: implement NACK and RTX suppport

2025-07-02 Thread Steven Liu
Jack Lau 于2025年7月2日周三 20:09写道: > > RTP retransmission described in RFC4588 (RTX) is an effective packet > loss recovery technique for real-time applications with relaxed delay bounds. > > This patch provides a minimal implementation for RTX and RTCP NACK (RFC3940) > and its associated SDP signalin

Re: [FFmpeg-devel] [PATCH 6/6] avformat/whip: implement NACK and RTX suppport

2025-07-01 Thread Steven Liu
Jack Lau 于2025年7月2日周三 12:35写道: > > RTP retransmission described in RFC4588 (RTX) is an effective packet > loss recovery technique for real-time applications with relaxed delay bounds. > > This patch provides a minimal implementation for RTX and RTCP NACK (RFC3940) > and its associated SDP signalin

Re: [FFmpeg-devel] [PATCH 1/6] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates

2025-07-01 Thread Steven Liu
Jack Lau 于2025年7月2日周三 12:25写道: > > mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate, > preventing “No route to host” errors on devices without IPv6 connectivity. > > Signed-off-by: Jack Lau > --- > libavformat/whip.c | 13 + > 1 file changed, 13 insertions(+) > > diff -

Re: [FFmpeg-devel] [PATCH 2/6] avformat/whip: reindent whip options

2025-07-01 Thread Steven Liu
Jack Lau 于2025年7月2日周三 12:25写道: > > Signed-off-by: Jack Lau > --- > libavformat/whip.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index be6ee9c951..8d1be90f32 100644 > --- a/libavformat/whip.c > +++ b/l

Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-13 Thread Steven Liu
Jack Lau 于2025年6月13日周五 13:07写道: > > > > > On Jun 8, 2025, at 08:25, Jack Lau via ffmpeg-devel > > wrote: > > > > api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem > > > > In higher versions (openssl 1.0.2 and higher), > > the function signature is BIO *BIO_new_mem_buf(const void *buf, int l

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 candidates

2025-06-13 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年6月13日周五 13:05写道: > > > > > -- Forwarded message -- > From: Jack Lau > To: ffmpeg-devel@ffmpeg.org > Cc: Jack Lau > Bcc: > Date: Fri, 13 Jun 2025 13:03:35 +0800 > Subject: [PATCH v2 1/2] avformat/whip: add whip_flags ignore_ipv6 to skip > IPv6 cand

Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-07 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年6月7日周六 09:35写道: > > In higher versions (like openssl 1.1.1 and higher), > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), > so passing a const string doesn't cause an warnings. > However, in lower versions of OpenSSL, > the function signatu

[FFmpeg-devel] [PATCH 2/2] avformat/whip: check the exchange sdp url is start with http

2025-06-05 Thread Steven Liu
Make sure the WHIP protocol performs the SDP offer/answer exchange with the WebRTC peer over HTTP. Signed-off-by: Steven Liu --- libavformat/whip.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/whip.c b/libavformat/whip.c index ce06a66bc4..b78ad27858 100644 --- a

[FFmpeg-devel] [PATCH 1/2] avformat/whip: Remove unnecessary pkt checks

2025-06-05 Thread Steven Liu
h264_annexb_insert_sps_pps (called after write_packet) reorganizes PPS, SPS, and IDR packets in H.264 streams. Since write_packet already validates pkt, redundant null checks in h264_annexb_insert_sps_pps can be removed. Signed-off-by: Steven Liu --- libavformat/whip.c | 2 -- 1 file changed, 2

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_min_time to guarantee minimal segment duration

2025-06-05 Thread Steven Liu
bx264 -g 25 part2.mp4 > echo "file part1.mp4\nfile part2.mp4" > list.txt > ffmpeg -f concat -i list.txt -codec copy \ > -f hls -hls_time 2 -hls_list_size 0 parts.m3u8 > cat parts.m3u8 > > v2 changes: > Adjusting wording in commit message as suggested by Steven

Re: [FFmpeg-devel] [PATCH v3] avformat/whip: Add WHIP muxer support for subsecond latency streaming

2025-06-04 Thread Steven Liu
Kieran Kunhya via ffmpeg-devel 于2025年6月4日周三 19:35写道: Hi Kieran, > > @Andreas Rheinhardt > Should we revert this? I believe it would be better to leave comments if there are any concerns about the patch. Several weeks have passed without objections, and I’ve been actively maintaining it for over

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: Return error code when read key file failed

2025-04-29 Thread Steven Liu
Zhao Zhili 于2025年4月29日 周二17:30写道: > From: Zhao Zhili > > --- > libavformat/hls.c | 47 ++- > 1 file changed, 34 insertions(+), 13 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 6623c80309..fe908a563b 100644 > --- a/libavfor

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hls: Show error info when read key file failed

2025-04-23 Thread Steven Liu
> On Apr 23, 2025, at 20:59, Zhao Zhili > wrote: Hi Zhili, > > From: Zhao Zhili > > --- > libavformat/hls.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 6623c80309..45c1b283c9 100644 > --- a/libavformat/h

Re: [FFmpeg-devel] [PATCH v2] avcodec/libwebpdec: Add libwebp WebP decoder.

2025-04-05 Thread Steven Liu
Peter Xia 于2025年4月5日周六 11:21写道: > > Hi Michael, > > The current webp decoder does not support animated, only webp stills. It has > been a pretty long standing feature request (#4907). > > Although it adds dependency of the libwebp decoder library, libwebp itself is > already a dependency of the

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: calculate bitrate for segments with duration < 0.5

2025-03-23 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年3月24日周一 07:13写道: > > The previous code sets the bitrate to be calculated only when duration>0.5, > which is obviously not general enough. > > In some scenarios, we may need to set hls_time<0.5, then the generated > segments are all <0.5. At this time, because the

Re: [FFmpeg-devel] [PATCH v2 1/6] tests: Add enhanced-flv-hevc-hdr10 for demux and mux HDR color info

2025-03-11 Thread Steven Liu
Zhao Zhili 于2025年3月11日周二 10:35写道: > > From: Zhao Zhili > > --- > tests/fate/flvenc.mak | 4 + > tests/ref/fate/enhanced-flv-hevc-hdr10 | 100 + > 2 files changed, 104 insertions(+) > create mode 100644 tests/ref/fate/enhanced-flv-hevc-hdr10 > > diff --

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-11 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年3月3日周一 09:38写道: > > fix ticket: 10786 > parse the SPS from extradata and get profile_compatibility, tier, constraints > which was been hard code before. > > HEVC CODECS Attribute reference to: ISO/IEC14496-15 > Signed-off-by: Jack Lau > --- > libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年3月2日周日 21:31写道: > > fix ticket: 10786 > parse the SPS from extradata and get profile_compatibility, tier, constraints > which was been hard code before. > > HEVC CODECS Attribute reference to: ISO/IEC14496-15 > Signed-off-by: Jack Lau > --- > libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年3月2日周日 15:47写道: > > fix ticket: 10786 > parse the SPS from extradata and get profile_compatibility, tier, constraints > which was been hard code before. > > HEVC CODECS Attribute reference to: ISO/IEC14496-15 > Signed-off-by: Jack Lau > --- > libavformat/hlsenc.c

Re: [FFmpeg-devel] Fw: GSoC 2025: Please review your Project Ideas lists

2025-02-15 Thread Steven Liu
Michael Niedermayer 于2025年2月15日周六 23:14写道: > > Hi Steven > > On Sat, Feb 15, 2025 at 07:30:40AM +0800, Steven Liu wrote: > [...] > > That’s not whole WebRTC, just push streams to server, we can implement a > > tiny function, I know WebRTC is too huge and there have

Re: [FFmpeg-devel] Fw: GSoC 2025: Please review your Project Ideas lists

2025-02-14 Thread Steven Liu
Kieran Kunhya 于2025年2月15日 周六06:15写道: > > > On Fri, 14 Feb 2025, 21:29 Steven Liu, wrote: > >> >> >> Kieran Kunhya via ffmpeg-devel 于2025年2月15日 >> 周六04:21写道: >> >>> On Fri, Feb 14, 2025 at 7:28 PM Michael Niedermayer >>> wrote: >

Re: [FFmpeg-devel] Fw: GSoC 2025: Please review your Project Ideas lists

2025-02-14 Thread Steven Liu
Kieran Kunhya via ffmpeg-devel 于2025年2月15日 周六04:21写道: > On Fri, Feb 14, 2025 at 7:28 PM Michael Niedermayer > wrote: > > > > Hi everyone > > > > Please help improve the gsoc 2025 page > > > > 2 ideas are missing backup mentors, if you are able please > > add yourself to them as backup mentor > >

Re: [FFmpeg-devel] [RFC] Experiment: enable github pull requests

2025-02-13 Thread Steven Liu
Stephen Hutchinson 于2025年2月14日 周五05:44写道: > On 2/13/25 8:32 AM, Timo Rothenpieler wrote: > > If anyone wants to be allowed to fork, just let me know with an account > > name and I'll up the limit. > > Yes, in my case. Account name: qyot27 Yes too. account name:lq Thanks Steven > > > __

Re: [FFmpeg-devel] GSoC 2025

2025-02-11 Thread Steven Liu
Michael Niedermayer 于2025年1月28日 周二10:21写道: > Hi > > Everyone interested in mentoring a project in 2025, please add your > idea(s) to [1]. > > during February 11 - 26 "Google program administrators review organization > applications" > That means that by February 11th the list of ideas must be comp

Re: [FFmpeg-devel] [PATCH] avformat/hls: Revert "reduce default max reload to 3"

2025-02-06 Thread Steven Liu
softworkz 于2025年1月19日周日 16:52写道: > > From: softworkz > > This change has caused regressions for many users and consumers. > Playlist reloads only happen when a playlist doesn't indicate that it > has ended (via #EXT-X-ENDLIST), which means that the addition of future > segments is still expected.

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fix twitter

2025-02-06 Thread Steven Liu
Michael Niedermayer 于2025年2月6日周四 20:10写道: > > Allow mp4 with all mpegts extensions > > Fixes: Ticket11435 > > Signed-off-by: Michael Niedermayer > --- > libavformat/hls.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 8e

Re: [FFmpeg-devel] considering ffmpeg's twitter/x

2025-01-29 Thread Steven Liu
compn 于2025年1月29日 周三17:26写道: > hi, Hi compn > > as i asked on irc this week, and as many of you may have seen it, the > owner of twitter/x did a thing at a political rally last week: > https://www.youtube.com/watch?v=wubITdJ_MCw > > when asked if he meant the gesture, the man replied with this

Re: [FFmpeg-devel] [PATCH v1] avformat/hlsenc: add hls_min_time to enforce minimal segment duration

2025-01-29 Thread Steven Liu
Ingo Oppermann 于2025年1月29日 周三17:54写道: Hi Ingo, Great job, thanks for your valuable patch, > The current implementation of the hls_time might produce segments > with shorter duration in some cases. With the hls_min_time option > a minimal segment duration will be enforced. > > Instead of changing

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: Check whitelist

2025-01-18 Thread Steven Liu
Michael Niedermayer 于2025年1月18日周六 06:31写道: > > On Thu, Jan 16, 2025 at 04:39:49AM +0100, Michael Niedermayer wrote: > > Fixes: CVE-2023-6602, V. DASH Playlist SSRF > > > > Found-by: Harvey Phillips of Amazon Element55 (element55) > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/das

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-29 Thread Steven Liu
Ronald S. Bultje 于2024年12月29日 周日00:54写道: > Hi all, > > (Prior note: the election was scheduled to end on the 23rd of December. > Anton is currently taking a break so I've asked him to let me announce the > election results.) > > The poll has concluded, with 31 votes out of 52. Results are availabl

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: check NULL pointer of av_strtok

2024-12-27 Thread Steven Liu
Leo Izen 于2024年12月27日周五 21:29写道: Hi Leo, > > On 12/26/24 6:37 PM, Steven Liu wrote: > > fix CID: 1637073 > > there maybe have NULL pointer return by av_strtok, and should be checked > > before > > strtoll it. > > > > Signed-off-by: Steven Liu > >

[FFmpeg-devel] [PATCH] avformat/dashdec: check NULL pointer of av_strtok

2024-12-26 Thread Steven Liu
fix CID: 1637073 there maybe have NULL pointer return by av_strtok, and should be checked before strtoll it. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 8107280444..043cd52232

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

2024-12-24 Thread Steven Liu
Ronald S. Bultje 于2024年12月23日周一 21:24写道: > > Hi, > > On Mon, Dec 23, 2024 at 8:22 AM Nicolas George wrote: > > > Could you all stop ganging against Michael? It is reminiscent of the > > bullying he was subjected to in the months leading to the fork that > > convinced him to “resign” as project le

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: reformat and lowercase get_Fragment()

2024-12-24 Thread Steven Liu
Marth64 于2024年12月25日 周三05:50写道: > Hi Steven, > > OK with me pushing this readability change? Sure, go ahead and push it. I'm really sorry for forgetting about this patch. I've been taking care of my newborn baby for the past few days and it must have slipped my mind. > > > Thank you > Thanks St

Re: [FFmpeg-devel] [PATCH] delete unused variable ret in libavutil

2024-11-13 Thread Steven Liu
唐莎 于2024年11月14日周四 09:18写道: looks ok, the ret is unused. Thanks Steven > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ..

Re: [FFmpeg-devel] [PATCH 0/2] fix for seeking in HLS with FMP4 media

2024-11-09 Thread Steven Liu
vectronic 于2024年11月8日周五 05:31写道: > > I am again updating and resubmitting a patch which fixes the following ticket: > > https://trac.ffmpeg.org/ticket/7359 > > This fix has been tested and recommended by several people now and I have > been using it in production successfully since I submitted it

Re: [FFmpeg-devel] Develop FFmpeg through your browser?

2024-11-08 Thread Steven Liu
Nicolas George 于2024年11月8日周五 00:24写道: > > Michael Niedermayer (12024-11-03): > > We can install gitlab on our infrastructure, if the community decides that > > it > > wants gitlab. We can also install anything else the community wants. > > If we want a more-than-monthly emergency security update

Re: [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: Fix a typo

2024-11-06 Thread Steven Liu
> On Nov 6, 2024, at 17:32, Zhao Zhili wrote: > > From: Zhao Zhili > > The typo has no real effect except confusing. > > Signed-off-by: Zhao Zhili > Reported-by: Chen Haibo > --- > fftools/ffplay_renderer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools

Re: [FFmpeg-devel] [RFC] Issue tarcker state for fate tests

2024-11-04 Thread Steven Liu
Michael Niedermayer 于2024年11月5日 周二04:34写道: > Hi all > > I think, in general most fixed issues (both bugs and features) > should have a test added to fate. > > To make that actually happen i suggest to introduce a state like > "fixed_and_fate_test" to trac > > That way we can track if a closed issu

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: return ret directly in open_demux_for_component()

2024-10-13 Thread Steven Liu
Steven Liu 于2024年10月12日周六 09:21写道: > > Marth64 于2024年10月11日周五 15:06写道: > > > > Signed-off-by: Marth64 > > --- > > libavformat/dashdec.c | 15 ++- > > 1 file changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check return value of avcodec_parameters_copy()

2024-10-13 Thread Steven Liu
Steven Liu 于2024年10月13日周日 08:42写道: > > Marth64 于2024年10月13日周日 01:25写道: > > > > Written in the dominant style of the surrounding code block. > > > > Signed-off-by: Marth64 > > --- > > libavformat/hlsenc.c | 4 +++- > > 1 file changed, 3 i

Re: [FFmpeg-devel] [PATCH] libavformat/hlsplaylist: add subtitle_varname for naming subtitle streams

2024-10-13 Thread Steven Liu
Jonathan Baecker 于2024年10月13日周日 19:54写道: > > Am 04.10.24 um 12:09 schrieb Steven Liu: > > Jonathan Baecker 于2024年9月29日周日 05:56写道: > >> If 'sname:*' is set in the var_stream_map variable, use it as > >> the NAME attribute for subtitles. This improves the

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check return value of avcodec_parameters_copy()

2024-10-12 Thread Steven Liu
Marth64 于2024年10月13日周日 01:25写道: > > Written in the dominant style of the surrounding code block. > > Signed-off-by: Marth64 > --- > libavformat/hlsenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 571d6b2752..1b3

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashdec: check return code of avcodec_parameters_copy()

2024-10-11 Thread Steven Liu
Marth64 于2024年10月11日周五 15:13写道: > > Signed-off-by: Marth64 > --- > libavformat/dashdec.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 9ce23aec65..cd1b3da3a2 100644 > --- a/libavformat/dashdec.c > +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashdec: format open_demux_for_component()

2024-10-11 Thread Steven Liu
Marth64 于2024年10月11日周五 15:07写道: > > Signed-off-by: Marth64 > --- > libavformat/dashdec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index cd1b3da3a2..a1d274f2f0 100644 > --- a/libavformat/dashdec.c > +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: return ret directly in open_demux_for_component()

2024-10-11 Thread Steven Liu
Marth64 于2024年10月11日周五 15:06写道: > > Signed-off-by: Marth64 > --- > libavformat/dashdec.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 99ac6197be..9ce23aec65 100644 > --- a/libavformat/dashdec.c > ++

[FFmpeg-devel] [PATCH v1] avformat/dashdec: remove xmlCleanupParser call in dashdec

2024-10-10 Thread Steven Liu
ation if another thread or a plugin is still using libxml2. So give a warning message to user for call xmlCleanupParser by themselves. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dash

Re: [FFmpeg-devel] [PATCH] libavformat/hlsplaylist: add subtitle_varname for naming subtitle streams

2024-10-04 Thread Steven Liu
Jonathan Baecker 于2024年9月29日周日 05:56写道: > > If 'sname:*' is set in the var_stream_map variable, use it as > the NAME attribute for subtitles. This improves the naming of > subtitle streams in HTML players, providing clearer and more > descriptive labels for users. > --- > doc/muxers.texi

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: Respect `omit_endlist` flag in subtitle playlists

2024-10-04 Thread Steven Liu
Jonathan Baecker 于2024年10月1日周二 07:56写道: > > This modification applies Steven's suggestion. > > Original description was: > Ensure that when the `-hls_flags omit_endlist` option is set, > the `#EXT-X-ENDLIST` tag is also omitted from the `stream_vtt.m3u8` > subtitle playlist. This maintains consist

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: Respect `append_list` flag in subtitle

2024-10-04 Thread Steven Liu
Jonathan Baecker 于2024年10月1日周二 03:51写道: > > Apply Stevens suggestion. > > Original description: > Ensure that when the `-hls_flags append_list` option is set, > that *.vtt files in stream_vtt.m3u8 are correctly updated. > This fixes https://trac.ffmpeg.org/ticket/11208 > --- > libavformat/hlsenc.

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Respect `omit_endlist` flag in subtitle playlists

2024-09-30 Thread Steven Liu
Jonathan Baecker 于2024年9月29日周日 01:29写道: Hi Jonathan, > > Ensure that when the `-hls_flags omit_endlist` option is set, > the `#EXT-X-ENDLIST` tag is also omitted from the `stream_vtt.m3u8` > subtitle playlist. This maintains consistency with the behavior > in other playlists when `omit_endlist` i

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix missing EXT-X-DISCONTINUITY tag in subtitle streams

2024-09-30 Thread Steven Liu
Steven Liu 于2024年9月26日周四 21:18写道: > > Jonathan Baecker 于2024年9月26日周四 15:59写道: > > > > The EXT-X-DISCONTINUITY tag was not being added to subtitle streams, > > causing synchronization issues. This patch ensures that the tag is applied > > consistently acr

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Respect `append_list` flag in subtitle playlists

2024-09-30 Thread Steven Liu
Jonathan Baecker 于2024年9月29日周日 03:51写道: Hi Jonathan, > > Ensure that when the `-hls_flags append_list` option is set, > that *.vtt files in stream_vtt.m3u8 are correctly updated. > > This fixes https://trac.ffmpeg.org/ticket/11208 > > Is a bit of an ugly fix, let me know what you think. > --- >

Re: [FFmpeg-devel] [PATCH] avformat/hlsplaylist: set stream name according to var_stream_map varname

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 19:57, jb wrote: > > Sorry for the last empty replay! > > That patch is not working correctly. > > The variable `varname` is also used for multiple video streams. What about try to use a varname for webvtt, eg. subtitle_varname ? > > Is there another way, to specify th

Re: [FFmpeg-devel] Exposing ability to add new filters without recompiling libavfilter?

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 19:22, Carlos Ruiz wrote: > > Hi all, > > Not sure if this should be directed at libav-user instead, feel free to > redirect > me if needed. > > I've read the writing_filters.txt documentation and numerous StackOverflow > posts and everything indicates that in order to

Re: [FFmpeg-devel] [PATCH] Respect `append_list` flag in subtitle playlists

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 14:32, Jonathan Baecker wrote: Hi Jonathan, thanks for your valuable patch. > > Ensure that when the `-hls_flags append_list` option is set, that *.vtt files > in stream_vtt.m3u8 are correctly updated. This fixes > https://trac.ffmpeg.org/ticket/11208 > > This is a bi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix missing EXT-X-DISCONTINUITY tag in subtitle streams

2024-09-26 Thread Steven Liu
Jonathan Baecker 于2024年9月26日周四 15:59写道: > > The EXT-X-DISCONTINUITY tag was not being added to subtitle streams, causing > synchronization issues. This patch ensures that the tag is applied > consistently across video and subtitle streams. > --- > libavformat/hlsenc.c | 2 +- > 1 file changed,

Re: [FFmpeg-devel] [RFC] 7.1 Release

2024-09-24 Thread Steven Liu
> On Sep 25, 2024, at 05:38, Dennis Mungai wrote: > > On Tue, 24 Sept 2024, 22:24 Ingo Oppermann, wrote: > >> "Leavitt" (https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt) >> >>> On 24 Sep 2024, at 17:47, Michael Niedermayer >> wrote: >>> >>> On Wed, Aug 14, 2024 at 02:41:55PM +0200, Mi

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: The segments in dash file doesn't read completely when segment's size and duration is very small.

2024-09-13 Thread Steven Liu
Steven Liu 于2024年9月2日周一 16:46写道: > > jiangjie 于2024年9月2日周一 16:35写道: > > > > If the segment is very small, avformat_find_stream_info will read all > > audio/video data in this segment. cur->is_restart_needed is set to 0 later > > in dash_read_packet function, a

Re: [FFmpeg-devel] [PATCH 7/7] avformat/flvdec: Free metaVideoColor

2024-09-12 Thread Steven Liu
Michael Niedermayer 于2024年9月13日周五 07:44写道: > > Fixes: memeleak > Fixes: > 70659/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-4539872627458048 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

[FFmpeg-devel] [PATCH v1 5/5] tests/fate/cbs: make cbs-vvc test depends prerequisites correct

2024-09-09 Thread Steven Liu
the VVC test cases cbs-vvc should prerequisites VVC{demuxer, parser, metadata_bsf, muser} Signed-off-by: Steven Liu --- tests/fate/cbs.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak index 4c30c5ec6c..dfd9e7d93c 100644 --- a

[FFmpeg-devel] [PATCH v1 3/5] tests/fate/demux: refine depend prerequisites for fate-mov-mp3-demux

2024-09-09 Thread Steven Liu
fix fate error when --disable-everything --samples=fate-suite/ --enable-demuxer=mov Signed-off-by: Steven Liu --- tests/fate/demux.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index d9b9045f0b..e0d1fccc8f 100644 --- a/tests

[FFmpeg-devel] [PATCH v1 4/5] tests/fate/cbs: refine depend prerequisites for cbs-hevc-discard test

2024-09-09 Thread Steven Liu
add h264_metadata_bsf and file protocol for cbs-hevc-discard test cases Signed-off-by: Steven Liu --- tests/fate/cbs.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak index 368385982c..4c30c5ec6c 100644 --- a/tests/fate/cbs.mak +++ b

[FFmpeg-devel] [PATCH v1 2/5] tests/fate/cbs: refine depend prerequisites for cbs-h264-discard test

2024-09-09 Thread Steven Liu
add h264_metadata and file protocol for cbs-h264-discard test Signed-off-by: Steven Liu --- tests/fate/cbs.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak index 802b0351a3..368385982c 100644 --- a/tests/fate/cbs.mak +++ b/tests

[FFmpeg-devel] [PATCH v1 1/5] tests/fate/seek: check seek opertation with mov demuxer and file protocol

2024-09-09 Thread Steven Liu
fix error at fate-seek-* when configure with --disable-everything --samples=fate-suite/ --enable-demuxer=mov Signed-off-by: Steven Liu --- tests/fate/seek.mak | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/seek.mak b/tests/fate/seek.mak index dfc2fa6a96

[FFmpeg-devel] [PATCH v2 5/5] tests/fate/mov: check mov and framemd5 has enabled when test

2024-09-08 Thread Steven Liu
fix error st fate-mov-neg-firstpts-discard when --disable-everything --samples=fate-suite Signed-off-by: Steven Liu --- tests/fate/mov.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 4160c63a45..682997f7fe 100644 --- a/tests

[FFmpeg-devel] [PATCH v2 4/5] tests/fate/matroska: check the demuxer and decoder allyes before fate-matroska-side-data-pref-codec

2024-09-08 Thread Steven Liu
fix error message when use --disable-everything --samples=fate-suite/ Signed-off-by: Steven Liu --- tests/fate/matroska.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak index 738c7fe30a..563d756485 100644 --- a/tests/fate

[FFmpeg-devel] [PATCH v2 3/5] tests/fate/audio: set flcl1905 test case with depend formats, decoder, protocol

2024-09-08 Thread Steven Liu
move fate-flcl1905 with depend on test case, because there will get an error when disable-everything with fate-suite samples. Signed-off-by: Steven Liu --- tests/fate/audio.mak | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak

[FFmpeg-devel] [PATCH v2 2/5] tests/fate/mov: check mov formats build status be for make test

2024-09-08 Thread Steven Liu
fix make fate error when make fate with --disable-everything, should check the mov build into ffmpeg status before test mov functions. Signed-off-by: Steven Liu --- tests/fate/mov.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/mov.mak b/tests/fate

[FFmpeg-devel] [PATCH v2 1/5] tests/fate/libavcodec: add mjpeg encoder depend for fate-libavcodec-huffman

2024-09-08 Thread Steven Liu
fix make fate failed problem, because fate libavcodec-avcodec need mjpeg encoder when fate-libavcodec-huffman Signed-off-by: Steven Liu --- tests/fate/libavcodec.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index

[FFmpeg-devel] [PATCH v1 1/4] tests/fate/libavcodec: add mjpeg encoder depend for fate-libavcodec-huffman

2024-09-08 Thread Steven Liu
fix make fate failed problem, because fate libavcodec-avcodec need mjpeg encoder when fate-libavcodec-huffman Signed-off-by: Steven Liu --- tests/fate/libavcodec.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index

[FFmpeg-devel] [PATCH v1 2/4] tests/fate/mov: check mov formats build status be for make test

2024-09-08 Thread Steven Liu
fix make fate error when make fate with --disable-everything, should check the mov build into ffmpeg status before test mov functions. Signed-off-by: Steven Liu --- tests/fate/mov.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/mov.mak b/tests/fate

[FFmpeg-devel] [PATCH v1 3/4] tests/fate/audio: set flcl1905 test case with depend formats, decoder, protocol

2024-09-08 Thread Steven Liu
move fate-flcl1905 with depend on test case, because there will get an error when disable-everything with fate-suite samples. Signed-off-by: Steven Liu --- tests/fate/audio.mak | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak

[FFmpeg-devel] [PATCH v1 4/4] tests/fate/matroska: check the demuxer and decoder allyes before fate-matroska-side-data-pref-codec

2024-09-08 Thread Steven Liu
fix error message when use --disable-everything --samples=fate-suite/ Signed-off-by: Steven Liu --- tests/fate/matroska.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak index 738c7fe30a..563d756485 100644 --- a/tests/fate

[FFmpeg-devel] [PATCH v3] tests/fate/hlsenc: add test case for var stream map of hlsenc

2024-09-04 Thread Steven Liu
Output var stream map m3u8 list file, and check the list file correct. Signed-off-by: Steven Liu --- tests/fate-run.sh | 4 tests/fate/hlsenc.mak | 17 + 2 files changed, 21 insertions(+) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 6ae0320c60..12d8faa65b

Re: [FFmpeg-devel] [PATCH v1] tests/fate/hlsenc: add test case for var stream map of hlsenc

2024-09-02 Thread Steven Liu
Steven Liu 于2024年9月2日周一 14:31写道: > > Signed-off-by: Steven Liu > --- > tests/fate/hlsenc.mak | 15 +++ > tests/ref/fate/hls-with-vtt-var-stream_map | 1 + > 2 files changed, 16 insertions(+) > create mode 100644 tests/ref/fate/hls-with-vtt

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: The segments in dash file doesn't read completely when segment's size and duration is very small.

2024-09-02 Thread Steven Liu
jiangjie 于2024年9月2日周一 16:35写道: > > If the segment is very small, avformat_find_stream_info will read all > audio/video data in this segment. cur->is_restart_needed is set to 0 later in > dash_read_packet function, and no chance to be set to 1 again in the > read_data function. > > Reproduction:

  1   2   3   4   5   6   7   8   9   10   >