Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: Check whitelist

2025-01-18 Thread Steven Liu
Michael Niedermayer 于2025年1月18日周六 06:31写道: > > On Thu, Jan 16, 2025 at 04:39:49AM +0100, Michael Niedermayer wrote: > > Fixes: CVE-2023-6602, V. DASH Playlist SSRF > > > > Found-by: Harvey Phillips of Amazon Element55 (element55) > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/das

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-29 Thread Steven Liu
Ronald S. Bultje 于2024年12月29日 周日00:54写道: > Hi all, > > (Prior note: the election was scheduled to end on the 23rd of December. > Anton is currently taking a break so I've asked him to let me announce the > election results.) > > The poll has concluded, with 31 votes out of 52. Results are availabl

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: check NULL pointer of av_strtok

2024-12-27 Thread Steven Liu
Leo Izen 于2024年12月27日周五 21:29写道: Hi Leo, > > On 12/26/24 6:37 PM, Steven Liu wrote: > > fix CID: 1637073 > > there maybe have NULL pointer return by av_strtok, and should be checked > > before > > strtoll it. > > > > Signed-off-by: Steven Liu > >

[FFmpeg-devel] [PATCH] avformat/dashdec: check NULL pointer of av_strtok

2024-12-26 Thread Steven Liu
fix CID: 1637073 there maybe have NULL pointer return by av_strtok, and should be checked before strtoll it. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 8107280444..043cd52232

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

2024-12-24 Thread Steven Liu
Ronald S. Bultje 于2024年12月23日周一 21:24写道: > > Hi, > > On Mon, Dec 23, 2024 at 8:22 AM Nicolas George wrote: > > > Could you all stop ganging against Michael? It is reminiscent of the > > bullying he was subjected to in the months leading to the fork that > > convinced him to “resign” as project le

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: reformat and lowercase get_Fragment()

2024-12-24 Thread Steven Liu
Marth64 于2024年12月25日 周三05:50写道: > Hi Steven, > > OK with me pushing this readability change? Sure, go ahead and push it. I'm really sorry for forgetting about this patch. I've been taking care of my newborn baby for the past few days and it must have slipped my mind. > > > Thank you > Thanks St

Re: [FFmpeg-devel] [PATCH] delete unused variable ret in libavutil

2024-11-13 Thread Steven Liu
唐莎 于2024年11月14日周四 09:18写道: looks ok, the ret is unused. Thanks Steven > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ..

Re: [FFmpeg-devel] [PATCH 0/2] fix for seeking in HLS with FMP4 media

2024-11-09 Thread Steven Liu
vectronic 于2024年11月8日周五 05:31写道: > > I am again updating and resubmitting a patch which fixes the following ticket: > > https://trac.ffmpeg.org/ticket/7359 > > This fix has been tested and recommended by several people now and I have > been using it in production successfully since I submitted it

Re: [FFmpeg-devel] Develop FFmpeg through your browser?

2024-11-08 Thread Steven Liu
Nicolas George 于2024年11月8日周五 00:24写道: > > Michael Niedermayer (12024-11-03): > > We can install gitlab on our infrastructure, if the community decides that > > it > > wants gitlab. We can also install anything else the community wants. > > If we want a more-than-monthly emergency security update

Re: [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: Fix a typo

2024-11-06 Thread Steven Liu
> On Nov 6, 2024, at 17:32, Zhao Zhili wrote: > > From: Zhao Zhili > > The typo has no real effect except confusing. > > Signed-off-by: Zhao Zhili > Reported-by: Chen Haibo > --- > fftools/ffplay_renderer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools

Re: [FFmpeg-devel] [RFC] Issue tarcker state for fate tests

2024-11-04 Thread Steven Liu
Michael Niedermayer 于2024年11月5日 周二04:34写道: > Hi all > > I think, in general most fixed issues (both bugs and features) > should have a test added to fate. > > To make that actually happen i suggest to introduce a state like > "fixed_and_fate_test" to trac > > That way we can track if a closed issu

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: return ret directly in open_demux_for_component()

2024-10-13 Thread Steven Liu
Steven Liu 于2024年10月12日周六 09:21写道: > > Marth64 于2024年10月11日周五 15:06写道: > > > > Signed-off-by: Marth64 > > --- > > libavformat/dashdec.c | 15 ++- > > 1 file changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check return value of avcodec_parameters_copy()

2024-10-13 Thread Steven Liu
Steven Liu 于2024年10月13日周日 08:42写道: > > Marth64 于2024年10月13日周日 01:25写道: > > > > Written in the dominant style of the surrounding code block. > > > > Signed-off-by: Marth64 > > --- > > libavformat/hlsenc.c | 4 +++- > > 1 file changed, 3 i

Re: [FFmpeg-devel] [PATCH] libavformat/hlsplaylist: add subtitle_varname for naming subtitle streams

2024-10-13 Thread Steven Liu
Jonathan Baecker 于2024年10月13日周日 19:54写道: > > Am 04.10.24 um 12:09 schrieb Steven Liu: > > Jonathan Baecker 于2024年9月29日周日 05:56写道: > >> If 'sname:*' is set in the var_stream_map variable, use it as > >> the NAME attribute for subtitles. This improves the

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check return value of avcodec_parameters_copy()

2024-10-12 Thread Steven Liu
Marth64 于2024年10月13日周日 01:25写道: > > Written in the dominant style of the surrounding code block. > > Signed-off-by: Marth64 > --- > libavformat/hlsenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 571d6b2752..1b3

Re: [FFmpeg-devel] [PATCH 2/3] avformat/dashdec: check return code of avcodec_parameters_copy()

2024-10-11 Thread Steven Liu
Marth64 于2024年10月11日周五 15:13写道: > > Signed-off-by: Marth64 > --- > libavformat/dashdec.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 9ce23aec65..cd1b3da3a2 100644 > --- a/libavformat/dashdec.c > +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 3/3] avformat/dashdec: format open_demux_for_component()

2024-10-11 Thread Steven Liu
Marth64 于2024年10月11日周五 15:07写道: > > Signed-off-by: Marth64 > --- > libavformat/dashdec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index cd1b3da3a2..a1d274f2f0 100644 > --- a/libavformat/dashdec.c > +++ b/libavfo

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: return ret directly in open_demux_for_component()

2024-10-11 Thread Steven Liu
Marth64 于2024年10月11日周五 15:06写道: > > Signed-off-by: Marth64 > --- > libavformat/dashdec.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 99ac6197be..9ce23aec65 100644 > --- a/libavformat/dashdec.c > ++

[FFmpeg-devel] [PATCH v1] avformat/dashdec: remove xmlCleanupParser call in dashdec

2024-10-10 Thread Steven Liu
ation if another thread or a plugin is still using libxml2. So give a warning message to user for call xmlCleanupParser by themselves. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dash

Re: [FFmpeg-devel] [PATCH] libavformat/hlsplaylist: add subtitle_varname for naming subtitle streams

2024-10-04 Thread Steven Liu
Jonathan Baecker 于2024年9月29日周日 05:56写道: > > If 'sname:*' is set in the var_stream_map variable, use it as > the NAME attribute for subtitles. This improves the naming of > subtitle streams in HTML players, providing clearer and more > descriptive labels for users. > --- > doc/muxers.texi

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: Respect `omit_endlist` flag in subtitle playlists

2024-10-04 Thread Steven Liu
Jonathan Baecker 于2024年10月1日周二 07:56写道: > > This modification applies Steven's suggestion. > > Original description was: > Ensure that when the `-hls_flags omit_endlist` option is set, > the `#EXT-X-ENDLIST` tag is also omitted from the `stream_vtt.m3u8` > subtitle playlist. This maintains consist

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: Respect `append_list` flag in subtitle

2024-10-04 Thread Steven Liu
Jonathan Baecker 于2024年10月1日周二 03:51写道: > > Apply Stevens suggestion. > > Original description: > Ensure that when the `-hls_flags append_list` option is set, > that *.vtt files in stream_vtt.m3u8 are correctly updated. > This fixes https://trac.ffmpeg.org/ticket/11208 > --- > libavformat/hlsenc.

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Respect `omit_endlist` flag in subtitle playlists

2024-09-30 Thread Steven Liu
Jonathan Baecker 于2024年9月29日周日 01:29写道: Hi Jonathan, > > Ensure that when the `-hls_flags omit_endlist` option is set, > the `#EXT-X-ENDLIST` tag is also omitted from the `stream_vtt.m3u8` > subtitle playlist. This maintains consistency with the behavior > in other playlists when `omit_endlist` i

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix missing EXT-X-DISCONTINUITY tag in subtitle streams

2024-09-30 Thread Steven Liu
Steven Liu 于2024年9月26日周四 21:18写道: > > Jonathan Baecker 于2024年9月26日周四 15:59写道: > > > > The EXT-X-DISCONTINUITY tag was not being added to subtitle streams, > > causing synchronization issues. This patch ensures that the tag is applied > > consistently acr

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Respect `append_list` flag in subtitle playlists

2024-09-30 Thread Steven Liu
Jonathan Baecker 于2024年9月29日周日 03:51写道: Hi Jonathan, > > Ensure that when the `-hls_flags append_list` option is set, > that *.vtt files in stream_vtt.m3u8 are correctly updated. > > This fixes https://trac.ffmpeg.org/ticket/11208 > > Is a bit of an ugly fix, let me know what you think. > --- >

Re: [FFmpeg-devel] [PATCH] avformat/hlsplaylist: set stream name according to var_stream_map varname

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 19:57, jb wrote: > > Sorry for the last empty replay! > > That patch is not working correctly. > > The variable `varname` is also used for multiple video streams. What about try to use a varname for webvtt, eg. subtitle_varname ? > > Is there another way, to specify th

Re: [FFmpeg-devel] Exposing ability to add new filters without recompiling libavfilter?

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 19:22, Carlos Ruiz wrote: > > Hi all, > > Not sure if this should be directed at libav-user instead, feel free to > redirect > me if needed. > > I've read the writing_filters.txt documentation and numerous StackOverflow > posts and everything indicates that in order to

Re: [FFmpeg-devel] [PATCH] Respect `append_list` flag in subtitle playlists

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 14:32, Jonathan Baecker wrote: Hi Jonathan, thanks for your valuable patch. > > Ensure that when the `-hls_flags append_list` option is set, that *.vtt files > in stream_vtt.m3u8 are correctly updated. This fixes > https://trac.ffmpeg.org/ticket/11208 > > This is a bi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix missing EXT-X-DISCONTINUITY tag in subtitle streams

2024-09-26 Thread Steven Liu
Jonathan Baecker 于2024年9月26日周四 15:59写道: > > The EXT-X-DISCONTINUITY tag was not being added to subtitle streams, causing > synchronization issues. This patch ensures that the tag is applied > consistently across video and subtitle streams. > --- > libavformat/hlsenc.c | 2 +- > 1 file changed,

Re: [FFmpeg-devel] [RFC] 7.1 Release

2024-09-24 Thread Steven Liu
> On Sep 25, 2024, at 05:38, Dennis Mungai wrote: > > On Tue, 24 Sept 2024, 22:24 Ingo Oppermann, wrote: > >> "Leavitt" (https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt) >> >>> On 24 Sep 2024, at 17:47, Michael Niedermayer >> wrote: >>> >>> On Wed, Aug 14, 2024 at 02:41:55PM +0200, Mi

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: The segments in dash file doesn't read completely when segment's size and duration is very small.

2024-09-13 Thread Steven Liu
Steven Liu 于2024年9月2日周一 16:46写道: > > jiangjie 于2024年9月2日周一 16:35写道: > > > > If the segment is very small, avformat_find_stream_info will read all > > audio/video data in this segment. cur->is_restart_needed is set to 0 later > > in dash_read_packet function, a

Re: [FFmpeg-devel] [PATCH 7/7] avformat/flvdec: Free metaVideoColor

2024-09-12 Thread Steven Liu
Michael Niedermayer 于2024年9月13日周五 07:44写道: > > Fixes: memeleak > Fixes: > 70659/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-4539872627458048 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer >

[FFmpeg-devel] [PATCH v1 5/5] tests/fate/cbs: make cbs-vvc test depends prerequisites correct

2024-09-09 Thread Steven Liu
the VVC test cases cbs-vvc should prerequisites VVC{demuxer, parser, metadata_bsf, muser} Signed-off-by: Steven Liu --- tests/fate/cbs.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak index 4c30c5ec6c..dfd9e7d93c 100644 --- a

[FFmpeg-devel] [PATCH v1 3/5] tests/fate/demux: refine depend prerequisites for fate-mov-mp3-demux

2024-09-09 Thread Steven Liu
fix fate error when --disable-everything --samples=fate-suite/ --enable-demuxer=mov Signed-off-by: Steven Liu --- tests/fate/demux.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index d9b9045f0b..e0d1fccc8f 100644 --- a/tests

[FFmpeg-devel] [PATCH v1 4/5] tests/fate/cbs: refine depend prerequisites for cbs-hevc-discard test

2024-09-09 Thread Steven Liu
add h264_metadata_bsf and file protocol for cbs-hevc-discard test cases Signed-off-by: Steven Liu --- tests/fate/cbs.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak index 368385982c..4c30c5ec6c 100644 --- a/tests/fate/cbs.mak +++ b

[FFmpeg-devel] [PATCH v1 2/5] tests/fate/cbs: refine depend prerequisites for cbs-h264-discard test

2024-09-09 Thread Steven Liu
add h264_metadata and file protocol for cbs-h264-discard test Signed-off-by: Steven Liu --- tests/fate/cbs.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak index 802b0351a3..368385982c 100644 --- a/tests/fate/cbs.mak +++ b/tests

[FFmpeg-devel] [PATCH v1 1/5] tests/fate/seek: check seek opertation with mov demuxer and file protocol

2024-09-09 Thread Steven Liu
fix error at fate-seek-* when configure with --disable-everything --samples=fate-suite/ --enable-demuxer=mov Signed-off-by: Steven Liu --- tests/fate/seek.mak | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fate/seek.mak b/tests/fate/seek.mak index dfc2fa6a96

[FFmpeg-devel] [PATCH v2 5/5] tests/fate/mov: check mov and framemd5 has enabled when test

2024-09-08 Thread Steven Liu
fix error st fate-mov-neg-firstpts-discard when --disable-everything --samples=fate-suite Signed-off-by: Steven Liu --- tests/fate/mov.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 4160c63a45..682997f7fe 100644 --- a/tests

[FFmpeg-devel] [PATCH v2 4/5] tests/fate/matroska: check the demuxer and decoder allyes before fate-matroska-side-data-pref-codec

2024-09-08 Thread Steven Liu
fix error message when use --disable-everything --samples=fate-suite/ Signed-off-by: Steven Liu --- tests/fate/matroska.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak index 738c7fe30a..563d756485 100644 --- a/tests/fate

[FFmpeg-devel] [PATCH v2 3/5] tests/fate/audio: set flcl1905 test case with depend formats, decoder, protocol

2024-09-08 Thread Steven Liu
move fate-flcl1905 with depend on test case, because there will get an error when disable-everything with fate-suite samples. Signed-off-by: Steven Liu --- tests/fate/audio.mak | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak

[FFmpeg-devel] [PATCH v2 2/5] tests/fate/mov: check mov formats build status be for make test

2024-09-08 Thread Steven Liu
fix make fate error when make fate with --disable-everything, should check the mov build into ffmpeg status before test mov functions. Signed-off-by: Steven Liu --- tests/fate/mov.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/mov.mak b/tests/fate

[FFmpeg-devel] [PATCH v2 1/5] tests/fate/libavcodec: add mjpeg encoder depend for fate-libavcodec-huffman

2024-09-08 Thread Steven Liu
fix make fate failed problem, because fate libavcodec-avcodec need mjpeg encoder when fate-libavcodec-huffman Signed-off-by: Steven Liu --- tests/fate/libavcodec.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index

[FFmpeg-devel] [PATCH v1 1/4] tests/fate/libavcodec: add mjpeg encoder depend for fate-libavcodec-huffman

2024-09-08 Thread Steven Liu
fix make fate failed problem, because fate libavcodec-avcodec need mjpeg encoder when fate-libavcodec-huffman Signed-off-by: Steven Liu --- tests/fate/libavcodec.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index

[FFmpeg-devel] [PATCH v1 2/4] tests/fate/mov: check mov formats build status be for make test

2024-09-08 Thread Steven Liu
fix make fate error when make fate with --disable-everything, should check the mov build into ffmpeg status before test mov functions. Signed-off-by: Steven Liu --- tests/fate/mov.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/mov.mak b/tests/fate

[FFmpeg-devel] [PATCH v1 3/4] tests/fate/audio: set flcl1905 test case with depend formats, decoder, protocol

2024-09-08 Thread Steven Liu
move fate-flcl1905 with depend on test case, because there will get an error when disable-everything with fate-suite samples. Signed-off-by: Steven Liu --- tests/fate/audio.mak | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak

[FFmpeg-devel] [PATCH v1 4/4] tests/fate/matroska: check the demuxer and decoder allyes before fate-matroska-side-data-pref-codec

2024-09-08 Thread Steven Liu
fix error message when use --disable-everything --samples=fate-suite/ Signed-off-by: Steven Liu --- tests/fate/matroska.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/matroska.mak b/tests/fate/matroska.mak index 738c7fe30a..563d756485 100644 --- a/tests/fate

[FFmpeg-devel] [PATCH v3] tests/fate/hlsenc: add test case for var stream map of hlsenc

2024-09-04 Thread Steven Liu
Output var stream map m3u8 list file, and check the list file correct. Signed-off-by: Steven Liu --- tests/fate-run.sh | 4 tests/fate/hlsenc.mak | 17 + 2 files changed, 21 insertions(+) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 6ae0320c60..12d8faa65b

Re: [FFmpeg-devel] [PATCH v1] tests/fate/hlsenc: add test case for var stream map of hlsenc

2024-09-02 Thread Steven Liu
Steven Liu 于2024年9月2日周一 14:31写道: > > Signed-off-by: Steven Liu > --- > tests/fate/hlsenc.mak | 15 +++ > tests/ref/fate/hls-with-vtt-var-stream_map | 1 + > 2 files changed, 16 insertions(+) > create mode 100644 tests/ref/fate/hls-with-vtt

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: The segments in dash file doesn't read completely when segment's size and duration is very small.

2024-09-02 Thread Steven Liu
jiangjie 于2024年9月2日周一 16:35写道: > > If the segment is very small, avformat_find_stream_info will read all > audio/video data in this segment. cur->is_restart_needed is set to 0 later in > dash_read_packet function, and no chance to be set to 1 again in the > read_data function. > > Reproduction:

[FFmpeg-devel] [PATCH v2] tests/fate/hlsenc: add test case for var stream map of hlsenc

2024-09-02 Thread Steven Liu
Output var stream map m3u8 list file, and check the list file correct. Signed-off-by: Steven Liu --- tests/fate-run.sh | 4 tests/fate/hlsenc.mak | 17 + 2 files changed, 21 insertions(+) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 6ae0320c60..12d8faa65b

[FFmpeg-devel] [PATCH v1] tests/fate/hlsenc: add test case for var stream map of hlsenc

2024-09-01 Thread Steven Liu
Signed-off-by: Steven Liu --- tests/fate/hlsenc.mak | 15 +++ tests/ref/fate/hls-with-vtt-var-stream_map | 1 + 2 files changed, 16 insertions(+) create mode 100644 tests/ref/fate/hls-with-vtt-var-stream_map diff --git a/tests/fate/hlsenc.mak b/tests/fate

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: correctly reset subtitle stream counter per-varstream

2024-08-15 Thread Steven Liu
Timo Rothenpieler 于2024年8月16日 周五08:03写道: > Without resetting it, if there was a previous set of varstreams with > subtitles, it would subtract from all the streams, leading to chaos and > segfaults when trying to access for example stream -1. > --- > libavformat/hlsenc.c | 2 +- > 1 file changed,

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: Fixed incorrect behaviour of default

2024-07-16 Thread Steven Liu
Steven Liu 于2024年7月15日周一 21:47写道: > > CoderVenkat 于2024年7月15日周一 00:07写道: > > > > Apologies > > Correct file attached in this > > mail.___ > I need more time look at the deep for and if logic. Hi CoderVenkat, +

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: Fixed incorrect behaviour of default

2024-07-15 Thread Steven Liu
CoderVenkat 于2024年7月15日周一 00:07写道: > > Apologies > Correct file attached in this > mail.___ I need more time look at the deep for and if logic. Thanks Steven ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH v2] avformat/hls: Fixed incorrect behaviour of default

2024-07-14 Thread Steven Liu
CoderVenkat 于2024年7月14日周日 16:21写道: Hi Coder Venkat, > > Ping. > Any chance you could take a look? I would like to submit another fix based on > this. @@ -1434,6 +1436,31 @@ static int create_master_playlist(AVFormatContext *s, avio_printf(hls->m3u8_out, ",INSTREAM-ID=\"%s\"\n", ccs->in

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixed incorrect behaviour of default setting, , added autoselect and forced

2024-07-07 Thread Steven Liu
CoderVenkat 于2024年7月5日周五 21:27写道: > > In absence of default in var_stream_map, it was setting default=yes on > every stream, > but according to RFC8216 4.3.4.1 only one stream in a default group may > have that. > Additionally added support for autoselect=yes/no, whose presence > combined with def

[FFmpeg-devel] [PATCH] avformat/hlsenc: refine error message when retry with new http session

2024-07-07 Thread Steven Liu
Fix CID: 1609624 The hlsenc should give error message when hlsenc_io_open error, release memory of filename and options, should return warning message when hlsenc_io_close error. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a

Re: [FFmpeg-devel] [PATCH v2 3/5] hlsenc: Remove bogus check for if (vs->start_pos) for appending segments

2024-07-02 Thread Steven Liu
Martin Storsjö 于2024年7月3日周三 04:46写道: > > On Wed, 26 Jun 2024, Martin Storsjö wrote: > > > Previously, vs->start_pos was never 0 here, unless using the > > -hls_segment_size option, which wasn't allowed for SEGMENT_TYPE_FMP4. > > Therefore, this if statement was practically always taken anyway. > >

Re: [FFmpeg-devel] [PATCH 2/4] hlsenc: Fix setting vs->start_pos when not using HLS_SINGLE_FILE or hls_segment_size

2024-06-24 Thread Steven Liu
> On Jun 24, 2024, at 16:49, Martin Storsjö wrote: > > When not using HLS_SINGLE_FILE or hls_segment_size, we're writing > each segment into a separate file. In that case, the file start pos for > each segment will be zero. > > This matches the case in (hls->max_seg_size > 0) above, where we >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-19 Thread Steven Liu
Nuo Mi 于2024年6月19日周三 16:40写道: > > On Tue, Jun 18, 2024 at 8:06 PM Steven Liu wrote: > > > Nuo Mi 于2024年6月18日周二 19:51写道: > > > > > > On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili > > wrote: > > > > > > > > > &

Re: [FFmpeg-devel] [PATCH 1/2] avutil/executor: Allowing thread_count be zero

2024-06-18 Thread Steven Liu
Nuo Mi 于2024年6月18日周二 19:51写道: > > On Mon, Jun 17, 2024 at 5:28 PM Zhao Zhili wrote: > > > > > > > > On Jun 17, 2024, at 16:45, Hendrik Leppkes wrote: > > > > > > On Mon, Jun 17, 2024 at 10:03 AM Zhao Zhili > > wrote: > > >> > > >> > > >> > > >>> On Jun 17, 2024, at 15:05, Anton Khirnov wrote:

Re: [FFmpeg-devel] [PATCH 7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg

2024-06-18 Thread Steven Liu
Steven Liu 于2024年6月18日周二 17:53写道: > > Michael Niedermayer 于2024年6月17日周一 07:09写道: > > > > Ive been told that someone at the BCN video tech meetup claimed to be the > > "release maintainer for FFmpeg". > > > > If you have any doubt who maintains relea

Re: [FFmpeg-devel] [PATCH 7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg

2024-06-18 Thread Steven Liu
Michael Niedermayer 于2024年6月17日周一 07:09写道: > > Ive been told that someone at the BCN video tech meetup claimed to be the > "release maintainer for FFmpeg". > > If you have any doubt who maintains releases, just do something like the > following and look at the output: > VER=5.1 > echo commiters ;

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Remove dead ret stores

2024-05-25 Thread Steven Liu
Michael Niedermayer 于2024年5月25日周六 19:18写道: > > Fixes: CID1529222 Unused value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/hlsenc.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 0

Re: [FFmpeg-devel] [RFC 00/13] flvdec/flvenc: add support for enhanced rtmp codecs and multitrack/multichannel

2024-05-22 Thread Steven Liu
Timo Rothenpieler 于2024年5月21日周二 17:03写道: > > This is based on the preliminary spec for enhanced rtmp v2: > https://veovera.org/docs/enhanced/enhanced-rtmp-v2 > > The spec is not final, and can still undergo breaking changes, hence this set > is purely for comments and review, and not ready to be

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: fix a memory leak in libavformat/hlsenc.c

2024-04-15 Thread Steven Liu
LuMingYin 于2024年4月13日周六 14:35写道: > > In the function 'hls_write_trailer' in the file > '/FFmpeg/libavformat/hlsenc.c', the variable named 'options' allocates a > block of dynamic memory in the 'av_dict_set' function, which is not freed on > error paths. > > Signed-off-by: LuMingYin > --- > li

Re: [FFmpeg-devel] resignation from CC

2024-04-13 Thread Steven Liu
Anton Khirnov 于2024年4月13日周六 17:58写道: > > Hi all, > I am hereby resigning from my position as a CC member, since I do not > want to be associated with the CC's utter lack of initiative and > meaningful action. What's happened? Perhaps have some misunderstand with some body or some things? Thanks

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/hls.c: support in-stream ID3 metadata update.

2024-04-07 Thread Steven Liu
Romain Beauxis 于2024年3月26日周二 08:58写道: > > This patch adds support for updating HLS metadata passed as ID3 frames. > > This seems like a pretty straight-forward improvement. Updating the > metadaata of the first stream seems to be the mechanism is other places > in the code and works as expected. >

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Don't free AVOpt-strings manually, fix crash

2024-03-31 Thread Steven Liu
gt; return 0; > >> > >> fail: > >> -av_freep(&rt->playpath); > >> -av_freep(&rt->tcurl); > >> -av_freep(&rt->flashver); > >> av_dict_free(opts); > >> rtmp_close(s); > >> return ret; > >

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/hls.c: support in-stream ID3 metadata update.

2024-03-29 Thread Steven Liu
> 在 2024年3月29日,06:51,Romain Beauxis 写道: > > On Mon, Mar 25, 2024, 19:58 Romain Beauxis wrote: > >> This patch adds support for updating HLS metadata passed as ID3 frames. >> >> This seems like a pretty straight-forward improvement. Updating the >> metadaata of the first stream seems to be t

[FFmpeg-devel] [PATCH] Changelog: Add Support PacketTypeMetadata of PacketType in enhanced flv

2024-03-18 Thread Steven Liu via ffmpeg-devel
Signed-off-by: Steven Liu --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index b7d7535a9e..e3ca52430c 100644 --- a/Changelog +++ b/Changelog @@ -34,6 +34,7 @@ version : - ffprobe (with -export_side_data film_grain) now prints film grain metadata - AEA

Re: [FFmpeg-devel] [PATCH v5 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-18 Thread Steven Liu
Steven Liu 于2024年3月7日周四 17:33写道: > > zhupengfei via ffmpeg-devel 于2024年3月4日周一 21:52写道: > > > > From: Zhu Pengfei <411294...@qq.com> > > > > Signed-off-by: Zhu Pengfei <411294...@qq.com> > > --- > > libavformat/flvdec.c | 177 ++

Re: [FFmpeg-devel] [PATCH] fate/flvenc: force the av1 decoder in all steps for fate-enhanced-flv-av1

2024-03-08 Thread Steven Liu
James Almer 于2024年3月8日周五 21:19写道: > > Signed-off-by: James Almer > --- > tests/fate-run.sh | 5 +++-- > tests/fate/flvenc.mak | 2 +- > tests/fate/mpegps.mak | 2 +- > 3 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/fate-run.sh b/tests/fate-run.sh > index 2de560354f..

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init

2024-03-08 Thread Steven Liu
James Almer 于2024年3月8日周五 21:13写道: > > On 3/8/2024 10:07 AM, Andreas Rheinhardt wrote: > > Steven Liu: > >> before patch: > >> test failed when using libaomdec. > >> TESTenhanced-flv-av1 > >> --- src/tests/ref/fate/enhanced-flv-av1 2024-03-

[FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init

2024-03-08 Thread Steven Liu
: 320x176 -#sar 0: 0/1 +#sar 0: 1/1 0, 0, 0, 41, 4718, 0xc4d912ec 0, 42, 42, 41, 5109, 0xc065dd7d, F=0x0 0, 83, 83, 41, 192, 0x160c5335, F=0x0 after patch: test passed Signed-off-by: Steven Liu --- libavcodec

Re: [FFmpeg-devel] [PATCH v5 1/3] avformat/flvdec: support enhanced flv PacketTypeMetadata

2024-03-07 Thread Steven Liu
zhupengfei via ffmpeg-devel 于2024年3月4日周一 21:52写道: > > From: Zhu Pengfei <411294...@qq.com> > > Signed-off-by: Zhu Pengfei <411294...@qq.com> > --- > libavformat/flvdec.c | 177 ++- > 1 file changed, 176 insertions(+), 1 deletion(-) > > diff --git a/libavfor

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-22 Thread Steven Liu
Dennis Mungai 于2024年1月22日 周一18:20写道: > On Mon, 22 Jan 2024 at 13:10, Steven Liu wrote: > > > Dennis Mungai 于2024年1月21日周日 00:42写道: > > > > > > > > > Perfect, and thanks for considering a revert of this deprecated > feature. > > > > H

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-22 Thread Steven Liu
Dennis Mungai 于2024年1月21日周日 00:42写道: > > > Perfect, and thanks for considering a revert of this deprecated feature. Hi Dennis, Need more talk, Why don't try to use hls_flags +delete_segments+append_list. ? Thanks Steven ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-20 Thread Steven Liu
Dennis Mungai 于2024年1月20日 周六23:15写道: > On Sat, 20 Jan 2024, 6:09 pm Steven Liu, wrote: > > > Dennis Mungai 于2024年1月20日 周六21:02写道: > > > > > Hello, > > > > > > Is there a valid technical reason as to why FFmpeg's HLS muxer dropped > >

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-20 Thread Steven Liu
Dennis Mungai 于2024年1月20日 周六21:02写道: > Hello, > > Is there a valid technical reason as to why FFmpeg's HLS muxer dropped the > hls_wrap option? eg. three player playing the list and every fragment less or equal 1 second , 1. Player 1 from fragment1, fragment2 2. Now Player 2 from fragment 1, fra

Re: [FFmpeg-devel] [PATCH 3/4] fftools/ffmpeg_opt: add a stream_group_script option

2024-01-07 Thread Steven Liu
James Almer 于2024年1月8日周一 05:31写道: Hi James, > > Similar to filter_complex_script. Should make setting stream groups > easier. > > Signed-off-by: James Almer > --- > fftools/ffmpeg_mux_init.c | 2 +- > fftools/ffmpeg_opt.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff -

Re: [FFmpeg-devel] [PATCH v2] libavformat/hlsenc.c: Populate OTI using AAC profile in write_codec_attr.

2024-01-01 Thread Steven Liu
Romain Beauxis 于2024年1月1日周一 23:53写道: > > This patch populates the third entry for HLS codec attribute using the > AAC profile. > > The HLS specifications[1] require this value to be the Object Type ID as > referred to in table 1.3 of ISO/IEC 14496-3:2009[2]. > > The numerical constants in the code

Re: [FFmpeg-devel] [PATCH] libavformat/dashdec.c Fix for ticket #7395

2023-12-06 Thread Steven Liu
Evgeniy Pantyuhin via ffmpeg-devel 于2023年12月7日周四 04:32写道: > > Signed-off-by: Evgeniy > --- > libavformat/dashdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 29d4680..36e4719 100644 > --- a/libavformat/dashdec.c

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC/CC elections

2023-12-05 Thread Steven Liu
Anton Khirnov 于2023年12月5日周二 18:07写道: > > Hi all, > Both elections have now concluded. > > We have 36 votes for the CC election (70% turnout) and 38 votes for TC > (75% turnout); raw votes in CSV format are attached. > > The CC members now are: > * James Almer > * Jean-Baptiste Kempf > * Anton Khir

Re: [FFmpeg-devel] [PATCH 2/2] avformat/flvenc: add extract_extradata bsf for new video codecs

2023-11-18 Thread Steven Liu
> 在 2023年11月18日,16:03,Zhao Zhili 写道: > > From: Zhao Zhili > > When encoders don't support global header like MediaCodec, FLV > muxer needs to add extract_extradata bsf automatically. The codec > list doesn't include VP9 since it's not supported by > extract_extradata. > > Signed-off-by: Zha

[FFmpeg-devel] [PATCH] avformat/hlsenc: remove unnessecery av_dict_free operations

2023-11-17 Thread Steven Liu
The option will be freed at the end of the hls_window function, And will go to fail label call av_dict_free if every open operation return failed. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio

2023-11-08 Thread Steven Liu
David Johansen 于2023年11月9日周四 07:47写道: > > On Fri, Oct 27, 2023 at 1:33 AM Steven Liu wrote: > > > David Johansen 于2023年10月27日周五 12:03写道: > > > > > > > > > > > LGTM > > > > > > > > > > > > Thanks > > >

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-11-07 Thread Steven Liu
Steven Liu 于2023年11月8日周三 09:26写道: > > Tristan Matthews 于2023年11月8日周三 00:47写道: > > > > On Tue, Nov 7, 2023 at 2:36 AM Lynne wrote: > > > > > > Oct 29, 2023, 06:57 by d...@lynne.ee: > > > > > > > Oct 29, 2023, 05:51 by mich...@niedermaye

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-11-07 Thread Steven Liu
Tristan Matthews 于2023年11月8日周三 00:47写道: > > On Tue, Nov 7, 2023 at 2:36 AM Lynne wrote: > > > > Oct 29, 2023, 06:57 by d...@lynne.ee: > > > > > Oct 29, 2023, 05:51 by mich...@niedermayer.cc: > > > > > >> On Sat, Oct 28, 2023 at 09:23:45PM +0200, Lynne wrote: > > >> > > >>> Oct 28, 2023, 18:49 by

Re: [FFmpeg-devel] [RFC] financial sustainability Plan A (SPI)

2023-10-31 Thread Steven Liu
Thilo Borgmann via ffmpeg-devel 于2023年11月1日周三 08:04写道: > > > it would just show up once lets say on a specific day 1 year after the code > > is added. we would remove it on that day ourselfs. > > It would just be a simple one time shown message that says > > "Decoded by ffmpeg.org / Please donate

Re: [FFmpeg-devel] [PATCH 3/4] avformat/hlsenc: Fix name of flag in error message

2023-10-27 Thread Steven Liu
Dave Johansen 于2023年10月27日周五 12:00写道: > > --- > libavformat/hlsenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 24a0304f78..93c47b631b 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -1013,

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio

2023-10-27 Thread Steven Liu
David Johansen 于2023年10月27日周五 12:03写道: > > > > > LGTM > > > > > > Thanks > > Steven > > > > I'm new to ffmpeg development so what's the process for this to be merged? > Do I need to do something or is it taken care of by a different > process/someone else? Nothing, just leave enough time for more

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Add CHANNELS to EXT-X-MEDIA for Audio

2023-10-26 Thread Steven Liu
Dave Johansen 于2023年10月27日周五 09:44写道: > > --- > libavformat/dashenc.c | 3 ++- > libavformat/hlsenc.c | 8 +++- > libavformat/hlsplaylist.c | 5 - > libavformat/hlsplaylist.h | 2 +- > 4 files changed, 14 insertions(+), 4 deletions(-) > > diff --git a/libavformat/dashenc.c b/liba

Re: [FFmpeg-devel] [PATCH] avformat/hls: use av_strlcopy instead of strncpy

2023-10-25 Thread Steven Liu
Leo Izen 于2023年10月26日周四 11:14写道: > > Avoids a -Wstringop-truncation warning by using av_strlcopy instead of > strncpy. > > Signed-off-by: Leo Izen > --- > libavformat/hls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index f5f5

Re: [FFmpeg-devel] [REFUND-REQUEST]] VDD23 Travel

2023-10-23 Thread Steven Liu
Stefano Sabatini 于2023年10月10日周二 14:09写道: Hi Stefano, > > On date Sunday 2023-10-08 10:09:03 +0800, Steven Liu wrote: > > Nice to see you all after so long. > > My request is for my flights, 9750,00 CNY Beijing from/to Abu Dhabi, > > Abu Dhabi from/to Dublin > >

Re: [FFmpeg-devel] [PATCH 3/3] doc: add spi.txt

2023-10-11 Thread Steven Liu
Michael Niedermayer 于2023年10月12日周四 02:10写道: > > This explains how to request refunds and what can be funded by SPI > --- > doc/spi.txt | 50 ++ > 1 file changed, 50 insertions(+) > create mode 100644 doc/spi.txt > > diff --git a/doc/spi.txt b/doc/s

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists

2023-10-10 Thread Steven Liu
Léon Spaans 于2023年10月7日周六 05:41写道: > > Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant > playlists. > > Signed-off-by: Léon Spaans > --- > libavformat/hlsenc.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavforma

Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread Steven Liu
James Almer 于2023年10月8日 周日20:08写道: > On 10/8/2023 8:57 AM, Steven Liu wrote: > > Makes the output of the libaom av1 decoder consistent with external > decoders like > > libdav1d. > > > > reference commit: 1652f2492f88434010053289d946dab6a57e4d58 > > Bu

[FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread Steven Liu
Makes the output of the libaom av1 decoder consistent with external decoders like libdav1d. reference commit: 1652f2492f88434010053289d946dab6a57e4d58 Signed-off-by: Steven Liu --- libavcodec/libaomdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/libaomdec.c b/libavcodec

[FFmpeg-devel] [REFUND-REQUEST]] VDD23 Travel

2023-10-07 Thread Steven Liu
Nice to see you all after so long. My request is for my flights, 9750,00 CNY Beijing from/to Abu Dhabi, Abu Dhabi from/to Dublin Thanks Steven ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

  1   2   3   4   5   6   7   8   9   10   >